2023-12-08 17:12:32 -06:00
|
|
|
//@no-rustfix
|
|
|
|
|
|
|
|
#![warn(clippy::unconditional_recursion)]
|
2023-12-16 11:15:32 -06:00
|
|
|
#![allow(clippy::partialeq_ne_impl)]
|
2023-12-08 17:12:32 -06:00
|
|
|
|
|
|
|
enum Foo {
|
|
|
|
A,
|
|
|
|
B,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl PartialEq for Foo {
|
|
|
|
fn ne(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
self != other
|
|
|
|
}
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
self == other
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
enum Foo2 {
|
|
|
|
A,
|
|
|
|
B,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl PartialEq for Foo2 {
|
|
|
|
fn ne(&self, other: &Self) -> bool {
|
|
|
|
self != &Foo2::B // no error here
|
|
|
|
}
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
self == &Foo2::B // no error here
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
enum Foo3 {
|
|
|
|
A,
|
|
|
|
B,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl PartialEq for Foo3 {
|
|
|
|
fn ne(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
self.ne(other)
|
|
|
|
}
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
self.eq(other)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
enum Foo4 {
|
|
|
|
A,
|
|
|
|
B,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl PartialEq for Foo4 {
|
|
|
|
fn ne(&self, other: &Self) -> bool {
|
|
|
|
self.eq(other) // no error
|
|
|
|
}
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
self.ne(other) // no error
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
enum Foo5 {
|
|
|
|
A,
|
|
|
|
B,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Foo5 {
|
|
|
|
fn a(&self) -> bool {
|
|
|
|
true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl PartialEq for Foo5 {
|
|
|
|
fn ne(&self, other: &Self) -> bool {
|
|
|
|
self.a() // no error
|
|
|
|
}
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
self.a() // no error
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct S;
|
|
|
|
|
|
|
|
// Check the order doesn't matter.
|
|
|
|
impl PartialEq for S {
|
|
|
|
fn ne(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
other != self
|
|
|
|
}
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
other == self
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct S2;
|
|
|
|
|
|
|
|
// Check that if the same element is compared, it's also triggering the lint.
|
|
|
|
impl PartialEq for S2 {
|
|
|
|
fn ne(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
other != other
|
|
|
|
}
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
other == other
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct S3;
|
|
|
|
|
|
|
|
impl PartialEq for S3 {
|
|
|
|
fn ne(&self, _other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
self != self
|
|
|
|
}
|
|
|
|
fn eq(&self, _other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
self == self
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-16 11:15:32 -06:00
|
|
|
// There should be no warning here!
|
|
|
|
#[derive(PartialEq)]
|
|
|
|
enum E {
|
|
|
|
A,
|
|
|
|
B,
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(PartialEq)]
|
|
|
|
struct Bar<T: PartialEq>(T);
|
|
|
|
|
|
|
|
struct S4;
|
|
|
|
|
|
|
|
impl PartialEq for S4 {
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
// No warning here.
|
|
|
|
Bar(self) == Bar(other)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
macro_rules! impl_partial_eq {
|
|
|
|
($ty:ident) => {
|
|
|
|
impl PartialEq for $ty {
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
self == other
|
|
|
|
}
|
|
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
struct S5;
|
|
|
|
|
|
|
|
impl_partial_eq!(S5);
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
|
2023-12-31 04:01:47 -06:00
|
|
|
struct S6 {
|
|
|
|
field: String,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl PartialEq for S6 {
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
let mine = &self.field;
|
|
|
|
let theirs = &other.field;
|
|
|
|
mine == theirs // Should not warn!
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct S7<'a> {
|
|
|
|
field: &'a S7<'a>,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'a> PartialEq for S7<'a> {
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
let mine = &self.field;
|
|
|
|
let theirs = &other.field;
|
|
|
|
mine == theirs
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct S8 {
|
|
|
|
num: i32,
|
|
|
|
field: Option<Box<S8>>,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl PartialEq for S8 {
|
|
|
|
fn eq(&self, other: &Self) -> bool {
|
|
|
|
if self.num != other.num {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
let (this, other) = match (self.field.as_deref(), other.field.as_deref()) {
|
|
|
|
(Some(x1), Some(x2)) => (x1, x2),
|
|
|
|
(None, None) => return true,
|
|
|
|
_ => return false,
|
|
|
|
};
|
|
|
|
|
|
|
|
this == other
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct S9;
|
2023-12-18 09:44:07 -06:00
|
|
|
|
2023-12-31 04:01:47 -06:00
|
|
|
impl std::string::ToString for S9 {
|
2023-12-18 09:44:07 -06:00
|
|
|
fn to_string(&self) -> String {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
self.to_string()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-31 04:01:47 -06:00
|
|
|
struct S10;
|
2023-12-18 09:44:07 -06:00
|
|
|
|
2023-12-31 04:01:47 -06:00
|
|
|
impl std::string::ToString for S10 {
|
2023-12-18 09:44:07 -06:00
|
|
|
fn to_string(&self) -> String {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
let x = self;
|
|
|
|
x.to_string()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-31 04:01:47 -06:00
|
|
|
struct S11;
|
2023-12-18 09:44:07 -06:00
|
|
|
|
2023-12-31 04:01:47 -06:00
|
|
|
impl std::string::ToString for S11 {
|
2023-12-18 09:44:07 -06:00
|
|
|
fn to_string(&self) -> String {
|
|
|
|
//~^ ERROR: function cannot return without recursing
|
|
|
|
(self as &Self).to_string()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-12-08 17:12:32 -06:00
|
|
|
fn main() {
|
|
|
|
// test code goes here
|
|
|
|
}
|