2014-11-02 17:58:00 -06:00
|
|
|
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution and at
|
|
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 02:30:51 -06:00
|
|
|
// If `Index` used an associated type for its output, this test would
|
|
|
|
// work more smoothly.
|
|
|
|
#![feature(old_orphan_check)]
|
|
|
|
|
2014-12-22 11:04:23 -06:00
|
|
|
use std::ops::Index;
|
|
|
|
|
2014-11-02 17:58:00 -06:00
|
|
|
struct Mat<T> { data: Vec<T>, cols: uint, }
|
|
|
|
|
|
|
|
impl<T> Mat<T> {
|
|
|
|
fn new(data: Vec<T>, cols: uint) -> Mat<T> {
|
|
|
|
Mat { data: data, cols: cols }
|
|
|
|
}
|
|
|
|
fn row<'a>(&'a self, row: uint) -> Row<&'a Mat<T>> {
|
|
|
|
Row { mat: self, row: row, }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<T> Index<(uint, uint), T> for Mat<T> {
|
|
|
|
fn index<'a>(&'a self, &(row, col): &(uint, uint)) -> &'a T {
|
|
|
|
&self.data[row * self.cols + col]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'a, T> Index<(uint, uint), T> for &'a Mat<T> {
|
|
|
|
fn index<'b>(&'b self, index: &(uint, uint)) -> &'b T {
|
|
|
|
(*self).index(index)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct Row<M> { mat: M, row: uint, }
|
|
|
|
|
|
|
|
impl<T, M: Index<(uint, uint), T>> Index<uint, T> for Row<M> {
|
|
|
|
fn index<'a>(&'a self, col: &uint) -> &'a T {
|
|
|
|
&self.mat[(self.row, *col)]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
let m = Mat::new(vec!(1u, 2, 3, 4, 5, 6), 3);
|
|
|
|
let r = m.row(1);
|
|
|
|
|
|
|
|
assert!(r.index(&2) == &6);
|
|
|
|
assert!(r[2] == 6);
|
|
|
|
assert!(r[2u] == 6u);
|
|
|
|
assert!(6 == r[2]);
|
|
|
|
|
|
|
|
let e = r[2];
|
|
|
|
assert!(e == 6);
|
|
|
|
|
|
|
|
let e: uint = r[2];
|
|
|
|
assert!(e == 6);
|
|
|
|
}
|