2019-01-02 15:48:44 -06:00
|
|
|
|
// aux-build:option_helpers.rs
|
|
|
|
|
|
2019-10-16 12:43:26 -05:00
|
|
|
|
#![warn(clippy::all, clippy::pedantic)]
|
2018-12-08 11:56:59 -06:00
|
|
|
|
#![allow(
|
2022-06-08 14:08:37 -05:00
|
|
|
|
clippy::disallowed_names,
|
2019-09-18 01:37:41 -05:00
|
|
|
|
clippy::default_trait_access,
|
2023-02-16 06:05:08 -06:00
|
|
|
|
clippy::let_underscore_untyped,
|
2019-09-18 01:37:41 -05:00
|
|
|
|
clippy::missing_docs_in_private_items,
|
2020-04-08 05:57:58 -05:00
|
|
|
|
clippy::missing_safety_doc,
|
2018-12-08 11:56:59 -06:00
|
|
|
|
clippy::non_ascii_literal,
|
|
|
|
|
clippy::new_without_default,
|
|
|
|
|
clippy::needless_pass_by_value,
|
2020-06-16 18:16:34 -05:00
|
|
|
|
clippy::needless_lifetimes,
|
2019-09-18 01:37:41 -05:00
|
|
|
|
clippy::print_stdout,
|
|
|
|
|
clippy::must_use_candidate,
|
2018-12-08 11:56:59 -06:00
|
|
|
|
clippy::use_self,
|
2019-07-31 23:54:57 -05:00
|
|
|
|
clippy::useless_format,
|
2019-09-18 01:37:41 -05:00
|
|
|
|
clippy::wrong_self_convention,
|
2022-06-20 07:03:27 -05:00
|
|
|
|
clippy::unused_async,
|
2019-10-04 12:18:52 -05:00
|
|
|
|
clippy::unused_self,
|
2019-09-18 01:37:41 -05:00
|
|
|
|
unused
|
2018-12-08 11:56:59 -06:00
|
|
|
|
)]
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2019-01-02 15:48:44 -06:00
|
|
|
|
#[macro_use]
|
|
|
|
|
extern crate option_helpers;
|
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
use std::collections::BTreeMap;
|
|
|
|
|
use std::collections::HashMap;
|
|
|
|
|
use std::collections::HashSet;
|
|
|
|
|
use std::collections::VecDeque;
|
2019-02-22 00:05:21 -06:00
|
|
|
|
use std::ops::Mul;
|
2017-09-09 20:51:54 -05:00
|
|
|
|
use std::rc::{self, Rc};
|
|
|
|
|
use std::sync::{self, Arc};
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2021-08-13 01:34:33 -05:00
|
|
|
|
use option_helpers::{IteratorFalsePositives, IteratorMethodFalsePositives};
|
2019-01-02 00:23:00 -06:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
struct Lt<'a> {
|
|
|
|
|
foo: &'a u32,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> Lt<'a> {
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// The lifetime is different, but that’s irrelevant; see issue #734.
|
2018-07-28 10:34:52 -05:00
|
|
|
|
#[allow(clippy::needless_lifetimes)]
|
2019-02-22 00:05:21 -06:00
|
|
|
|
pub fn new<'b>(s: &'b str) -> Lt<'b> {
|
|
|
|
|
unimplemented!()
|
|
|
|
|
}
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct Lt2<'a> {
|
|
|
|
|
foo: &'a u32,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> Lt2<'a> {
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// The lifetime is different, but that’s irrelevant; see issue #734.
|
2019-02-22 00:05:21 -06:00
|
|
|
|
pub fn new(s: &str) -> Lt2 {
|
|
|
|
|
unimplemented!()
|
|
|
|
|
}
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct Lt3<'a> {
|
|
|
|
|
foo: &'a u32,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> Lt3<'a> {
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// The lifetime is different, but that’s irrelevant; see issue #734.
|
2019-02-22 00:05:21 -06:00
|
|
|
|
pub fn new() -> Lt3<'static> {
|
|
|
|
|
unimplemented!()
|
|
|
|
|
}
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|
|
|
|
|
|
2019-02-22 00:05:21 -06:00
|
|
|
|
#[derive(Clone, Copy)]
|
2017-02-07 14:05:30 -06:00
|
|
|
|
struct U;
|
|
|
|
|
|
|
|
|
|
impl U {
|
2019-02-22 00:05:21 -06:00
|
|
|
|
fn new() -> Self {
|
|
|
|
|
U
|
|
|
|
|
}
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// Ok because `U` is `Copy`.
|
2019-02-22 00:05:21 -06:00
|
|
|
|
fn to_something(self) -> u32 {
|
|
|
|
|
0
|
|
|
|
|
}
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct V<T> {
|
2019-02-22 00:05:21 -06:00
|
|
|
|
_dummy: T,
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<T> V<T> {
|
2019-02-22 00:05:21 -06:00
|
|
|
|
fn new() -> Option<V<T>> {
|
|
|
|
|
None
|
|
|
|
|
}
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|
|
|
|
|
|
2019-08-09 10:44:05 -05:00
|
|
|
|
struct AsyncNew;
|
|
|
|
|
|
|
|
|
|
impl AsyncNew {
|
2019-08-09 12:19:49 -05:00
|
|
|
|
async fn new() -> Option<Self> {
|
|
|
|
|
None
|
2019-08-09 10:44:05 -05:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-08-09 16:15:49 -05:00
|
|
|
|
struct BadNew;
|
|
|
|
|
|
|
|
|
|
impl BadNew {
|
|
|
|
|
fn new() -> i32 {
|
|
|
|
|
0
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2020-07-29 18:41:12 -05:00
|
|
|
|
struct T;
|
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
impl Mul<T> for T {
|
|
|
|
|
type Output = T;
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// No error, obviously.
|
2019-02-22 00:05:21 -06:00
|
|
|
|
fn mul(self, other: T) -> T {
|
|
|
|
|
self
|
|
|
|
|
}
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-30 19:15:29 -06:00
|
|
|
|
/// Checks implementation of `FILTER_NEXT` lint.
|
2019-02-21 23:49:17 -06:00
|
|
|
|
#[rustfmt::skip]
|
2017-02-07 14:05:30 -06:00
|
|
|
|
fn filter_next() {
|
|
|
|
|
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
|
|
|
|
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// Multi-line case.
|
2017-02-08 07:58:07 -06:00
|
|
|
|
let _ = v.iter().filter(|&x| {
|
2017-02-07 14:05:30 -06:00
|
|
|
|
*x < 0
|
|
|
|
|
}
|
|
|
|
|
).next();
|
|
|
|
|
|
2020-10-23 02:49:47 -05:00
|
|
|
|
// Check that we don't lint if the caller is not an `Iterator`.
|
2017-02-07 14:05:30 -06:00
|
|
|
|
let foo = IteratorFalsePositives { foo: 0 };
|
|
|
|
|
let _ = foo.filter().next();
|
2021-08-13 01:34:33 -05:00
|
|
|
|
|
|
|
|
|
let foo = IteratorMethodFalsePositives {};
|
|
|
|
|
let _ = foo.filter(42).next();
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn main() {
|
2019-10-16 12:43:26 -05:00
|
|
|
|
filter_next();
|
2017-02-07 14:05:30 -06:00
|
|
|
|
}
|