2019-02-23 23:30:08 -06:00
|
|
|
|
// run-rustfix
|
2023-02-25 16:39:15 -06:00
|
|
|
|
// aux-build: proc_macro_with_span.rs
|
2022-10-02 14:13:22 -05:00
|
|
|
|
#![warn(clippy::useless_format)]
|
2022-01-27 08:12:45 -06:00
|
|
|
|
#![allow(
|
2022-07-25 15:36:03 -05:00
|
|
|
|
unused_tuple_struct_fields,
|
2022-01-27 08:12:45 -06:00
|
|
|
|
clippy::print_literal,
|
|
|
|
|
clippy::redundant_clone,
|
|
|
|
|
clippy::to_string_in_format_args,
|
2022-10-02 14:13:22 -05:00
|
|
|
|
clippy::needless_borrow,
|
|
|
|
|
clippy::uninlined_format_args
|
2022-01-27 08:12:45 -06:00
|
|
|
|
)]
|
2016-02-20 10:35:07 -06:00
|
|
|
|
|
2023-02-25 16:39:15 -06:00
|
|
|
|
extern crate proc_macro_with_span;
|
|
|
|
|
|
2018-04-05 00:52:26 -05:00
|
|
|
|
struct Foo(pub String);
|
|
|
|
|
|
|
|
|
|
macro_rules! foo {
|
2019-03-10 12:19:47 -05:00
|
|
|
|
($($t:tt)*) => (Foo(format!($($t)*)))
|
2018-04-05 00:52:26 -05:00
|
|
|
|
}
|
|
|
|
|
|
2016-02-20 10:35:07 -06:00
|
|
|
|
fn main() {
|
2017-02-08 07:58:07 -06:00
|
|
|
|
format!("foo");
|
2019-04-09 09:15:48 -05:00
|
|
|
|
format!("{{}}");
|
|
|
|
|
format!("{{}} abc {{}}");
|
2019-08-23 03:01:41 -05:00
|
|
|
|
format!(
|
|
|
|
|
r##"foo {{}}
|
|
|
|
|
" bar"##
|
|
|
|
|
);
|
2016-02-22 10:54:46 -06:00
|
|
|
|
|
2021-11-04 07:52:36 -05:00
|
|
|
|
let _ = format!("");
|
|
|
|
|
|
2017-02-08 07:58:07 -06:00
|
|
|
|
format!("{}", "foo");
|
2019-01-30 19:15:29 -06:00
|
|
|
|
format!("{:?}", "foo"); // Don't warn about `Debug`.
|
2018-04-12 01:21:03 -05:00
|
|
|
|
format!("{:8}", "foo");
|
2018-10-02 16:54:50 -05:00
|
|
|
|
format!("{:width$}", "foo", width = 8);
|
2016-02-22 10:54:46 -06:00
|
|
|
|
format!("foo {}", "bar");
|
|
|
|
|
format!("{} bar", "foo");
|
|
|
|
|
|
2022-08-05 18:59:50 -05:00
|
|
|
|
let arg = String::new();
|
2017-02-08 07:58:07 -06:00
|
|
|
|
format!("{}", arg);
|
2019-01-30 19:15:29 -06:00
|
|
|
|
format!("{:?}", arg); // Don't warn about debug.
|
2018-04-12 01:21:03 -05:00
|
|
|
|
format!("{:8}", arg);
|
2018-10-02 16:54:50 -05:00
|
|
|
|
format!("{:width$}", arg, width = 8);
|
2016-02-22 10:54:46 -06:00
|
|
|
|
format!("foo {}", arg);
|
|
|
|
|
format!("{} bar", arg);
|
|
|
|
|
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// We don’t want to warn for non-string args; see issue #697.
|
2016-02-22 10:54:46 -06:00
|
|
|
|
format!("{}", 42);
|
|
|
|
|
format!("{:?}", 42);
|
|
|
|
|
format!("{:+}", 42);
|
2016-02-20 10:35:07 -06:00
|
|
|
|
format!("foo {}", 42);
|
2016-02-20 14:15:05 -06:00
|
|
|
|
format!("{} bar", 42);
|
2016-02-20 10:35:07 -06:00
|
|
|
|
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// We only want to warn about `format!` itself.
|
2016-02-20 10:35:07 -06:00
|
|
|
|
println!("foo");
|
2016-02-22 10:54:46 -06:00
|
|
|
|
println!("{}", "foo");
|
|
|
|
|
println!("foo {}", "foo");
|
|
|
|
|
println!("{}", 42);
|
2016-02-20 10:35:07 -06:00
|
|
|
|
println!("foo {}", 42);
|
2018-04-05 00:52:26 -05:00
|
|
|
|
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// A `format!` inside a macro should not trigger a warning.
|
2018-04-05 00:52:26 -05:00
|
|
|
|
foo!("should not warn");
|
2018-10-02 16:55:25 -05:00
|
|
|
|
|
2019-01-30 19:15:29 -06:00
|
|
|
|
// Precision on string means slicing without panicking on size.
|
2019-03-10 12:19:47 -05:00
|
|
|
|
format!("{:.1}", "foo"); // Could be `"foo"[..1]`
|
|
|
|
|
format!("{:.10}", "foo"); // Could not be `"foo"[..10]`
|
2018-10-02 16:55:25 -05:00
|
|
|
|
format!("{:.prec$}", "foo", prec = 1);
|
|
|
|
|
format!("{:.prec$}", "foo", prec = 10);
|
2018-10-03 13:59:59 -05:00
|
|
|
|
|
|
|
|
|
format!("{}", 42.to_string());
|
|
|
|
|
let x = std::path::PathBuf::from("/bar/foo/qux");
|
|
|
|
|
format!("{}", x.display().to_string());
|
2019-08-23 03:46:23 -05:00
|
|
|
|
|
|
|
|
|
// False positive
|
|
|
|
|
let a = "foo".to_string();
|
|
|
|
|
let _ = Some(format!("{}", a + "bar"));
|
2021-04-22 04:31:13 -05:00
|
|
|
|
|
|
|
|
|
// Wrap it with braces
|
|
|
|
|
let v: Vec<String> = vec!["foo".to_string(), "bar".to_string()];
|
|
|
|
|
let _s: String = format!("{}", &*v.join("\n"));
|
2021-07-15 03:44:10 -05:00
|
|
|
|
|
|
|
|
|
format!("prepend {:+}", "s");
|
2022-01-17 06:29:07 -06:00
|
|
|
|
|
|
|
|
|
// Issue #8290
|
|
|
|
|
let x = "foo";
|
|
|
|
|
let _ = format!("{x}");
|
|
|
|
|
let _ = format!("{x:?}"); // Don't lint on debug
|
|
|
|
|
let _ = format!("{y}", y = x);
|
2022-07-28 12:08:22 -05:00
|
|
|
|
|
|
|
|
|
// Issue #9234
|
|
|
|
|
let abc = "abc";
|
|
|
|
|
let _ = format!("{abc}");
|
|
|
|
|
let xx = "xx";
|
|
|
|
|
let _ = format!("{xx}");
|
2023-02-25 16:39:15 -06:00
|
|
|
|
|
|
|
|
|
// Issue #10148
|
|
|
|
|
println!(proc_macro_with_span::with_span!(""something ""));
|
2016-02-20 10:35:07 -06:00
|
|
|
|
}
|