2022-02-11 08:45:56 -06:00
|
|
|
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
|
|
use clippy_utils::macros::root_macro_call_first_node;
|
|
|
|
use clippy_utils::source::snippet_with_applicability;
|
2019-02-03 03:28:42 -06:00
|
|
|
use rustc_errors::Applicability;
|
2022-02-11 08:45:56 -06:00
|
|
|
use rustc_hir::{Expr, ExprKind};
|
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-01-11 05:37:08 -06:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2022-02-11 08:45:56 -06:00
|
|
|
use rustc_span::sym;
|
2019-01-30 11:39:38 -06:00
|
|
|
|
|
|
|
declare_clippy_lint! {
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for usage of dbg!() macro.
|
2019-03-05 10:50:33 -06:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// `dbg!` macro is intended as a debugging tool. It
|
2019-03-05 10:50:33 -06:00
|
|
|
/// should not be in version control.
|
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Example
|
2019-03-05 10:50:33 -06:00
|
|
|
/// ```rust,ignore
|
|
|
|
/// // Bad
|
|
|
|
/// dbg!(true)
|
|
|
|
///
|
|
|
|
/// // Good
|
|
|
|
/// true
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 14:06:26 -05:00
|
|
|
#[clippy::version = "1.34.0"]
|
2019-01-30 11:39:38 -06:00
|
|
|
pub DBG_MACRO,
|
2019-01-31 18:23:40 -06:00
|
|
|
restriction,
|
2019-01-30 11:39:38 -06:00
|
|
|
"`dbg!` macro is intended as a debugging tool"
|
|
|
|
}
|
|
|
|
|
2019-04-08 15:43:55 -05:00
|
|
|
declare_lint_pass!(DbgMacro => [DBG_MACRO]);
|
2019-01-30 11:39:38 -06:00
|
|
|
|
2022-02-11 08:45:56 -06:00
|
|
|
impl LateLintPass<'_> for DbgMacro {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
|
|
|
|
let Some(macro_call) = root_macro_call_first_node(cx, expr) else { return };
|
|
|
|
if cx.tcx.is_diagnostic_item(sym::dbg_macro, macro_call.def_id) {
|
|
|
|
let mut applicability = Applicability::MachineApplicable;
|
|
|
|
let suggestion = match expr.peel_drop_temps().kind {
|
|
|
|
// dbg!()
|
|
|
|
ExprKind::Block(_, _) => String::new(),
|
|
|
|
// dbg!(1)
|
|
|
|
ExprKind::Match(val, ..) => {
|
|
|
|
snippet_with_applicability(cx, val.span.source_callsite(), "..", &mut applicability).to_string()
|
|
|
|
},
|
|
|
|
// dbg!(2, 3)
|
|
|
|
ExprKind::Tup(
|
|
|
|
[
|
|
|
|
Expr {
|
|
|
|
kind: ExprKind::Match(first, ..),
|
|
|
|
..
|
|
|
|
},
|
|
|
|
..,
|
|
|
|
Expr {
|
|
|
|
kind: ExprKind::Match(last, ..),
|
|
|
|
..
|
|
|
|
},
|
|
|
|
],
|
|
|
|
) => {
|
|
|
|
let snippet = snippet_with_applicability(
|
|
|
|
cx,
|
|
|
|
first.span.source_callsite().to(last.span.source_callsite()),
|
|
|
|
"..",
|
|
|
|
&mut applicability,
|
|
|
|
);
|
|
|
|
format!("({snippet})")
|
|
|
|
},
|
|
|
|
_ => return,
|
|
|
|
};
|
|
|
|
|
|
|
|
span_lint_and_sugg(
|
|
|
|
cx,
|
|
|
|
DBG_MACRO,
|
|
|
|
macro_call.span,
|
|
|
|
"`dbg!` macro is intended as a debugging tool",
|
|
|
|
"ensure to avoid having uses of it in version control",
|
|
|
|
suggestion,
|
|
|
|
applicability,
|
|
|
|
);
|
2019-01-30 11:39:38 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|