2017-08-21 03:26:46 -05:00
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:20:25
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
20 | fn add(self, other: T) -> T { self }
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
|
= note: `-D use-self` implied by `-D warnings`
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:20:31
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
20 | fn add(self, other: T) -> T { self }
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:23:26
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
23 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:23:33
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
23 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:24:21
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
24 | fn div(self) -> T { self } // no error, different #arguments
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:25:25
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
25 | fn rem(self, other: T) { } // no error, wrong return type
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
2017-02-07 14:05:30 -06:00
error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:20:5
2017-02-07 14:05:30 -06:00
|
2017-09-09 20:51:54 -05:00
20 | fn add(self, other: T) -> T { self }
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D should-implement-trait` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: defining a method called `drop` on this type; consider implementing the `std::ops::Drop` trait or choosing a less ambiguous name
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:21:5
2017-02-07 14:05:30 -06:00
|
2017-09-09 20:51:54 -05:00
21 | fn drop(&mut self) { }
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^
error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:28:17
2017-02-07 14:05:30 -06:00
|
2017-09-09 20:51:54 -05:00
28 | fn into_u16(&self) -> u16 { 0 }
2017-02-07 14:05:30 -06:00
| ^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D wrong-self-convention` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:30:21
2017-02-07 14:05:30 -06:00
|
2017-09-09 20:51:54 -05:00
30 | fn to_something(self) -> u32 { 0 }
2017-02-07 14:05:30 -06:00
| ^^^^
error: methods called `new` usually take no self; consider choosing a less ambiguous name
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:32:12
2017-02-07 14:05:30 -06:00
|
2017-09-09 20:51:54 -05:00
32 | fn new(self) {}
2017-02-07 14:05:30 -06:00
| ^^^^
error: methods called `new` usually return `Self`
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:32:5
2017-02-07 14:05:30 -06:00
|
2017-09-09 20:51:54 -05:00
32 | fn new(self) {}
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D new-ret-no-self` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
2017-08-21 03:26:46 -05:00
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:76:24
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
76 | fn new() -> Option<V<T>> { None }
2017-08-21 03:26:46 -05:00
| ^^^^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:80:19
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
80 | type Output = T;
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:81:25
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
81 | fn mul(self, other: T) -> T { self } // no error, obviously
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:81:31
2017-08-21 03:26:46 -05:00
|
2017-09-09 20:51:54 -05:00
81 | fn mul(self, other: T) -> T { self } // no error, obviously
2017-08-21 03:26:46 -05:00
| ^ help: use the applicable keyword: `Self`
2017-02-07 14:05:30 -06:00
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:99:13
|
99 | let _ = opt.map(|x| x + 1)
| _____________^
100 | |
101 | | .unwrap_or(0); // should lint even though this call is on a separate line
| |____________________________^
|
= note: `-D option-map-unwrap-or` implied by `-D warnings`
= note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
2017-02-07 14:05:30 -06:00
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:103:13
2017-02-07 14:05:30 -06:00
|
2017-09-09 20:51:54 -05:00
103 | let _ = opt.map(|x| {
2017-04-23 08:25:22 -05:00
| _____________^
2017-09-09 20:51:54 -05:00
104 | | x + 1
105 | | }
106 | | ).unwrap_or(0);
2017-04-23 08:25:22 -05:00
| |____________________________^
2017-02-07 14:05:30 -06:00
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
2017-09-09 20:51:54 -05:00
--> $DIR/methods.rs:107:13
2017-02-07 14:05:30 -06:00
|
2017-09-09 20:51:54 -05:00
107 | let _ = opt.map(|x| x + 1)
2017-04-23 08:25:22 -05:00
| _____________^
2017-09-09 20:51:54 -05:00
108 | | .unwrap_or({
109 | | 0
110 | | });
2017-04-23 08:25:22 -05:00
| |__________________^
2017-02-07 14:05:30 -06:00
2017-10-06 08:04:16 -05:00
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
--> $DIR/methods.rs:112:13
|
112 | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
2017-10-07 07:14:30 -05:00
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
--> $DIR/methods.rs:114:13
|
114 | let _ = opt.map(|x| {
| _____________^
115 | | Some(x + 1)
116 | | }
117 | | ).unwrap_or(None);
| |_____________________^
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
2017-10-06 08:04:16 -05:00
--> $DIR/methods.rs:118:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
118 | let _ = opt
| _____________^
119 | | .map(|x| Some(x + 1))
120 | | .unwrap_or(None);
| |________________________^
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
--> $DIR/methods.rs:126:13
|
126 | let _ = opt.map(|x| x + 1)
2017-04-23 08:25:22 -05:00
| _____________^
2017-10-07 07:14:30 -05:00
127 | |
128 | | .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
2017-04-23 08:25:22 -05:00
| |____________________________________^
2017-02-07 14:05:30 -06:00
|
2017-05-17 07:19:44 -05:00
= note: `-D option-map-unwrap-or-else` implied by `-D warnings`
2017-04-01 08:49:55 -05:00
= note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
2017-02-07 14:05:30 -06:00
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:130:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
130 | let _ = opt.map(|x| {
2017-04-23 08:25:22 -05:00
| _____________^
2017-10-07 07:14:30 -05:00
131 | | x + 1
132 | | }
133 | | ).unwrap_or_else(|| 0);
2017-04-23 08:25:22 -05:00
| |____________________________________^
2017-02-07 14:05:30 -06:00
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:134:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
134 | let _ = opt.map(|x| x + 1)
2017-04-23 08:25:22 -05:00
| _____________^
2017-10-07 07:14:30 -05:00
135 | | .unwrap_or_else(||
136 | | 0
137 | | );
2017-04-23 08:25:22 -05:00
| |_________________^
2017-02-07 14:05:30 -06:00
2017-08-21 03:26:46 -05:00
error: unnecessary structure name repetition
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:163:24
2017-08-21 03:26:46 -05:00
|
2017-10-07 07:14:30 -05:00
163 | fn filter(self) -> IteratorFalsePositives {
2017-08-21 03:26:46 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:167:22
2017-08-21 03:26:46 -05:00
|
2017-10-07 07:14:30 -05:00
167 | fn next(self) -> IteratorFalsePositives {
2017-08-21 03:26:46 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
error: unnecessary structure name repetition
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:187:32
2017-08-21 03:26:46 -05:00
|
2017-10-07 07:14:30 -05:00
187 | fn skip(self, _: usize) -> IteratorFalsePositives {
2017-08-21 03:26:46 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
2017-02-07 14:05:30 -06:00
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:206:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
206 | let _ = v.iter().filter(|&x| *x < 0).next();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D filter-next` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:209:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
209 | let _ = v.iter().filter(|&x| {
2017-04-23 08:25:22 -05:00
| _____________^
2017-10-07 07:14:30 -05:00
210 | | *x < 0
211 | | }
212 | | ).next();
2017-04-23 08:25:22 -05:00
| |___________________________^
2017-02-07 14:05:30 -06:00
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:224:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
224 | let _ = v.iter().find(|&x| *x < 0).is_some();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D search-is-some` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
= note: replace `find(|&x| *x < 0).is_some()` with `any(|&x| *x < 0)`
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:227:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
227 | let _ = v.iter().find(|&x| {
2017-04-23 08:25:22 -05:00
| _____________^
2017-10-07 07:14:30 -05:00
228 | | *x < 0
229 | | }
230 | | ).is_some();
2017-04-23 08:25:22 -05:00
| |______________________________^
2017-02-07 14:05:30 -06:00
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:233:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
233 | let _ = v.iter().position(|&x| x < 0).is_some();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:236:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
236 | let _ = v.iter().position(|&x| {
2017-04-23 08:25:22 -05:00
| _____________^
2017-10-07 07:14:30 -05:00
237 | | x < 0
238 | | }
239 | | ).is_some();
2017-04-23 08:25:22 -05:00
| |______________________________^
2017-02-07 14:05:30 -06:00
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:242:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
242 | let _ = v.iter().rposition(|&x| x < 0).is_some();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:245:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
245 | let _ = v.iter().rposition(|&x| {
2017-04-23 08:25:22 -05:00
| _____________^
2017-10-07 07:14:30 -05:00
246 | | x < 0
247 | | }
248 | | ).is_some();
2017-04-23 08:25:22 -05:00
| |______________________________^
2017-02-07 14:05:30 -06:00
2017-08-21 03:26:46 -05:00
error: unnecessary structure name repetition
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:262:21
2017-08-21 03:26:46 -05:00
|
2017-10-07 07:14:30 -05:00
262 | fn new() -> Foo { Foo }
2017-08-21 03:26:46 -05:00
| ^^^ help: use the applicable keyword: `Self`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:280:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
280 | with_constructor.unwrap_or(make());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_constructor.unwrap_or_else(make)`
2017-02-07 14:05:30 -06:00
|
2017-05-17 07:19:44 -05:00
= note: `-D or-fun-call` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a call to `new`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:283:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
283 | with_new.unwrap_or(Vec::new());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:286:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
286 | with_const_args.unwrap_or(Vec::with_capacity(12));
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_const_args.unwrap_or_else(|| Vec::with_capacity(12))`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:289:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
289 | with_err.unwrap_or(make());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err.unwrap_or_else(|_| make())`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:292:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
292 | with_err_args.unwrap_or(Vec::with_capacity(12));
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err_args.unwrap_or_else(|_| Vec::with_capacity(12))`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a call to `default`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:295:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
295 | with_default_trait.unwrap_or(Default::default());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a call to `default`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:298:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
298 | with_default_type.unwrap_or(u64::default());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:301:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
301 | with_vec.unwrap_or(vec![]);
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_vec.unwrap_or_else(|| < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:306:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
306 | without_default.unwrap_or(Foo::new());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `without_default.unwrap_or_else(Foo::new)`
2017-02-07 14:05:30 -06:00
error: use of `or_insert` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:309:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
309 | map.entry(42).or_insert(String::new());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `map.entry(42).or_insert_with(String::new)`
2017-02-07 14:05:30 -06:00
error: use of `or_insert` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:312:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
312 | btree.entry(42).or_insert(String::new());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `btree.entry(42).or_insert_with(String::new)`
2017-02-07 14:05:30 -06:00
error: use of `unwrap_or` followed by a function call
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:315:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
315 | let _ = stringy.unwrap_or("".to_owned());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `stringy.unwrap_or_else(|| "".to_owned())`
2017-02-07 14:05:30 -06:00
error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:326:23
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
326 | let bad_vec = some_vec.iter().nth(3);
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D iter-nth` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:327:26
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
327 | let bad_slice = &some_vec[..].iter().nth(3);
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:328:31
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
328 | let bad_boxed_slice = boxed_slice.iter().nth(3);
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:329:29
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
329 | let bad_vec_deque = some_vec_deque.iter().nth(3);
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:334:23
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
334 | let bad_vec = some_vec.iter_mut().nth(3);
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:337:26
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
337 | let bad_slice = &some_vec[..].iter_mut().nth(3);
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:340:29
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
340 | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:352:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
352 | let _ = some_vec.iter().skip(42).next();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D iter-skip-next` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:353:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
353 | let _ = some_vec.iter().cycle().skip(42).next();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:354:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
354 | let _ = (1..10).skip(10).next();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:355:14
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
355 | let _ = &some_vec[..].iter().skip(3).next();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:381:17
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
381 | let _ = boxed_slice.get(1).unwrap();
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&boxed_slice[1]`
2017-02-07 14:05:30 -06:00
|
2017-05-17 07:19:44 -05:00
= note: `-D get-unwrap` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:382:17
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
382 | let _ = some_slice.get(0).unwrap();
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_slice[0]`
2017-02-07 14:05:30 -06:00
error: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:383:17
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
383 | let _ = some_vec.get(0).unwrap();
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_vec[0]`
2017-02-07 14:05:30 -06:00
error: called `.get().unwrap()` on a VecDeque. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:384:17
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
384 | let _ = some_vecdeque.get(0).unwrap();
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_vecdeque[0]`
2017-02-07 14:05:30 -06:00
error: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:385:17
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
385 | let _ = some_hashmap.get(&1).unwrap();
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_hashmap[&1]`
2017-02-07 14:05:30 -06:00
error: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:386:17
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
386 | let _ = some_btreemap.get(&1).unwrap();
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_btreemap[&1]`
2017-02-07 14:05:30 -06:00
error: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:391:10
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
391 | *boxed_slice.get_mut(0).unwrap() = 1;
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut boxed_slice[0]`
2017-02-07 14:05:30 -06:00
error: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:392:10
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
392 | *some_slice.get_mut(0).unwrap() = 1;
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut some_slice[0]`
2017-02-07 14:05:30 -06:00
error: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:393:10
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
393 | *some_vec.get_mut(0).unwrap() = 1;
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut some_vec[0]`
2017-02-07 14:05:30 -06:00
error: called `.get_mut().unwrap()` on a VecDeque. Using `[]` is more clear and more concise
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:394:10
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
394 | *some_vecdeque.get_mut(0).unwrap() = 1;
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mut some_vecdeque[0]`
2017-02-07 14:05:30 -06:00
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:408:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
408 | let _ = opt.unwrap();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D option-unwrap-used` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: used unwrap() on a Result value. If you don't want to handle the Err case gracefully, consider using expect() to provide a better panic message
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:411:13
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
411 | let _ = res.unwrap();
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D result-unwrap-used` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:413:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
413 | res.ok().expect("disaster!");
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 07:19:44 -05:00
= note: `-D ok-expect` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:419:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
419 | res3.ok().expect("whoof");
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:421:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
421 | res4.ok().expect("argh");
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:423:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
423 | res5.ok().expect("oops");
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-10-07 07:14:30 -05:00
--> $DIR/methods.rs:425:5
2017-02-07 14:05:30 -06:00
|
2017-10-07 07:14:30 -05:00
425 | res6.ok().expect("meh");
2017-02-07 14:05:30 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^
error: calling `.extend(_.chars())`
2017-10-09 22:45:03 -05:00
--> $DIR/methods.rs:441:5
2017-02-07 14:05:30 -06:00
|
2017-10-09 22:45:03 -05:00
441 | s.extend(abc.chars());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^ help: try this: `s.push_str(abc)`
2017-02-07 14:05:30 -06:00
|
2017-05-17 07:19:44 -05:00
= note: `-D string-extend-chars` implied by `-D warnings`
2017-02-07 14:05:30 -06:00
error: calling `.extend(_.chars())`
2017-10-09 22:45:03 -05:00
--> $DIR/methods.rs:444:5
2017-02-07 14:05:30 -06:00
|
2017-10-09 22:45:03 -05:00
444 | s.extend("abc".chars());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `s.push_str("abc")`
2017-02-07 14:05:30 -06:00
error: calling `.extend(_.chars())`
2017-10-09 22:45:03 -05:00
--> $DIR/methods.rs:447:5
2017-02-07 14:05:30 -06:00
|
2017-10-09 22:45:03 -05:00
447 | s.extend(def.chars());
2017-07-21 03:40:23 -05:00
| ^^^^^^^^^^^^^^^^^^^^^ help: try this: `s.push_str(&def)`
2017-02-07 14:05:30 -06:00