2017-09-18 05:47:33 -05:00
|
|
|
#![feature(rustc_private)]
|
|
|
|
|
2018-09-15 02:21:58 -05:00
|
|
|
// FIXME: switch to something more ergonomic here, once available.
|
2019-01-30 19:15:29 -06:00
|
|
|
// (Currently there is no way to opt into sysroot crates without `extern crate`.)
|
2018-09-15 02:21:58 -05:00
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
extern crate rustc_driver;
|
|
|
|
#[allow(unused_extern_crates)]
|
2019-02-01 16:28:14 -06:00
|
|
|
extern crate rustc_interface;
|
2019-03-10 06:00:17 -05:00
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
extern crate rustc_plugin;
|
2018-09-15 02:21:58 -05:00
|
|
|
|
2019-02-01 16:28:14 -06:00
|
|
|
use rustc_interface::interface;
|
2019-04-30 04:10:31 -05:00
|
|
|
use rustc_tools_util::*;
|
|
|
|
|
2018-09-06 00:01:56 -05:00
|
|
|
use std::path::Path;
|
2018-12-14 03:15:56 -06:00
|
|
|
use std::process::{exit, Command};
|
2017-09-18 05:47:33 -05:00
|
|
|
|
2019-06-04 19:32:03 -05:00
|
|
|
mod lintlist;
|
|
|
|
|
2019-01-15 12:56:09 -06:00
|
|
|
/// If a command-line option matches `find_arg`, then apply the predicate `pred` on its value. If
|
|
|
|
/// true, then return it. The parameter is assumed to be either `--arg=value` or `--arg value`.
|
|
|
|
fn arg_value<'a>(
|
|
|
|
args: impl IntoIterator<Item = &'a String>,
|
|
|
|
find_arg: &str,
|
|
|
|
pred: impl Fn(&str) -> bool,
|
|
|
|
) -> Option<&'a str> {
|
|
|
|
let mut args = args.into_iter().map(String::as_str);
|
|
|
|
|
|
|
|
while let Some(arg) = args.next() {
|
|
|
|
let arg: Vec<_> = arg.splitn(2, '=').collect();
|
|
|
|
if arg.get(0) != Some(&find_arg) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
let value = arg.get(1).cloned().or_else(|| args.next());
|
|
|
|
if value.as_ref().map_or(false, |p| pred(p)) {
|
|
|
|
return value;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_arg_value() {
|
|
|
|
let args: Vec<_> = ["--bar=bar", "--foobar", "123", "--foo"]
|
|
|
|
.iter()
|
2019-02-10 06:35:44 -06:00
|
|
|
.map(std::string::ToString::to_string)
|
2019-01-15 12:56:09 -06:00
|
|
|
.collect();
|
|
|
|
|
|
|
|
assert_eq!(arg_value(None, "--foobar", |_| true), None);
|
|
|
|
assert_eq!(arg_value(&args, "--bar", |_| false), None);
|
|
|
|
assert_eq!(arg_value(&args, "--bar", |_| true), Some("bar"));
|
|
|
|
assert_eq!(arg_value(&args, "--bar", |p| p == "bar"), Some("bar"));
|
|
|
|
assert_eq!(arg_value(&args, "--bar", |p| p == "foo"), None);
|
|
|
|
assert_eq!(arg_value(&args, "--foobar", |p| p == "foo"), None);
|
|
|
|
assert_eq!(arg_value(&args, "--foobar", |p| p == "123"), Some("123"));
|
|
|
|
assert_eq!(arg_value(&args, "--foo", |_| true), None);
|
|
|
|
}
|
|
|
|
|
2019-01-13 09:19:02 -06:00
|
|
|
#[allow(clippy::too_many_lines)]
|
2019-02-01 16:28:14 -06:00
|
|
|
|
|
|
|
struct ClippyCallbacks;
|
|
|
|
|
|
|
|
impl rustc_driver::Callbacks for ClippyCallbacks {
|
|
|
|
fn after_parsing(&mut self, compiler: &interface::Compiler) -> bool {
|
|
|
|
let sess = compiler.session();
|
|
|
|
let mut registry = rustc_plugin::registry::Registry::new(
|
|
|
|
sess,
|
2019-03-10 06:00:17 -05:00
|
|
|
compiler
|
|
|
|
.parse()
|
|
|
|
.expect(
|
|
|
|
"at this compilation stage \
|
|
|
|
the crate must be parsed",
|
|
|
|
)
|
|
|
|
.peek()
|
|
|
|
.span,
|
2019-02-01 16:28:14 -06:00
|
|
|
);
|
|
|
|
registry.args_hidden = Some(Vec::new());
|
|
|
|
|
|
|
|
let conf = clippy_lints::read_conf(®istry);
|
|
|
|
clippy_lints::register_plugins(&mut registry, &conf);
|
|
|
|
|
|
|
|
let rustc_plugin::registry::Registry {
|
|
|
|
early_lint_passes,
|
|
|
|
late_lint_passes,
|
|
|
|
lint_groups,
|
|
|
|
llvm_passes,
|
|
|
|
attributes,
|
|
|
|
..
|
|
|
|
} = registry;
|
|
|
|
let mut ls = sess.lint_store.borrow_mut();
|
|
|
|
for pass in early_lint_passes {
|
|
|
|
ls.register_early_pass(Some(sess), true, false, pass);
|
|
|
|
}
|
|
|
|
for pass in late_lint_passes {
|
2019-03-30 09:58:14 -05:00
|
|
|
ls.register_late_pass(Some(sess), true, false, false, pass);
|
2019-02-01 16:28:14 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
for (name, (to, deprecated_name)) in lint_groups {
|
|
|
|
ls.register_group(Some(sess), true, name, deprecated_name, to);
|
|
|
|
}
|
|
|
|
clippy_lints::register_pre_expansion_lints(sess, &mut ls, &conf);
|
|
|
|
clippy_lints::register_renamed(&mut ls);
|
|
|
|
|
|
|
|
sess.plugin_llvm_passes.borrow_mut().extend(llvm_passes);
|
|
|
|
sess.plugin_attributes.borrow_mut().extend(attributes);
|
|
|
|
|
|
|
|
// Continue execution
|
|
|
|
true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-10 17:47:31 -05:00
|
|
|
#[allow(clippy::find_map, clippy::filter_map)]
|
2019-06-08 16:19:16 -05:00
|
|
|
fn describe_lints() {
|
|
|
|
use lintlist::*;
|
2019-06-08 16:49:33 -05:00
|
|
|
use std::collections::HashSet;
|
2018-11-27 14:12:13 -06:00
|
|
|
|
2019-06-08 16:19:16 -05:00
|
|
|
println!(
|
|
|
|
"
|
|
|
|
Available lint options:
|
|
|
|
-W <foo> Warn about <foo>
|
|
|
|
-A <foo> Allow <foo>
|
|
|
|
-D <foo> Deny <foo>
|
|
|
|
-F <foo> Forbid <foo> (deny <foo> and all attempts to override)
|
2018-11-27 14:12:13 -06:00
|
|
|
|
2019-06-08 16:19:16 -05:00
|
|
|
"
|
|
|
|
);
|
|
|
|
|
2019-06-08 19:08:16 -05:00
|
|
|
let lint_level = |lint: &Lint| {
|
|
|
|
LINT_LEVELS
|
|
|
|
.iter()
|
|
|
|
.find(|level_mapping| level_mapping.0 == lint.group)
|
2019-06-10 17:47:31 -05:00
|
|
|
.map(|(_, level)| match level {
|
|
|
|
Level::Allow => "allow",
|
|
|
|
Level::Warn => "warn",
|
|
|
|
Level::Deny => "deny",
|
2019-06-10 13:03:51 -05:00
|
|
|
})
|
2019-06-08 19:08:16 -05:00
|
|
|
.unwrap()
|
|
|
|
};
|
|
|
|
|
2019-06-08 16:19:16 -05:00
|
|
|
let mut lints: Vec<_> = ALL_LINTS.iter().collect();
|
|
|
|
// The sort doesn't case-fold but it's doubtful we care.
|
2019-06-08 19:08:16 -05:00
|
|
|
lints.sort_by_cached_key(|x: &&Lint| (lint_level(x), x.name));
|
2019-06-08 16:19:16 -05:00
|
|
|
|
2019-06-10 17:47:31 -05:00
|
|
|
let max_lint_name_len = lints
|
2019-06-08 16:19:16 -05:00
|
|
|
.iter()
|
|
|
|
.map(|lint| lint.name.len())
|
|
|
|
.map(|len| len + "clippy::".len())
|
|
|
|
.max()
|
|
|
|
.unwrap_or(0);
|
|
|
|
|
|
|
|
let padded = |x: &str| {
|
2019-06-10 17:47:31 -05:00
|
|
|
let mut s = " ".repeat(max_lint_name_len - x.chars().count());
|
2019-06-08 16:19:16 -05:00
|
|
|
s.push_str(x);
|
|
|
|
s
|
|
|
|
};
|
|
|
|
|
|
|
|
let scoped = |x: &str| format!("clippy::{}", x);
|
|
|
|
|
2019-06-08 16:49:33 -05:00
|
|
|
let lint_groups: HashSet<_> = lints.iter().map(|lint| lint.group).collect();
|
|
|
|
|
2019-06-08 16:19:16 -05:00
|
|
|
println!("Lint checks provided by clippy:\n");
|
|
|
|
println!(" {} {:7.7} meaning", padded("name"), "default");
|
|
|
|
println!(" {} {:7.7} -------", padded("----"), "-------");
|
|
|
|
|
2019-06-08 16:49:33 -05:00
|
|
|
let print_lints = |lints: &[&Lint]| {
|
2019-06-08 16:19:16 -05:00
|
|
|
for lint in lints {
|
|
|
|
let name = lint.name.replace("_", "-");
|
2019-06-10 13:14:54 -05:00
|
|
|
println!(
|
|
|
|
" {} {:7.7} {}",
|
|
|
|
padded(&scoped(&name)),
|
|
|
|
lint_level(lint),
|
|
|
|
lint.desc
|
|
|
|
);
|
2019-06-08 16:19:16 -05:00
|
|
|
}
|
|
|
|
println!("\n");
|
|
|
|
};
|
|
|
|
|
2019-06-08 16:49:33 -05:00
|
|
|
print_lints(&lints);
|
|
|
|
|
2019-06-10 17:47:31 -05:00
|
|
|
let max_group_name_len = std::cmp::max(
|
2019-06-12 14:29:23 -05:00
|
|
|
"clippy::all".len(),
|
2019-06-08 16:49:33 -05:00
|
|
|
lint_groups
|
|
|
|
.iter()
|
|
|
|
.map(|group| group.len())
|
|
|
|
.map(|len| len + "clippy::".len())
|
|
|
|
.max()
|
|
|
|
.unwrap_or(0),
|
|
|
|
);
|
|
|
|
|
2019-06-10 17:47:31 -05:00
|
|
|
let padded_group = |x: &str| {
|
|
|
|
let mut s = " ".repeat(max_group_name_len - x.chars().count());
|
2019-06-08 16:49:33 -05:00
|
|
|
s.push_str(x);
|
|
|
|
s
|
|
|
|
};
|
|
|
|
|
2019-06-10 13:03:51 -05:00
|
|
|
println!("Lint groups provided by clippy:\n");
|
2019-06-10 17:47:31 -05:00
|
|
|
println!(" {} sub-lints", padded_group("name"));
|
|
|
|
println!(" {} ---------", padded_group("----"));
|
|
|
|
println!(" {} the set of all clippy lints", padded_group("clippy::all"));
|
2019-06-08 16:49:33 -05:00
|
|
|
|
|
|
|
let print_lint_groups = || {
|
|
|
|
for group in lint_groups {
|
|
|
|
let name = group.to_lowercase().replace("_", "-");
|
2019-06-08 19:08:16 -05:00
|
|
|
let desc = lints
|
|
|
|
.iter()
|
2019-06-08 16:49:33 -05:00
|
|
|
.filter(|&lint| lint.group == group)
|
|
|
|
.map(|lint| lint.name)
|
|
|
|
.map(|name| name.replace("_", "-"))
|
|
|
|
.collect::<Vec<String>>()
|
|
|
|
.join(", ");
|
2019-06-10 17:47:31 -05:00
|
|
|
println!(" {} {}", padded_group(&scoped(&name)), desc);
|
2019-06-08 16:49:33 -05:00
|
|
|
}
|
|
|
|
println!("\n");
|
|
|
|
};
|
|
|
|
|
|
|
|
print_lint_groups();
|
2019-06-08 16:19:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn display_help() {
|
|
|
|
println!(
|
|
|
|
"\
|
2019-06-04 19:32:03 -05:00
|
|
|
Checks a package to catch common mistakes and improve your Rust code.
|
|
|
|
|
|
|
|
Usage:
|
|
|
|
cargo clippy [options] [--] [<opts>...]
|
|
|
|
|
|
|
|
Common options:
|
|
|
|
-h, --help Print this message
|
|
|
|
-V, --version Print version info and exit
|
|
|
|
|
|
|
|
Other options are the same as `cargo check`.
|
|
|
|
|
|
|
|
To allow or deny a lint from the command line you can use `cargo clippy --`
|
|
|
|
with:
|
|
|
|
|
|
|
|
-W --warn OPT Set lint warnings
|
|
|
|
-A --allow OPT Set lint allowed
|
|
|
|
-D --deny OPT Set lint denied
|
|
|
|
-F --forbid OPT Set lint forbidden
|
|
|
|
|
|
|
|
You can use tool lints to allow or deny lints from your code, eg.:
|
|
|
|
|
|
|
|
#[allow(clippy::needless_lifetimes)]
|
|
|
|
"
|
2019-06-08 16:19:16 -05:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
pub fn main() {
|
|
|
|
rustc_driver::init_rustc_env_logger();
|
|
|
|
exit(
|
|
|
|
rustc_driver::report_ices_to_stderr_if_any(move || {
|
|
|
|
use std::env;
|
2019-06-04 19:32:03 -05:00
|
|
|
|
2019-06-08 16:19:16 -05:00
|
|
|
if std::env::args().any(|a| a == "--version" || a == "-V") {
|
|
|
|
let version_info = rustc_tools_util::get_version_info!();
|
|
|
|
println!("{}", version_info);
|
2019-06-04 19:32:03 -05:00
|
|
|
exit(0);
|
|
|
|
}
|
|
|
|
|
2019-01-15 13:39:23 -06:00
|
|
|
let mut orig_args: Vec<String> = env::args().collect();
|
|
|
|
|
|
|
|
// Get the sysroot, looking from most specific to this invocation to the least:
|
|
|
|
// - command line
|
|
|
|
// - runtime environment
|
|
|
|
// - SYSROOT
|
|
|
|
// - RUSTUP_HOME, MULTIRUST_HOME, RUSTUP_TOOLCHAIN, MULTIRUST_TOOLCHAIN
|
|
|
|
// - sysroot from rustc in the path
|
|
|
|
// - compile-time environment
|
|
|
|
let sys_root_arg = arg_value(&orig_args, "--sysroot", |_| true);
|
|
|
|
let have_sys_root_arg = sys_root_arg.is_some();
|
|
|
|
let sys_root = sys_root_arg
|
2019-02-10 06:35:44 -06:00
|
|
|
.map(std::string::ToString::to_string)
|
2018-12-14 03:15:56 -06:00
|
|
|
.or_else(|| std::env::var("SYSROOT").ok())
|
|
|
|
.or_else(|| {
|
|
|
|
let home = option_env!("RUSTUP_HOME").or(option_env!("MULTIRUST_HOME"));
|
|
|
|
let toolchain = option_env!("RUSTUP_TOOLCHAIN").or(option_env!("MULTIRUST_TOOLCHAIN"));
|
|
|
|
home.and_then(|home| toolchain.map(|toolchain| format!("{}/toolchains/{}", home, toolchain)))
|
|
|
|
})
|
|
|
|
.or_else(|| {
|
|
|
|
Command::new("rustc")
|
|
|
|
.arg("--print")
|
|
|
|
.arg("sysroot")
|
|
|
|
.output()
|
|
|
|
.ok()
|
|
|
|
.and_then(|out| String::from_utf8(out.stdout).ok())
|
|
|
|
.map(|s| s.trim().to_owned())
|
|
|
|
})
|
2019-01-15 13:39:23 -06:00
|
|
|
.or_else(|| option_env!("SYSROOT").map(String::from))
|
2018-12-14 03:15:56 -06:00
|
|
|
.expect("need to specify SYSROOT env var during clippy compilation, or use rustup or multirust");
|
|
|
|
|
2018-11-27 14:12:13 -06:00
|
|
|
// Setting RUSTC_WRAPPER causes Cargo to pass 'rustc' as the first argument.
|
|
|
|
// We're invoking the compiler programmatically, so we ignore this/
|
2019-06-08 16:19:16 -05:00
|
|
|
let wrapper_mode = Path::new(&orig_args[1]).file_stem() == Some("rustc".as_ref());
|
|
|
|
|
|
|
|
if wrapper_mode {
|
2018-11-27 14:12:13 -06:00
|
|
|
// we still want to be able to invoke it normally though
|
2018-12-14 03:15:56 -06:00
|
|
|
orig_args.remove(1);
|
2018-11-27 14:12:13 -06:00
|
|
|
}
|
2019-06-08 16:19:16 -05:00
|
|
|
|
|
|
|
if !wrapper_mode && std::env::args().any(|a| a == "--help" || a == "-h") {
|
|
|
|
display_help();
|
|
|
|
exit(0);
|
|
|
|
}
|
|
|
|
|
2019-06-08 16:49:33 -05:00
|
|
|
let should_describe_lints = || {
|
|
|
|
let args: Vec<_> = std::env::args().collect();
|
|
|
|
args.windows(2).any(|args| {
|
2019-06-08 16:19:16 -05:00
|
|
|
args[1] == "help"
|
|
|
|
&& match args[0].as_str() {
|
|
|
|
"-W" | "-A" | "-D" | "-F" => true,
|
|
|
|
_ => false,
|
|
|
|
}
|
|
|
|
})
|
2019-06-08 16:49:33 -05:00
|
|
|
};
|
|
|
|
|
|
|
|
if !wrapper_mode && should_describe_lints() {
|
2019-06-08 16:19:16 -05:00
|
|
|
describe_lints();
|
|
|
|
exit(0);
|
|
|
|
}
|
|
|
|
|
2018-12-14 03:15:56 -06:00
|
|
|
// this conditional check for the --sysroot flag is there so users can call
|
|
|
|
// `clippy_driver` directly
|
|
|
|
// without having to pass --sysroot or anything
|
2019-01-15 13:39:23 -06:00
|
|
|
let mut args: Vec<String> = if have_sys_root_arg {
|
2018-12-14 03:15:56 -06:00
|
|
|
orig_args.clone()
|
|
|
|
} else {
|
|
|
|
orig_args
|
|
|
|
.clone()
|
|
|
|
.into_iter()
|
|
|
|
.chain(Some("--sysroot".to_owned()))
|
|
|
|
.chain(Some(sys_root))
|
|
|
|
.collect()
|
|
|
|
};
|
2018-11-27 14:12:13 -06:00
|
|
|
|
|
|
|
// this check ensures that dependencies are built but not linted and the final
|
|
|
|
// crate is
|
|
|
|
// linted but not built
|
|
|
|
let clippy_enabled = env::var("CLIPPY_TESTS").ok().map_or(false, |val| val == "true")
|
2019-01-15 12:56:09 -06:00
|
|
|
|| arg_value(&orig_args, "--emit", |val| val.split(',').any(|e| e == "metadata")).is_some();
|
2018-11-27 14:12:13 -06:00
|
|
|
|
|
|
|
if clippy_enabled {
|
|
|
|
args.extend_from_slice(&["--cfg".to_owned(), r#"feature="cargo-clippy""#.to_owned()]);
|
|
|
|
if let Ok(extra_args) = env::var("CLIPPY_ARGS") {
|
|
|
|
args.extend(extra_args.split("__CLIPPY_HACKERY__").filter_map(|s| {
|
|
|
|
if s.is_empty() {
|
2018-09-14 05:56:25 -05:00
|
|
|
None
|
|
|
|
} else {
|
|
|
|
Some(s.to_string())
|
2018-11-27 14:12:13 -06:00
|
|
|
}
|
|
|
|
}));
|
2018-08-26 08:49:08 -05:00
|
|
|
}
|
2018-11-27 14:12:13 -06:00
|
|
|
}
|
2018-06-07 15:03:15 -05:00
|
|
|
|
2019-02-01 16:28:14 -06:00
|
|
|
let mut clippy = ClippyCallbacks;
|
|
|
|
let mut default = rustc_driver::DefaultCallbacks;
|
2019-03-10 06:00:17 -05:00
|
|
|
let callbacks: &mut (dyn rustc_driver::Callbacks + Send) =
|
|
|
|
if clippy_enabled { &mut clippy } else { &mut default };
|
2018-11-27 14:12:13 -06:00
|
|
|
let args = args;
|
2019-02-01 16:28:14 -06:00
|
|
|
rustc_driver::run_compiler(&args, callbacks, None, None)
|
2019-03-10 06:00:17 -05:00
|
|
|
})
|
|
|
|
.and_then(|result| result)
|
|
|
|
.is_err() as i32,
|
2018-11-27 14:12:13 -06:00
|
|
|
)
|
2017-09-18 05:47:33 -05:00
|
|
|
}
|