rust/tests/ui/wrong_self_convention.rs

#![warn(clippy::wrong_self_convention)]
#![allow(dead_code)]

fn main() {}

#[derive(Clone, Copy)]
struct Foo;

impl Foo {
    fn as_i32(self) {}
    fn as_u32(&self) {}
    fn into_i32(self) {}
    fn is_i32(self) {}
    fn is_u32(&self) {}
    fn to_i32(self) {}
    fn from_i32(self) {}
    //~^ ERROR: methods called `from_*` usually take no `self`

    pub fn as_i64(self) {}
    pub fn into_i64(self) {}
    pub fn is_i64(self) {}
    pub fn to_i64(self) {}
    pub fn from_i64(self) {}
    //~^ ERROR: methods called `from_*` usually take no `self`
    // check whether the lint can be allowed at the function level
    #[allow(clippy::wrong_self_convention)]
    pub fn from_cake(self) {}

    fn as_x<F: AsRef<Self>>(_: F) {}
    fn as_y<F: AsRef<Foo>>(_: F) {}
}

struct Bar;

impl Bar {
    fn as_i32(self) {}
    //~^ ERROR: methods called `as_*` usually take `self` by reference or `self` by mutabl
    fn as_u32(&self) {}
    fn into_i32(&self) {}
    //~^ ERROR: methods called `into_*` usually take `self` by value
    fn into_u32(self) {}
    fn is_i32(self) {}
    //~^ ERROR: methods called `is_*` usually take `self` by mutable reference or `self` b
    fn is_u32(&self) {}
    fn to_i32(self) {}
    //~^ ERROR: methods with the following characteristics: (`to_*` and `self` type is not
    fn to_u32(&self) {}
    fn from_i32(self) {}
    //~^ ERROR: methods called `from_*` usually take no `self`

    pub fn as_i64(self) {}
    //~^ ERROR: methods called `as_*` usually take `self` by reference or `self` by mutabl
    pub fn into_i64(&self) {}
    //~^ ERROR: methods called `into_*` usually take `self` by value
    pub fn is_i64(self) {}
    //~^ ERROR: methods called `is_*` usually take `self` by mutable reference or `self` b
    pub fn to_i64(self) {}
    //~^ ERROR: methods with the following characteristics: (`to_*` and `self` type is not
    pub fn from_i64(self) {}
    //~^ ERROR: methods called `from_*` usually take no `self`

    // test for false positives
    fn as_(self) {}
    fn into_(&self) {}
    fn is_(self) {}
    fn to_(self) {}
    fn from_(self) {}
    fn to_mut(&mut self) {}
}

// Allow Box<Self>, Rc<Self>, Arc<Self> for methods that take conventionally take Self by value
#[allow(clippy::boxed_local)]
mod issue4293 {
    use std::rc::Rc;
    use std::sync::Arc;

    struct T;

    impl T {
        fn into_s1(self: Box<Self>) {}
        fn into_s2(self: Rc<Self>) {}
        fn into_s3(self: Arc<Self>) {}

        fn into_t1(self: Box<T>) {}
        fn into_t2(self: Rc<T>) {}
        fn into_t3(self: Arc<T>) {}
    }
}

// False positive for async (see #4037)
mod issue4037 {
    pub struct Foo;
    pub struct Bar;

    impl Foo {
        pub async fn into_bar(self) -> Bar {
            Bar
        }
    }
}

// Lint also in trait definition (see #6307)
mod issue6307 {
    trait T: Sized {
        fn as_i32(self) {}
        //~^ ERROR: methods called `as_*` usually take `self` by reference or `self` by mu
        fn as_u32(&self) {}
        fn into_i32(self) {}
        fn into_i32_ref(&self) {}
        //~^ ERROR: methods called `into_*` usually take `self` by value
        fn into_u32(self) {}
        fn is_i32(self) {}
        //~^ ERROR: methods called `is_*` usually take `self` by mutable reference or `sel
        fn is_u32(&self) {}
        fn to_i32(self) {}
        fn to_u32(&self) {}
        fn from_i32(self) {}
        //~^ ERROR: methods called `from_*` usually take no `self`
        // check whether the lint can be allowed at the function level
        #[allow(clippy::wrong_self_convention)]
        fn from_cake(self) {}

        // test for false positives
        fn as_(self) {}
        fn into_(&self) {}
        fn is_(self) {}
        fn to_(self) {}
        fn from_(self) {}
        fn to_mut(&mut self) {}
    }

    trait U {
        fn as_i32(self);
        //~^ ERROR: methods called `as_*` usually take `self` by reference or `self` by mu
        fn as_u32(&self);
        fn into_i32(self);
        fn into_i32_ref(&self);
        //~^ ERROR: methods called `into_*` usually take `self` by value
        fn into_u32(self);
        fn is_i32(self);
        //~^ ERROR: methods called `is_*` usually take `self` by mutable reference or `sel
        fn is_u32(&self);
        fn to_i32(self);
        fn to_u32(&self);
        fn from_i32(self);
        //~^ ERROR: methods called `from_*` usually take no `self`
        // check whether the lint can be allowed at the function level
        #[allow(clippy::wrong_self_convention)]
        fn from_cake(self);

        // test for false positives
        fn as_(self);
        fn into_(&self);
        fn is_(self);
        fn to_(self);
        fn from_(self);
        fn to_mut(&mut self);
    }

    trait C: Copy {
        fn as_i32(self);
        fn as_u32(&self);
        fn into_i32(self);
        fn into_i32_ref(&self);
        //~^ ERROR: methods called `into_*` usually take `self` by value
        fn into_u32(self);
        fn is_i32(self);
        fn is_u32(&self);
        fn to_i32(self);
        fn to_u32(&self);
        fn from_i32(self);
        //~^ ERROR: methods called `from_*` usually take no `self`
        // check whether the lint can be allowed at the function level
        #[allow(clippy::wrong_self_convention)]
        fn from_cake(self);

        // test for false positives
        fn as_(self);
        fn into_(&self);
        fn is_(self);
        fn to_(self);
        fn from_(self);
        fn to_mut(&mut self);
    }
}

mod issue6727 {
    #[derive(Clone, Copy)]
    struct FooCopy;

    impl FooCopy {
        fn to_u64(self) -> u64 {
            1
        }
        // trigger lint
        fn to_u64_v2(&self) -> u64 {
            //~^ ERROR: methods with the following characteristics: (`to_*` and `self` type is
            1
        }
    }

    struct FooNoCopy;

    impl FooNoCopy {
        // trigger lint
        fn to_u64(self) -> u64 {
            //~^ ERROR: methods with the following characteristics: (`to_*` and `self` type is
            2
        }
        fn to_u64_v2(&self) -> u64 {
            2
        }
    }
}

pub mod issue8142 {
    struct S;

    impl S {
        // Should not lint: "no self at all" is allowed.
        fn is_forty_two(x: u32) -> bool {
            x == 42
        }

        // Should not lint: &self is allowed.
        fn is_test_code(&self) -> bool {
            true
        }
    }
}