2019-05-14 03:06:21 -05:00
|
|
|
use crate::utils::{span_lint, span_lint_and_then};
|
2020-01-12 00:08:41 -06:00
|
|
|
use rustc_lint::{EarlyContext, EarlyLintPass};
|
2020-01-11 05:37:08 -06:00
|
|
|
use rustc_session::{declare_tool_lint, impl_lint_pass};
|
2020-01-04 04:00:00 -06:00
|
|
|
use rustc_span::source_map::Span;
|
|
|
|
use rustc_span::symbol::SymbolStr;
|
2019-09-24 16:55:05 -05:00
|
|
|
use std::cmp::Ordering;
|
2020-02-21 02:39:38 -06:00
|
|
|
use syntax::ast::{
|
|
|
|
Arm, AssocItem, AssocItemKind, Attribute, Block, FnDecl, Ident, Item, ItemKind, Local, Mac, Pat, PatKind,
|
|
|
|
};
|
2018-12-29 09:04:45 -06:00
|
|
|
use syntax::attr;
|
|
|
|
use syntax::visit::{walk_block, walk_expr, walk_pat, Visitor};
|
2016-03-01 03:13:54 -06:00
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks for names that are very similar and thus confusing.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** It's hard to distinguish between names that differ only
|
|
|
|
/// by a single character.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None?
|
|
|
|
///
|
|
|
|
/// **Example:**
|
2019-03-05 16:23:50 -06:00
|
|
|
/// ```ignore
|
2019-03-05 10:50:33 -06:00
|
|
|
/// let checked_exp = something;
|
|
|
|
/// let checked_expr = something_else;
|
|
|
|
/// ```
|
2016-03-01 03:13:54 -06:00
|
|
|
pub SIMILAR_NAMES,
|
2018-03-28 08:24:26 -05:00
|
|
|
pedantic,
|
2016-03-01 03:13:54 -06:00
|
|
|
"similarly named items and bindings"
|
|
|
|
}
|
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks for too many variables whose name consists of a
|
|
|
|
/// single character.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** It's hard to memorize what a variable means without a
|
|
|
|
/// descriptive name.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None?
|
|
|
|
///
|
|
|
|
/// **Example:**
|
2019-03-05 16:23:50 -06:00
|
|
|
/// ```ignore
|
2019-03-05 10:50:33 -06:00
|
|
|
/// let (a, b, c, d, e, f, g) = (...);
|
|
|
|
/// ```
|
2016-03-01 06:05:39 -06:00
|
|
|
pub MANY_SINGLE_CHAR_NAMES,
|
2018-03-28 08:24:26 -05:00
|
|
|
style,
|
2016-03-01 06:05:39 -06:00
|
|
|
"too many single character bindings"
|
|
|
|
}
|
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks if you have variables whose name consists of just
|
|
|
|
/// underscores and digits.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** It's hard to memorize what a variable means without a
|
|
|
|
/// descriptive name.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None?
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// let _1 = 1;
|
|
|
|
/// let ___1 = 1;
|
|
|
|
/// let __1___2 = 11;
|
|
|
|
/// ```
|
2017-11-02 20:01:41 -05:00
|
|
|
pub JUST_UNDERSCORES_AND_DIGITS,
|
2018-03-28 08:24:26 -05:00
|
|
|
style,
|
2017-11-02 20:01:41 -05:00
|
|
|
"unclear name"
|
|
|
|
}
|
|
|
|
|
2019-04-08 15:43:55 -05:00
|
|
|
#[derive(Copy, Clone)]
|
2016-03-01 06:05:39 -06:00
|
|
|
pub struct NonExpressiveNames {
|
2017-05-09 08:23:38 -05:00
|
|
|
pub single_char_binding_names_threshold: u64,
|
2016-03-01 06:05:39 -06:00
|
|
|
}
|
2016-03-01 03:13:54 -06:00
|
|
|
|
2019-04-08 15:43:55 -05:00
|
|
|
impl_lint_pass!(NonExpressiveNames => [SIMILAR_NAMES, MANY_SINGLE_CHAR_NAMES, JUST_UNDERSCORES_AND_DIGITS]);
|
2016-03-01 03:13:54 -06:00
|
|
|
|
2016-03-30 10:05:15 -05:00
|
|
|
struct ExistingName {
|
2019-11-06 03:50:24 -06:00
|
|
|
interned: SymbolStr,
|
2016-03-30 10:05:15 -05:00
|
|
|
span: Span,
|
|
|
|
len: usize,
|
2016-04-14 13:14:03 -05:00
|
|
|
whitelist: &'static [&'static str],
|
2016-03-30 10:05:15 -05:00
|
|
|
}
|
|
|
|
|
2019-06-19 13:36:23 -05:00
|
|
|
struct SimilarNamesLocalVisitor<'a, 'tcx> {
|
2016-03-30 10:05:15 -05:00
|
|
|
names: Vec<ExistingName>,
|
2016-12-06 04:32:21 -06:00
|
|
|
cx: &'a EarlyContext<'tcx>,
|
2016-03-01 06:05:39 -06:00
|
|
|
lint: &'a NonExpressiveNames,
|
2019-04-03 14:06:39 -05:00
|
|
|
|
|
|
|
/// A stack of scopes containing the single-character bindings in each scope.
|
|
|
|
single_char_names: Vec<Vec<Ident>>,
|
|
|
|
}
|
|
|
|
|
2019-06-19 13:36:23 -05:00
|
|
|
impl<'a, 'tcx> SimilarNamesLocalVisitor<'a, 'tcx> {
|
2019-04-03 14:06:39 -05:00
|
|
|
fn check_single_char_names(&self) {
|
|
|
|
let num_single_char_names = self.single_char_names.iter().flatten().count();
|
|
|
|
let threshold = self.lint.single_char_binding_names_threshold;
|
|
|
|
if num_single_char_names as u64 >= threshold {
|
|
|
|
let span = self
|
|
|
|
.single_char_names
|
|
|
|
.iter()
|
|
|
|
.flatten()
|
|
|
|
.map(|ident| ident.span)
|
|
|
|
.collect::<Vec<_>>();
|
|
|
|
span_lint(
|
|
|
|
self.cx,
|
|
|
|
MANY_SINGLE_CHAR_NAMES,
|
|
|
|
span,
|
|
|
|
&format!(
|
|
|
|
"{} bindings with single-character names in scope",
|
|
|
|
num_single_char_names
|
|
|
|
),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
|
|
|
|
2016-03-30 10:05:15 -05:00
|
|
|
// this list contains lists of names that are allowed to be similar
|
|
|
|
// the assumption is that no name is ever contained in multiple lists.
|
2018-05-30 11:24:44 -05:00
|
|
|
#[rustfmt::skip]
|
2017-10-20 07:41:24 -05:00
|
|
|
const WHITELIST: &[&[&str]] = &[
|
2016-03-30 10:05:15 -05:00
|
|
|
&["parsed", "parser"],
|
|
|
|
&["lhs", "rhs"],
|
2016-03-31 08:38:43 -05:00
|
|
|
&["tx", "rx"],
|
|
|
|
&["set", "get"],
|
2017-10-27 03:51:43 -05:00
|
|
|
&["args", "arms"],
|
|
|
|
&["qpath", "path"],
|
|
|
|
&["lit", "lint"],
|
2016-03-01 03:13:54 -06:00
|
|
|
];
|
|
|
|
|
2019-06-19 13:36:23 -05:00
|
|
|
struct SimilarNamesNameVisitor<'a, 'tcx, 'b>(&'b mut SimilarNamesLocalVisitor<'a, 'tcx>);
|
2016-03-01 03:13:54 -06:00
|
|
|
|
2019-06-19 13:36:23 -05:00
|
|
|
impl<'a, 'tcx, 'b> Visitor<'tcx> for SimilarNamesNameVisitor<'a, 'tcx, 'b> {
|
2016-12-06 04:32:21 -06:00
|
|
|
fn visit_pat(&mut self, pat: &'tcx Pat) {
|
2019-09-27 10:16:06 -05:00
|
|
|
match pat.kind {
|
2019-04-03 14:06:39 -05:00
|
|
|
PatKind::Ident(_, ident, _) => self.check_ident(ident),
|
2018-11-27 14:14:15 -06:00
|
|
|
PatKind::Struct(_, ref fields, _) => {
|
|
|
|
for field in fields {
|
2019-08-15 21:30:38 -05:00
|
|
|
if !field.is_shorthand {
|
|
|
|
self.visit_pat(&field.pat);
|
2018-11-27 14:14:15 -06:00
|
|
|
}
|
2016-05-11 09:44:43 -05:00
|
|
|
}
|
2016-12-20 11:21:30 -06:00
|
|
|
},
|
2019-09-08 05:40:04 -05:00
|
|
|
// just go through the first pattern, as either all patterns
|
|
|
|
// bind the same bindings or rustc would have errored much earlier
|
|
|
|
PatKind::Or(ref pats) => self.visit_pat(&pats[0]),
|
2016-05-11 09:44:43 -05:00
|
|
|
_ => walk_pat(self, pat),
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
|
|
|
}
|
2018-08-25 07:49:56 -05:00
|
|
|
fn visit_mac(&mut self, _mac: &Mac) {
|
|
|
|
// do not check macs
|
|
|
|
}
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
|
|
|
|
2019-09-18 01:37:41 -05:00
|
|
|
#[must_use]
|
2016-04-14 13:14:03 -05:00
|
|
|
fn get_whitelist(interned_name: &str) -> Option<&'static [&'static str]> {
|
2016-03-14 08:34:47 -05:00
|
|
|
for &allow in WHITELIST {
|
2016-03-30 10:05:15 -05:00
|
|
|
if whitelisted(interned_name, allow) {
|
|
|
|
return Some(allow);
|
2016-03-14 08:34:47 -05:00
|
|
|
}
|
2016-03-30 10:05:15 -05:00
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
|
|
|
|
2019-09-18 01:37:41 -05:00
|
|
|
#[must_use]
|
2016-03-30 10:05:15 -05:00
|
|
|
fn whitelisted(interned_name: &str, list: &[&str]) -> bool {
|
2017-09-05 04:33:04 -05:00
|
|
|
list.iter()
|
|
|
|
.any(|&name| interned_name.starts_with(name) || interned_name.ends_with(name))
|
2016-03-14 08:34:47 -05:00
|
|
|
}
|
|
|
|
|
2016-12-06 04:32:21 -06:00
|
|
|
impl<'a, 'tcx, 'b> SimilarNamesNameVisitor<'a, 'tcx, 'b> {
|
2019-04-03 14:06:39 -05:00
|
|
|
fn check_short_ident(&mut self, ident: Ident) {
|
|
|
|
// Ignore shadowing
|
|
|
|
if self
|
|
|
|
.0
|
|
|
|
.single_char_names
|
|
|
|
.iter()
|
|
|
|
.flatten()
|
|
|
|
.any(|id| id.name == ident.name)
|
|
|
|
{
|
2016-03-14 08:34:47 -05:00
|
|
|
return;
|
2019-06-20 06:44:00 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
if let Some(scope) = &mut self.0.single_char_names.last_mut() {
|
2019-04-03 14:06:39 -05:00
|
|
|
scope.push(ident);
|
2016-03-14 08:34:47 -05:00
|
|
|
}
|
|
|
|
}
|
2019-04-03 14:06:39 -05:00
|
|
|
|
2019-01-13 09:19:02 -06:00
|
|
|
#[allow(clippy::too_many_lines)]
|
2019-04-03 14:06:39 -05:00
|
|
|
fn check_ident(&mut self, ident: Ident) {
|
|
|
|
let interned_name = ident.name.as_str();
|
2016-03-01 03:13:54 -06:00
|
|
|
if interned_name.chars().any(char::is_uppercase) {
|
|
|
|
return;
|
|
|
|
}
|
2017-11-02 20:01:41 -05:00
|
|
|
if interned_name.chars().all(|c| c.is_digit(10) || c == '_') {
|
|
|
|
span_lint(
|
|
|
|
self.0.cx,
|
2017-11-03 15:54:33 -05:00
|
|
|
JUST_UNDERSCORES_AND_DIGITS,
|
2019-04-03 14:06:39 -05:00
|
|
|
ident.span,
|
2017-11-03 15:54:33 -05:00
|
|
|
"consider choosing a more descriptive name",
|
2017-11-02 20:01:41 -05:00
|
|
|
);
|
|
|
|
return;
|
|
|
|
}
|
2016-03-01 06:05:39 -06:00
|
|
|
let count = interned_name.chars().count();
|
|
|
|
if count < 3 {
|
2016-03-30 10:05:15 -05:00
|
|
|
if count == 1 {
|
2019-04-03 14:06:39 -05:00
|
|
|
self.check_short_ident(ident);
|
2016-03-08 07:36:21 -06:00
|
|
|
}
|
2016-03-01 03:13:54 -06:00
|
|
|
return;
|
|
|
|
}
|
2016-03-30 10:05:15 -05:00
|
|
|
for existing_name in &self.0.names {
|
|
|
|
if whitelisted(&interned_name, existing_name.whitelist) {
|
|
|
|
continue;
|
|
|
|
}
|
2016-03-01 03:34:45 -06:00
|
|
|
let mut split_at = None;
|
2019-09-24 16:55:05 -05:00
|
|
|
match existing_name.len.cmp(&count) {
|
|
|
|
Ordering::Greater => {
|
|
|
|
if existing_name.len - count != 1 || levenstein_not_1(&interned_name, &existing_name.interned) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
},
|
|
|
|
Ordering::Less => {
|
|
|
|
if count - existing_name.len != 1 || levenstein_not_1(&existing_name.interned, &interned_name) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
},
|
|
|
|
Ordering::Equal => {
|
|
|
|
let mut interned_chars = interned_name.chars();
|
|
|
|
let mut existing_chars = existing_name.interned.chars();
|
|
|
|
let first_i = interned_chars.next().expect("we know we have at least one char");
|
|
|
|
let first_e = existing_chars.next().expect("we know we have at least one char");
|
|
|
|
let eq_or_numeric = |(a, b): (char, char)| a == b || a.is_numeric() && b.is_numeric();
|
2016-03-14 08:34:47 -05:00
|
|
|
|
2019-09-24 16:55:05 -05:00
|
|
|
if eq_or_numeric((first_i, first_e)) {
|
|
|
|
let last_i = interned_chars.next_back().expect("we know we have at least two chars");
|
|
|
|
let last_e = existing_chars.next_back().expect("we know we have at least two chars");
|
|
|
|
if eq_or_numeric((last_i, last_e)) {
|
|
|
|
if interned_chars
|
|
|
|
.zip(existing_chars)
|
|
|
|
.filter(|&ie| !eq_or_numeric(ie))
|
|
|
|
.count()
|
|
|
|
!= 1
|
|
|
|
{
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
let second_last_i = interned_chars
|
|
|
|
.next_back()
|
|
|
|
.expect("we know we have at least three chars");
|
|
|
|
let second_last_e = existing_chars
|
|
|
|
.next_back()
|
|
|
|
.expect("we know we have at least three chars");
|
|
|
|
if !eq_or_numeric((second_last_i, second_last_e))
|
|
|
|
|| second_last_i == '_'
|
|
|
|
|| !interned_chars.zip(existing_chars).all(eq_or_numeric)
|
|
|
|
{
|
|
|
|
// allowed similarity foo_x, foo_y
|
|
|
|
// or too many chars differ (foo_x, boo_y) or (foox, booy)
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
split_at = interned_name.char_indices().rev().next().map(|(i, _)| i);
|
2016-03-14 08:34:47 -05:00
|
|
|
}
|
|
|
|
} else {
|
2019-09-24 16:55:05 -05:00
|
|
|
let second_i = interned_chars.next().expect("we know we have at least two chars");
|
|
|
|
let second_e = existing_chars.next().expect("we know we have at least two chars");
|
|
|
|
if !eq_or_numeric((second_i, second_e))
|
|
|
|
|| second_i == '_'
|
2017-11-04 14:55:56 -05:00
|
|
|
|| !interned_chars.zip(existing_chars).all(eq_or_numeric)
|
2017-08-09 02:30:56 -05:00
|
|
|
{
|
2019-09-24 16:55:05 -05:00
|
|
|
// allowed similarity x_foo, y_foo
|
|
|
|
// or too many chars differ (x_foo, y_boo) or (xfoo, yboo)
|
2016-03-14 08:34:47 -05:00
|
|
|
continue;
|
|
|
|
}
|
2019-09-24 16:55:05 -05:00
|
|
|
split_at = interned_name.chars().next().map(char::len_utf8);
|
2016-03-30 09:40:21 -05:00
|
|
|
}
|
2019-09-24 16:55:05 -05:00
|
|
|
},
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
2017-08-09 02:30:56 -05:00
|
|
|
span_lint_and_then(
|
|
|
|
self.0.cx,
|
|
|
|
SIMILAR_NAMES,
|
2019-04-03 14:06:39 -05:00
|
|
|
ident.span,
|
2017-08-09 02:30:56 -05:00
|
|
|
"binding's name is too similar to existing binding",
|
|
|
|
|diag| {
|
|
|
|
diag.span_note(existing_name.span, "existing binding defined here");
|
|
|
|
if let Some(split) = split_at {
|
|
|
|
diag.span_help(
|
2019-04-03 14:06:39 -05:00
|
|
|
ident.span,
|
2017-08-09 02:30:56 -05:00
|
|
|
&format!(
|
|
|
|
"separate the discriminating character by an \
|
2017-09-05 04:33:04 -05:00
|
|
|
underscore like: `{}_{}`",
|
2017-08-09 02:30:56 -05:00
|
|
|
&interned_name[..split],
|
|
|
|
&interned_name[split..]
|
|
|
|
),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
},
|
|
|
|
);
|
2016-03-01 03:13:54 -06:00
|
|
|
return;
|
|
|
|
}
|
2016-03-30 10:05:15 -05:00
|
|
|
self.0.names.push(ExistingName {
|
|
|
|
whitelist: get_whitelist(&interned_name).unwrap_or(&[]),
|
|
|
|
interned: interned_name,
|
2019-04-03 14:06:39 -05:00
|
|
|
span: ident.span,
|
2016-03-30 10:05:15 -05:00
|
|
|
len: count,
|
|
|
|
});
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-03-01 06:05:39 -06:00
|
|
|
impl<'a, 'b> SimilarNamesLocalVisitor<'a, 'b> {
|
2016-03-08 07:36:21 -06:00
|
|
|
/// ensure scoping rules work
|
|
|
|
fn apply<F: for<'c> Fn(&'c mut Self)>(&mut self, f: F) {
|
|
|
|
let n = self.names.len();
|
|
|
|
let single_char_count = self.single_char_names.len();
|
|
|
|
f(self);
|
|
|
|
self.names.truncate(n);
|
|
|
|
self.single_char_names.truncate(single_char_count);
|
2016-03-01 06:05:39 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-06 04:32:21 -06:00
|
|
|
impl<'a, 'tcx> Visitor<'tcx> for SimilarNamesLocalVisitor<'a, 'tcx> {
|
|
|
|
fn visit_local(&mut self, local: &'tcx Local) {
|
2016-03-08 07:36:21 -06:00
|
|
|
if let Some(ref init) = local.init {
|
2016-05-11 09:44:43 -05:00
|
|
|
self.apply(|this| walk_expr(this, &**init));
|
2016-03-08 07:36:21 -06:00
|
|
|
}
|
2017-08-09 02:30:56 -05:00
|
|
|
// add the pattern after the expression because the bindings aren't available
|
|
|
|
// yet in the init
|
2016-12-21 03:25:14 -06:00
|
|
|
// expression
|
2016-03-08 07:36:21 -06:00
|
|
|
SimilarNamesNameVisitor(self).visit_pat(&*local.pat);
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
2016-12-06 04:32:21 -06:00
|
|
|
fn visit_block(&mut self, blk: &'tcx Block) {
|
2019-04-03 14:06:39 -05:00
|
|
|
self.single_char_names.push(vec![]);
|
|
|
|
|
2016-05-11 09:44:43 -05:00
|
|
|
self.apply(|this| walk_block(this, blk));
|
2019-04-03 14:06:39 -05:00
|
|
|
|
|
|
|
self.check_single_char_names();
|
|
|
|
self.single_char_names.pop();
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
2016-12-06 04:32:21 -06:00
|
|
|
fn visit_arm(&mut self, arm: &'tcx Arm) {
|
2019-04-03 14:06:39 -05:00
|
|
|
self.single_char_names.push(vec![]);
|
|
|
|
|
2016-03-08 07:36:21 -06:00
|
|
|
self.apply(|this| {
|
2019-09-06 06:57:27 -05:00
|
|
|
SimilarNamesNameVisitor(this).visit_pat(&arm.pat);
|
2016-05-11 09:44:43 -05:00
|
|
|
this.apply(|this| walk_expr(this, &arm.body));
|
2016-03-08 07:36:21 -06:00
|
|
|
});
|
2019-04-03 14:06:39 -05:00
|
|
|
|
|
|
|
self.check_single_char_names();
|
|
|
|
self.single_char_names.pop();
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
2016-06-28 08:54:23 -05:00
|
|
|
fn visit_item(&mut self, _: &Item) {
|
2016-05-02 03:52:55 -05:00
|
|
|
// do not recurse into inner items
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
2018-08-15 01:11:07 -05:00
|
|
|
fn visit_mac(&mut self, _mac: &Mac) {
|
|
|
|
// do not check macs
|
|
|
|
}
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
|
|
|
|
2016-03-01 06:05:39 -06:00
|
|
|
impl EarlyLintPass for NonExpressiveNames {
|
2018-07-23 06:01:12 -05:00
|
|
|
fn check_item(&mut self, cx: &EarlyContext<'_>, item: &Item) {
|
2020-02-23 22:33:04 -06:00
|
|
|
if let ItemKind::Fn(_, ref sig, _, Some(ref blk)) = item.kind {
|
2019-11-08 14:12:08 -06:00
|
|
|
do_check(self, cx, &item.attrs, &sig.decl, blk);
|
2018-02-02 00:49:47 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-12-20 14:19:46 -06:00
|
|
|
fn check_impl_item(&mut self, cx: &EarlyContext<'_>, item: &AssocItem) {
|
2020-02-23 22:33:04 -06:00
|
|
|
if let AssocItemKind::Fn(_, ref sig, _, Some(ref blk)) = item.kind {
|
2018-02-02 00:49:47 -06:00
|
|
|
do_check(self, cx, &item.attrs, &sig.decl, blk);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-23 06:01:12 -05:00
|
|
|
fn do_check(lint: &mut NonExpressiveNames, cx: &EarlyContext<'_>, attrs: &[Attribute], decl: &FnDecl, blk: &Block) {
|
2019-05-17 16:53:54 -05:00
|
|
|
if !attr::contains_name(attrs, sym!(test)) {
|
2018-02-02 00:49:47 -06:00
|
|
|
let mut visitor = SimilarNamesLocalVisitor {
|
|
|
|
names: Vec::new(),
|
2018-03-15 10:07:15 -05:00
|
|
|
cx,
|
|
|
|
lint,
|
2019-04-03 14:06:39 -05:00
|
|
|
single_char_names: vec![vec![]],
|
2018-02-02 00:49:47 -06:00
|
|
|
};
|
2019-04-03 14:06:39 -05:00
|
|
|
|
2018-02-02 00:49:47 -06:00
|
|
|
// initialize with function arguments
|
|
|
|
for arg in &decl.inputs {
|
|
|
|
SimilarNamesNameVisitor(&mut visitor).visit_pat(&arg.pat);
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
2018-02-02 00:49:47 -06:00
|
|
|
// walk all other bindings
|
|
|
|
walk_block(&mut visitor, blk);
|
2019-04-03 14:06:39 -05:00
|
|
|
|
|
|
|
visitor.check_single_char_names();
|
2016-03-01 03:13:54 -06:00
|
|
|
}
|
|
|
|
}
|
2016-03-14 08:34:47 -05:00
|
|
|
|
2016-03-19 11:48:29 -05:00
|
|
|
/// Precondition: `a_name.chars().count() < b_name.chars().count()`.
|
2019-09-18 01:37:41 -05:00
|
|
|
#[must_use]
|
2016-03-14 08:34:47 -05:00
|
|
|
fn levenstein_not_1(a_name: &str, b_name: &str) -> bool {
|
|
|
|
debug_assert!(a_name.chars().count() < b_name.chars().count());
|
|
|
|
let mut a_chars = a_name.chars();
|
|
|
|
let mut b_chars = b_name.chars();
|
|
|
|
while let (Some(a), Some(b)) = (a_chars.next(), b_chars.next()) {
|
|
|
|
if a == b {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if let Some(b2) = b_chars.next() {
|
|
|
|
// check if there's just one character inserted
|
2016-03-23 08:50:47 -05:00
|
|
|
return a != b2 || a_chars.ne(b_chars);
|
2016-03-14 08:34:47 -05:00
|
|
|
} else {
|
|
|
|
// tuple
|
|
|
|
// ntuple
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// for item in items
|
|
|
|
true
|
|
|
|
}
|