mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
60956837cf
rust/tests/ui/generator/issue-68112.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

62 lines
2.5 KiB
Plaintext
Raw Normal View History

Use "generator" instead of "future" when appropriate
2020-03-24 23:13:05 -05:00
error: generator cannot be sent between threads safely
Bless tests.
2023-06-24 05:02:54 -05:00
--> $DIR/issue-68112.rs:40:5
Add test for #68112 (existing output)
2020-03-24 19:23:50 -05:00
|
LL | require_send(send_gen);
Bless tests.
2023-06-24 05:02:54 -05:00
| ^^^^^^^^^^^^ generator is not `Send`
Add test for #68112 (existing output)
2020-03-24 19:23:50 -05:00
|
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
= help: the trait `Sync` is not implemented for `RefCell<i32>`
Add `rustc_on_unimplemented` on `Sync` for cell types Suggest using a lock instead.
2023-01-16 11:51:31 -06:00
= note: if you want to do aliasing and mutation between multiple threads, use `std::sync::RwLock` instead
Incorporate feedback into diagnostics
2020-04-08 13:54:31 -05:00
note: generator is not `Send` as this value is used across a yield
Revert duplication of tests.
2023-05-07 13:38:52 -05:00
--> $DIR/issue-68112.rs:36:9
Add test for #68112 (existing output)
2020-03-24 19:23:50 -05:00
|
LL | let _non_send_gen = make_non_send_generator();
s/Generator/Coroutine/
2023-10-19 11:06:43 -05:00
| ------------- has type `impl Coroutine<Return = Arc<RefCell<i32>>>` which is not `Send`
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
LL |
Add test for #68112 (existing output)
2020-03-24 19:23:50 -05:00
LL | yield;
| ^^^^^ yield occurs here, with `_non_send_gen` maybe used later
Use note to point at bound introducing requirement
2021-07-31 11:26:55 -05:00
note: required by a bound in `require_send`
Revert duplication of tests.
2023-05-07 13:38:52 -05:00
--> $DIR/issue-68112.rs:22:25
Use note to point at bound introducing requirement
2021-07-31 11:26:55 -05:00
|
LL | fn require_send(_: impl Send) {}
| ^^^^ required by this bound in `require_send`
Add test for #68112 (existing output)
2020-03-24 19:23:50 -05:00
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
error[E0277]: `RefCell<i32>` cannot be shared between threads safely
Bless tests.
2023-06-24 05:02:54 -05:00
--> $DIR/issue-68112.rs:64:5
Add test for #68112 (existing output)
2020-03-24 19:23:50 -05:00
|
LL | require_send(send_gen);
Bless tests.
2023-06-24 05:02:54 -05:00
| ^^^^^^^^^^^^ `RefCell<i32>` cannot be shared between threads safely
Add test for #68112 (existing output)
2020-03-24 19:23:50 -05:00
|
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
= help: the trait `Sync` is not implemented for `RefCell<i32>`
Add `rustc_on_unimplemented` on `Sync` for cell types Suggest using a lock instead.
2023-01-16 11:51:31 -06:00
= note: if you want to do aliasing and mutation between multiple threads, use `std::sync::RwLock` instead
Reword "Required because of the requirements on the impl of ..."
2022-08-15 15:31:37 -05:00
= note: required for `Arc<RefCell<i32>>` to implement `Send`
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
note: required because it's used within this generator
Revert duplication of tests.
2023-05-07 13:38:52 -05:00
--> $DIR/issue-68112.rs:49:5
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
|
Shorten span for closures.
2022-06-27 00:45:35 -05:00
LL | || {
| ^^
s/Generator/Coroutine/
2023-10-19 11:06:43 -05:00
note: required because it appears within the type `impl Coroutine<Return = Arc<RefCell<i32>>>`
Revert duplication of tests.
2023-05-07 13:38:52 -05:00
--> $DIR/issue-68112.rs:46:30
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
|
s/Generator/Coroutine/
2023-10-19 11:06:43 -05:00
LL | pub fn make_gen2<T>(t: T) -> impl Coroutine<Return = T> {
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
s/Generator/Coroutine/
2023-10-19 11:06:43 -05:00
note: required because it appears within the type `impl Coroutine<Return = Arc<RefCell<i32>>>`
Revert duplication of tests.
2023-05-07 13:38:52 -05:00
--> $DIR/issue-68112.rs:54:34
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
|
s/Generator/Coroutine/
2023-10-19 11:06:43 -05:00
LL | fn make_non_send_generator2() -> impl Coroutine<Return = Arc<RefCell<i32>>> {
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
s/Generator/Coroutine/
2023-10-19 11:06:43 -05:00
= note: required because it captures the following types: `impl Coroutine<Return = Arc<RefCell<i32>>>`
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
note: required because it's used within this generator
Revert duplication of tests.
2023-05-07 13:38:52 -05:00
--> $DIR/issue-68112.rs:60:20
Greatly improve error reporting for futures and generators in `note_obligation_cause_code` Most futures don't go through this code path, because they're caught by `maybe_note_obligation_cause_for_async_await`. But all generators do, and `maybe_note` is imperfect and doesn't catch all futures. Improve the error message for those it misses. At some point, we may want to consider unifying this with the code for `maybe_note_async_await`, so that `async_await` notes all parent constraints, and `note_obligation` can point to yield points. But both functions are quite complicated, and it's not clear to me how to combine them; this seems like a good incremental improvement.
2022-06-19 13:59:36 -05:00
|
Shorten span for closures.
2022-06-27 00:45:35 -05:00
LL | let send_gen = || {
| ^^
Use note to point at bound introducing requirement
2021-07-31 11:26:55 -05:00
note: required by a bound in `require_send`
Revert duplication of tests.
2023-05-07 13:38:52 -05:00
--> $DIR/issue-68112.rs:22:25
Use note to point at bound introducing requirement
2021-07-31 11:26:55 -05:00
|
LL | fn require_send(_: impl Send) {}
| ^^^^ required by this bound in `require_send`
Add test for #68112 (existing output)
2020-03-24 19:23:50 -05:00
error: aborting due to 2 previous errors
For more information about this error, try `rustc --explain E0277`.
Reference in New Issue Copy Permalink