rust/tests/ui/needless_return.rs

241 lines
4.0 KiB
Rust
Raw Normal View History

// run-rustfix
#![feature(lint_reasons)]
2021-09-18 09:40:16 -05:00
#![feature(let_else)]
#![allow(unused)]
2021-10-04 01:33:40 -05:00
#![allow(
clippy::if_same_then_else,
clippy::single_match,
clippy::needless_bool,
clippy::equatable_if_let
)]
2018-07-28 10:34:52 -05:00
#![warn(clippy::needless_return)]
2015-08-11 11:55:07 -05:00
2022-06-18 11:36:47 -05:00
use std::cell::RefCell;
macro_rules! the_answer {
2019-06-20 06:44:00 -05:00
() => {
42
};
}
2015-08-11 11:55:07 -05:00
fn test_end_of_fn() -> bool {
if true {
// no error!
return true;
}
2015-12-11 01:28:05 -06:00
return true;
2015-08-11 11:55:07 -05:00
}
fn test_no_semicolon() -> bool {
2018-12-09 16:26:16 -06:00
return true;
2015-08-11 11:55:07 -05:00
}
fn test_if_block() -> bool {
if true {
return true;
2015-08-11 11:55:07 -05:00
} else {
return false;
2015-08-11 11:55:07 -05:00
}
}
fn test_match(x: bool) -> bool {
match x {
true => return false,
2015-08-11 11:55:07 -05:00
false => {
return true;
2018-12-09 16:26:16 -06:00
},
2015-08-11 11:55:07 -05:00
}
}
fn test_closure() {
let _ = || {
return true;
2015-08-11 11:55:07 -05:00
};
2017-01-14 22:16:02 -06:00
let _ = || return true;
2015-08-11 11:55:07 -05:00
}
fn test_macro_call() -> i32 {
return the_answer!();
}
fn test_void_fun() {
return;
}
fn test_void_if_fun(b: bool) {
if b {
return;
} else {
return;
}
}
2019-06-20 06:44:00 -05:00
fn test_void_match(x: u32) {
match x {
0 => (),
_ => return,
}
}
fn test_nested_match(x: u32) {
match x {
0 => (),
1 => {
let _ = 42;
return;
},
_ => return,
}
}
2022-06-18 11:36:47 -05:00
fn temporary_outlives_local() -> String {
let x = RefCell::<String>::default();
return x.borrow().clone();
}
fn borrows_but_not_last(value: bool) -> String {
if value {
2022-06-18 11:36:47 -05:00
let x = RefCell::<String>::default();
let _a = x.borrow().clone();
return String::from("test");
} else {
return String::new();
}
}
macro_rules! needed_return {
($e:expr) => {
if $e > 3 {
return;
}
};
}
fn test_return_in_macro() {
// This will return and the macro below won't be executed. Removing the `return` from the macro
// will change semantics.
needed_return!(10);
needed_return!(0);
}
mod issue6501 {
#[allow(clippy::unnecessary_lazy_evaluations)]
fn foo(bar: Result<(), ()>) {
bar.unwrap_or_else(|_| return)
}
fn test_closure() {
let _ = || {
return;
};
let _ = || return;
}
2021-01-18 15:33:25 -06:00
struct Foo;
#[allow(clippy::unnecessary_lazy_evaluations)]
fn bar(res: Result<Foo, u8>) -> Foo {
res.unwrap_or_else(|_| return Foo)
}
}
async fn async_test_end_of_fn() -> bool {
if true {
// no error!
return true;
}
return true;
}
async fn async_test_no_semicolon() -> bool {
return true;
}
async fn async_test_if_block() -> bool {
if true {
return true;
} else {
return false;
}
}
async fn async_test_match(x: bool) -> bool {
match x {
true => return false,
false => {
return true;
},
}
}
async fn async_test_closure() {
let _ = || {
return true;
};
let _ = || return true;
}
async fn async_test_macro_call() -> i32 {
return the_answer!();
}
async fn async_test_void_fun() {
return;
}
async fn async_test_void_if_fun(b: bool) {
if b {
return;
} else {
return;
}
}
async fn async_test_void_match(x: u32) {
match x {
0 => (),
_ => return,
}
}
2022-06-18 11:36:47 -05:00
async fn async_temporary_outlives_local() -> String {
let x = RefCell::<String>::default();
return x.borrow().clone();
}
async fn async_borrows_but_not_last(value: bool) -> String {
if value {
2022-06-18 11:36:47 -05:00
let x = RefCell::<String>::default();
let _a = x.borrow().clone();
return String::from("test");
} else {
return String::new();
}
}
async fn async_test_return_in_macro() {
needed_return!(10);
needed_return!(0);
}
2021-09-18 09:40:16 -05:00
fn let_else() {
let Some(1) = Some(1) else { return };
}
fn needless_return_macro() -> String {
let _ = "foo";
let _ = "bar";
return format!("Hello {}", "world!");
}
fn check_expect() -> bool {
if true {
// no error!
return true;
}
#[expect(clippy::needless_return)]
return true;
}
2021-04-12 07:58:34 -05:00
fn main() {}