mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5d2b9a9ed0
rust/tests/ui/pattern/usefulness/match-arm-statics-2.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

55 lines
2.1 KiB
Plaintext
Raw Normal View History

Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
error[E0004]: non-exhaustive patterns: `(true, false)` not covered
tests: remove ignore directives from tests that mention core/alloc/std spans.
2020-03-31 20:10:13 -05:00
--> $DIR/match-arm-statics-2.rs:17:11
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
|
LL | match (true, false) {
| ^^^^^^^^^^^^^ pattern `(true, false)` not covered
Point at enum definition when match patterns are not exhaustive ``` error[E0004]: non-exhaustive patterns: type `X` is non-empty --> file.rs:9:11 | 1 | / enum X { 2 | | A, | | - variant not covered 3 | | B, | | - variant not covered 4 | | C, | | - variant not covered 5 | | } | |_- `X` defined here ... 9 | match x { | ^ | = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms error[E0004]: non-exhaustive patterns: `B` and `C` not covered --> file.rs:11:11 | 1 | / enum X { 2 | | A, 3 | | B, 4 | | C, | | - not covered 5 | | } | |_- `X` defined here ... 11 | match x { | ^ patterns `C` not covered ``` When a match expression doesn't have patterns covering every variant, point at the enum's definition span. On a best effort basis, point at the variant(s) that are missing. This does not handle the case when the missing pattern is due to a field's enum variants: ``` enum E1 { A, B, C, } enum E2 { A(E1), B, } fn foo() { match E2::A(E1::A) { E2::A(E1::B) => {} E2::B => {} } //~^ ERROR `E2::A(E1::A)` and `E2::A(E1::C)` not handled } ``` Unify look between match with no arms and match with some missing patterns. Fix #37518.
2019-02-10 07:12:00 -06:00
|
non-exhastive diagnostic: add note re. scrutinee type
2020-03-27 00:44:30 -05:00
= note: the matched value is of type `(bool, bool)`
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
When finding a match expr with multiple arms that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} Some(1) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} Some(1) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:28:09 -06:00
|
LL ~ (false, true) => (),
LL + (true, false) => todo!()
|
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
error[E0004]: non-exhaustive patterns: `Some(Some(Direction::West))` not covered
tests: remove ignore directives from tests that mention core/alloc/std spans.
2020-03-31 20:10:13 -05:00
--> $DIR/match-arm-statics-2.rs:29:11
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
|
LL | match Some(Some(North)) {
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
| ^^^^^^^^^^^^^^^^^ pattern `Some(Some(Direction::West))` not covered
Remove trailing whitespace from error messages
2021-06-10 06:52:00 -05:00
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
note: `Option<Option<Direction>>` defined here
--> $SRC_DIR/core/src/option.rs:LL:COL
Avoid rendering empty annotations
2022-12-12 09:25:04 -06:00
::: $SRC_DIR/core/src/option.rs:LL:COL
|
= note: not covered
|
= note: not covered
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
= note: the matched value is of type `Option<Option<Direction>>`
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
When finding a match expr with multiple arms that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} Some(1) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} Some(1) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:28:09 -06:00
|
LL ~ None => (),
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
LL + Some(Some(Direction::West)) => todo!()
When finding a match expr with multiple arms that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} Some(1) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} Some(1) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:28:09 -06:00
|
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
error[E0004]: non-exhaustive patterns: `Foo { bar: Some(Direction::North), baz: NewBool(true) }` not covered
tests: remove ignore directives from tests that mention core/alloc/std spans.
2020-03-31 20:10:13 -05:00
--> $DIR/match-arm-statics-2.rs:48:11
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
LL | match (Foo { bar: Some(North), baz: NewBool(true) }) {
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ pattern `Foo { bar: Some(Direction::North), baz: NewBool(true) }` not covered
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
|
note: `Foo` defined here
--> $DIR/match-arm-statics-2.rs:40:8
Point at enum definition when match patterns are not exhaustive ``` error[E0004]: non-exhaustive patterns: type `X` is non-empty --> file.rs:9:11 | 1 | / enum X { 2 | | A, | | - variant not covered 3 | | B, | | - variant not covered 4 | | C, | | - variant not covered 5 | | } | |_- `X` defined here ... 9 | match x { | ^ | = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms error[E0004]: non-exhaustive patterns: `B` and `C` not covered --> file.rs:11:11 | 1 | / enum X { 2 | | A, 3 | | B, 4 | | C, | | - not covered 5 | | } | |_- `X` defined here ... 11 | match x { | ^ patterns `C` not covered ``` When a match expression doesn't have patterns covering every variant, point at the enum's definition span. On a best effort basis, point at the variant(s) that are missing. This does not handle the case when the missing pattern is due to a field's enum variants: ``` enum E1 { A, B, C, } enum E2 { A(E1), B, } fn foo() { match E2::A(E1::A) { E2::A(E1::B) => {} E2::B => {} } //~^ ERROR `E2::A(E1::A)` and `E2::A(E1::C)` not handled } ``` Unify look between match with no arms and match with some missing patterns. Fix #37518.
2019-02-10 07:12:00 -06:00
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
LL | struct Foo {
| ^^^
non-exhastive diagnostic: add note re. scrutinee type
2020-03-27 00:44:30 -05:00
= note: the matched value is of type `Foo`
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
When finding a match expr with multiple arms that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} Some(1) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} Some(1) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:28:09 -06:00
|
LL ~ Foo { bar: Some(EAST), .. } => (),
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
LL + Foo { bar: Some(Direction::North), baz: NewBool(true) } => todo!()
When finding a match expr with multiple arms that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} Some(1) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} Some(1) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:28:09 -06:00
|
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
error: aborting due to 3 previous errors
For more information about this error, try `rustc --explain E0004`.
Reference in New Issue Copy Permalink