rust/tests/ui/rc_clone_in_vec_init/weak.rs

102 lines
3.0 KiB
Rust
Raw Normal View History

2023-07-27 06:40:22 -05:00
//@no-rustfix: overlapping suggestions
#![warn(clippy::rc_clone_in_vec_init)]
2023-06-06 15:56:57 -05:00
#![allow(clippy::useless_vec)]
use std::rc::{Rc, Weak as UnSyncWeak};
use std::sync::{Arc, Mutex, Weak as SyncWeak};
fn main() {}
fn should_warn_simple_case() {
let v = vec![SyncWeak::<u32>::new(); 2];
//~^ ERROR: initializing a reference-counted pointer in `vec![elem; len]`
//~| NOTE: each element will point to the same `Weak` instance
let v2 = vec![UnSyncWeak::<u32>::new(); 2];
//~^ ERROR: initializing a reference-counted pointer in `vec![elem; len]`
//~| NOTE: each element will point to the same `Weak` instance
let v = vec![Rc::downgrade(&Rc::new("x".to_string())); 2];
//~^ ERROR: initializing a reference-counted pointer in `vec![elem; len]`
//~| NOTE: each element will point to the same `Weak` instance
let v = vec![Arc::downgrade(&Arc::new("x".to_string())); 2];
//~^ ERROR: initializing a reference-counted pointer in `vec![elem; len]`
//~| NOTE: each element will point to the same `Weak` instance
}
fn should_warn_simple_case_with_big_indentation() {
if true {
let k = 1;
dbg!(k);
if true {
let v = vec![Arc::downgrade(&Arc::new("x".to_string())); 2];
//~^ ERROR: initializing a reference-counted pointer in `vec![elem; len]`
//~| NOTE: each element will point to the same `Weak` instance
let v2 = vec![Rc::downgrade(&Rc::new("x".to_string())); 2];
//~^ ERROR: initializing a reference-counted pointer in `vec![elem; len]`
//~| NOTE: each element will point to the same `Weak` instance
}
}
}
fn should_warn_complex_case() {
let v = vec![
//~^ ERROR: initializing a reference-counted pointer in `vec![elem; len]`
//~| NOTE: each element will point to the same `Weak` instance
Arc::downgrade(&Arc::new(Mutex::new({
let x = 1;
dbg!(x);
x
})));
2
];
let v1 = vec![
//~^ ERROR: initializing a reference-counted pointer in `vec![elem; len]`
//~| NOTE: each element will point to the same `Weak` instance
Rc::downgrade(&Rc::new(Mutex::new({
let x = 1;
dbg!(x);
x
})));
2
];
}
fn should_not_warn_custom_weak() {
#[derive(Clone)]
struct Weak;
impl Weak {
fn new() -> Self {
Weak
}
}
let v = vec![Weak::new(); 2];
}
fn should_not_warn_vec_from_elem_but_not_weak() {
let v = vec![String::new(); 2];
let v1 = vec![1; 2];
let v2 = vec![
Box::new(Arc::downgrade(&Arc::new({
let y = 3;
dbg!(y);
y
})));
2
];
let v3 = vec![
Box::new(Rc::downgrade(&Rc::new({
let y = 3;
dbg!(y);
y
})));
2
];
}
fn should_not_warn_vec_macro_but_not_from_elem() {
let v = vec![Arc::downgrade(&Arc::new("x".to_string()))];
let v = vec![Rc::downgrade(&Rc::new("x".to_string()))];
}