rust/clippy_lints/src/redundant_field_names.rs

use syntax::ast::Name;
use rustc::lint::*;
use rustc::hir::*;
use utils::{match_qpath, match_var, span_lint_and_sugg};
use utils::paths;

/// **What it does:** Checks for fields in struct literals where shorthands
/// could be used.
/// 
/// **Why is this bad?** If the field and variable names are the same,
/// the field name is redundant.
/// 
/// **Known problems:** None.
/// 
/// **Example:**
/// ```rust
/// let bar: u8 = 123;
/// 
/// struct Foo {
///     bar: u8,
/// }
/// 
/// let foo = Foo{ bar: bar }
/// ```
declare_lint! {
    pub REDUNDANT_FIELD_NAMES,
    Warn,
    "checks for fields in struct literals where shorthands could be used"
}

pub struct RedundantFieldNames;

impl LintPass for RedundantFieldNames {
    fn get_lints(&self) -> LintArray {
        lint_array!(REDUNDANT_FIELD_NAMES)
    }
}

impl<'a, 'tcx> LateLintPass<'a, 'tcx> for RedundantFieldNames {
    fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
        if let ExprStruct(ref path, ref fields, _) = expr.node {
            for field in fields {
                let name = field.name.node;

                if is_range_struct_field(path, &name) {
                    continue;
                }

                if match_var(&field.expr, name) && !field.is_shorthand {
                    span_lint_and_sugg (
                        cx,
                        REDUNDANT_FIELD_NAMES,
                        field.span,
                        "redundant field names in struct initialization",
                        "replace it with",
                        name.to_string()
                    );
                }
            }
        }
    }
}

/// ```rust
/// let start = 0;
/// let _ = start..;
///
/// let end = 0;
/// let _ = ..end;
///
/// let _ = start..end;
/// ```
fn is_range_struct_field(path: &QPath, name: &Name) -> bool {
    match name.as_str().as_ref() {
        "start" => {
            match_qpath(path, &paths::RANGE_STD) || match_qpath(path, &paths::RANGE_FROM_STD)
                || match_qpath(path, &paths::RANGE_INCLUSIVE_STD)
        },
        "end" => {
            match_qpath(path, &paths::RANGE_STD) || match_qpath(path, &paths::RANGE_TO_STD)
                || match_qpath(path, &paths::RANGE_INCLUSIVE_STD)
                || match_qpath(path, &paths::RANGE_TO_INCLUSIVE_STD)
        },
        _ => false,
    }
}