mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5ae8e23816
rust/tests/ui/privacy/pub-priv-dep/pub-priv1.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

27 lines
756 B
Plaintext
Raw Normal View History

pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
error: type `OtherType` from private dependency 'priv_dep' in public interface
Clean up some `-Z unstable-options` in tests.
2021-11-03 22:00:00 -05:00
--> $DIR/pub-priv1.rs:21:5
Add UI test
2019-01-13 17:50:24 -06:00
|
LL | pub field: OtherType,
| ^^^^^^^^^^^^^^^^^^^^
|
Normalise notes with the/is
2020-01-22 17:57:38 -06:00
note: the lint level is defined here
Clean up some `-Z unstable-options` in tests.
2021-11-03 22:00:00 -05:00
--> $DIR/pub-priv1.rs:4:9
Add UI test
2019-01-13 17:50:24 -06:00
|
Rename external_private_dependency to exported_private_dependencies
2019-01-20 21:04:22 -06:00
LL | #![deny(exported_private_dependencies)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Add UI test
2019-01-13 17:50:24 -06:00
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
error: type `OtherType` from private dependency 'priv_dep' in public interface
Clean up some `-Z unstable-options` in tests.
2021-11-03 22:00:00 -05:00
--> $DIR/pub-priv1.rs:28:5
Add UI test
2019-01-13 17:50:24 -06:00
|
LL | pub fn pub_fn(param: OtherType) {}
Use smaller def span for functions Currently, the def span of a funtion encompasses the entire function signature and body. However, this is usually unnecessarily verbose - when we are pointing at an entire function in a diagnostic, we almost always want to point at the signature. The actual contents of the body tends to be irrelevant to the diagnostic we are emitting, and just takes up additional screen space. This commit changes the `def_span` of all function items (freestanding functions, `impl`-block methods, and `trait`-block methods) to be the span of the signature. For example, the function ```rust pub fn foo<T>(val: T) -> T { val } ``` now has a `def_span` corresponding to `pub fn foo<T>(val: T) -> T` (everything before the opening curly brace). Trait methods without a body have a `def_span` which includes the trailing semicolon. For example: ```rust trait Foo { fn bar(); }``` the function definition `Foo::bar` has a `def_span` of `fn bar();` This makes our diagnostic output much shorter, and emphasizes information that is relevant to whatever diagnostic we are reporting. We continue to use the full span (including the body) in a few of places: * MIR building uses the full span when building source scopes. * 'Outlives suggestions' use the full span to sort the diagnostics being emitted. * The `#[rustc_on_unimplemented(enclosing_scope="in this scope")]` attribute points the entire scope body. * The 'unconditional recursion' lint uses the full span to show additional context for the recursive call. All of these cases work only with local items, so we don't need to add anything extra to crate metadata.
2020-08-12 16:02:14 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Add UI test
2019-01-13 17:50:24 -06:00
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
error: trait `OtherTrait` from private dependency 'priv_dep' in public interface
Clean up some `-Z unstable-options` in tests.
2021-11-03 22:00:00 -05:00
--> $DIR/pub-priv1.rs:35:5
Improve UI tests
2019-01-13 19:37:27 -06:00
|
Separate bounds and predicates for associated/opaque types
2020-06-27 15:36:35 -05:00
LL | type Foo: OtherTrait;
Shorten def_span for more items.
2022-02-13 09:27:59 -06:00
| ^^^^^^^^^^^^^^^^^^^^
Improve UI tests
2019-01-13 19:37:27 -06:00
error: aborting due to 3 previous errors
Add UI test
2019-01-13 17:50:24 -06:00
Reference in New Issue Copy Permalink