implement unwinding abi's (RFC 2945)
### Changes
This commit implements unwind ABI's, specified in RFC 2945.
We adjust the `rustc_middle::ty::layout::fn_can_unwind` function,
used to compute whether or not a `FnAbi` object represents a
function that should be able to unwind when `panic=unwind` is in
use.
Changes are also made to
`rustc_mir_build::build::should_abort_on_panic` so that the
function ABI is used to determind whether it should abort, assuming
that the `panic=unwind` strategy is being used, and no explicit
unwind attribute was provided.
### Tests
Unit tests, checking that the behavior is correct for `C-unwind`,
`stdcall-unwind`, `system-unwind`, and `thiscall-unwind`, are
included. These alternative `unwind` ABI strings are specified in
RFC 2945, in the "_Other `unwind` ABI strings_" section.
Additionally, a test case is included to assert that the LLVM IR
generated for an external function defined with the `C-unwind` ABI
will be appropriately labeled with the `nounwind` LLVM attribute
when the `panic=abort` compilation flag is used.
### Ignore Directives
This commit uses `ignore-*` directives in two of our `*-unwind` ABI
test cases.
Specifically, the `stdcall-unwind` and `thiscall-unwind` test cases
ignore architectures that do not support `stdcall` and `thiscall`,
respectively.
These directives are cribbed from
`src/test/ui/c-variadic/variadic-ffi-1.rs` for `stdcall`, and
`src/test/ui/extern/extern-thiscall.rs` for `thiscall`.
2020-09-10 12:38:39 -05:00
|
|
|
// compile-flags: -C opt-level=0
|
2023-05-23 08:20:57 -05:00
|
|
|
// needs-unwind
|
implement unwinding abi's (RFC 2945)
### Changes
This commit implements unwind ABI's, specified in RFC 2945.
We adjust the `rustc_middle::ty::layout::fn_can_unwind` function,
used to compute whether or not a `FnAbi` object represents a
function that should be able to unwind when `panic=unwind` is in
use.
Changes are also made to
`rustc_mir_build::build::should_abort_on_panic` so that the
function ABI is used to determind whether it should abort, assuming
that the `panic=unwind` strategy is being used, and no explicit
unwind attribute was provided.
### Tests
Unit tests, checking that the behavior is correct for `C-unwind`,
`stdcall-unwind`, `system-unwind`, and `thiscall-unwind`, are
included. These alternative `unwind` ABI strings are specified in
RFC 2945, in the "_Other `unwind` ABI strings_" section.
Additionally, a test case is included to assert that the LLVM IR
generated for an external function defined with the `C-unwind` ABI
will be appropriately labeled with the `nounwind` LLVM attribute
when the `panic=abort` compilation flag is used.
### Ignore Directives
This commit uses `ignore-*` directives in two of our `*-unwind` ABI
test cases.
Specifically, the `stdcall-unwind` and `thiscall-unwind` test cases
ignore architectures that do not support `stdcall` and `thiscall`,
respectively.
These directives are cribbed from
`src/test/ui/c-variadic/variadic-ffi-1.rs` for `stdcall`, and
`src/test/ui/extern/extern-thiscall.rs` for `thiscall`.
2020-09-10 12:38:39 -05:00
|
|
|
|
2022-08-17 21:13:37 -05:00
|
|
|
// Test that `nounwind` attributes are correctly applied to exported `system` and `system-unwind`
|
implement unwinding abi's (RFC 2945)
### Changes
This commit implements unwind ABI's, specified in RFC 2945.
We adjust the `rustc_middle::ty::layout::fn_can_unwind` function,
used to compute whether or not a `FnAbi` object represents a
function that should be able to unwind when `panic=unwind` is in
use.
Changes are also made to
`rustc_mir_build::build::should_abort_on_panic` so that the
function ABI is used to determind whether it should abort, assuming
that the `panic=unwind` strategy is being used, and no explicit
unwind attribute was provided.
### Tests
Unit tests, checking that the behavior is correct for `C-unwind`,
`stdcall-unwind`, `system-unwind`, and `thiscall-unwind`, are
included. These alternative `unwind` ABI strings are specified in
RFC 2945, in the "_Other `unwind` ABI strings_" section.
Additionally, a test case is included to assert that the LLVM IR
generated for an external function defined with the `C-unwind` ABI
will be appropriately labeled with the `nounwind` LLVM attribute
when the `panic=abort` compilation flag is used.
### Ignore Directives
This commit uses `ignore-*` directives in two of our `*-unwind` ABI
test cases.
Specifically, the `stdcall-unwind` and `thiscall-unwind` test cases
ignore architectures that do not support `stdcall` and `thiscall`,
respectively.
These directives are cribbed from
`src/test/ui/c-variadic/variadic-ffi-1.rs` for `stdcall`, and
`src/test/ui/extern/extern-thiscall.rs` for `thiscall`.
2020-09-10 12:38:39 -05:00
|
|
|
// extern functions. `system-unwind` functions MUST NOT have this attribute. We disable
|
|
|
|
|
// optimizations above to prevent LLVM from inferring the attribute.
|
|
|
|
|
|
|
|
|
|
#![crate_type = "lib"]
|
|
|
|
|
#![feature(c_unwind)]
|
|
|
|
|
|
|
|
|
|
// CHECK: @rust_item_that_cannot_unwind() unnamed_addr #0 {
|
|
|
|
|
#[no_mangle]
|
|
|
|
|
pub extern "system" fn rust_item_that_cannot_unwind() {
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// CHECK: @rust_item_that_can_unwind() unnamed_addr #1 {
|
|
|
|
|
#[no_mangle]
|
|
|
|
|
pub extern "system-unwind" fn rust_item_that_can_unwind() {
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Now, make some assertions that the LLVM attributes for these functions are correct. First, make
|
|
|
|
|
// sure that the first item is correctly marked with the `nounwind` attribute:
|
|
|
|
|
//
|
|
|
|
|
// CHECK: attributes #0 = { {{.*}}nounwind{{.*}} }
|
|
|
|
|
//
|
|
|
|
|
// Next, let's assert that the second item, which CAN unwind, does not have this attribute.
|
|
|
|
|
//
|
|
|
|
|
// CHECK: attributes #1 = {
|
|
|
|
|
// CHECK-NOT: nounwind
|
|
|
|
|
// CHECK: }
|
