rust/tests/ui/unnecessary_literal_unwrap.rs

111 lines
3.3 KiB
Rust
Raw Normal View History

2023-02-16 17:14:20 -06:00
//@run-rustfix
2023-02-16 05:32:12 -06:00
#![warn(clippy::unnecessary_literal_unwrap)]
2023-02-16 16:31:52 -06:00
#![allow(unreachable_code)]
2023-05-31 14:09:12 -05:00
#![allow(
clippy::unnecessary_lazy_evaluations,
clippy::diverging_sub_expression,
clippy::let_unit_value,
clippy::no_effect
)]
2023-02-16 05:32:12 -06:00
2023-02-16 16:31:52 -06:00
fn unwrap_option_some() {
2023-02-16 08:37:18 -06:00
let _val = Some(1).unwrap();
let _val = Some(1).expect("this never happens");
2023-05-31 14:09:12 -05:00
Some(1).unwrap();
Some(1).expect("this never happens");
2023-02-16 08:37:18 -06:00
}
2023-07-05 22:24:20 -05:00
#[rustfmt::skip] // force rustfmt not to remove braces in `|| { 234 }`
2023-02-16 16:31:52 -06:00
fn unwrap_option_none() {
2023-05-31 14:09:12 -05:00
let _val = None::<()>.unwrap();
let _val = None::<()>.expect("this always happens");
2023-07-05 21:13:37 -05:00
let _val: String = None.unwrap_or_default();
2023-07-05 22:24:20 -05:00
let _val: u16 = None.unwrap_or(234);
let _val: u16 = None.unwrap_or_else(|| 234);
let _val: u16 = None.unwrap_or_else(|| { 234 });
let _val: u16 = None.unwrap_or_else(|| -> u16 { 234 });
2023-05-31 14:09:12 -05:00
None::<()>.unwrap();
None::<()>.expect("this always happens");
2023-07-05 21:13:37 -05:00
None::<String>.unwrap_or_default();
2023-07-05 22:24:20 -05:00
None::<u16>.unwrap_or(234);
None::<u16>.unwrap_or_else(|| 234);
None::<u16>.unwrap_or_else(|| { 234 });
None::<u16>.unwrap_or_else(|| -> u16 { 234 });
2023-02-16 16:31:52 -06:00
}
2023-02-16 11:15:19 -06:00
fn unwrap_result_ok() {
2023-05-31 14:09:12 -05:00
let _val = Ok::<_, ()>(1).unwrap();
let _val = Ok::<_, ()>(1).expect("this never happens");
let _val = Ok::<_, ()>(1).unwrap_err();
let _val = Ok::<_, ()>(1).expect_err("this always happens");
Ok::<_, ()>(1).unwrap();
Ok::<_, ()>(1).expect("this never happens");
Ok::<_, ()>(1).unwrap_err();
Ok::<_, ()>(1).expect_err("this always happens");
2023-02-16 11:15:19 -06:00
}
fn unwrap_result_err() {
2023-05-31 14:09:12 -05:00
let _val = Err::<(), _>(1).unwrap_err();
let _val = Err::<(), _>(1).expect_err("this never happens");
let _val = Err::<(), _>(1).unwrap();
let _val = Err::<(), _>(1).expect("this always happens");
Err::<(), _>(1).unwrap_err();
Err::<(), _>(1).expect_err("this never happens");
Err::<(), _>(1).unwrap();
Err::<(), _>(1).expect("this always happens");
2023-02-16 05:32:12 -06:00
}
2023-02-16 08:43:41 -06:00
fn unwrap_methods_option() {
let _val = Some(1).unwrap_or(2);
let _val = Some(1).unwrap_or_default();
2023-02-16 17:14:20 -06:00
let _val = Some(1).unwrap_or_else(|| 2);
2023-05-31 14:09:12 -05:00
Some(1).unwrap_or(2);
Some(1).unwrap_or_default();
Some(1).unwrap_or_else(|| 2);
2023-02-16 08:43:41 -06:00
}
fn unwrap_methods_result() {
2023-05-31 14:09:12 -05:00
let _val = Ok::<_, ()>(1).unwrap_or(2);
let _val = Ok::<_, ()>(1).unwrap_or_default();
let _val = Ok::<_, ()>(1).unwrap_or_else(|_| 2);
Ok::<_, ()>(1).unwrap_or(2);
Ok::<_, ()>(1).unwrap_or_default();
Ok::<_, ()>(1).unwrap_or_else(|_| 2);
2023-02-16 08:43:41 -06:00
}
fn unwrap_from_binding() {
macro_rules! from_macro {
() => {
Some("")
};
}
let val = from_macro!();
let _ = val.unwrap_or("");
}
fn unwrap_unchecked() {
let _ = unsafe { Some(1).unwrap_unchecked() };
let _ = unsafe { Some(1).unwrap_unchecked() + *(&1 as *const i32) }; // needs to keep the unsafe block
let _ = unsafe { Some(1).unwrap_unchecked() } + 1;
let _ = unsafe { Ok::<_, ()>(1).unwrap_unchecked() };
let _ = unsafe { Ok::<_, ()>(1).unwrap_unchecked() + *(&1 as *const i32) };
let _ = unsafe { Ok::<_, ()>(1).unwrap_unchecked() } + 1;
let _ = unsafe { Err::<(), i32>(123).unwrap_err_unchecked() };
}
2023-02-16 05:32:12 -06:00
fn main() {
2023-02-16 16:31:52 -06:00
unwrap_option_some();
unwrap_option_none();
2023-02-16 11:15:19 -06:00
unwrap_result_ok();
unwrap_result_err();
2023-02-16 08:43:41 -06:00
unwrap_methods_option();
unwrap_methods_result();
unwrap_unchecked();
2023-02-16 05:32:12 -06:00
}