2019-11-25 10:23:48 -06:00
|
|
|
#![cfg_attr(feature = "deny-warnings", deny(warnings))]
|
2021-05-20 05:30:31 -05:00
|
|
|
// warn on lints, that are included in `rust-lang/rust`s bootstrap
|
|
|
|
#![warn(rust_2018_idioms, unused_lifetimes)]
|
2019-11-25 10:23:48 -06:00
|
|
|
|
2021-07-01 11:17:38 -05:00
|
|
|
use clap::{App, AppSettings, Arg, ArgMatches, SubCommand};
|
2021-12-06 05:33:31 -06:00
|
|
|
use clippy_dev::{bless, fmt, lint, new_lint, serve, setup, update_lints};
|
2022-04-07 12:39:59 -05:00
|
|
|
use indoc::indoc;
|
2018-07-17 15:50:17 -05:00
|
|
|
fn main() {
|
2020-12-20 10:19:49 -06:00
|
|
|
let matches = get_clap_config();
|
|
|
|
|
|
|
|
match matches.subcommand() {
|
2021-01-15 03:56:44 -06:00
|
|
|
("bless", Some(matches)) => {
|
|
|
|
bless::bless(matches.is_present("ignore-timestamp"));
|
2020-12-20 10:19:49 -06:00
|
|
|
},
|
|
|
|
("fmt", Some(matches)) => {
|
|
|
|
fmt::run(matches.is_present("check"), matches.is_present("verbose"));
|
|
|
|
},
|
|
|
|
("update_lints", Some(matches)) => {
|
|
|
|
if matches.is_present("print-only") {
|
|
|
|
update_lints::print_lints();
|
|
|
|
} else if matches.is_present("check") {
|
2022-05-05 09:12:52 -05:00
|
|
|
update_lints::update(update_lints::UpdateMode::Check);
|
2020-12-20 10:19:49 -06:00
|
|
|
} else {
|
2022-05-05 09:12:52 -05:00
|
|
|
update_lints::update(update_lints::UpdateMode::Change);
|
2020-12-20 10:19:49 -06:00
|
|
|
}
|
|
|
|
},
|
|
|
|
("new_lint", Some(matches)) => {
|
|
|
|
match new_lint::create(
|
|
|
|
matches.value_of("pass"),
|
|
|
|
matches.value_of("name"),
|
|
|
|
matches.value_of("category"),
|
2021-10-21 06:11:36 -05:00
|
|
|
matches.is_present("msrv"),
|
2020-12-20 10:19:49 -06:00
|
|
|
) {
|
2022-05-05 09:12:52 -05:00
|
|
|
Ok(_) => update_lints::update(update_lints::UpdateMode::Change),
|
2020-12-20 10:19:49 -06:00
|
|
|
Err(e) => eprintln!("Unable to create lint: {}", e),
|
|
|
|
}
|
|
|
|
},
|
2021-07-01 11:17:38 -05:00
|
|
|
("setup", Some(sub_command)) => match sub_command.subcommand() {
|
2022-05-05 09:12:52 -05:00
|
|
|
("intellij", Some(matches)) => {
|
|
|
|
if matches.is_present("remove") {
|
|
|
|
setup::intellij::remove_rustc_src();
|
|
|
|
} else {
|
|
|
|
setup::intellij::setup_rustc_src(
|
|
|
|
matches
|
|
|
|
.value_of("rustc-repo-path")
|
|
|
|
.expect("this field is mandatory and therefore always valid"),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
},
|
|
|
|
("git-hook", Some(matches)) => {
|
|
|
|
if matches.is_present("remove") {
|
|
|
|
setup::git_hook::remove_hook();
|
|
|
|
} else {
|
|
|
|
setup::git_hook::install_hook(matches.is_present("force-override"));
|
|
|
|
}
|
|
|
|
},
|
|
|
|
("vscode-tasks", Some(matches)) => {
|
|
|
|
if matches.is_present("remove") {
|
|
|
|
setup::vscode::remove_tasks();
|
|
|
|
} else {
|
|
|
|
setup::vscode::install_tasks(matches.is_present("force-override"));
|
|
|
|
}
|
|
|
|
},
|
2021-07-01 11:17:38 -05:00
|
|
|
_ => {},
|
|
|
|
},
|
|
|
|
("remove", Some(sub_command)) => match sub_command.subcommand() {
|
|
|
|
("git-hook", Some(_)) => setup::git_hook::remove_hook(),
|
|
|
|
("intellij", Some(_)) => setup::intellij::remove_rustc_src(),
|
|
|
|
("vscode-tasks", Some(_)) => setup::vscode::remove_tasks(),
|
|
|
|
_ => {},
|
|
|
|
},
|
2020-12-20 10:19:49 -06:00
|
|
|
("serve", Some(matches)) => {
|
|
|
|
let port = matches.value_of("port").unwrap().parse().unwrap();
|
|
|
|
let lint = matches.value_of("lint");
|
|
|
|
serve::run(port, lint);
|
|
|
|
},
|
2021-12-06 05:33:31 -06:00
|
|
|
("lint", Some(matches)) => {
|
2022-04-07 12:39:59 -05:00
|
|
|
let path = matches.value_of("path").unwrap();
|
2022-05-21 06:24:00 -05:00
|
|
|
let args = matches.values_of("args").into_iter().flatten();
|
|
|
|
lint::run(path, args);
|
2021-12-06 05:33:31 -06:00
|
|
|
},
|
2022-05-05 09:12:52 -05:00
|
|
|
("rename_lint", Some(matches)) => {
|
|
|
|
let old_name = matches.value_of("old_name").unwrap();
|
|
|
|
let new_name = matches.value_of("new_name").unwrap_or(old_name);
|
|
|
|
let uplift = matches.is_present("uplift");
|
|
|
|
update_lints::rename(old_name, new_name, uplift);
|
|
|
|
},
|
2020-12-20 10:19:49 -06:00
|
|
|
_ => {},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn get_clap_config<'a>() -> ArgMatches<'a> {
|
2021-03-12 08:30:50 -06:00
|
|
|
App::new("Clippy developer tooling")
|
2021-07-01 11:17:38 -05:00
|
|
|
.setting(AppSettings::ArgRequiredElseHelp)
|
2021-01-15 03:56:44 -06:00
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("bless")
|
|
|
|
.about("bless the test output changes")
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("ignore-timestamp")
|
|
|
|
.long("ignore-timestamp")
|
|
|
|
.help("Include files updated before clippy was built"),
|
|
|
|
),
|
|
|
|
)
|
2019-06-24 23:43:38 -05:00
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("fmt")
|
|
|
|
.about("Run rustfmt on all projects and tests")
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("check")
|
|
|
|
.long("check")
|
|
|
|
.help("Use the rustfmt --check option"),
|
|
|
|
)
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("verbose")
|
|
|
|
.short("v")
|
|
|
|
.long("verbose")
|
|
|
|
.help("Echo commands run"),
|
|
|
|
),
|
|
|
|
)
|
2018-07-17 15:50:17 -05:00
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("update_lints")
|
2019-03-07 23:45:31 -06:00
|
|
|
.about("Updates lint registration and information from the source code")
|
|
|
|
.long_about(
|
2018-11-27 14:13:08 -06:00
|
|
|
"Makes sure that:\n \
|
2020-12-20 10:19:49 -06:00
|
|
|
* the lint count in README.md is correct\n \
|
|
|
|
* the changelog contains markdown link references at the bottom\n \
|
|
|
|
* all lint groups include the correct lints\n \
|
2022-05-21 06:24:00 -05:00
|
|
|
* lint modules in `clippy_lints/*` are visible in `src/lib.rs` via `pub mod`\n \
|
2020-12-20 10:19:49 -06:00
|
|
|
* all lints are registered in the lint store",
|
2018-11-04 02:41:28 -06:00
|
|
|
)
|
2018-11-27 14:13:08 -06:00
|
|
|
.arg(Arg::with_name("print-only").long("print-only").help(
|
|
|
|
"Print a table of lints to STDOUT. \
|
2020-12-20 10:19:49 -06:00
|
|
|
This does not include deprecated and internal lints. \
|
|
|
|
(Does not modify any files)",
|
2018-11-27 14:13:08 -06:00
|
|
|
))
|
2018-11-04 02:41:28 -06:00
|
|
|
.arg(
|
|
|
|
Arg::with_name("check")
|
|
|
|
.long("check")
|
2020-01-30 01:33:48 -06:00
|
|
|
.help("Checks that `cargo dev update_lints` has been run. Used on CI."),
|
2018-11-27 14:13:08 -06:00
|
|
|
),
|
|
|
|
)
|
2019-12-31 19:07:39 -06:00
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("new_lint")
|
2020-01-30 01:33:48 -06:00
|
|
|
.about("Create new lint and run `cargo dev update_lints`")
|
2019-12-31 19:07:39 -06:00
|
|
|
.arg(
|
|
|
|
Arg::with_name("pass")
|
|
|
|
.short("p")
|
|
|
|
.long("pass")
|
|
|
|
.help("Specify whether the lint runs during the early or late pass")
|
|
|
|
.takes_value(true)
|
|
|
|
.possible_values(&["early", "late"])
|
|
|
|
.required(true),
|
|
|
|
)
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("name")
|
|
|
|
.short("n")
|
|
|
|
.long("name")
|
|
|
|
.help("Name of the new lint in snake case, ex: fn_too_long")
|
|
|
|
.takes_value(true)
|
|
|
|
.required(true),
|
|
|
|
)
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("category")
|
|
|
|
.short("c")
|
|
|
|
.long("category")
|
|
|
|
.help("What category the lint belongs to")
|
|
|
|
.default_value("nursery")
|
|
|
|
.possible_values(&[
|
|
|
|
"style",
|
|
|
|
"correctness",
|
2021-07-01 11:17:38 -05:00
|
|
|
"suspicious",
|
2019-12-31 19:07:39 -06:00
|
|
|
"complexity",
|
|
|
|
"perf",
|
|
|
|
"pedantic",
|
|
|
|
"restriction",
|
|
|
|
"cargo",
|
|
|
|
"nursery",
|
|
|
|
"internal",
|
|
|
|
"internal_warn",
|
|
|
|
])
|
|
|
|
.takes_value(true),
|
2021-10-21 06:11:36 -05:00
|
|
|
)
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("msrv")
|
|
|
|
.long("msrv")
|
|
|
|
.help("Add MSRV config code to the lint"),
|
2019-12-31 19:07:39 -06:00
|
|
|
),
|
|
|
|
)
|
2020-06-09 09:36:01 -05:00
|
|
|
.subcommand(
|
2021-07-01 11:17:38 -05:00
|
|
|
SubCommand::with_name("setup")
|
|
|
|
.about("Support for setting up your personal development environment")
|
|
|
|
.setting(AppSettings::ArgRequiredElseHelp)
|
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("intellij")
|
|
|
|
.about("Alter dependencies so Intellij Rust can find rustc internals")
|
2022-05-05 09:12:52 -05:00
|
|
|
.arg(
|
|
|
|
Arg::with_name("remove")
|
|
|
|
.long("remove")
|
|
|
|
.help("Remove the dependencies added with 'cargo dev setup intellij'")
|
|
|
|
.required(false),
|
|
|
|
)
|
2021-07-01 11:17:38 -05:00
|
|
|
.arg(
|
|
|
|
Arg::with_name("rustc-repo-path")
|
|
|
|
.long("repo-path")
|
|
|
|
.short("r")
|
|
|
|
.help("The path to a rustc repo that will be used for setting the dependencies")
|
|
|
|
.takes_value(true)
|
|
|
|
.value_name("path")
|
2022-05-05 09:12:52 -05:00
|
|
|
.conflicts_with("remove")
|
2021-07-01 11:17:38 -05:00
|
|
|
.required(true),
|
|
|
|
),
|
|
|
|
)
|
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("git-hook")
|
|
|
|
.about("Add a pre-commit git hook that formats your code to make it look pretty")
|
2022-05-05 09:12:52 -05:00
|
|
|
.arg(
|
|
|
|
Arg::with_name("remove")
|
|
|
|
.long("remove")
|
|
|
|
.help("Remove the pre-commit hook added with 'cargo dev setup git-hook'")
|
|
|
|
.required(false),
|
|
|
|
)
|
2021-07-01 11:17:38 -05:00
|
|
|
.arg(
|
|
|
|
Arg::with_name("force-override")
|
|
|
|
.long("force-override")
|
|
|
|
.short("f")
|
|
|
|
.help("Forces the override of an existing git pre-commit hook")
|
|
|
|
.required(false),
|
|
|
|
),
|
|
|
|
)
|
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("vscode-tasks")
|
|
|
|
.about("Add several tasks to vscode for formatting, validation and testing")
|
2022-05-05 09:12:52 -05:00
|
|
|
.arg(
|
|
|
|
Arg::with_name("remove")
|
|
|
|
.long("remove")
|
|
|
|
.help("Remove the tasks added with 'cargo dev setup vscode-tasks'")
|
|
|
|
.required(false),
|
|
|
|
)
|
2021-07-01 11:17:38 -05:00
|
|
|
.arg(
|
|
|
|
Arg::with_name("force-override")
|
|
|
|
.long("force-override")
|
|
|
|
.short("f")
|
|
|
|
.help("Forces the override of existing vscode tasks")
|
|
|
|
.required(false),
|
|
|
|
),
|
|
|
|
),
|
|
|
|
)
|
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("remove")
|
|
|
|
.about("Support for undoing changes done by the setup command")
|
|
|
|
.setting(AppSettings::ArgRequiredElseHelp)
|
|
|
|
.subcommand(SubCommand::with_name("git-hook").about("Remove any existing pre-commit git hook"))
|
|
|
|
.subcommand(SubCommand::with_name("vscode-tasks").about("Remove any existing vscode tasks"))
|
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("intellij")
|
|
|
|
.about("Removes rustc source paths added via `cargo dev setup intellij`"),
|
2020-06-09 09:36:01 -05:00
|
|
|
),
|
|
|
|
)
|
2020-10-09 05:45:29 -05:00
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("serve")
|
|
|
|
.about("Launch a local 'ALL the Clippy Lints' website in a browser")
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("port")
|
|
|
|
.long("port")
|
|
|
|
.short("p")
|
|
|
|
.help("Local port for the http server")
|
|
|
|
.default_value("8000")
|
|
|
|
.validator_os(serve::validate_port),
|
|
|
|
)
|
|
|
|
.arg(Arg::with_name("lint").help("Which lint's page to load initially (optional)")),
|
2021-03-12 08:30:50 -06:00
|
|
|
)
|
2021-12-06 05:33:31 -06:00
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("lint")
|
2022-04-07 12:39:59 -05:00
|
|
|
.about("Manually run clippy on a file or package")
|
|
|
|
.after_help(indoc! {"
|
|
|
|
EXAMPLES
|
|
|
|
Lint a single file:
|
|
|
|
cargo dev lint tests/ui/attrs.rs
|
|
|
|
|
|
|
|
Lint a package directory:
|
|
|
|
cargo dev lint tests/ui-cargo/wildcard_dependencies/fail
|
|
|
|
cargo dev lint ~/my-project
|
2022-05-21 06:24:00 -05:00
|
|
|
|
|
|
|
Run rustfix:
|
|
|
|
cargo dev lint ~/my-project -- --fix
|
|
|
|
|
|
|
|
Set lint levels:
|
|
|
|
cargo dev lint file.rs -- -W clippy::pedantic
|
|
|
|
cargo dev lint ~/my-project -- -- -W clippy::pedantic
|
2022-04-07 12:39:59 -05:00
|
|
|
"})
|
2021-12-06 05:33:31 -06:00
|
|
|
.arg(
|
2022-04-07 12:39:59 -05:00
|
|
|
Arg::with_name("path")
|
2021-12-06 05:33:31 -06:00
|
|
|
.required(true)
|
2022-04-07 12:39:59 -05:00
|
|
|
.help("The path to a file or package directory to lint"),
|
2022-05-21 06:24:00 -05:00
|
|
|
)
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("args")
|
|
|
|
.multiple(true)
|
|
|
|
.help("Pass extra arguments to cargo/clippy-driver"),
|
2021-12-06 05:33:31 -06:00
|
|
|
),
|
|
|
|
)
|
2022-05-05 09:12:52 -05:00
|
|
|
.subcommand(
|
|
|
|
SubCommand::with_name("rename_lint")
|
|
|
|
.about("Renames the given lint")
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("old_name")
|
|
|
|
.index(1)
|
|
|
|
.required(true)
|
|
|
|
.help("The name of the lint to rename"),
|
|
|
|
)
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("new_name")
|
|
|
|
.index(2)
|
|
|
|
.required_unless("uplift")
|
|
|
|
.help("The new name of the lint"),
|
|
|
|
)
|
|
|
|
.arg(
|
|
|
|
Arg::with_name("uplift")
|
|
|
|
.long("uplift")
|
|
|
|
.help("This lint will be uplifted into rustc"),
|
|
|
|
),
|
|
|
|
)
|
2021-03-12 08:30:50 -06:00
|
|
|
.get_matches()
|
2018-07-17 15:50:17 -05:00
|
|
|
}
|