mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5451fe7d7c
rust/tests/ui/macros/issue-99265.fixed

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

140 lines
7.9 KiB
Rust
Raw Normal View History

Generate correct suggestion with named arguments used positionally Address issue #99265 by checking each positionally used argument to see if the argument is named and adding a lint to use the name instead. This way, when named arguments are used positionally in a different order than their argument order, the suggested lint is correct. For example: ``` println!("{b} {}", a=1, b=2); ``` This will now generate the suggestion: ``` println!("{b} {a}", a=1, b=2); ``` Additionally, this check now also correctly replaces or inserts only where the positional argument is (or would be if implicit). Also, width and precision are replaced with their argument names when they exists. Since the issues were so closely related, this fix for issue #99265 also fixes issue #99266. Fixes #99265 Fixes #99266
2022-07-16 16:13:14 -05:00
// check-pass
// run-rustfix
fn main() {
println!("{b} {a}", a=1, b=2);
//~^ WARNING named argument `a` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
println!("{} {a} {b} {c} {d}", 0, a=1, b=2, c=3, d=4);
//~^ WARNING named argument `a` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `b` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `c` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `d` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
println!("Hello {:width$}!", "x", width = 5);
//~^ WARNING named argument `width` is not used by name [named_arguments_used_positionally
//~| HELP use the named argument by name to avoid ambiguity
println!("Hello {f:width$.precision$}!", f = 0.02f32, width = 5, precision = 2);
//~^ WARNING named argument `width` is not used by name [named_arguments_used_positionally
//~| WARNING named argument `precision` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `f` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
println!("Hello {f:width$.precision$}!", f = 0.02f32, width = 5, precision = 2);
//~^ WARNING named argument `width` is not used by name [named_arguments_used_positionally
//~| WARNING named argument `precision` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `f` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
println!(
"{}, Hello {f:width$.precision$} {g:width2$.precision2$}! {f}",
//~^ HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
1,
f = 0.02f32,
//~^ WARNING named argument `f` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `f` is not used by name [named_arguments_used_positionally]
width = 5,
//~^ WARNING named argument `width` is not used by name [named_arguments_used_positionally
precision = 2,
//~^ WARNING named argument `precision` is not used by name [named_arguments_used_positionally]
g = 0.02f32,
//~^ WARNING named argument `g` is not used by name [named_arguments_used_positionally]
width2 = 5,
//~^ WARNING named argument `width2` is not used by name [named_arguments_used_positionally
precision2 = 2
//~^ WARNING named argument `precision2` is not used by name [named_arguments_used_positionally]
);
println!("Hello {f:0.1}!", f = 0.02f32);
//~^ WARNING named argument `f` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
println!("Hello {f:0.1}!", f = 0.02f32);
//~^ WARNING named argument `f` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
println!("Hello {f:width$.precision$}!", f = 0.02f32, width = 5, precision = 2);
let width = 5;
let precision = 2;
println!("Hello {f:width$.precision$}!", f = 0.02f32);
let val = 5;
println!("{v:v$}", v = val);
//~^ WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
println!("{v:v$}", v = val);
//~^ WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
println!("{v:v$.v$}", v = val);
//~^ WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
println!("{v:v$.v$}", v = val);
//~^ WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `v` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
println!("{a} {a} {a}", a = 1);
//~^ WARNING named argument `a` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `a` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
println!("aaaaaaaaaaaaaaa\
{a:b$.c$}",
//~^ HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
a = 1.0, b = 1, c = 2,
//~^ WARNING named argument `a` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `b` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `c` is not used by name [named_arguments_used_positionally]
);
println!("aaaaaaaaaaaaaaa\
{a:b$.c$}",
//~^ HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
a = 1.0, b = 1, c = 2,
//~^ WARNING named argument `a` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `b` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `c` is not used by name [named_arguments_used_positionally]
);
println!("{{{x:width$.precision$}}}", x = 1.0, width = 3, precision = 2);
//~^ WARNING named argument `x` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `width` is not used by name [named_arguments_used_positionally]
//~| WARNING named argument `precision` is not used by name [named_arguments_used_positionally]
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
//~| HELP use the named argument by name to avoid ambiguity
}
Reference in New Issue Copy Permalink