2019-09-30 03:58:53 -05:00
|
|
|
//! FIXME: write short doc here
|
|
|
|
|
2019-08-22 13:31:21 -05:00
|
|
|
use std::iter;
|
2019-02-03 12:26:35 -06:00
|
|
|
|
2019-09-12 16:34:52 -05:00
|
|
|
use hir::{db::HirDatabase, Adt, HasSource};
|
2019-10-12 14:07:47 -05:00
|
|
|
use ra_syntax::ast::{self, edit::IndentLevel, make, AstNode, NameOwner};
|
2019-02-03 12:26:35 -06:00
|
|
|
|
2019-09-26 04:18:26 -05:00
|
|
|
use crate::{Assist, AssistCtx, AssistId};
|
2019-06-23 23:05:50 -05:00
|
|
|
|
2019-10-26 09:37:04 -05:00
|
|
|
// Assist: fill_match_arms
|
|
|
|
//
|
|
|
|
// Adds missing clauses to a `match` expression.
|
|
|
|
//
|
|
|
|
// ```
|
|
|
|
// enum Action { Move { distance: u32 }, Stop }
|
|
|
|
//
|
|
|
|
// fn handle(action: Action) {
|
|
|
|
// match action {
|
|
|
|
// <|>
|
|
|
|
// }
|
|
|
|
// }
|
|
|
|
// ```
|
|
|
|
// ->
|
|
|
|
// ```
|
|
|
|
// enum Action { Move { distance: u32 }, Stop }
|
|
|
|
//
|
|
|
|
// fn handle(action: Action) {
|
|
|
|
// match action {
|
2019-10-26 10:03:55 -05:00
|
|
|
// Action::Move { distance } => (),
|
2019-10-26 09:37:04 -05:00
|
|
|
// Action::Stop => (),
|
|
|
|
// }
|
|
|
|
// }
|
|
|
|
// ```
|
2019-10-27 09:35:37 -05:00
|
|
|
pub(crate) fn fill_match_arms(ctx: AssistCtx<impl HirDatabase>) -> Option<Assist> {
|
2019-10-27 03:48:40 -05:00
|
|
|
let match_expr = ctx.find_node_at_offset::<ast::MatchExpr>()?;
|
2019-08-22 13:31:21 -05:00
|
|
|
let match_arm_list = match_expr.match_arm_list()?;
|
2019-02-03 12:26:35 -06:00
|
|
|
|
|
|
|
// We already have some match arms, so we don't provide any assists.
|
2019-06-23 23:05:50 -05:00
|
|
|
// Unless if there is only one trivial match arm possibly created
|
|
|
|
// by match postfix complete. Trivial match arm is the catch all arm.
|
2019-08-22 13:31:21 -05:00
|
|
|
let mut existing_arms = match_arm_list.arms();
|
|
|
|
if let Some(arm) = existing_arms.next() {
|
|
|
|
if !is_trivial(&arm) || existing_arms.next().is_some() {
|
|
|
|
return None;
|
2019-02-03 12:26:35 -06:00
|
|
|
}
|
2019-07-04 21:59:28 -05:00
|
|
|
};
|
2019-02-03 12:26:35 -06:00
|
|
|
|
|
|
|
let expr = match_expr.expr()?;
|
2020-01-10 14:42:04 -06:00
|
|
|
let (enum_def, module) = {
|
2019-11-15 16:14:56 -06:00
|
|
|
let analyzer = ctx.source_analyzer(expr.syntax(), None);
|
2020-01-10 14:42:04 -06:00
|
|
|
(resolve_enum_def(ctx.db, &analyzer, &expr)?, analyzer.module()?)
|
2019-08-22 13:31:21 -05:00
|
|
|
};
|
2020-01-10 14:42:04 -06:00
|
|
|
let variants = enum_def.variants(ctx.db);
|
|
|
|
if variants.is_empty() {
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
|
|
|
|
let db = ctx.db;
|
2019-02-03 12:26:35 -06:00
|
|
|
|
2020-01-14 10:49:14 -06:00
|
|
|
ctx.add_assist(AssistId("fill_match_arms"), "Fill Match Arms", |edit| {
|
2019-10-12 14:07:47 -05:00
|
|
|
let indent_level = IndentLevel::from_node(match_arm_list.syntax());
|
|
|
|
|
|
|
|
let new_arm_list = {
|
|
|
|
let arms = variants
|
2020-01-10 14:42:04 -06:00
|
|
|
.into_iter()
|
|
|
|
.filter_map(|variant| build_pat(db, module, variant))
|
2019-10-12 14:07:47 -05:00
|
|
|
.map(|pat| make::match_arm(iter::once(pat), make::expr_unit()));
|
|
|
|
indent_level.increase_indent(make::match_arm_list(arms))
|
|
|
|
};
|
2019-02-03 12:26:35 -06:00
|
|
|
|
2019-07-20 04:58:27 -05:00
|
|
|
edit.target(match_expr.syntax().text_range());
|
|
|
|
edit.set_cursor(expr.syntax().text_range().start());
|
2019-10-12 14:07:47 -05:00
|
|
|
edit.replace_ast(match_arm_list, new_arm_list);
|
2019-10-27 09:35:37 -05:00
|
|
|
})
|
2019-02-03 12:26:35 -06:00
|
|
|
}
|
|
|
|
|
2019-08-22 13:31:21 -05:00
|
|
|
fn is_trivial(arm: &ast::MatchArm) -> bool {
|
|
|
|
arm.pats().any(|pat| match pat {
|
|
|
|
ast::Pat::PlaceholderPat(..) => true,
|
|
|
|
_ => false,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
fn resolve_enum_def(
|
|
|
|
db: &impl HirDatabase,
|
|
|
|
analyzer: &hir::SourceAnalyzer,
|
|
|
|
expr: &ast::Expr,
|
2020-01-10 14:42:04 -06:00
|
|
|
) -> Option<hir::Enum> {
|
2019-08-22 13:31:21 -05:00
|
|
|
let expr_ty = analyzer.type_of(db, &expr)?;
|
|
|
|
|
2020-01-10 14:42:04 -06:00
|
|
|
let result = expr_ty.autoderef(db).find_map(|ty| match ty.as_adt() {
|
|
|
|
Some(Adt::Enum(e)) => Some(e),
|
2019-08-22 13:31:21 -05:00
|
|
|
_ => None,
|
2019-11-26 05:02:57 -06:00
|
|
|
});
|
2020-01-10 14:42:04 -06:00
|
|
|
result
|
2019-08-22 13:31:21 -05:00
|
|
|
}
|
|
|
|
|
2020-01-10 14:42:04 -06:00
|
|
|
fn build_pat(
|
|
|
|
db: &impl HirDatabase,
|
|
|
|
module: hir::Module,
|
|
|
|
var: hir::EnumVariant,
|
|
|
|
) -> Option<ast::Pat> {
|
|
|
|
let path = crate::ast_transform::path_to_ast(module.find_use_path(db, var.into())?);
|
2019-08-22 13:31:21 -05:00
|
|
|
|
2020-01-10 14:42:04 -06:00
|
|
|
// FIXME: use HIR for this; it doesn't currently expose struct vs. tuple vs. unit variants though
|
|
|
|
let pat: ast::Pat = match var.source(db).value.kind() {
|
2019-08-22 13:31:21 -05:00
|
|
|
ast::StructKind::Tuple(field_list) => {
|
2019-09-26 04:18:26 -05:00
|
|
|
let pats =
|
|
|
|
iter::repeat(make::placeholder_pat().into()).take(field_list.fields().count());
|
|
|
|
make::tuple_struct_pat(path, pats).into()
|
2019-08-22 13:31:21 -05:00
|
|
|
}
|
2019-11-22 12:52:06 -06:00
|
|
|
ast::StructKind::Record(field_list) => {
|
2019-09-26 04:18:26 -05:00
|
|
|
let pats = field_list.fields().map(|f| make::bind_pat(f.name().unwrap()).into());
|
|
|
|
make::record_pat(path, pats).into()
|
2019-08-22 13:31:21 -05:00
|
|
|
}
|
2020-01-10 14:42:04 -06:00
|
|
|
ast::StructKind::Unit => make::path_pat(path),
|
2019-08-22 13:31:21 -05:00
|
|
|
};
|
|
|
|
|
|
|
|
Some(pat)
|
|
|
|
}
|
|
|
|
|
2019-02-03 12:26:35 -06:00
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
2019-02-08 17:34:05 -06:00
|
|
|
use crate::helpers::{check_assist, check_assist_target};
|
2019-02-03 12:26:35 -06:00
|
|
|
|
|
|
|
use super::fill_match_arms;
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn fill_match_arms_empty_body() {
|
|
|
|
check_assist(
|
|
|
|
fill_match_arms,
|
|
|
|
r#"
|
|
|
|
enum A {
|
|
|
|
As,
|
|
|
|
Bs,
|
|
|
|
Cs(String),
|
|
|
|
Ds(String, String),
|
2019-08-22 13:31:21 -05:00
|
|
|
Es{ x: usize, y: usize }
|
2019-02-03 12:26:35 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
let a = A::As;
|
|
|
|
match a<|> {}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
enum A {
|
|
|
|
As,
|
|
|
|
Bs,
|
|
|
|
Cs(String),
|
|
|
|
Ds(String, String),
|
2019-08-22 13:31:21 -05:00
|
|
|
Es{ x: usize, y: usize }
|
2019-02-03 12:26:35 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
let a = A::As;
|
|
|
|
match <|>a {
|
|
|
|
A::As => (),
|
|
|
|
A::Bs => (),
|
|
|
|
A::Cs(_) => (),
|
|
|
|
A::Ds(_, _) => (),
|
2019-10-26 10:03:55 -05:00
|
|
|
A::Es { x, y } => (),
|
2019-02-03 12:26:35 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
2019-02-23 06:59:41 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_fill_match_arm_refs() {
|
|
|
|
check_assist(
|
|
|
|
fill_match_arms,
|
|
|
|
r#"
|
|
|
|
enum A {
|
|
|
|
As,
|
|
|
|
}
|
|
|
|
|
|
|
|
fn foo(a: &A) {
|
|
|
|
match a<|> {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
enum A {
|
|
|
|
As,
|
|
|
|
}
|
|
|
|
|
|
|
|
fn foo(a: &A) {
|
|
|
|
match <|>a {
|
|
|
|
A::As => (),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
|
|
|
|
check_assist(
|
|
|
|
fill_match_arms,
|
|
|
|
r#"
|
|
|
|
enum A {
|
2019-08-22 13:31:21 -05:00
|
|
|
Es{ x: usize, y: usize }
|
2019-02-23 06:59:41 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
fn foo(a: &mut A) {
|
|
|
|
match a<|> {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
enum A {
|
2019-08-22 13:31:21 -05:00
|
|
|
Es{ x: usize, y: usize }
|
2019-02-23 06:59:41 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
fn foo(a: &mut A) {
|
|
|
|
match <|>a {
|
2019-10-26 10:03:55 -05:00
|
|
|
A::Es { x, y } => (),
|
2019-02-03 12:26:35 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
2019-02-08 17:34:05 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn fill_match_arms_target() {
|
|
|
|
check_assist_target(
|
|
|
|
fill_match_arms,
|
|
|
|
r#"
|
2019-08-22 13:31:21 -05:00
|
|
|
enum E { X, Y }
|
2019-02-08 17:34:05 -06:00
|
|
|
|
|
|
|
fn main() {
|
|
|
|
match E::X<|> {}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
"match E::X {}",
|
|
|
|
);
|
|
|
|
}
|
2019-06-23 23:05:50 -05:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn fill_match_arms_trivial_arm() {
|
|
|
|
check_assist(
|
|
|
|
fill_match_arms,
|
|
|
|
r#"
|
|
|
|
enum E { X, Y }
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
match E::X {
|
|
|
|
<|>_ => {},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
enum E { X, Y }
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
match <|>E::X {
|
|
|
|
E::X => (),
|
|
|
|
E::Y => (),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
2020-01-10 14:42:04 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn fill_match_arms_qualifies_path() {
|
|
|
|
check_assist(
|
|
|
|
fill_match_arms,
|
|
|
|
r#"
|
|
|
|
mod foo { pub enum E { X, Y } }
|
|
|
|
use foo::E::X;
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
match X {
|
|
|
|
<|>
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
mod foo { pub enum E { X, Y } }
|
|
|
|
use foo::E::X;
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
match <|>X {
|
|
|
|
X => (),
|
|
|
|
foo::E::Y => (),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
2019-02-03 12:26:35 -06:00
|
|
|
}
|