2020-05-17 10:36:26 -05:00
|
|
|
use crate::consts::{constant, Constant};
|
2018-11-27 14:14:15 -06:00
|
|
|
use if_chain::if_chain;
|
2020-02-29 21:23:33 -06:00
|
|
|
use rustc_ast::ast::RangeLimits;
|
2018-12-29 09:04:45 -06:00
|
|
|
use rustc_errors::Applicability;
|
2020-02-21 02:39:38 -06:00
|
|
|
use rustc_hir::{BinOpKind, Expr, ExprKind, QPath};
|
2020-01-12 00:08:41 -06:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-05-17 10:36:26 -05:00
|
|
|
use rustc_middle::ty;
|
2020-01-11 05:37:08 -06:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2020-01-04 04:00:00 -06:00
|
|
|
use rustc_span::source_map::Spanned;
|
2020-05-17 10:36:26 -05:00
|
|
|
use std::cmp::Ordering;
|
2015-08-15 11:55:25 -05:00
|
|
|
|
2019-01-30 19:15:29 -06:00
|
|
|
use crate::utils::sugg::Sugg;
|
2020-05-17 10:36:26 -05:00
|
|
|
use crate::utils::{get_parent_expr, is_integer_const, snippet, snippet_opt, span_lint, span_lint_and_then};
|
2019-12-18 10:59:43 -06:00
|
|
|
use crate::utils::{higher, SpanlessEq};
|
2017-06-18 08:14:46 -05:00
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks for zipping a collection with the range of
|
|
|
|
/// `0.._.len()`.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is better expressed with `.enumerate()`.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
2019-08-02 01:13:54 -05:00
|
|
|
/// # let x = vec![1];
|
|
|
|
/// x.iter().zip(0..x.len());
|
2019-03-05 10:50:33 -06:00
|
|
|
/// ```
|
2019-08-20 09:55:17 -05:00
|
|
|
/// Could be written as
|
|
|
|
/// ```rust
|
|
|
|
/// # let x = vec![1];
|
|
|
|
/// x.iter().enumerate();
|
|
|
|
/// ```
|
2016-08-06 03:18:36 -05:00
|
|
|
pub RANGE_ZIP_WITH_LEN,
|
2018-03-28 08:24:26 -05:00
|
|
|
complexity,
|
2016-08-06 03:18:36 -05:00
|
|
|
"zipping iterator with a range when `enumerate()` would do"
|
2015-11-03 08:42:52 -06:00
|
|
|
}
|
2015-08-15 11:55:25 -05:00
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks for exclusive ranges where 1 is added to the
|
2019-01-30 19:15:29 -06:00
|
|
|
/// upper bound, e.g., `x..(y+1)`.
|
2019-03-05 10:50:33 -06:00
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is more readable with an inclusive range
|
|
|
|
/// like `x..=y`.
|
|
|
|
///
|
|
|
|
/// **Known problems:** Will add unnecessary pair of parentheses when the
|
|
|
|
/// expression is not wrapped in a pair but starts with a opening parenthesis
|
|
|
|
/// and ends with a closing one.
|
2019-01-30 19:15:29 -06:00
|
|
|
/// I.e., `let _ = (f()+1)..(f()+1)` results in `let _ = ((f()+1)..=f())`.
|
2019-03-05 10:50:33 -06:00
|
|
|
///
|
2020-01-17 03:15:14 -06:00
|
|
|
/// Also in many cases, inclusive ranges are still slower to run than
|
|
|
|
/// exclusive ranges, because they essentially add an extra branch that
|
|
|
|
/// LLVM may fail to hoist out of the loop.
|
|
|
|
///
|
2020-07-14 07:59:59 -05:00
|
|
|
/// This will cause a warning that cannot be fixed if the consumer of the
|
|
|
|
/// range only accepts a specific range type, instead of the generic
|
|
|
|
/// `RangeBounds` trait
|
|
|
|
/// ([#3307](https://github.com/rust-lang/rust-clippy/issues/3307)).
|
|
|
|
///
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **Example:**
|
2019-08-02 01:13:54 -05:00
|
|
|
/// ```rust,ignore
|
2019-03-05 10:50:33 -06:00
|
|
|
/// for x..(y+1) { .. }
|
|
|
|
/// ```
|
2019-08-20 09:55:17 -05:00
|
|
|
/// Could be written as
|
|
|
|
/// ```rust,ignore
|
|
|
|
/// for x..=y { .. }
|
|
|
|
/// ```
|
2017-10-07 09:56:45 -05:00
|
|
|
pub RANGE_PLUS_ONE,
|
2020-01-17 03:15:14 -06:00
|
|
|
pedantic,
|
2017-10-07 09:56:45 -05:00
|
|
|
"`x..(y+1)` reads better as `x..=y`"
|
|
|
|
}
|
|
|
|
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 10:50:33 -06:00
|
|
|
/// **What it does:** Checks for inclusive ranges where 1 is subtracted from
|
2019-01-30 19:15:29 -06:00
|
|
|
/// the upper bound, e.g., `x..=(y-1)`.
|
2019-03-05 10:50:33 -06:00
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is more readable with an exclusive range
|
|
|
|
/// like `x..y`.
|
|
|
|
///
|
2020-07-14 07:59:59 -05:00
|
|
|
/// **Known problems:** This will cause a warning that cannot be fixed if
|
|
|
|
/// the consumer of the range only accepts a specific range type, instead of
|
|
|
|
/// the generic `RangeBounds` trait
|
|
|
|
/// ([#3307](https://github.com/rust-lang/rust-clippy/issues/3307)).
|
2019-03-05 10:50:33 -06:00
|
|
|
///
|
|
|
|
/// **Example:**
|
2019-08-02 01:13:54 -05:00
|
|
|
/// ```rust,ignore
|
2019-03-05 10:50:33 -06:00
|
|
|
/// for x..=(y-1) { .. }
|
|
|
|
/// ```
|
2019-08-20 09:55:17 -05:00
|
|
|
/// Could be written as
|
|
|
|
/// ```rust,ignore
|
|
|
|
/// for x..y { .. }
|
|
|
|
/// ```
|
2017-10-07 09:56:45 -05:00
|
|
|
pub RANGE_MINUS_ONE,
|
2020-07-14 07:59:59 -05:00
|
|
|
pedantic,
|
2017-10-07 09:56:45 -05:00
|
|
|
"`x..=(y-1)` reads better as `x..y`"
|
|
|
|
}
|
|
|
|
|
2020-05-17 10:36:26 -05:00
|
|
|
declare_clippy_lint! {
|
|
|
|
/// **What it does:** Checks for range expressions `x..y` where both `x` and `y`
|
|
|
|
/// are constant and `x` is greater or equal to `y`.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** Empty ranges yield no values so iterating them is a no-op.
|
|
|
|
/// Moreover, trying to use a reversed range to index a slice will panic at run-time.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
///
|
|
|
|
/// ```rust,no_run
|
|
|
|
/// fn main() {
|
|
|
|
/// (10..=0).for_each(|x| println!("{}", x));
|
|
|
|
///
|
|
|
|
/// let arr = [1, 2, 3, 4, 5];
|
|
|
|
/// let sub = &arr[3..1];
|
|
|
|
/// }
|
|
|
|
/// ```
|
|
|
|
/// Use instead:
|
|
|
|
/// ```rust
|
|
|
|
/// fn main() {
|
|
|
|
/// (0..=10).rev().for_each(|x| println!("{}", x));
|
|
|
|
///
|
|
|
|
/// let arr = [1, 2, 3, 4, 5];
|
|
|
|
/// let sub = &arr[1..3];
|
|
|
|
/// }
|
|
|
|
/// ```
|
|
|
|
pub REVERSED_EMPTY_RANGES,
|
|
|
|
correctness,
|
|
|
|
"reversing the limits of range expressions, resulting in empty ranges"
|
|
|
|
}
|
|
|
|
|
2019-04-08 15:43:55 -05:00
|
|
|
declare_lint_pass!(Ranges => [
|
|
|
|
RANGE_ZIP_WITH_LEN,
|
|
|
|
RANGE_PLUS_ONE,
|
2020-05-17 10:36:26 -05:00
|
|
|
RANGE_MINUS_ONE,
|
|
|
|
REVERSED_EMPTY_RANGES,
|
2019-04-08 15:43:55 -05:00
|
|
|
]);
|
2015-08-15 11:55:25 -05:00
|
|
|
|
2020-06-25 15:41:36 -05:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for Ranges {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
2020-06-09 16:44:04 -05:00
|
|
|
if let ExprKind::MethodCall(ref path, _, ref args, _) = expr.kind {
|
2018-06-28 08:46:58 -05:00
|
|
|
let name = path.ident.as_str();
|
2019-12-18 10:59:43 -06:00
|
|
|
if name == "zip" && args.len() == 2 {
|
2019-09-27 10:16:06 -05:00
|
|
|
let iter = &args[0].kind;
|
2016-03-07 09:31:38 -06:00
|
|
|
let zip_arg = &args[1];
|
2017-10-23 14:18:02 -05:00
|
|
|
if_chain! {
|
2019-01-30 19:15:29 -06:00
|
|
|
// `.iter()` call
|
2020-06-09 16:44:04 -05:00
|
|
|
if let ExprKind::MethodCall(ref iter_path, _, ref iter_args , _) = *iter;
|
2019-05-17 16:53:54 -05:00
|
|
|
if iter_path.ident.name == sym!(iter);
|
2019-01-30 19:15:29 -06:00
|
|
|
// range expression in `.zip()` call: `0..x.len()`
|
2018-05-08 10:16:01 -05:00
|
|
|
if let Some(higher::Range { start: Some(start), end: Some(end), .. }) = higher::range(cx, zip_arg);
|
2019-09-09 10:01:01 -05:00
|
|
|
if is_integer_const(cx, start, 0);
|
2019-01-30 19:15:29 -06:00
|
|
|
// `.len()` call
|
2020-06-09 16:44:04 -05:00
|
|
|
if let ExprKind::MethodCall(ref len_path, _, ref len_args, _) = end.kind;
|
2019-05-17 16:53:54 -05:00
|
|
|
if len_path.ident.name == sym!(len) && len_args.len() == 1;
|
2019-01-30 19:15:29 -06:00
|
|
|
// `.iter()` and `.len()` called on same `Path`
|
2019-09-27 10:16:06 -05:00
|
|
|
if let ExprKind::Path(QPath::Resolved(_, ref iter_path)) = iter_args[0].kind;
|
|
|
|
if let ExprKind::Path(QPath::Resolved(_, ref len_path)) = len_args[0].kind;
|
2018-07-14 17:00:27 -05:00
|
|
|
if SpanlessEq::new(cx).eq_path_segments(&iter_path.segments, &len_path.segments);
|
2017-10-23 14:18:02 -05:00
|
|
|
then {
|
|
|
|
span_lint(cx,
|
|
|
|
RANGE_ZIP_WITH_LEN,
|
|
|
|
expr.span,
|
2020-08-11 08:43:21 -05:00
|
|
|
&format!("it is more idiomatic to use `{}.iter().enumerate()`",
|
2017-10-23 14:18:02 -05:00
|
|
|
snippet(cx, iter_args[0].span, "_")));
|
|
|
|
}
|
|
|
|
}
|
2015-11-03 08:42:52 -06:00
|
|
|
}
|
2015-08-15 11:55:25 -05:00
|
|
|
}
|
2017-10-07 09:56:45 -05:00
|
|
|
|
2019-09-02 23:26:49 -05:00
|
|
|
check_exclusive_range_plus_one(cx, expr);
|
|
|
|
check_inclusive_range_minus_one(cx, expr);
|
2020-05-17 10:36:26 -05:00
|
|
|
check_reversed_empty_range(cx, expr);
|
2019-09-02 23:26:49 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// exclusive range plus one: `x..(y+1)`
|
2020-06-25 15:41:36 -05:00
|
|
|
fn check_exclusive_range_plus_one(cx: &LateContext<'_>, expr: &Expr<'_>) {
|
2019-09-02 23:26:49 -05:00
|
|
|
if_chain! {
|
|
|
|
if let Some(higher::Range {
|
|
|
|
start,
|
|
|
|
end: Some(end),
|
|
|
|
limits: RangeLimits::HalfOpen
|
|
|
|
}) = higher::range(cx, expr);
|
2019-09-09 10:01:01 -05:00
|
|
|
if let Some(y) = y_plus_one(cx, end);
|
2019-09-02 23:26:49 -05:00
|
|
|
then {
|
|
|
|
let span = if expr.span.from_expansion() {
|
|
|
|
expr.span
|
|
|
|
.ctxt()
|
|
|
|
.outer_expn_data()
|
|
|
|
.call_site
|
|
|
|
} else {
|
|
|
|
expr.span
|
|
|
|
};
|
|
|
|
span_lint_and_then(
|
|
|
|
cx,
|
|
|
|
RANGE_PLUS_ONE,
|
|
|
|
span,
|
|
|
|
"an inclusive range would be more readable",
|
2020-04-17 01:08:00 -05:00
|
|
|
|diag| {
|
2019-09-02 23:26:49 -05:00
|
|
|
let start = start.map_or(String::new(), |x| Sugg::hir(cx, x, "x").to_string());
|
|
|
|
let end = Sugg::hir(cx, y, "y");
|
|
|
|
if let Some(is_wrapped) = &snippet_opt(cx, span) {
|
|
|
|
if is_wrapped.starts_with('(') && is_wrapped.ends_with(')') {
|
2020-04-17 01:08:00 -05:00
|
|
|
diag.span_suggestion(
|
2019-09-02 23:26:49 -05:00
|
|
|
span,
|
|
|
|
"use",
|
|
|
|
format!("({}..={})", start, end),
|
|
|
|
Applicability::MaybeIncorrect,
|
|
|
|
);
|
|
|
|
} else {
|
2020-04-17 01:08:00 -05:00
|
|
|
diag.span_suggestion(
|
2019-09-02 23:26:49 -05:00
|
|
|
span,
|
|
|
|
"use",
|
|
|
|
format!("{}..={}", start, end),
|
|
|
|
Applicability::MachineApplicable, // snippet
|
|
|
|
);
|
2018-08-30 12:06:13 -05:00
|
|
|
}
|
2019-09-02 23:26:49 -05:00
|
|
|
}
|
|
|
|
},
|
|
|
|
);
|
2017-10-23 14:18:02 -05:00
|
|
|
}
|
2019-09-02 23:26:49 -05:00
|
|
|
}
|
|
|
|
}
|
2017-10-07 09:56:45 -05:00
|
|
|
|
2019-09-02 23:26:49 -05:00
|
|
|
// inclusive range minus one: `x..=(y-1)`
|
2020-06-25 15:41:36 -05:00
|
|
|
fn check_inclusive_range_minus_one(cx: &LateContext<'_>, expr: &Expr<'_>) {
|
2019-09-02 23:26:49 -05:00
|
|
|
if_chain! {
|
|
|
|
if let Some(higher::Range { start, end: Some(end), limits: RangeLimits::Closed }) = higher::range(cx, expr);
|
2019-09-09 10:01:01 -05:00
|
|
|
if let Some(y) = y_minus_one(cx, end);
|
2019-09-02 23:26:49 -05:00
|
|
|
then {
|
|
|
|
span_lint_and_then(
|
|
|
|
cx,
|
|
|
|
RANGE_MINUS_ONE,
|
|
|
|
expr.span,
|
|
|
|
"an exclusive range would be more readable",
|
2020-04-17 01:08:00 -05:00
|
|
|
|diag| {
|
2019-09-02 23:26:49 -05:00
|
|
|
let start = start.map_or(String::new(), |x| Sugg::hir(cx, x, "x").to_string());
|
|
|
|
let end = Sugg::hir(cx, y, "y");
|
2020-04-17 01:08:00 -05:00
|
|
|
diag.span_suggestion(
|
2019-09-02 23:26:49 -05:00
|
|
|
expr.span,
|
|
|
|
"use",
|
|
|
|
format!("{}..{}", start, end),
|
|
|
|
Applicability::MachineApplicable, // snippet
|
|
|
|
);
|
|
|
|
},
|
|
|
|
);
|
2017-10-23 14:18:02 -05:00
|
|
|
}
|
2015-08-15 11:55:25 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-06-25 15:41:36 -05:00
|
|
|
fn check_reversed_empty_range(cx: &LateContext<'_>, expr: &Expr<'_>) {
|
|
|
|
fn inside_indexing_expr(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
|
2020-06-09 09:36:01 -05:00
|
|
|
matches!(
|
|
|
|
get_parent_expr(cx, expr),
|
|
|
|
Some(Expr {
|
2020-05-17 10:36:26 -05:00
|
|
|
kind: ExprKind::Index(..),
|
|
|
|
..
|
2020-06-09 09:36:01 -05:00
|
|
|
})
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
2020-06-25 15:41:36 -05:00
|
|
|
fn is_for_loop_arg(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
|
2020-06-09 09:36:01 -05:00
|
|
|
let mut cur_expr = expr;
|
|
|
|
while let Some(parent_expr) = get_parent_expr(cx, cur_expr) {
|
|
|
|
match higher::for_loop(parent_expr) {
|
|
|
|
Some((_, args, _)) if args.hir_id == expr.hir_id => return true,
|
|
|
|
_ => cur_expr = parent_expr,
|
|
|
|
}
|
2020-05-28 08:45:24 -05:00
|
|
|
}
|
2020-06-09 09:36:01 -05:00
|
|
|
|
|
|
|
false
|
2020-05-17 10:36:26 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn is_empty_range(limits: RangeLimits, ordering: Ordering) -> bool {
|
|
|
|
match limits {
|
|
|
|
RangeLimits::HalfOpen => ordering != Ordering::Less,
|
|
|
|
RangeLimits::Closed => ordering == Ordering::Greater,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if_chain! {
|
|
|
|
if let Some(higher::Range { start: Some(start), end: Some(end), limits }) = higher::range(cx, expr);
|
2020-07-17 03:47:04 -05:00
|
|
|
let ty = cx.typeck_results().expr_ty(start);
|
2020-05-17 10:36:26 -05:00
|
|
|
if let ty::Int(_) | ty::Uint(_) = ty.kind;
|
2020-07-17 03:47:04 -05:00
|
|
|
if let Some((start_idx, _)) = constant(cx, cx.typeck_results(), start);
|
|
|
|
if let Some((end_idx, _)) = constant(cx, cx.typeck_results(), end);
|
2020-05-17 10:36:26 -05:00
|
|
|
if let Some(ordering) = Constant::partial_cmp(cx.tcx, ty, &start_idx, &end_idx);
|
|
|
|
if is_empty_range(limits, ordering);
|
|
|
|
then {
|
2020-06-09 09:36:01 -05:00
|
|
|
if inside_indexing_expr(cx, expr) {
|
|
|
|
// Avoid linting `N..N` as it has proven to be useful, see #5689 and #5628 ...
|
|
|
|
if ordering != Ordering::Equal {
|
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
REVERSED_EMPTY_RANGES,
|
|
|
|
expr.span,
|
|
|
|
"this range is reversed and using it to index a slice will panic at run-time",
|
|
|
|
);
|
|
|
|
}
|
|
|
|
// ... except in for loop arguments for backwards compatibility with `reverse_range_loop`
|
|
|
|
} else if ordering != Ordering::Equal || is_for_loop_arg(cx, expr) {
|
2020-05-17 10:36:26 -05:00
|
|
|
span_lint_and_then(
|
|
|
|
cx,
|
|
|
|
REVERSED_EMPTY_RANGES,
|
|
|
|
expr.span,
|
|
|
|
"this range is empty so it will yield no values",
|
|
|
|
|diag| {
|
|
|
|
if ordering != Ordering::Equal {
|
|
|
|
let start_snippet = snippet(cx, start.span, "_");
|
|
|
|
let end_snippet = snippet(cx, end.span, "_");
|
|
|
|
let dots = match limits {
|
|
|
|
RangeLimits::HalfOpen => "..",
|
|
|
|
RangeLimits::Closed => "..="
|
|
|
|
};
|
|
|
|
|
|
|
|
diag.span_suggestion(
|
|
|
|
expr.span,
|
|
|
|
"consider using the following if you are attempting to iterate over this \
|
|
|
|
range in reverse",
|
|
|
|
format!("({}{}{}).rev()", end_snippet, dots, start_snippet),
|
|
|
|
Applicability::MaybeIncorrect,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
},
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-06-25 15:41:36 -05:00
|
|
|
fn y_plus_one<'t>(cx: &LateContext<'_>, expr: &'t Expr<'_>) -> Option<&'t Expr<'t>> {
|
2019-09-27 10:16:06 -05:00
|
|
|
match expr.kind {
|
2018-11-27 14:14:15 -06:00
|
|
|
ExprKind::Binary(
|
|
|
|
Spanned {
|
|
|
|
node: BinOpKind::Add, ..
|
|
|
|
},
|
|
|
|
ref lhs,
|
|
|
|
ref rhs,
|
|
|
|
) => {
|
2019-09-09 10:01:01 -05:00
|
|
|
if is_integer_const(cx, lhs, 1) {
|
2018-11-27 14:14:15 -06:00
|
|
|
Some(rhs)
|
2019-09-09 10:01:01 -05:00
|
|
|
} else if is_integer_const(cx, rhs, 1) {
|
2018-11-27 14:14:15 -06:00
|
|
|
Some(lhs)
|
|
|
|
} else {
|
|
|
|
None
|
|
|
|
}
|
2017-10-07 09:56:45 -05:00
|
|
|
},
|
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-06-25 15:41:36 -05:00
|
|
|
fn y_minus_one<'t>(cx: &LateContext<'_>, expr: &'t Expr<'_>) -> Option<&'t Expr<'t>> {
|
2019-09-27 10:16:06 -05:00
|
|
|
match expr.kind {
|
2018-11-27 14:14:15 -06:00
|
|
|
ExprKind::Binary(
|
|
|
|
Spanned {
|
|
|
|
node: BinOpKind::Sub, ..
|
|
|
|
},
|
|
|
|
ref lhs,
|
|
|
|
ref rhs,
|
2019-09-09 10:01:01 -05:00
|
|
|
) if is_integer_const(cx, rhs, 1) => Some(lhs),
|
2017-10-07 09:56:45 -05:00
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|