rust/tests/ui/fn_params_excessive_bools.rs

61 lines
2.0 KiB
Rust
Raw Normal View History

2020-02-01 17:49:52 -06:00
#![warn(clippy::fn_params_excessive_bools)]
#![allow(clippy::too_many_arguments)]
2020-02-01 17:49:52 -06:00
extern "C" {
// Should not lint, most of the time users have no control over extern function signatures
2020-02-01 17:49:52 -06:00
fn f(_: bool, _: bool, _: bool, _: bool);
}
macro_rules! foo {
() => {
fn fff(_: bool, _: bool, _: bool, _: bool) {}
};
}
foo!();
#[no_mangle]
extern "C" fn k(_: bool, _: bool, _: bool, _: bool) {}
fn g(_: bool, _: bool, _: bool, _: bool) {}
//~^ ERROR: more than 3 bools in function parameters
2020-02-01 17:49:52 -06:00
fn h(_: bool, _: bool, _: bool) {}
fn e(_: S, _: S, _: Box<S>, _: Vec<u32>) {}
fn t(_: S, _: S, _: Box<S>, _: Vec<u32>, _: bool, _: bool, _: bool, _: bool) {}
//~^ ERROR: more than 3 bools in function parameters
2020-02-01 17:49:52 -06:00
struct S;
2020-02-01 17:49:52 -06:00
trait Trait {
// should warn for trait functions with and without body
2020-02-01 17:49:52 -06:00
fn f(_: bool, _: bool, _: bool, _: bool);
//~^ ERROR: more than 3 bools in function parameters
2020-02-01 17:49:52 -06:00
fn g(_: bool, _: bool, _: bool, _: Vec<u32>);
#[allow(clippy::fn_params_excessive_bools)]
fn h(_: bool, _: bool, _: bool, _: bool, _: bool, _: bool);
fn i(_: bool, _: bool, _: bool, _: bool) {}
//~^ ERROR: more than 3 bools in function parameters
2020-02-01 17:49:52 -06:00
}
impl S {
fn f(&self, _: bool, _: bool, _: bool, _: bool) {}
//~^ ERROR: more than 3 bools in function parameters
2020-02-01 17:49:52 -06:00
fn g(&self, _: bool, _: bool, _: bool) {}
#[no_mangle]
extern "C" fn h(_: bool, _: bool, _: bool, _: bool) {}
}
impl Trait for S {
// Should not lint because the trait might not be changeable by the user
// We only lint in the trait definition
2020-02-01 17:49:52 -06:00
fn f(_: bool, _: bool, _: bool, _: bool) {}
fn g(_: bool, _: bool, _: bool, _: Vec<u32>) {}
fn h(_: bool, _: bool, _: bool, _: bool, _: bool, _: bool) {}
2020-02-01 17:49:52 -06:00
}
fn main() {
fn n(_: bool, _: u32, _: bool, _: Box<u32>, _: bool, _: bool) {
//~^ ERROR: more than 3 bools in function parameters
2020-02-01 17:49:52 -06:00
fn nn(_: bool, _: bool, _: bool, _: bool) {}
//~^ ERROR: more than 3 bools in function parameters
2020-02-01 17:49:52 -06:00
}
}