2021-03-15 19:55:45 -05:00
|
|
|
use clippy_utils::diagnostics::span_lint;
|
2021-03-16 11:06:34 -05:00
|
|
|
use clippy_utils::{is_expn_of, match_panic_call};
|
2018-11-27 14:14:15 -06:00
|
|
|
use if_chain::if_chain;
|
2020-11-19 11:13:32 -06:00
|
|
|
use rustc_hir::Expr;
|
2020-01-12 00:08:41 -06:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-01-11 05:37:08 -06:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2019-12-30 18:17:56 -06:00
|
|
|
use rustc_span::Span;
|
2015-12-23 15:37:52 -06:00
|
|
|
|
2019-10-11 06:58:56 -05:00
|
|
|
declare_clippy_lint! {
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for usage of `panic!`.
|
2019-10-11 06:58:56 -05:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// `panic!` will stop the execution of the executable
|
2019-10-11 06:58:56 -05:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Example
|
2019-10-11 06:58:56 -05:00
|
|
|
/// ```no_run
|
|
|
|
/// panic!("even with a good reason");
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 14:06:26 -05:00
|
|
|
#[clippy::version = "1.40.0"]
|
2019-10-11 06:58:56 -05:00
|
|
|
pub PANIC,
|
|
|
|
restriction,
|
2019-10-16 12:43:26 -05:00
|
|
|
"usage of the `panic!` macro"
|
2019-10-11 06:58:56 -05:00
|
|
|
}
|
|
|
|
|
2018-05-23 09:43:05 -05:00
|
|
|
declare_clippy_lint! {
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for usage of `unimplemented!`.
|
2019-03-05 10:50:33 -06:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// This macro should not be present in production code
|
2019-03-05 10:50:33 -06:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Example
|
2019-03-05 16:23:50 -06:00
|
|
|
/// ```no_run
|
2019-03-05 10:50:33 -06:00
|
|
|
/// unimplemented!();
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 14:06:26 -05:00
|
|
|
#[clippy::version = "pre 1.29.0"]
|
2018-05-23 09:43:05 -05:00
|
|
|
pub UNIMPLEMENTED,
|
2018-05-24 12:26:04 -05:00
|
|
|
restriction,
|
2018-05-23 09:43:05 -05:00
|
|
|
"`unimplemented!` should not be present in production code"
|
|
|
|
}
|
|
|
|
|
2019-10-12 06:26:14 -05:00
|
|
|
declare_clippy_lint! {
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for usage of `todo!`.
|
2019-10-12 06:26:14 -05:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// This macro should not be present in production code
|
2019-10-12 06:26:14 -05:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Example
|
2019-10-12 06:26:14 -05:00
|
|
|
/// ```no_run
|
|
|
|
/// todo!();
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 14:06:26 -05:00
|
|
|
#[clippy::version = "1.40.0"]
|
2019-10-12 06:26:14 -05:00
|
|
|
pub TODO,
|
|
|
|
restriction,
|
|
|
|
"`todo!` should not be present in production code"
|
|
|
|
}
|
|
|
|
|
2019-10-11 06:58:56 -05:00
|
|
|
declare_clippy_lint! {
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for usage of `unreachable!`.
|
2019-10-11 06:58:56 -05:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// This macro can cause code to panic
|
2019-10-11 06:58:56 -05:00
|
|
|
///
|
2021-07-02 13:37:11 -05:00
|
|
|
/// ### Example
|
2019-10-11 06:58:56 -05:00
|
|
|
/// ```no_run
|
|
|
|
/// unreachable!();
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 14:06:26 -05:00
|
|
|
#[clippy::version = "1.40.0"]
|
2019-10-11 06:58:56 -05:00
|
|
|
pub UNREACHABLE,
|
|
|
|
restriction,
|
2020-11-28 11:19:57 -06:00
|
|
|
"usage of the `unreachable!` macro"
|
2019-10-11 06:58:56 -05:00
|
|
|
}
|
|
|
|
|
2020-11-19 11:13:32 -06:00
|
|
|
declare_lint_pass!(PanicUnimplemented => [UNIMPLEMENTED, UNREACHABLE, TODO, PANIC]);
|
2015-12-23 15:37:52 -06:00
|
|
|
|
2020-06-25 15:41:36 -05:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for PanicUnimplemented {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
2021-07-06 02:14:53 -05:00
|
|
|
if match_panic_call(cx, expr).is_some()
|
|
|
|
&& (is_expn_of(expr.span, "debug_assert").is_none() && is_expn_of(expr.span, "assert").is_none())
|
|
|
|
{
|
2020-11-17 14:16:15 -06:00
|
|
|
let span = get_outer_span(expr);
|
|
|
|
if is_expn_of(expr.span, "unimplemented").is_some() {
|
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
UNIMPLEMENTED,
|
|
|
|
span,
|
|
|
|
"`unimplemented` should not be present in production code",
|
|
|
|
);
|
|
|
|
} else if is_expn_of(expr.span, "todo").is_some() {
|
|
|
|
span_lint(cx, TODO, span, "`todo` should not be present in production code");
|
|
|
|
} else if is_expn_of(expr.span, "unreachable").is_some() {
|
2020-11-28 11:19:57 -06:00
|
|
|
span_lint(cx, UNREACHABLE, span, "usage of the `unreachable!` macro");
|
2020-11-17 14:16:15 -06:00
|
|
|
} else if is_expn_of(expr.span, "panic").is_some() {
|
|
|
|
span_lint(cx, PANIC, span, "`panic` should not be present in production code");
|
2017-10-23 14:18:02 -05:00
|
|
|
}
|
|
|
|
}
|
2015-12-23 15:37:52 -06:00
|
|
|
}
|
|
|
|
}
|
2018-05-23 09:43:05 -05:00
|
|
|
|
2019-12-27 01:12:26 -06:00
|
|
|
fn get_outer_span(expr: &Expr<'_>) -> Span {
|
2018-05-24 12:26:04 -05:00
|
|
|
if_chain! {
|
2019-08-16 11:29:30 -05:00
|
|
|
if expr.span.from_expansion();
|
2021-03-30 14:59:59 -05:00
|
|
|
let first = expr.span.ctxt().outer_expn_data().call_site;
|
|
|
|
if first.from_expansion();
|
2018-05-24 12:26:04 -05:00
|
|
|
then {
|
2021-03-30 14:59:59 -05:00
|
|
|
first.ctxt().outer_expn_data().call_site
|
2018-05-24 12:26:04 -05:00
|
|
|
} else {
|
|
|
|
expr.span
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|