rust/tests/ui/block_in_if_condition.rs

101 lines
2.0 KiB
Rust
Raw Normal View History

2018-10-06 11:18:06 -05:00
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
2018-10-11 05:16:22 -05:00
2017-09-18 05:47:33 -05:00
2018-07-28 10:34:52 -05:00
#![warn(clippy::block_in_if_condition_expr)]
#![warn(clippy::block_in_if_condition_stmt)]
#![allow(unused, clippy::let_and_return)]
#![warn(clippy::nonminimal_bool)]
2015-11-19 23:22:52 -06:00
macro_rules! blocky {
() => {{true}}
}
2016-01-31 16:25:10 -06:00
macro_rules! blocky_too {
() => {{
let r = true;
r
}}
}
fn macro_if() {
if blocky!() {
}
2016-12-21 05:30:41 -06:00
2016-01-31 16:25:10 -06:00
if blocky_too!() {
}
}
2016-01-31 16:25:10 -06:00
2015-11-19 23:22:52 -06:00
fn condition_has_block() -> i32 {
2017-02-08 07:58:07 -06:00
if {
2015-11-19 23:22:52 -06:00
let x = 3;
x == 3
} {
6
} else {
10
}
}
fn condition_has_block_with_single_expression() -> i32 {
2017-02-08 07:58:07 -06:00
if { true } {
2015-11-19 23:22:52 -06:00
6
} else {
10
}
}
fn predicate<F: FnOnce(T) -> bool, T>(pfn: F, val:T) -> bool {
pfn(val)
}
fn pred_test() {
let v = 3;
let sky = "blue";
// this is a sneaky case, where the block isn't directly in the condition, but is actually
// inside a closure that the condition is using. same principle applies. add some extra
// expressions to make sure linter isn't confused by them.
2016-12-21 05:30:41 -06:00
if v == 3 && sky == "blue" && predicate(|x| { let target = 3; x == target }, v) {
2015-11-19 23:22:52 -06:00
}
2016-12-21 05:30:41 -06:00
if predicate(|x| { let target = 3; x == target }, v) {
2015-11-19 23:22:52 -06:00
}
}
fn condition_is_normal() -> i32 {
let x = 3;
2017-02-08 07:58:07 -06:00
if true && x == 3 {
2015-11-19 23:22:52 -06:00
6
} else {
10
}
}
fn closure_without_block() {
if predicate(|x| x == 3, 6) {
}
}
fn condition_is_unsafe_block() {
let a: i32 = 1;
// this should not warn because the condition is an unsafe block
if unsafe { 1u32 == std::mem::transmute(a) } {
println!("1u32 == a");
}
}
2015-11-19 23:22:52 -06:00
fn main() {
}