2016-07-13 17:53:42 -04:00
|
|
|
error[E0499]: cannot borrow `v` as mutable more than once at a time
|
2018-12-25 08:56:47 -07:00
|
|
|
--> $DIR/one_line.rs:3:12
|
2016-07-13 17:53:42 -04:00
|
|
|
|
|
2019-03-09 15:03:44 +03:00
|
|
|
LL | v.push(v.pop().unwrap());
|
Use larger span for adjustments on method calls
Currently, we use a relatively 'small' span for THIR
expressions generated by an 'adjustment' (e.g. an autoderef,
autoborrow, unsizing). As a result, if a borrow generated
by an adustment ends up causing a borrowcheck error, for example:
```rust
let mut my_var = String::new();
let my_ref = &my_var
my_var.push('a');
my_ref;
```
then the span for the mutable borrow may end up referring
to only the base expression (e.g. `my_var`), rather than
the method call which triggered the mutable borrow
(e.g. `my_var.push('a')`)
Due to a quirk of the MIR borrowck implementation,
this doesn't always get exposed in migration mode,
but it does in many cases.
This commit makes THIR building consistently use 'larger'
spans for adjustment expressions
The intent of this change it make it clearer to users
when it's the specific way in which a variable is
used (for example, in a method call) that produdes
a borrowcheck error. For example, an error message
claiming that a 'mutable borrow occurs here' might
be confusing if it just points at a usage of a variable
(e.g. `my_var`), when no `&mut` is in sight. Pointing
at the entire expression should help to emphasize
that the method call itself is responsible for
the mutable borrow.
In several cases, this makes the `#![feature(nll)]` diagnostic
output match up exactly with the default (migration mode) output.
As a result, several `.nll.stderr` files end up getting removed
entirely.
2021-09-16 15:01:22 -05:00
|
|
|
| -------^^^^^^^----------
|
|
|
|
|
| | | |
|
|
|
|
|
| | | second mutable borrow occurs here
|
2019-04-22 08:40:08 +01:00
|
|
|
| | first borrow later used by call
|
2016-07-13 17:53:42 -04:00
|
|
|
| first mutable borrow occurs here
|
2021-03-15 15:09:06 -07:00
|
|
|
|
|
|
|
|
|
help: try adding a local storing this argument...
|
|
|
|
|
--> $DIR/one_line.rs:3:12
|
|
|
|
|
|
|
|
|
|
|
LL | v.push(v.pop().unwrap());
|
|
|
|
|
| ^^^^^^^
|
|
|
|
|
help: ...and then using that local as the argument to this call
|
|
|
|
|
--> $DIR/one_line.rs:3:5
|
|
|
|
|
|
|
|
|
|
|
LL | v.push(v.pop().unwrap());
|
|
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
2016-07-13 17:53:42 -04:00
|
|
|
|
2017-07-02 13:49:30 +03:00
|
|
|
error: aborting due to previous error
|
2016-07-13 17:53:42 -04:00
|
|
|
|
2018-03-03 15:59:40 +01:00
|
|
|
For more information about this error, try `rustc --explain E0499`.
|
