2018-01-30 17:09:16 -06:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:7:5
|
2018-10-06 11:18:06 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if a.is_none() {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | }
|
2020-03-04 01:59:16 -06:00
|
|
|
| |_____^ help: replace it with: `a?;`
|
2018-10-06 11:18:06 -05:00
|
|
|
|
|
|
|
|
= note: `-D clippy::question-mark` implied by `-D warnings`
|
2023-08-01 07:02:21 -05:00
|
|
|
= help: to override `-D warnings` add `#[allow(clippy::question_mark)]`
|
2018-01-30 17:09:16 -06:00
|
|
|
|
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:52:9
|
2018-01-30 17:09:16 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if (self.opt).is_none() {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | }
|
2020-03-04 01:59:16 -06:00
|
|
|
| |_________^ help: replace it with: `(self.opt)?;`
|
2018-01-30 17:09:16 -06:00
|
|
|
|
2018-12-12 02:46:52 -06:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:56:9
|
2018-12-12 02:46:52 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if self.opt.is_none() {
|
|
|
|
LL | | return None
|
|
|
|
LL | | }
|
2020-03-04 01:59:16 -06:00
|
|
|
| |_________^ help: replace it with: `self.opt?;`
|
2018-12-12 02:46:52 -06:00
|
|
|
|
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:60:17
|
2018-12-12 02:46:52 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | let _ = if self.opt.is_none() {
|
2018-12-12 02:46:52 -06:00
|
|
|
| _________________^
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | return None;
|
|
|
|
LL | | } else {
|
|
|
|
LL | | self.opt
|
|
|
|
LL | | };
|
2020-03-04 01:59:16 -06:00
|
|
|
| |_________^ help: replace it with: `Some(self.opt?)`
|
|
|
|
|
2022-07-18 02:39:37 -05:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:66:17
|
2020-03-04 01:59:16 -06:00
|
|
|
|
|
|
|
|
LL | let _ = if let Some(x) = self.opt {
|
|
|
|
| _________________^
|
|
|
|
LL | | x
|
|
|
|
LL | | } else {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | };
|
|
|
|
| |_________^ help: replace it with: `self.opt?`
|
2018-12-12 02:46:52 -06:00
|
|
|
|
2018-12-18 06:55:04 -06:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:83:9
|
2018-12-18 06:55:04 -06:00
|
|
|
|
|
2018-12-28 13:19:51 -06:00
|
|
|
LL | / if self.opt.is_none() {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | }
|
2020-03-04 01:59:16 -06:00
|
|
|
| |_________^ help: replace it with: `self.opt.as_ref()?;`
|
2018-12-18 06:55:04 -06:00
|
|
|
|
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:91:9
|
2018-12-18 06:55:04 -06:00
|
|
|
|
|
2018-12-28 13:19:51 -06:00
|
|
|
LL | / if self.opt.is_none() {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | }
|
2020-03-04 01:59:16 -06:00
|
|
|
| |_________^ help: replace it with: `self.opt.as_ref()?;`
|
2018-12-18 06:55:04 -06:00
|
|
|
|
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:99:9
|
2018-12-18 06:55:04 -06:00
|
|
|
|
|
2018-12-28 13:19:51 -06:00
|
|
|
LL | / if self.opt.is_none() {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | }
|
2020-03-04 01:59:16 -06:00
|
|
|
| |_________^ help: replace it with: `self.opt.as_ref()?;`
|
|
|
|
|
2022-07-18 02:39:37 -05:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:106:26
|
2020-03-04 01:59:16 -06:00
|
|
|
|
|
2020-03-04 02:21:07 -06:00
|
|
|
LL | let v: &Vec<_> = if let Some(ref v) = self.opt {
|
|
|
|
| __________________________^
|
2020-03-04 01:59:16 -06:00
|
|
|
LL | | v
|
|
|
|
LL | | } else {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | };
|
|
|
|
| |_________^ help: replace it with: `self.opt.as_ref()?`
|
|
|
|
|
2022-07-18 02:39:37 -05:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:116:17
|
2020-03-04 01:59:16 -06:00
|
|
|
|
|
2020-03-04 02:21:07 -06:00
|
|
|
LL | let v = if let Some(v) = self.opt {
|
|
|
|
| _________________^
|
2020-03-04 01:59:16 -06:00
|
|
|
LL | | v
|
|
|
|
LL | | } else {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | };
|
|
|
|
| |_________^ help: replace it with: `self.opt?`
|
2018-12-18 06:55:04 -06:00
|
|
|
|
2020-04-16 23:09:02 -05:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:131:5
|
2020-04-16 23:09:02 -05:00
|
|
|
|
|
|
|
|
LL | / if f().is_none() {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | }
|
|
|
|
| |_____^ help: replace it with: `f()?;`
|
|
|
|
|
2022-07-18 02:39:37 -05:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:143:13
|
2021-10-21 06:11:36 -05:00
|
|
|
|
|
|
|
|
LL | let _ = if let Ok(x) = x { x } else { return x };
|
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x?`
|
|
|
|
|
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:145:5
|
2021-10-21 06:11:36 -05:00
|
|
|
|
|
|
|
|
LL | / if x.is_err() {
|
|
|
|
LL | | return x;
|
|
|
|
LL | | }
|
|
|
|
| |_____^ help: replace it with: `x?;`
|
|
|
|
|
2022-07-18 02:39:37 -05:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:213:5
|
2022-07-18 02:39:37 -05:00
|
|
|
|
|
|
|
|
LL | / if let Err(err) = func_returning_result() {
|
|
|
|
LL | | return Err(err);
|
|
|
|
LL | | }
|
|
|
|
| |_____^ help: replace it with: `func_returning_result()?;`
|
|
|
|
|
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:220:5
|
2022-07-18 02:39:37 -05:00
|
|
|
|
|
|
|
|
LL | / if let Err(err) = func_returning_result() {
|
|
|
|
LL | | return Err(err);
|
|
|
|
LL | | }
|
|
|
|
| |_____^ help: replace it with: `func_returning_result()?;`
|
|
|
|
|
2023-07-02 07:35:19 -05:00
|
|
|
error: this block may be rewritten with the `?` operator
|
2024-02-17 06:16:29 -06:00
|
|
|
--> tests/ui/question_mark.rs:297:13
|
2023-07-02 07:35:19 -05:00
|
|
|
|
|
|
|
|
LL | / if a.is_none() {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | // do lint here, the outer `try` is not relevant here
|
|
|
|
LL | | // https://github.com/rust-lang/rust-clippy/pull/11001#issuecomment-1610636867
|
|
|
|
LL | | }
|
|
|
|
| |_____________^ help: replace it with: `a?;`
|
|
|
|
|
2024-03-26 19:36:08 -05:00
|
|
|
error: this `let...else` may be rewritten with the `?` operator
|
|
|
|
--> tests/ui/question_mark.rs:357:5
|
|
|
|
|
|
|
|
|
LL | / let Some(v) = bar.foo.owned.clone() else {
|
|
|
|
LL | | return None;
|
|
|
|
LL | | };
|
|
|
|
| |______^ help: replace it with: `let v = bar.foo.owned.clone()?;`
|
|
|
|
|
|
|
|
error: aborting due to 17 previous errors
|
2018-01-30 17:09:16 -06:00
|
|
|
|