rust/tests/ui/needless_collect.stderr

40 lines
1.4 KiB
Plaintext
Raw Normal View History

2020-07-22 22:46:23 -07:00
error: avoid using `collect()` when not needed
--> $DIR/needless_collect.rs:21:5
|
LL | let indirect_positive = sample.iter().collect::<Vec<_>>();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D clippy::needless-collect` implied by `-D warnings`
help: Use the original Iterator instead of collecting it and then producing a new one
|
LL |
LL | sample.iter()
|
2018-08-31 18:26:04 -04:00
error: avoid using `collect()` when not needed
2020-05-25 23:22:01 +07:00
--> $DIR/needless_collect.rs:11:29
2018-10-06 09:18:06 -07:00
|
2018-12-27 16:57:55 +01:00
LL | let len = sample.iter().collect::<Vec<_>>().len();
2020-05-25 23:22:01 +07:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `count()`
2018-08-31 18:26:04 -04:00
error: avoid using `collect()` when not needed
2020-05-25 23:22:01 +07:00
--> $DIR/needless_collect.rs:12:15
2018-09-03 23:50:24 -04:00
|
2018-12-27 16:57:55 +01:00
LL | if sample.iter().collect::<Vec<_>>().is_empty() {
2020-05-25 23:22:01 +07:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `get(0).is_none()`
2018-08-31 18:26:04 -04:00
error: avoid using `collect()` when not needed
2020-05-25 23:22:01 +07:00
--> $DIR/needless_collect.rs:15:28
2018-08-31 18:14:33 -04:00
|
2018-12-27 16:57:55 +01:00
LL | sample.iter().cloned().collect::<Vec<_>>().contains(&1);
2020-05-25 23:22:01 +07:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `any(|x| x == 1)`
2018-08-31 18:14:33 -04:00
2018-08-31 18:26:04 -04:00
error: avoid using `collect()` when not needed
2020-05-25 23:22:01 +07:00
--> $DIR/needless_collect.rs:16:35
2018-08-31 18:14:33 -04:00
|
2018-12-27 16:57:55 +01:00
LL | sample.iter().map(|x| (x, x)).collect::<HashMap<_, _>>().len();
2020-05-25 23:22:01 +07:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `count()`
2020-07-22 22:46:23 -07:00
error: aborting due to 5 previous errors