2018-10-06 11:18:06 -05:00
|
|
|
|
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
|
// file at the top-level directory of this distribution.
|
|
|
|
|
//
|
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
|
// except according to those terms.
|
|
|
|
|
|
2016-05-24 11:25:25 -05:00
|
|
|
|
// error-pattern:cargo-clippy
|
|
|
|
|
|
2016-06-06 10:09:51 -05:00
|
|
|
|
#![feature(box_syntax)]
|
|
|
|
|
#![feature(rustc_private)]
|
|
|
|
|
#![feature(slice_patterns)]
|
2016-05-24 11:25:25 -05:00
|
|
|
|
#![feature(stmt_expr_attributes)]
|
2018-03-16 05:09:05 -05:00
|
|
|
|
#![feature(range_contains)]
|
2018-11-23 01:18:23 -06:00
|
|
|
|
#![feature(str_escape)]
|
2018-11-17 06:47:27 -06:00
|
|
|
|
#![allow(clippy::missing_docs_in_private_items)]
|
2017-11-04 14:55:56 -05:00
|
|
|
|
#![recursion_limit = "256"]
|
2018-09-06 08:57:32 -05:00
|
|
|
|
#![warn(rust_2018_idioms, trivial_casts, trivial_numeric_casts)]
|
2018-09-07 18:32:40 -05:00
|
|
|
|
#![feature(crate_visibility_modifier)]
|
2018-10-08 23:40:21 -05:00
|
|
|
|
#![feature(try_from)]
|
2018-03-25 21:04:05 -05:00
|
|
|
|
|
2018-09-15 02:21:58 -05:00
|
|
|
|
// FIXME: switch to something more ergonomic here, once available.
|
|
|
|
|
// (currently there is no way to opt into sysroot crates w/o `extern crate`)
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate fmt_macros;
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate rustc;
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate rustc_data_structures;
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate rustc_errors;
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate rustc_plugin;
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate rustc_target;
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate rustc_typeck;
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate syntax;
|
|
|
|
|
#[allow(unused_extern_crates)]
|
|
|
|
|
extern crate syntax_pos;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
|
2018-09-15 02:21:58 -05:00
|
|
|
|
use toml;
|
2016-06-05 13:19:00 -05:00
|
|
|
|
|
2018-10-12 05:32:48 -05:00
|
|
|
|
// Currently, categories "style", "correctness", "complexity" and "perf" are enabled by default,
|
|
|
|
|
// as said in the README.md of this repository. If this changes, please update README.md.
|
2018-10-12 01:09:04 -05:00
|
|
|
|
#[macro_export]
|
2018-03-27 10:13:55 -05:00
|
|
|
|
macro_rules! declare_clippy_lint {
|
|
|
|
|
{ pub $name:tt, style, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Warn, $description, report_in_external_macro: true }
|
2018-03-27 10:13:55 -05:00
|
|
|
|
};
|
|
|
|
|
{ pub $name:tt, correctness, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Deny, $description, report_in_external_macro: true }
|
2018-03-27 10:13:55 -05:00
|
|
|
|
};
|
|
|
|
|
{ pub $name:tt, complexity, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Warn, $description, report_in_external_macro: true }
|
2018-03-27 10:13:55 -05:00
|
|
|
|
};
|
|
|
|
|
{ pub $name:tt, perf, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Warn, $description, report_in_external_macro: true }
|
2018-03-27 10:13:55 -05:00
|
|
|
|
};
|
2018-03-28 08:24:26 -05:00
|
|
|
|
{ pub $name:tt, pedantic, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Allow, $description, report_in_external_macro: true }
|
2018-03-28 08:24:26 -05:00
|
|
|
|
};
|
|
|
|
|
{ pub $name:tt, restriction, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Allow, $description, report_in_external_macro: true }
|
2018-03-28 08:24:26 -05:00
|
|
|
|
};
|
2018-04-29 18:20:39 -05:00
|
|
|
|
{ pub $name:tt, cargo, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Allow, $description, report_in_external_macro: true }
|
2018-04-29 18:20:39 -05:00
|
|
|
|
};
|
2018-03-28 08:24:26 -05:00
|
|
|
|
{ pub $name:tt, nursery, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Allow, $description, report_in_external_macro: true }
|
2018-03-28 08:24:26 -05:00
|
|
|
|
};
|
|
|
|
|
{ pub $name:tt, internal, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Allow, $description, report_in_external_macro: true }
|
2018-03-28 08:24:26 -05:00
|
|
|
|
};
|
2018-03-29 06:41:53 -05:00
|
|
|
|
{ pub $name:tt, internal_warn, $description:tt } => {
|
2018-07-29 04:04:40 -05:00
|
|
|
|
declare_tool_lint! { pub clippy::$name, Warn, $description, report_in_external_macro: true }
|
2018-03-29 06:41:53 -05:00
|
|
|
|
};
|
2018-03-27 10:13:55 -05:00
|
|
|
|
}
|
|
|
|
|
|
2018-08-28 21:32:20 -05:00
|
|
|
|
mod consts;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
#[macro_use]
|
2018-08-28 21:32:20 -05:00
|
|
|
|
mod utils;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
|
|
|
|
|
// begin lints modules, do not remove this comment, it’s used in `update_lints`
|
|
|
|
|
pub mod approx_const;
|
|
|
|
|
pub mod arithmetic;
|
|
|
|
|
pub mod assign_ops;
|
|
|
|
|
pub mod attrs;
|
|
|
|
|
pub mod bit_mask;
|
|
|
|
|
pub mod blacklisted_name;
|
|
|
|
|
pub mod block_in_if_condition;
|
|
|
|
|
pub mod booleans;
|
2017-08-22 16:45:08 -05:00
|
|
|
|
pub mod bytecount;
|
2018-11-13 07:43:30 -06:00
|
|
|
|
pub mod cargo_common_metadata;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod collapsible_if;
|
2017-10-20 08:51:35 -05:00
|
|
|
|
pub mod const_static_lifetime;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod copies;
|
2018-07-17 12:22:55 -05:00
|
|
|
|
pub mod copy_iterator;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod cyclomatic_complexity;
|
2018-06-14 02:57:27 -05:00
|
|
|
|
pub mod default_trait_access;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod derive;
|
|
|
|
|
pub mod doc;
|
2018-01-29 19:35:35 -06:00
|
|
|
|
pub mod double_comparison;
|
2016-12-28 12:54:23 -06:00
|
|
|
|
pub mod double_parens;
|
2016-12-29 21:43:22 -06:00
|
|
|
|
pub mod drop_forget_ref;
|
2018-03-18 15:27:15 -05:00
|
|
|
|
pub mod duration_subsec;
|
2017-12-16 14:37:44 -06:00
|
|
|
|
pub mod else_if_without_else;
|
2017-02-04 22:07:54 -06:00
|
|
|
|
pub mod empty_enum;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod entry;
|
|
|
|
|
pub mod enum_clike;
|
|
|
|
|
pub mod enum_glob_use;
|
|
|
|
|
pub mod enum_variants;
|
|
|
|
|
pub mod eq_op;
|
2017-10-29 04:30:33 -05:00
|
|
|
|
pub mod erasing_op;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod escape;
|
|
|
|
|
pub mod eta_reduction;
|
2016-08-10 22:16:28 -05:00
|
|
|
|
pub mod eval_order_dependence;
|
2018-04-12 19:42:57 -05:00
|
|
|
|
pub mod excessive_precision;
|
2017-10-20 02:24:37 -05:00
|
|
|
|
pub mod explicit_write;
|
2017-10-29 04:30:33 -05:00
|
|
|
|
pub mod fallible_impl_from;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod format;
|
|
|
|
|
pub mod formatting;
|
|
|
|
|
pub mod functions;
|
2017-02-04 22:41:09 -06:00
|
|
|
|
pub mod identity_conversion;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod identity_op;
|
|
|
|
|
pub mod if_not_else;
|
2018-12-05 07:39:09 -06:00
|
|
|
|
pub mod implicit_return;
|
2018-05-23 00:02:07 -05:00
|
|
|
|
pub mod indexing_slicing;
|
2018-04-19 14:34:31 -05:00
|
|
|
|
pub mod infallible_destructuring_match;
|
2017-08-25 15:20:52 -05:00
|
|
|
|
pub mod infinite_iter;
|
2018-05-28 19:17:55 -05:00
|
|
|
|
pub mod inherent_impl;
|
2018-01-17 03:41:24 -06:00
|
|
|
|
pub mod inline_fn_without_body;
|
2017-09-17 11:27:16 -05:00
|
|
|
|
pub mod int_plus_one;
|
2017-09-28 21:24:31 -05:00
|
|
|
|
pub mod invalid_ref;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod items_after_statements;
|
2017-01-30 06:17:56 -06:00
|
|
|
|
pub mod large_enum_variant;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod len_zero;
|
2016-03-30 12:53:43 -05:00
|
|
|
|
pub mod let_if_seq;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod lifetimes;
|
2018-01-16 07:01:07 -06:00
|
|
|
|
pub mod literal_representation;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod loops;
|
2018-10-02 08:13:43 -05:00
|
|
|
|
pub mod map_clone;
|
2018-04-15 05:30:38 -05:00
|
|
|
|
pub mod map_unit_fn;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod matches;
|
2018-10-20 22:46:13 -05:00
|
|
|
|
pub mod mem_discriminant;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod mem_forget;
|
2018-09-16 18:25:33 -05:00
|
|
|
|
pub mod mem_replace;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod methods;
|
|
|
|
|
pub mod minmax;
|
|
|
|
|
pub mod misc;
|
|
|
|
|
pub mod misc_early;
|
2016-08-23 11:09:37 -05:00
|
|
|
|
pub mod missing_doc;
|
2018-07-04 03:51:04 -05:00
|
|
|
|
pub mod missing_inline;
|
2018-04-29 18:20:39 -05:00
|
|
|
|
pub mod multiple_crate_versions;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod mut_mut;
|
|
|
|
|
pub mod mut_reference;
|
|
|
|
|
pub mod mutex_atomic;
|
|
|
|
|
pub mod needless_bool;
|
|
|
|
|
pub mod needless_borrow;
|
2017-06-24 05:04:56 -05:00
|
|
|
|
pub mod needless_borrowed_ref;
|
2016-08-21 16:18:58 -05:00
|
|
|
|
pub mod needless_continue;
|
2017-04-27 07:11:35 -05:00
|
|
|
|
pub mod needless_pass_by_value;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod needless_update;
|
2018-06-01 04:58:40 -05:00
|
|
|
|
pub mod neg_cmp_op_on_partial_ord;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod neg_multiply;
|
|
|
|
|
pub mod new_without_default;
|
|
|
|
|
pub mod no_effect;
|
2018-06-06 10:20:22 -05:00
|
|
|
|
pub mod non_copy_const;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod non_expressive_names;
|
2016-10-02 15:39:28 -05:00
|
|
|
|
pub mod ok_if_let;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod open_options;
|
|
|
|
|
pub mod overflow_check_conditional;
|
2018-05-24 01:59:54 -05:00
|
|
|
|
pub mod panic_unimplemented;
|
2016-10-29 20:33:57 -05:00
|
|
|
|
pub mod partialeq_ne_impl;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod precedence;
|
2016-08-22 11:29:29 -05:00
|
|
|
|
pub mod ptr;
|
2018-08-27 08:49:54 -05:00
|
|
|
|
pub mod ptr_offset_with_cast;
|
2018-02-02 01:53:32 -06:00
|
|
|
|
pub mod question_mark;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod ranges;
|
2018-10-23 02:01:45 -05:00
|
|
|
|
pub mod redundant_clone;
|
2018-02-10 14:13:17 -06:00
|
|
|
|
pub mod redundant_field_names;
|
2018-10-10 10:13:53 -05:00
|
|
|
|
pub mod redundant_pattern_matching;
|
2018-02-26 14:32:18 -06:00
|
|
|
|
pub mod reference;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod regex;
|
2018-01-09 22:42:07 -06:00
|
|
|
|
pub mod replace_consts;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod returns;
|
2017-05-09 08:23:10 -05:00
|
|
|
|
pub mod serde_api;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod shadow;
|
2018-10-18 18:15:48 -05:00
|
|
|
|
pub mod slow_vector_initialization;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod strings;
|
2018-02-13 08:40:17 -06:00
|
|
|
|
pub mod suspicious_trait_impl;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod swap;
|
|
|
|
|
pub mod temporary_assignment;
|
|
|
|
|
pub mod transmute;
|
2018-05-27 07:32:03 -05:00
|
|
|
|
pub mod trivially_copy_pass_by_ref;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod types;
|
|
|
|
|
pub mod unicode;
|
|
|
|
|
pub mod unsafe_removed_from_name;
|
2017-01-07 05:35:45 -06:00
|
|
|
|
pub mod unused_io_amount;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod unused_label;
|
2018-05-27 17:02:38 -05:00
|
|
|
|
pub mod unwrap;
|
2017-07-28 06:28:07 -05:00
|
|
|
|
pub mod use_self;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod vec;
|
2018-10-22 08:39:51 -05:00
|
|
|
|
pub mod wildcard_dependencies;
|
2018-04-04 22:46:39 -05:00
|
|
|
|
pub mod write;
|
2016-05-24 11:25:25 -05:00
|
|
|
|
pub mod zero_div_zero;
|
|
|
|
|
// end lints modules, do not remove this comment, it’s used in `update_lints`
|
|
|
|
|
|
2018-09-02 20:57:50 -05:00
|
|
|
|
pub use crate::utils::conf::Conf;
|
2018-08-15 01:11:07 -05:00
|
|
|
|
|
2016-05-24 11:25:25 -05:00
|
|
|
|
mod reexport {
|
2018-09-15 02:21:58 -05:00
|
|
|
|
crate use crate::syntax::ast::{Name, NodeId};
|
2016-05-24 11:25:25 -05:00
|
|
|
|
}
|
|
|
|
|
|
2018-11-27 14:14:15 -06:00
|
|
|
|
pub fn register_pre_expansion_lints(
|
|
|
|
|
session: &rustc::session::Session,
|
|
|
|
|
store: &mut rustc::lint::LintStore,
|
|
|
|
|
conf: &Conf,
|
|
|
|
|
) {
|
2018-08-16 00:13:52 -05:00
|
|
|
|
store.register_pre_expansion_pass(Some(session), box write::Pass);
|
|
|
|
|
store.register_pre_expansion_pass(Some(session), box redundant_field_names::RedundantFieldNames);
|
2018-11-27 14:14:15 -06:00
|
|
|
|
store.register_pre_expansion_pass(
|
|
|
|
|
Some(session),
|
|
|
|
|
box non_expressive_names::NonExpressiveNames {
|
|
|
|
|
single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
|
|
|
|
|
},
|
|
|
|
|
);
|
2018-09-03 08:34:12 -05:00
|
|
|
|
store.register_pre_expansion_pass(Some(session), box attrs::CfgAttrPass);
|
2018-08-16 00:13:52 -05:00
|
|
|
|
}
|
|
|
|
|
|
2018-08-15 01:11:07 -05:00
|
|
|
|
pub fn read_conf(reg: &rustc_plugin::Registry<'_>) -> Conf {
|
|
|
|
|
match utils::conf::file_from_args(reg.args()) {
|
2016-05-24 11:25:25 -05:00
|
|
|
|
Ok(file_name) => {
|
|
|
|
|
// if the user specified a file, it must exist, otherwise default to `clippy.toml` but
|
|
|
|
|
// do not require the file to exist
|
2016-10-25 12:41:24 -05:00
|
|
|
|
let file_name = if let Some(file_name) = file_name {
|
|
|
|
|
Some(file_name)
|
2016-05-24 11:25:25 -05:00
|
|
|
|
} else {
|
2016-10-25 12:41:24 -05:00
|
|
|
|
match utils::conf::lookup_conf_file() {
|
|
|
|
|
Ok(path) => path,
|
|
|
|
|
Err(error) => {
|
2018-11-27 14:14:15 -06:00
|
|
|
|
reg.sess
|
|
|
|
|
.struct_err(&format!("error finding Clippy's configuration file: {}", error))
|
|
|
|
|
.emit();
|
2016-10-25 12:41:24 -05:00
|
|
|
|
None
|
2018-11-27 14:14:15 -06:00
|
|
|
|
},
|
2016-10-25 12:41:24 -05:00
|
|
|
|
}
|
2016-05-24 11:25:25 -05:00
|
|
|
|
};
|
|
|
|
|
|
2018-11-27 14:14:15 -06:00
|
|
|
|
let file_name = file_name.map(|file_name| {
|
|
|
|
|
if file_name.is_relative() {
|
|
|
|
|
reg.sess
|
|
|
|
|
.local_crate_source_file
|
|
|
|
|
.as_ref()
|
|
|
|
|
.and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
|
|
|
|
|
.unwrap_or_default()
|
|
|
|
|
.join(file_name)
|
|
|
|
|
} else {
|
|
|
|
|
file_name
|
|
|
|
|
}
|
2017-11-14 07:56:00 -06:00
|
|
|
|
});
|
|
|
|
|
|
2016-10-25 12:41:24 -05:00
|
|
|
|
let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
|
2016-05-24 11:25:25 -05:00
|
|
|
|
|
|
|
|
|
// all conf errors are non-fatal, we just use the default conf in case of error
|
|
|
|
|
for error in errors {
|
2018-11-27 14:14:15 -06:00
|
|
|
|
reg.sess
|
|
|
|
|
.struct_err(&format!(
|
|
|
|
|
"error reading Clippy's configuration file `{}`: {}",
|
|
|
|
|
file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""),
|
|
|
|
|
error
|
|
|
|
|
))
|
|
|
|
|
.emit();
|
2016-05-24 11:25:25 -05:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
conf
|
2018-11-27 14:14:15 -06:00
|
|
|
|
},
|
2016-05-24 11:25:25 -05:00
|
|
|
|
Err((err, span)) => {
|
2018-11-27 14:14:15 -06:00
|
|
|
|
reg.sess
|
|
|
|
|
.struct_span_err(span, err)
|
|
|
|
|
.span_note(span, "Clippy will use default configuration")
|
|
|
|
|
.emit();
|
2017-05-09 08:23:38 -05:00
|
|
|
|
toml::from_str("").expect("we never error on empty config files")
|
2018-11-27 14:14:15 -06:00
|
|
|
|
},
|
2018-08-15 01:11:07 -05:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-05-24 11:25:25 -05:00
|
|
|
|
|
2018-08-15 01:11:07 -05:00
|
|
|
|
#[rustfmt::skip]
|
|
|
|
|
pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) {
|
2016-05-24 11:25:25 -05:00
|
|
|
|
let mut store = reg.sess.lint_store.borrow_mut();
|
2018-10-31 02:03:50 -05:00
|
|
|
|
// begin deprecated lints, do not remove this comment, it’s used in `update_lints`
|
2017-10-19 23:42:04 -05:00
|
|
|
|
store.register_removed(
|
|
|
|
|
"should_assert_eq",
|
2017-10-29 04:30:33 -05:00
|
|
|
|
"`assert!()` will be more flexible with RFC 2011",
|
2017-10-19 23:42:04 -05:00
|
|
|
|
);
|
2017-01-14 07:39:41 -06:00
|
|
|
|
store.register_removed(
|
|
|
|
|
"extend_from_slice",
|
|
|
|
|
"`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
|
|
|
|
|
);
|
2017-06-18 08:14:46 -05:00
|
|
|
|
store.register_removed(
|
|
|
|
|
"range_step_by_zero",
|
|
|
|
|
"`iterator.step_by(0)` panics nowadays",
|
|
|
|
|
);
|
2016-12-21 05:50:39 -06:00
|
|
|
|
store.register_removed(
|
|
|
|
|
"unstable_as_slice",
|
|
|
|
|
"`Vec::as_slice` has been stabilized in 1.7",
|
|
|
|
|
);
|
|
|
|
|
store.register_removed(
|
|
|
|
|
"unstable_as_mut_slice",
|
|
|
|
|
"`Vec::as_mut_slice` has been stabilized in 1.7",
|
|
|
|
|
);
|
|
|
|
|
store.register_removed(
|
|
|
|
|
"str_to_string",
|
|
|
|
|
"using `str::to_string` is common even today and specialization will likely happen soon",
|
|
|
|
|
);
|
|
|
|
|
store.register_removed(
|
|
|
|
|
"string_to_string",
|
|
|
|
|
"using `string::to_string` is common even today and specialization will likely happen soon",
|
|
|
|
|
);
|
2018-04-11 04:50:04 -05:00
|
|
|
|
store.register_removed(
|
|
|
|
|
"misaligned_transmute",
|
|
|
|
|
"this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
|
|
|
|
|
);
|
2018-08-09 14:14:12 -05:00
|
|
|
|
store.register_removed(
|
|
|
|
|
"assign_ops",
|
|
|
|
|
"using compound assignment operators (e.g. `+=`) is harmless",
|
|
|
|
|
);
|
2018-10-10 10:13:53 -05:00
|
|
|
|
store.register_removed(
|
|
|
|
|
"if_let_redundant_pattern_matching",
|
|
|
|
|
"this lint has been changed to redundant_pattern_matching",
|
|
|
|
|
);
|
2018-12-03 04:43:01 -06:00
|
|
|
|
store.register_removed(
|
|
|
|
|
"unsafe_vector_initialization",
|
|
|
|
|
"the replacement suggested by this lint had substantially different behavior",
|
|
|
|
|
);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
// end deprecated lints, do not remove this comment, it’s used in `update_lints`
|
|
|
|
|
|
2017-05-09 08:23:10 -05:00
|
|
|
|
reg.register_late_lint_pass(box serde_api::Serde);
|
2016-07-18 04:19:33 -05:00
|
|
|
|
reg.register_early_lint_pass(box utils::internal_lints::Clippy);
|
2018-09-14 05:38:09 -05:00
|
|
|
|
reg.register_late_lint_pass(box utils::internal_lints::CompilerLintFunctions::new());
|
2018-08-14 03:25:09 -05:00
|
|
|
|
reg.register_early_lint_pass(box utils::internal_lints::DefaultHashTypes::default());
|
2018-09-14 05:38:09 -05:00
|
|
|
|
reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
|
2016-10-18 09:57:39 -05:00
|
|
|
|
reg.register_late_lint_pass(box utils::inspector::Pass);
|
2017-07-03 08:24:52 -05:00
|
|
|
|
reg.register_late_lint_pass(box utils::author::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box types::TypePass);
|
|
|
|
|
reg.register_late_lint_pass(box booleans::NonminimalBool);
|
|
|
|
|
reg.register_late_lint_pass(box eq_op::EqOp);
|
2016-08-06 13:59:27 -05:00
|
|
|
|
reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box enum_clike::UnportableVariant);
|
2018-04-12 19:42:57 -05:00
|
|
|
|
reg.register_late_lint_pass(box excessive_precision::ExcessivePrecision);
|
2017-09-25 15:38:49 -05:00
|
|
|
|
reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
|
2016-08-22 11:29:29 -05:00
|
|
|
|
reg.register_late_lint_pass(box ptr::PointerPass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box needless_bool::NeedlessBool);
|
|
|
|
|
reg.register_late_lint_pass(box needless_bool::BoolComparison);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box approx_const::Pass);
|
2016-08-24 14:47:46 -05:00
|
|
|
|
reg.register_late_lint_pass(box misc::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_early_lint_pass(box precedence::Precedence);
|
2016-08-21 16:18:58 -05:00
|
|
|
|
reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box eta_reduction::EtaPass);
|
|
|
|
|
reg.register_late_lint_pass(box identity_op::IdentityOp);
|
2017-09-30 12:14:00 -05:00
|
|
|
|
reg.register_late_lint_pass(box erasing_op::ErasingOp);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
|
|
|
|
|
reg.register_late_lint_pass(box mut_mut::MutMut);
|
|
|
|
|
reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
|
|
|
|
|
reg.register_late_lint_pass(box len_zero::LenZero);
|
|
|
|
|
reg.register_late_lint_pass(box attrs::AttrPass);
|
2016-06-21 16:17:18 -05:00
|
|
|
|
reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
|
|
|
|
|
reg.register_late_lint_pass(box unicode::Unicode);
|
|
|
|
|
reg.register_late_lint_pass(box strings::StringAdd);
|
|
|
|
|
reg.register_early_lint_pass(box returns::ReturnPass);
|
2018-12-05 07:39:09 -06:00
|
|
|
|
reg.register_late_lint_pass(box implicit_return::Pass);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box methods::Pass);
|
2018-10-02 08:13:43 -05:00
|
|
|
|
reg.register_late_lint_pass(box map_clone::Pass);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box shadow::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box types::LetPass);
|
|
|
|
|
reg.register_late_lint_pass(box types::UnitCmp);
|
2017-07-31 17:58:26 -05:00
|
|
|
|
reg.register_late_lint_pass(box loops::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box lifetimes::LifetimePass);
|
|
|
|
|
reg.register_late_lint_pass(box entry::HashMapLint);
|
2017-10-07 09:56:45 -05:00
|
|
|
|
reg.register_late_lint_pass(box ranges::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box types::CastPass);
|
|
|
|
|
reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
|
|
|
|
|
reg.register_late_lint_pass(box matches::MatchPass);
|
|
|
|
|
reg.register_late_lint_pass(box minmax::MinMaxPass);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box open_options::NonSensical);
|
|
|
|
|
reg.register_late_lint_pass(box zero_div_zero::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box needless_update::Pass);
|
2018-11-02 01:56:47 -05:00
|
|
|
|
reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow::default());
|
2017-06-29 06:45:35 -05:00
|
|
|
|
reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box no_effect::Pass);
|
|
|
|
|
reg.register_late_lint_pass(box temporary_assignment::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box transmute::Transmute);
|
2016-12-21 05:30:41 -06:00
|
|
|
|
reg.register_late_lint_pass(
|
|
|
|
|
box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
|
|
|
|
|
);
|
2016-07-10 08:23:50 -05:00
|
|
|
|
reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_early_lint_pass(box misc_early::MiscEarly);
|
2018-05-23 00:02:07 -05:00
|
|
|
|
reg.register_late_lint_pass(box panic_unimplemented::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box strings::StringLitAsBytes);
|
|
|
|
|
reg.register_late_lint_pass(box derive::Derive);
|
|
|
|
|
reg.register_late_lint_pass(box types::CharLitAsU8);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box vec::Pass);
|
2016-12-29 21:43:22 -06:00
|
|
|
|
reg.register_late_lint_pass(box drop_forget_ref::Pass);
|
2017-02-04 22:07:54 -06:00
|
|
|
|
reg.register_late_lint_pass(box empty_enum::EmptyEnum);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
|
|
|
|
|
reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box regex::Pass::default());
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box copies::CopyAndPaste);
|
2018-07-17 12:22:55 -05:00
|
|
|
|
reg.register_late_lint_pass(box copy_iterator::CopyIterator);
|
2016-06-10 09:17:20 -05:00
|
|
|
|
reg.register_late_lint_pass(box format::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_early_lint_pass(box formatting::Formatting);
|
|
|
|
|
reg.register_late_lint_pass(box swap::Swap);
|
|
|
|
|
reg.register_early_lint_pass(box if_not_else::IfNotElse);
|
2017-12-16 14:37:44 -06:00
|
|
|
|
reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
|
2017-09-17 11:27:16 -05:00
|
|
|
|
reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
|
|
|
|
|
reg.register_late_lint_pass(box unused_label::UnusedLabel);
|
2018-10-21 23:59:45 -05:00
|
|
|
|
reg.register_late_lint_pass(box new_without_default::NewWithoutDefault::default());
|
2018-08-15 01:11:07 -05:00
|
|
|
|
reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names.clone()));
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
|
2018-08-15 01:11:07 -05:00
|
|
|
|
reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents.clone()));
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box neg_multiply::NegMultiply);
|
2016-12-01 15:31:56 -06:00
|
|
|
|
reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
|
2018-10-20 22:46:13 -05:00
|
|
|
|
reg.register_late_lint_pass(box mem_discriminant::MemDiscriminant);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box mem_forget::MemForget);
|
2018-09-16 18:25:33 -05:00
|
|
|
|
reg.register_late_lint_pass(box mem_replace::MemReplace);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
|
|
|
|
|
reg.register_late_lint_pass(box assign_ops::AssignOps);
|
2016-03-30 12:53:43 -05:00
|
|
|
|
reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
|
2016-08-10 22:16:28 -05:00
|
|
|
|
reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
|
2016-08-23 11:09:37 -05:00
|
|
|
|
reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
|
2018-07-04 08:32:55 -05:00
|
|
|
|
reg.register_late_lint_pass(box missing_inline::MissingInline);
|
2016-10-06 10:50:11 -05:00
|
|
|
|
reg.register_late_lint_pass(box ok_if_let::Pass);
|
2018-10-10 10:13:53 -05:00
|
|
|
|
reg.register_late_lint_pass(box redundant_pattern_matching::Pass);
|
2016-10-29 20:33:57 -05:00
|
|
|
|
reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
|
2016-11-25 08:54:07 -06:00
|
|
|
|
reg.register_early_lint_pass(box reference::Pass);
|
2018-05-28 02:29:02 -05:00
|
|
|
|
reg.register_early_lint_pass(box reference::DerefPass);
|
2016-12-28 12:54:23 -06:00
|
|
|
|
reg.register_early_lint_pass(box double_parens::DoubleParens);
|
2017-01-07 05:35:45 -06:00
|
|
|
|
reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
|
2017-01-30 06:17:56 -06:00
|
|
|
|
reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
|
2017-10-14 19:42:14 -05:00
|
|
|
|
reg.register_late_lint_pass(box explicit_write::Pass);
|
2017-02-19 21:50:31 -06:00
|
|
|
|
reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
|
2018-05-27 09:04:45 -05:00
|
|
|
|
reg.register_late_lint_pass(box trivially_copy_pass_by_ref::TriviallyCopyPassByRef::new(
|
|
|
|
|
conf.trivial_copy_size_limit,
|
2018-08-26 04:18:44 -05:00
|
|
|
|
®.sess.target,
|
2018-05-27 09:04:45 -05:00
|
|
|
|
));
|
2018-01-16 07:01:07 -06:00
|
|
|
|
reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
|
2018-01-23 05:34:40 -06:00
|
|
|
|
reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
|
|
|
|
|
conf.literal_representation_threshold
|
|
|
|
|
));
|
2017-07-28 06:28:07 -05:00
|
|
|
|
reg.register_late_lint_pass(box use_self::UseSelf);
|
2017-08-22 16:45:08 -05:00
|
|
|
|
reg.register_late_lint_pass(box bytecount::ByteCount);
|
2017-08-25 15:20:52 -05:00
|
|
|
|
reg.register_late_lint_pass(box infinite_iter::Pass);
|
2018-01-17 03:41:24 -06:00
|
|
|
|
reg.register_late_lint_pass(box inline_fn_without_body::Pass);
|
2017-09-28 21:24:31 -05:00
|
|
|
|
reg.register_late_lint_pass(box invalid_ref::InvalidRef);
|
2017-02-04 22:41:09 -06:00
|
|
|
|
reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
|
2017-10-05 09:57:31 -05:00
|
|
|
|
reg.register_late_lint_pass(box types::ImplicitHasher);
|
2017-10-20 08:51:35 -05:00
|
|
|
|
reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
|
2017-10-17 11:09:10 -05:00
|
|
|
|
reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
|
2018-01-09 22:42:07 -06:00
|
|
|
|
reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
|
2018-01-18 16:02:18 -06:00
|
|
|
|
reg.register_late_lint_pass(box types::UnitArg);
|
2018-10-12 19:07:48 -05:00
|
|
|
|
reg.register_late_lint_pass(box double_comparison::Pass);
|
|
|
|
|
reg.register_late_lint_pass(box question_mark::Pass);
|
2018-02-13 08:40:17 -06:00
|
|
|
|
reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
|
2018-11-13 07:43:30 -06:00
|
|
|
|
reg.register_early_lint_pass(box cargo_common_metadata::Pass);
|
2018-04-29 18:20:39 -05:00
|
|
|
|
reg.register_early_lint_pass(box multiple_crate_versions::Pass);
|
2018-10-22 08:39:51 -05:00
|
|
|
|
reg.register_early_lint_pass(box wildcard_dependencies::Pass);
|
2018-04-15 05:30:38 -05:00
|
|
|
|
reg.register_late_lint_pass(box map_unit_fn::Pass);
|
2018-04-19 14:34:31 -05:00
|
|
|
|
reg.register_late_lint_pass(box infallible_destructuring_match::Pass);
|
2018-05-28 19:17:55 -05:00
|
|
|
|
reg.register_late_lint_pass(box inherent_impl::Pass::default());
|
2018-06-01 04:58:40 -05:00
|
|
|
|
reg.register_late_lint_pass(box neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd);
|
2018-05-27 17:02:38 -05:00
|
|
|
|
reg.register_late_lint_pass(box unwrap::Pass);
|
2018-03-18 15:27:15 -05:00
|
|
|
|
reg.register_late_lint_pass(box duration_subsec::DurationSubsec);
|
2018-06-14 02:57:27 -05:00
|
|
|
|
reg.register_late_lint_pass(box default_trait_access::DefaultTraitAccess);
|
2018-06-13 18:28:57 -05:00
|
|
|
|
reg.register_late_lint_pass(box indexing_slicing::IndexingSlicing);
|
2018-06-06 10:20:22 -05:00
|
|
|
|
reg.register_late_lint_pass(box non_copy_const::NonCopyConst);
|
2018-08-27 08:49:54 -05:00
|
|
|
|
reg.register_late_lint_pass(box ptr_offset_with_cast::Pass);
|
2018-10-23 02:01:45 -05:00
|
|
|
|
reg.register_late_lint_pass(box redundant_clone::RedundantClone);
|
2018-10-18 18:15:48 -05:00
|
|
|
|
reg.register_late_lint_pass(box slow_vector_initialization::Pass);
|
2016-05-24 11:25:25 -05:00
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::restriction", Some("clippy_restriction"), vec![
|
2016-05-24 11:25:25 -05:00
|
|
|
|
arithmetic::FLOAT_ARITHMETIC,
|
|
|
|
|
arithmetic::INTEGER_ARITHMETIC,
|
2017-12-16 14:37:44 -06:00
|
|
|
|
else_if_without_else::ELSE_IF_WITHOUT_ELSE,
|
2018-12-05 07:39:09 -06:00
|
|
|
|
implicit_return::IMPLICIT_RETURN,
|
2018-08-02 12:06:03 -05:00
|
|
|
|
indexing_slicing::INDEXING_SLICING,
|
2018-05-29 03:19:16 -05:00
|
|
|
|
inherent_impl::MULTIPLE_INHERENT_IMPL,
|
2018-02-26 14:32:18 -06:00
|
|
|
|
literal_representation::DECIMAL_LITERAL_REPRESENTATION,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
mem_forget::MEM_FORGET,
|
2018-01-21 23:05:01 -06:00
|
|
|
|
methods::CLONE_ON_REF_PTR,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
methods::OPTION_UNWRAP_USED,
|
|
|
|
|
methods::RESULT_UNWRAP_USED,
|
|
|
|
|
methods::WRONG_PUB_SELF_CONVENTION,
|
2017-11-04 03:32:58 -05:00
|
|
|
|
misc::FLOAT_CMP_CONST,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
|
2018-07-04 03:51:04 -05:00
|
|
|
|
missing_inline::MISSING_INLINE_IN_PUBLIC_ITEMS,
|
2018-05-24 12:26:04 -05:00
|
|
|
|
panic_unimplemented::UNIMPLEMENTED,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
shadow::SHADOW_REUSE,
|
|
|
|
|
shadow::SHADOW_SAME,
|
|
|
|
|
strings::STRING_ADD,
|
2018-04-15 08:01:48 -05:00
|
|
|
|
write::PRINT_STDOUT,
|
|
|
|
|
write::USE_DEBUG,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
]);
|
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::pedantic", Some("clippy_pedantic"), vec![
|
2018-03-28 08:24:26 -05:00
|
|
|
|
attrs::INLINE_ALWAYS,
|
|
|
|
|
copies::MATCH_SAME_ARMS,
|
2018-07-17 12:22:55 -05:00
|
|
|
|
copy_iterator::COPY_ITERATOR,
|
2018-06-29 02:55:20 -05:00
|
|
|
|
default_trait_access::DEFAULT_TRAIT_ACCESS,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
derive::EXPL_IMPL_CLONE_ON_COPY,
|
|
|
|
|
doc::DOC_MARKDOWN,
|
2017-02-04 22:54:21 -06:00
|
|
|
|
empty_enum::EMPTY_ENUM,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
enum_glob_use::ENUM_GLOB_USE,
|
2018-12-16 07:10:53 -06:00
|
|
|
|
enum_variants::MODULE_NAME_REPEAT,
|
2018-12-16 15:49:46 -06:00
|
|
|
|
enum_variants::PUB_ENUM_VARIANT_NAMES,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
if_not_else::IF_NOT_ELSE,
|
2017-08-25 15:20:52 -05:00
|
|
|
|
infinite_iter::MAYBE_INFINITE_ITER,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
items_after_statements::ITEMS_AFTER_STATEMENTS,
|
2018-12-01 18:46:03 -06:00
|
|
|
|
literal_representation::LARGE_DIGIT_GROUPS,
|
2018-09-03 02:19:59 -05:00
|
|
|
|
loops::EXPLICIT_INTO_ITER_LOOP,
|
|
|
|
|
loops::EXPLICIT_ITER_LOOP,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
matches::SINGLE_MATCH_ELSE,
|
2016-06-21 06:32:34 -05:00
|
|
|
|
methods::FILTER_MAP,
|
2018-09-21 02:26:38 -05:00
|
|
|
|
methods::MAP_FLATTEN,
|
2016-10-02 14:23:26 -05:00
|
|
|
|
methods::OPTION_MAP_UNWRAP_OR,
|
|
|
|
|
methods::OPTION_MAP_UNWRAP_OR_ELSE,
|
2017-11-06 01:17:25 -06:00
|
|
|
|
methods::RESULT_MAP_UNWRAP_OR_ELSE,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
misc::USED_UNDERSCORE_BINDING,
|
2016-08-05 11:50:02 -05:00
|
|
|
|
misc_early::UNSEPARATED_LITERAL_SUFFIX,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
mut_mut::MUT_MUT,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
needless_continue::NEEDLESS_CONTINUE,
|
2018-11-21 03:58:27 -06:00
|
|
|
|
needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
non_expressive_names::SIMILAR_NAMES,
|
2018-01-09 22:42:07 -06:00
|
|
|
|
replace_consts::REPLACE_CONSTS,
|
2018-08-09 11:26:22 -05:00
|
|
|
|
shadow::SHADOW_UNRELATED,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
strings::STRING_ADD_ASSIGN,
|
|
|
|
|
types::CAST_POSSIBLE_TRUNCATION,
|
|
|
|
|
types::CAST_POSSIBLE_WRAP,
|
|
|
|
|
types::CAST_PRECISION_LOSS,
|
|
|
|
|
types::CAST_SIGN_LOSS,
|
|
|
|
|
types::INVALID_UPCAST_COMPARISONS,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
types::LINKEDLIST,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
unicode::NON_ASCII_LITERAL,
|
|
|
|
|
unicode::UNICODE_NOT_NFC,
|
2017-08-21 02:44:53 -05:00
|
|
|
|
use_self::USE_SELF,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
]);
|
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::internal", Some("clippy_internal"), vec![
|
2016-09-01 02:07:37 -05:00
|
|
|
|
utils::internal_lints::CLIPPY_LINTS_INTERNAL,
|
2018-09-14 05:38:09 -05:00
|
|
|
|
utils::internal_lints::COMPILER_LINT_FUNCTIONS,
|
2018-08-10 12:58:23 -05:00
|
|
|
|
utils::internal_lints::DEFAULT_HASH_TYPES,
|
2018-09-14 05:38:09 -05:00
|
|
|
|
utils::internal_lints::LINT_WITHOUT_LINT_PASS,
|
2016-09-01 02:07:37 -05:00
|
|
|
|
]);
|
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::all", Some("clippy"), vec![
|
2018-03-28 16:49:32 -05:00
|
|
|
|
approx_const::APPROX_CONSTANT,
|
|
|
|
|
assign_ops::ASSIGN_OP_PATTERN,
|
|
|
|
|
assign_ops::MISREFACTORED_ASSIGN_OP,
|
2018-09-03 08:34:12 -05:00
|
|
|
|
attrs::DEPRECATED_CFG_ATTR,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
attrs::DEPRECATED_SEMVER,
|
2018-09-10 10:09:15 -05:00
|
|
|
|
attrs::UNKNOWN_CLIPPY_LINTS,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
attrs::USELESS_ATTRIBUTE,
|
|
|
|
|
bit_mask::BAD_BIT_MASK,
|
|
|
|
|
bit_mask::INEFFECTIVE_BIT_MASK,
|
|
|
|
|
bit_mask::VERBOSE_BIT_MASK,
|
|
|
|
|
blacklisted_name::BLACKLISTED_NAME,
|
|
|
|
|
block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
|
|
|
|
|
block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
|
|
|
|
|
booleans::LOGIC_BUG,
|
|
|
|
|
booleans::NONMINIMAL_BOOL,
|
|
|
|
|
bytecount::NAIVE_BYTECOUNT,
|
|
|
|
|
collapsible_if::COLLAPSIBLE_IF,
|
|
|
|
|
const_static_lifetime::CONST_STATIC_LIFETIME,
|
|
|
|
|
copies::IFS_SAME_COND,
|
2018-11-04 02:41:28 -06:00
|
|
|
|
copies::IF_SAME_THEN_ELSE,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
|
|
|
|
|
derive::DERIVE_HASH_XOR_EQ,
|
|
|
|
|
double_comparison::DOUBLE_COMPARISONS,
|
|
|
|
|
double_parens::DOUBLE_PARENS,
|
|
|
|
|
drop_forget_ref::DROP_COPY,
|
|
|
|
|
drop_forget_ref::DROP_REF,
|
|
|
|
|
drop_forget_ref::FORGET_COPY,
|
|
|
|
|
drop_forget_ref::FORGET_REF,
|
2018-03-18 15:27:15 -05:00
|
|
|
|
duration_subsec::DURATION_SUBSEC,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
entry::MAP_ENTRY,
|
|
|
|
|
enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
|
|
|
|
|
enum_variants::ENUM_VARIANT_NAMES,
|
|
|
|
|
enum_variants::MODULE_INCEPTION,
|
|
|
|
|
eq_op::EQ_OP,
|
|
|
|
|
eq_op::OP_REF,
|
|
|
|
|
erasing_op::ERASING_OP,
|
|
|
|
|
escape::BOXED_LOCAL,
|
|
|
|
|
eta_reduction::REDUNDANT_CLOSURE,
|
|
|
|
|
eval_order_dependence::DIVERGING_SUB_EXPRESSION,
|
|
|
|
|
eval_order_dependence::EVAL_ORDER_DEPENDENCE,
|
2018-04-27 07:00:43 -05:00
|
|
|
|
excessive_precision::EXCESSIVE_PRECISION,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
explicit_write::EXPLICIT_WRITE,
|
|
|
|
|
format::USELESS_FORMAT,
|
|
|
|
|
formatting::POSSIBLE_MISSING_COMMA,
|
|
|
|
|
formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
|
|
|
|
|
formatting::SUSPICIOUS_ELSE_FORMATTING,
|
|
|
|
|
functions::NOT_UNSAFE_PTR_ARG_DEREF,
|
|
|
|
|
functions::TOO_MANY_ARGUMENTS,
|
|
|
|
|
identity_conversion::IDENTITY_CONVERSION,
|
|
|
|
|
identity_op::IDENTITY_OP,
|
2018-06-25 11:18:50 -05:00
|
|
|
|
indexing_slicing::OUT_OF_BOUNDS_INDEXING,
|
2018-04-19 14:34:31 -05:00
|
|
|
|
infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
infinite_iter::INFINITE_ITER,
|
|
|
|
|
inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
|
|
|
|
|
int_plus_one::INT_PLUS_ONE,
|
|
|
|
|
invalid_ref::INVALID_REF,
|
|
|
|
|
large_enum_variant::LARGE_ENUM_VARIANT,
|
|
|
|
|
len_zero::LEN_WITHOUT_IS_EMPTY,
|
|
|
|
|
len_zero::LEN_ZERO,
|
|
|
|
|
let_if_seq::USELESS_LET_IF_SEQ,
|
2018-05-26 03:23:34 -05:00
|
|
|
|
lifetimes::EXTRA_UNUSED_LIFETIMES,
|
2018-05-27 09:16:41 -05:00
|
|
|
|
lifetimes::NEEDLESS_LIFETIMES,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
literal_representation::INCONSISTENT_DIGIT_GROUPING,
|
2018-09-02 16:07:55 -05:00
|
|
|
|
literal_representation::MISTYPED_LITERAL_SUFFIXES,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
literal_representation::UNREADABLE_LITERAL,
|
|
|
|
|
loops::EMPTY_LOOP,
|
|
|
|
|
loops::EXPLICIT_COUNTER_LOOP,
|
|
|
|
|
loops::FOR_KV_MAP,
|
|
|
|
|
loops::FOR_LOOP_OVER_OPTION,
|
|
|
|
|
loops::FOR_LOOP_OVER_RESULT,
|
|
|
|
|
loops::ITER_NEXT_LOOP,
|
|
|
|
|
loops::MANUAL_MEMCPY,
|
|
|
|
|
loops::MUT_RANGE_BOUND,
|
2018-08-29 22:01:24 -05:00
|
|
|
|
loops::NEEDLESS_COLLECT,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
loops::NEEDLESS_RANGE_LOOP,
|
|
|
|
|
loops::NEVER_LOOP,
|
|
|
|
|
loops::REVERSE_RANGE_LOOP,
|
|
|
|
|
loops::UNUSED_COLLECT,
|
|
|
|
|
loops::WHILE_IMMUTABLE_CONDITION,
|
|
|
|
|
loops::WHILE_LET_LOOP,
|
|
|
|
|
loops::WHILE_LET_ON_ITERATOR,
|
2018-10-02 08:13:43 -05:00
|
|
|
|
map_clone::MAP_CLONE,
|
2018-04-19 01:30:07 -05:00
|
|
|
|
map_unit_fn::OPTION_MAP_UNIT_FN,
|
|
|
|
|
map_unit_fn::RESULT_MAP_UNIT_FN,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
matches::MATCH_AS_REF,
|
|
|
|
|
matches::MATCH_BOOL,
|
|
|
|
|
matches::MATCH_OVERLAPPING_ARM,
|
|
|
|
|
matches::MATCH_REF_PATS,
|
|
|
|
|
matches::MATCH_WILD_ERR_ARM,
|
|
|
|
|
matches::SINGLE_MATCH,
|
2018-10-20 22:46:13 -05:00
|
|
|
|
mem_discriminant::MEM_DISCRIMINANT_NON_ENUM,
|
2018-09-18 12:28:58 -05:00
|
|
|
|
mem_replace::MEM_REPLACE_OPTION_WITH_NONE,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
methods::CHARS_LAST_CMP,
|
|
|
|
|
methods::CHARS_NEXT_CMP,
|
|
|
|
|
methods::CLONE_DOUBLE_REF,
|
|
|
|
|
methods::CLONE_ON_COPY,
|
2018-06-18 02:55:59 -05:00
|
|
|
|
methods::EXPECT_FUN_CALL,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
methods::FILTER_NEXT,
|
|
|
|
|
methods::GET_UNWRAP,
|
2018-10-20 15:03:38 -05:00
|
|
|
|
methods::INTO_ITER_ON_ARRAY,
|
|
|
|
|
methods::INTO_ITER_ON_REF,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
methods::ITER_CLONED_COLLECT,
|
|
|
|
|
methods::ITER_NTH,
|
|
|
|
|
methods::ITER_SKIP_NEXT,
|
|
|
|
|
methods::NEW_RET_NO_SELF,
|
|
|
|
|
methods::OK_EXPECT,
|
|
|
|
|
methods::OPTION_MAP_OR_NONE,
|
|
|
|
|
methods::OR_FUN_CALL,
|
|
|
|
|
methods::SEARCH_IS_SOME,
|
|
|
|
|
methods::SHOULD_IMPLEMENT_TRAIT,
|
|
|
|
|
methods::SINGLE_CHAR_PATTERN,
|
|
|
|
|
methods::STRING_EXTEND_CHARS,
|
|
|
|
|
methods::TEMPORARY_CSTRING_AS_PTR,
|
2018-09-25 23:52:36 -05:00
|
|
|
|
methods::UNNECESSARY_FILTER_MAP,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
methods::UNNECESSARY_FOLD,
|
|
|
|
|
methods::USELESS_ASREF,
|
|
|
|
|
methods::WRONG_SELF_CONVENTION,
|
|
|
|
|
minmax::MIN_MAX,
|
|
|
|
|
misc::CMP_NAN,
|
|
|
|
|
misc::CMP_OWNED,
|
|
|
|
|
misc::FLOAT_CMP,
|
|
|
|
|
misc::MODULO_ONE,
|
|
|
|
|
misc::REDUNDANT_PATTERN,
|
|
|
|
|
misc::SHORT_CIRCUIT_STATEMENT,
|
|
|
|
|
misc::TOPLEVEL_REF_ARG,
|
|
|
|
|
misc::ZERO_PTR,
|
|
|
|
|
misc_early::BUILTIN_TYPE_SHADOW,
|
|
|
|
|
misc_early::DOUBLE_NEG,
|
|
|
|
|
misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
|
|
|
|
|
misc_early::MIXED_CASE_HEX_LITERALS,
|
|
|
|
|
misc_early::REDUNDANT_CLOSURE_CALL,
|
|
|
|
|
misc_early::UNNEEDED_FIELD_PATTERN,
|
|
|
|
|
misc_early::ZERO_PREFIXED_LITERAL,
|
|
|
|
|
mut_reference::UNNECESSARY_MUT_PASSED,
|
|
|
|
|
mutex_atomic::MUTEX_ATOMIC,
|
|
|
|
|
needless_bool::BOOL_COMPARISON,
|
|
|
|
|
needless_bool::NEEDLESS_BOOL,
|
|
|
|
|
needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
|
|
|
|
|
needless_update::NEEDLESS_UPDATE,
|
2018-06-09 23:22:07 -05:00
|
|
|
|
neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
neg_multiply::NEG_MULTIPLY,
|
|
|
|
|
new_without_default::NEW_WITHOUT_DEFAULT,
|
|
|
|
|
new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
|
|
|
|
|
no_effect::NO_EFFECT,
|
|
|
|
|
no_effect::UNNECESSARY_OPERATION,
|
2018-06-06 10:20:22 -05:00
|
|
|
|
non_copy_const::BORROW_INTERIOR_MUTABLE_CONST,
|
|
|
|
|
non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
|
|
|
|
|
non_expressive_names::MANY_SINGLE_CHAR_NAMES,
|
|
|
|
|
ok_if_let::IF_LET_SOME_RESULT,
|
|
|
|
|
open_options::NONSENSICAL_OPEN_OPTIONS,
|
|
|
|
|
overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
|
2018-05-24 01:59:54 -05:00
|
|
|
|
panic_unimplemented::PANIC_PARAMS,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
partialeq_ne_impl::PARTIALEQ_NE_IMPL,
|
|
|
|
|
precedence::PRECEDENCE,
|
|
|
|
|
ptr::CMP_NULL,
|
|
|
|
|
ptr::MUT_FROM_REF,
|
|
|
|
|
ptr::PTR_ARG,
|
2018-08-27 08:49:54 -05:00
|
|
|
|
ptr_offset_with_cast::PTR_OFFSET_WITH_CAST,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
question_mark::QUESTION_MARK,
|
|
|
|
|
ranges::ITERATOR_STEP_BY_ZERO,
|
|
|
|
|
ranges::RANGE_MINUS_ONE,
|
2018-08-26 03:57:04 -05:00
|
|
|
|
ranges::RANGE_PLUS_ONE,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
ranges::RANGE_ZIP_WITH_LEN,
|
|
|
|
|
redundant_field_names::REDUNDANT_FIELD_NAMES,
|
2018-10-10 10:13:53 -05:00
|
|
|
|
redundant_pattern_matching::REDUNDANT_PATTERN_MATCHING,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
reference::DEREF_ADDROF,
|
2018-05-29 04:58:58 -05:00
|
|
|
|
reference::REF_IN_DEREF,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
regex::INVALID_REGEX,
|
|
|
|
|
regex::REGEX_MACRO,
|
|
|
|
|
regex::TRIVIAL_REGEX,
|
|
|
|
|
returns::LET_AND_RETURN,
|
|
|
|
|
returns::NEEDLESS_RETURN,
|
2018-09-27 12:10:20 -05:00
|
|
|
|
returns::UNUSED_UNIT,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
serde_api::SERDE_API_MISUSE,
|
2018-11-25 16:36:04 -06:00
|
|
|
|
slow_vector_initialization::SLOW_VECTOR_INITIALIZATION,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
strings::STRING_LIT_AS_BYTES,
|
|
|
|
|
suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
|
|
|
|
|
suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
|
|
|
|
|
swap::ALMOST_SWAPPED,
|
|
|
|
|
swap::MANUAL_SWAP,
|
|
|
|
|
temporary_assignment::TEMPORARY_ASSIGNMENT,
|
|
|
|
|
transmute::CROSSPOINTER_TRANSMUTE,
|
|
|
|
|
transmute::TRANSMUTE_BYTES_TO_STR,
|
|
|
|
|
transmute::TRANSMUTE_INT_TO_BOOL,
|
|
|
|
|
transmute::TRANSMUTE_INT_TO_CHAR,
|
|
|
|
|
transmute::TRANSMUTE_INT_TO_FLOAT,
|
2018-04-11 04:17:59 -05:00
|
|
|
|
transmute::TRANSMUTE_PTR_TO_PTR,
|
2018-04-15 08:01:48 -05:00
|
|
|
|
transmute::TRANSMUTE_PTR_TO_REF,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
transmute::USELESS_TRANSMUTE,
|
|
|
|
|
transmute::WRONG_TRANSMUTE,
|
2018-05-27 07:32:03 -05:00
|
|
|
|
trivially_copy_pass_by_ref::TRIVIALLY_COPY_PASS_BY_REF,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
types::ABSURD_EXTREME_COMPARISONS,
|
|
|
|
|
types::BORROWED_BOX,
|
|
|
|
|
types::BOX_VEC,
|
|
|
|
|
types::CAST_LOSSLESS,
|
2018-04-11 04:17:59 -05:00
|
|
|
|
types::CAST_PTR_ALIGNMENT,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
types::CHAR_LIT_AS_U8,
|
2018-10-03 05:02:06 -05:00
|
|
|
|
types::FN_TO_NUMERIC_CAST,
|
2018-10-04 14:44:16 -05:00
|
|
|
|
types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
types::IMPLICIT_HASHER,
|
|
|
|
|
types::LET_UNIT_VALUE,
|
|
|
|
|
types::OPTION_OPTION,
|
|
|
|
|
types::TYPE_COMPLEXITY,
|
|
|
|
|
types::UNIT_ARG,
|
|
|
|
|
types::UNIT_CMP,
|
|
|
|
|
types::UNNECESSARY_CAST,
|
2018-12-13 12:15:56 -06:00
|
|
|
|
types::VEC_BOX,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
unicode::ZERO_WIDTH_SPACE,
|
|
|
|
|
unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
|
|
|
|
|
unused_io_amount::UNUSED_IO_AMOUNT,
|
|
|
|
|
unused_label::UNUSED_LABEL,
|
|
|
|
|
vec::USELESS_VEC,
|
2018-11-04 02:41:28 -06:00
|
|
|
|
write::PRINTLN_EMPTY_STRING,
|
2018-04-15 08:01:48 -05:00
|
|
|
|
write::PRINT_LITERAL,
|
|
|
|
|
write::PRINT_WITH_NEWLINE,
|
2018-11-04 02:41:28 -06:00
|
|
|
|
write::WRITELN_EMPTY_STRING,
|
2018-04-15 08:01:48 -05:00
|
|
|
|
write::WRITE_LITERAL,
|
|
|
|
|
write::WRITE_WITH_NEWLINE,
|
2018-03-28 16:49:32 -05:00
|
|
|
|
zero_div_zero::ZERO_DIVIDED_BY_ZERO,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
]);
|
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::style", Some("clippy_style"), vec![
|
2016-05-24 11:25:25 -05:00
|
|
|
|
assign_ops::ASSIGN_OP_PATTERN,
|
2018-09-10 10:09:15 -05:00
|
|
|
|
attrs::UNKNOWN_CLIPPY_LINTS,
|
2017-07-03 09:07:04 -05:00
|
|
|
|
bit_mask::VERBOSE_BIT_MASK,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
blacklisted_name::BLACKLISTED_NAME,
|
|
|
|
|
block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
|
|
|
|
|
block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
|
|
|
|
|
collapsible_if::COLLAPSIBLE_IF,
|
2017-10-29 04:30:33 -05:00
|
|
|
|
const_static_lifetime::CONST_STATIC_LIFETIME,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
enum_variants::ENUM_VARIANT_NAMES,
|
2016-09-12 03:30:42 -05:00
|
|
|
|
enum_variants::MODULE_INCEPTION,
|
2017-04-07 04:25:00 -05:00
|
|
|
|
eq_op::OP_REF,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
eta_reduction::REDUNDANT_CLOSURE,
|
2018-04-27 07:00:43 -05:00
|
|
|
|
excessive_precision::EXCESSIVE_PRECISION,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
|
|
|
|
|
formatting::SUSPICIOUS_ELSE_FORMATTING,
|
2018-04-19 14:34:31 -05:00
|
|
|
|
infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
len_zero::LEN_WITHOUT_IS_EMPTY,
|
|
|
|
|
len_zero::LEN_ZERO,
|
2016-03-30 12:53:43 -05:00
|
|
|
|
let_if_seq::USELESS_LET_IF_SEQ,
|
2018-01-16 07:01:07 -06:00
|
|
|
|
literal_representation::INCONSISTENT_DIGIT_GROUPING,
|
|
|
|
|
literal_representation::UNREADABLE_LITERAL,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
loops::EMPTY_LOOP,
|
|
|
|
|
loops::FOR_KV_MAP,
|
|
|
|
|
loops::NEEDLESS_RANGE_LOOP,
|
|
|
|
|
loops::WHILE_LET_ON_ITERATOR,
|
2018-10-02 08:13:43 -05:00
|
|
|
|
map_clone::MAP_CLONE,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
matches::MATCH_BOOL,
|
|
|
|
|
matches::MATCH_OVERLAPPING_ARM,
|
|
|
|
|
matches::MATCH_REF_PATS,
|
2017-02-11 00:57:50 -06:00
|
|
|
|
matches::MATCH_WILD_ERR_ARM,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
matches::SINGLE_MATCH,
|
2018-09-16 18:25:33 -05:00
|
|
|
|
mem_replace::MEM_REPLACE_OPTION_WITH_NONE,
|
2017-09-18 22:26:36 -05:00
|
|
|
|
methods::CHARS_LAST_CMP,
|
2016-11-01 01:43:19 -05:00
|
|
|
|
methods::GET_UNWRAP,
|
2018-10-20 15:03:38 -05:00
|
|
|
|
methods::INTO_ITER_ON_REF,
|
2017-02-13 04:40:27 -06:00
|
|
|
|
methods::ITER_CLONED_COLLECT,
|
2016-10-14 06:35:25 -05:00
|
|
|
|
methods::ITER_SKIP_NEXT,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
methods::NEW_RET_NO_SELF,
|
|
|
|
|
methods::OK_EXPECT,
|
2017-10-20 02:24:37 -05:00
|
|
|
|
methods::OPTION_MAP_OR_NONE,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
methods::SHOULD_IMPLEMENT_TRAIT,
|
2016-11-19 09:21:40 -06:00
|
|
|
|
methods::STRING_EXTEND_CHARS,
|
2018-01-21 23:05:01 -06:00
|
|
|
|
methods::UNNECESSARY_FOLD,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
methods::WRONG_SELF_CONVENTION,
|
|
|
|
|
misc::REDUNDANT_PATTERN,
|
|
|
|
|
misc::TOPLEVEL_REF_ARG,
|
2017-03-07 05:58:07 -06:00
|
|
|
|
misc::ZERO_PTR,
|
2016-08-27 18:52:01 -05:00
|
|
|
|
misc_early::BUILTIN_TYPE_SHADOW,
|
2016-06-29 18:00:25 -05:00
|
|
|
|
misc_early::DOUBLE_NEG,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
|
2016-08-05 11:30:07 -05:00
|
|
|
|
misc_early::MIXED_CASE_HEX_LITERALS,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
misc_early::UNNEEDED_FIELD_PATTERN,
|
|
|
|
|
mut_reference::UNNECESSARY_MUT_PASSED,
|
|
|
|
|
neg_multiply::NEG_MULTIPLY,
|
|
|
|
|
new_without_default::NEW_WITHOUT_DEFAULT,
|
|
|
|
|
new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
|
2017-11-06 01:17:25 -06:00
|
|
|
|
non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
non_expressive_names::MANY_SINGLE_CHAR_NAMES,
|
2016-10-02 15:39:28 -05:00
|
|
|
|
ok_if_let::IF_LET_SOME_RESULT,
|
2018-05-24 01:59:54 -05:00
|
|
|
|
panic_unimplemented::PANIC_PARAMS,
|
2016-08-22 11:29:29 -05:00
|
|
|
|
ptr::CMP_NULL,
|
|
|
|
|
ptr::PTR_ARG,
|
2018-02-02 01:53:32 -06:00
|
|
|
|
question_mark::QUESTION_MARK,
|
2018-02-10 14:13:17 -06:00
|
|
|
|
redundant_field_names::REDUNDANT_FIELD_NAMES,
|
2018-10-10 10:13:53 -05:00
|
|
|
|
redundant_pattern_matching::REDUNDANT_PATTERN_MATCHING,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
regex::REGEX_MACRO,
|
|
|
|
|
regex::TRIVIAL_REGEX,
|
|
|
|
|
returns::LET_AND_RETURN,
|
|
|
|
|
returns::NEEDLESS_RETURN,
|
2018-09-27 12:10:20 -05:00
|
|
|
|
returns::UNUSED_UNIT,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
strings::STRING_LIT_AS_BYTES,
|
2018-10-03 05:02:06 -05:00
|
|
|
|
types::FN_TO_NUMERIC_CAST,
|
2018-10-04 14:44:16 -05:00
|
|
|
|
types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
types::IMPLICIT_HASHER,
|
|
|
|
|
types::LET_UNIT_VALUE,
|
|
|
|
|
unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
|
2018-11-04 02:41:28 -06:00
|
|
|
|
write::PRINTLN_EMPTY_STRING,
|
2018-04-15 08:01:48 -05:00
|
|
|
|
write::PRINT_LITERAL,
|
|
|
|
|
write::PRINT_WITH_NEWLINE,
|
2018-11-04 02:41:28 -06:00
|
|
|
|
write::WRITELN_EMPTY_STRING,
|
2018-04-15 08:01:48 -05:00
|
|
|
|
write::WRITE_LITERAL,
|
|
|
|
|
write::WRITE_WITH_NEWLINE,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
]);
|
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::complexity", Some("clippy_complexity"), vec![
|
2018-03-28 08:24:26 -05:00
|
|
|
|
assign_ops::MISREFACTORED_ASSIGN_OP,
|
2018-09-03 08:34:12 -05:00
|
|
|
|
attrs::DEPRECATED_CFG_ATTR,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
booleans::NONMINIMAL_BOOL,
|
|
|
|
|
cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
|
|
|
|
|
double_comparison::DOUBLE_COMPARISONS,
|
|
|
|
|
double_parens::DOUBLE_PARENS,
|
2018-06-09 04:04:21 -05:00
|
|
|
|
duration_subsec::DURATION_SUBSEC,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
eval_order_dependence::DIVERGING_SUB_EXPRESSION,
|
|
|
|
|
eval_order_dependence::EVAL_ORDER_DEPENDENCE,
|
|
|
|
|
explicit_write::EXPLICIT_WRITE,
|
|
|
|
|
format::USELESS_FORMAT,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
functions::TOO_MANY_ARGUMENTS,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
identity_conversion::IDENTITY_CONVERSION,
|
|
|
|
|
identity_op::IDENTITY_OP,
|
|
|
|
|
int_plus_one::INT_PLUS_ONE,
|
2018-05-26 03:23:34 -05:00
|
|
|
|
lifetimes::EXTRA_UNUSED_LIFETIMES,
|
2018-05-27 09:16:41 -05:00
|
|
|
|
lifetimes::NEEDLESS_LIFETIMES,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
loops::EXPLICIT_COUNTER_LOOP,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
loops::MUT_RANGE_BOUND,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
loops::WHILE_LET_LOOP,
|
2018-04-19 01:30:07 -05:00
|
|
|
|
map_unit_fn::OPTION_MAP_UNIT_FN,
|
|
|
|
|
map_unit_fn::RESULT_MAP_UNIT_FN,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
matches::MATCH_AS_REF,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
methods::CHARS_NEXT_CMP,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
methods::CLONE_ON_COPY,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
methods::FILTER_NEXT,
|
|
|
|
|
methods::SEARCH_IS_SOME,
|
2018-09-25 23:52:36 -05:00
|
|
|
|
methods::UNNECESSARY_FILTER_MAP,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
methods::USELESS_ASREF,
|
|
|
|
|
misc::SHORT_CIRCUIT_STATEMENT,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
misc_early::REDUNDANT_CLOSURE_CALL,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
misc_early::ZERO_PREFIXED_LITERAL,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
needless_bool::BOOL_COMPARISON,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
needless_bool::NEEDLESS_BOOL,
|
|
|
|
|
needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
|
|
|
|
|
needless_update::NEEDLESS_UPDATE,
|
2018-06-09 23:22:07 -05:00
|
|
|
|
neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
no_effect::NO_EFFECT,
|
|
|
|
|
no_effect::UNNECESSARY_OPERATION,
|
|
|
|
|
overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
|
|
|
|
|
partialeq_ne_impl::PARTIALEQ_NE_IMPL,
|
|
|
|
|
precedence::PRECEDENCE,
|
2018-08-29 07:02:26 -05:00
|
|
|
|
ptr_offset_with_cast::PTR_OFFSET_WITH_CAST,
|
2018-08-26 03:57:04 -05:00
|
|
|
|
ranges::RANGE_MINUS_ONE,
|
|
|
|
|
ranges::RANGE_PLUS_ONE,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
ranges::RANGE_ZIP_WITH_LEN,
|
|
|
|
|
reference::DEREF_ADDROF,
|
2018-05-28 02:29:02 -05:00
|
|
|
|
reference::REF_IN_DEREF,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
swap::MANUAL_SWAP,
|
|
|
|
|
temporary_assignment::TEMPORARY_ASSIGNMENT,
|
|
|
|
|
transmute::CROSSPOINTER_TRANSMUTE,
|
2017-11-06 01:17:25 -06:00
|
|
|
|
transmute::TRANSMUTE_BYTES_TO_STR,
|
2017-10-20 02:24:37 -05:00
|
|
|
|
transmute::TRANSMUTE_INT_TO_BOOL,
|
|
|
|
|
transmute::TRANSMUTE_INT_TO_CHAR,
|
|
|
|
|
transmute::TRANSMUTE_INT_TO_FLOAT,
|
2018-04-11 04:17:59 -05:00
|
|
|
|
transmute::TRANSMUTE_PTR_TO_PTR,
|
2018-04-15 08:01:48 -05:00
|
|
|
|
transmute::TRANSMUTE_PTR_TO_REF,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
transmute::USELESS_TRANSMUTE,
|
2017-01-31 22:19:33 -06:00
|
|
|
|
types::BORROWED_BOX,
|
2017-08-29 07:48:19 -05:00
|
|
|
|
types::CAST_LOSSLESS,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
types::CHAR_LIT_AS_U8,
|
2017-12-25 23:25:13 -06:00
|
|
|
|
types::OPTION_OPTION,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
types::TYPE_COMPLEXITY,
|
2018-01-18 16:02:18 -06:00
|
|
|
|
types::UNIT_ARG,
|
2017-02-16 08:55:41 -06:00
|
|
|
|
types::UNNECESSARY_CAST,
|
2018-12-13 12:15:56 -06:00
|
|
|
|
types::VEC_BOX,
|
2016-05-24 11:25:25 -05:00
|
|
|
|
unused_label::UNUSED_LABEL,
|
|
|
|
|
zero_div_zero::ZERO_DIVIDED_BY_ZERO,
|
|
|
|
|
]);
|
2018-03-27 10:13:55 -05:00
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::correctness", Some("clippy_correctness"), vec![
|
2018-03-27 10:13:55 -05:00
|
|
|
|
approx_const::APPROX_CONSTANT,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
attrs::DEPRECATED_SEMVER,
|
|
|
|
|
attrs::USELESS_ATTRIBUTE,
|
|
|
|
|
bit_mask::BAD_BIT_MASK,
|
|
|
|
|
bit_mask::INEFFECTIVE_BIT_MASK,
|
|
|
|
|
booleans::LOGIC_BUG,
|
|
|
|
|
copies::IFS_SAME_COND,
|
2018-11-04 02:41:28 -06:00
|
|
|
|
copies::IF_SAME_THEN_ELSE,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
derive::DERIVE_HASH_XOR_EQ,
|
|
|
|
|
drop_forget_ref::DROP_COPY,
|
|
|
|
|
drop_forget_ref::DROP_REF,
|
|
|
|
|
drop_forget_ref::FORGET_COPY,
|
|
|
|
|
drop_forget_ref::FORGET_REF,
|
|
|
|
|
enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
|
|
|
|
|
eq_op::EQ_OP,
|
|
|
|
|
erasing_op::ERASING_OP,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
formatting::POSSIBLE_MISSING_COMMA,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
functions::NOT_UNSAFE_PTR_ARG_DEREF,
|
2018-06-25 11:18:50 -05:00
|
|
|
|
indexing_slicing::OUT_OF_BOUNDS_INDEXING,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
infinite_iter::INFINITE_ITER,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
invalid_ref::INVALID_REF,
|
2018-09-02 16:07:55 -05:00
|
|
|
|
literal_representation::MISTYPED_LITERAL_SUFFIXES,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
loops::FOR_LOOP_OVER_OPTION,
|
|
|
|
|
loops::FOR_LOOP_OVER_RESULT,
|
|
|
|
|
loops::ITER_NEXT_LOOP,
|
|
|
|
|
loops::NEVER_LOOP,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
loops::REVERSE_RANGE_LOOP,
|
|
|
|
|
loops::WHILE_IMMUTABLE_CONDITION,
|
2018-10-20 22:46:13 -05:00
|
|
|
|
mem_discriminant::MEM_DISCRIMINANT_NON_ENUM,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
methods::CLONE_DOUBLE_REF,
|
2018-10-20 15:03:38 -05:00
|
|
|
|
methods::INTO_ITER_ON_ARRAY,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
methods::TEMPORARY_CSTRING_AS_PTR,
|
|
|
|
|
minmax::MIN_MAX,
|
|
|
|
|
misc::CMP_NAN,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
misc::FLOAT_CMP,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
misc::MODULO_ONE,
|
2018-06-06 10:20:22 -05:00
|
|
|
|
non_copy_const::BORROW_INTERIOR_MUTABLE_CONST,
|
|
|
|
|
non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
open_options::NONSENSICAL_OPEN_OPTIONS,
|
|
|
|
|
ptr::MUT_FROM_REF,
|
|
|
|
|
ranges::ITERATOR_STEP_BY_ZERO,
|
|
|
|
|
regex::INVALID_REGEX,
|
|
|
|
|
serde_api::SERDE_API_MISUSE,
|
|
|
|
|
suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
|
|
|
|
|
suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
|
|
|
|
|
swap::ALMOST_SWAPPED,
|
|
|
|
|
transmute::WRONG_TRANSMUTE,
|
|
|
|
|
types::ABSURD_EXTREME_COMPARISONS,
|
2018-04-11 04:17:59 -05:00
|
|
|
|
types::CAST_PTR_ALIGNMENT,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
types::UNIT_CMP,
|
|
|
|
|
unicode::ZERO_WIDTH_SPACE,
|
|
|
|
|
unused_io_amount::UNUSED_IO_AMOUNT,
|
2018-03-27 10:13:55 -05:00
|
|
|
|
]);
|
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::perf", Some("clippy_perf"), vec![
|
2018-03-28 08:24:26 -05:00
|
|
|
|
bytecount::NAIVE_BYTECOUNT,
|
|
|
|
|
entry::MAP_ENTRY,
|
|
|
|
|
escape::BOXED_LOCAL,
|
|
|
|
|
large_enum_variant::LARGE_ENUM_VARIANT,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
loops::MANUAL_MEMCPY,
|
2018-08-29 22:01:24 -05:00
|
|
|
|
loops::NEEDLESS_COLLECT,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
loops::UNUSED_COLLECT,
|
2018-06-18 02:55:59 -05:00
|
|
|
|
methods::EXPECT_FUN_CALL,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
methods::ITER_NTH,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
methods::OR_FUN_CALL,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
methods::SINGLE_CHAR_PATTERN,
|
|
|
|
|
misc::CMP_OWNED,
|
|
|
|
|
mutex_atomic::MUTEX_ATOMIC,
|
2018-10-18 18:15:48 -05:00
|
|
|
|
slow_vector_initialization::SLOW_VECTOR_INITIALIZATION,
|
2018-05-27 07:32:03 -05:00
|
|
|
|
trivially_copy_pass_by_ref::TRIVIALLY_COPY_PASS_BY_REF,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
types::BOX_VEC,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
vec::USELESS_VEC,
|
|
|
|
|
]);
|
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::cargo", Some("clippy_cargo"), vec![
|
2018-11-13 07:43:30 -06:00
|
|
|
|
cargo_common_metadata::CARGO_COMMON_METADATA,
|
2018-04-29 18:20:39 -05:00
|
|
|
|
multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
|
2018-10-22 08:39:51 -05:00
|
|
|
|
wildcard_dependencies::WILDCARD_DEPENDENCIES,
|
2018-04-29 18:20:39 -05:00
|
|
|
|
]);
|
|
|
|
|
|
2018-08-28 07:16:31 -05:00
|
|
|
|
reg.register_lint_group("clippy::nursery", Some("clippy_nursery"), vec![
|
2018-04-04 20:00:21 -05:00
|
|
|
|
attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
|
2018-03-28 08:24:26 -05:00
|
|
|
|
fallible_impl_from::FALLIBLE_IMPL_FROM,
|
2018-03-29 06:41:53 -05:00
|
|
|
|
mutex_atomic::MUTEX_INTEGER,
|
2018-04-08 03:55:42 -05:00
|
|
|
|
needless_borrow::NEEDLESS_BORROW,
|
2018-10-23 02:01:45 -05:00
|
|
|
|
redundant_clone::REDUNDANT_CLONE,
|
2018-06-08 13:38:39 -05:00
|
|
|
|
unwrap::PANICKING_UNWRAP,
|
2018-06-09 23:22:07 -05:00
|
|
|
|
unwrap::UNNECESSARY_UNWRAP,
|
2018-03-27 10:13:55 -05:00
|
|
|
|
]);
|
2018-12-16 15:49:46 -06:00
|
|
|
|
|
|
|
|
|
store.register_renamed("stutter", "module_name_repeat");
|
2016-05-24 11:25:25 -05:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// only exists to let the dogfood integration test works.
|
|
|
|
|
// Don't run clippy as an executable directly
|
2018-11-17 06:47:27 -06:00
|
|
|
|
#[allow(dead_code)]
|
2016-05-24 11:25:25 -05:00
|
|
|
|
fn main() {
|
|
|
|
|
panic!("Please use the cargo-clippy executable");
|
|
|
|
|
}
|