rust/tests/rustdoc-ui/intra-doc/span-ice-55723.rs

#![deny(rustdoc::broken_intra_doc_links)]

// An error in calculating spans while reporting intra-doc link resolution errors caused rustdoc to
// attempt to slice in the middle of a multibyte character. See
// https://github.com/rust-lang/rust/issues/55723

/// ## For example:
///
/// （arr[i]）
//~^ ERROR `i`
pub fn test_ice() {
    unimplemented!();
}
-												Rename rustdoc lints to be a tool lint instead of built-in.

- Rename `broken_intra_doc_links` to `rustdoc::broken_intra_doc_links`
- Ensure that the old lint names still work and give deprecation errors
- Register lints even when running doctests

  Otherwise, all `rustdoc::` lints would be ignored.

- Register all existing lints as removed

  This unfortunately doesn't work with `register_renamed` because tool
  lints have not yet been registered when rustc is running. For similar
  reasons, `check_backwards_compat` doesn't work either. Call
  `register_removed` directly instead.

- Fix fallout

  + Rustdoc lints for compiler/
  + Rustdoc lints for library/

Note that this does *not* suggest `rustdoc::broken_intra_doc_links` for
`rustdoc::intra_doc_link_resolution_failure`, since there was no time
when the latter was valid.

											
										
										
											2020-12-29 22:16:16 -06:00
+								#![deny(rustdoc::broken_intra_doc_links)]
-												properly calculate spans for intra-doc link resolution errors

											
										
										
											2018-11-14 18:14:31 -06:00
 								// An error in calculating spans while reporting intra-doc link resolution errors caused rustdoc to
 								// attempt to slice in the middle of a multibyte character. See
 								// https://github.com/rust-lang/rust/issues/55723
 								/// ## For example:
-												Update doc-ui tests

											
										
										
											2018-11-30 09:20:07 -06:00
+								///
-												properly calculate spans for intra-doc link resolution errors

											
										
										
											2018-11-14 18:14:31 -06:00
+								/// （arr[i]）
-												refactor and reword intra-doc link errors

This commit refactors intra-doc link error reporting to deduplicate code
and decouple error construction from the type of error. This greatly
improves flexibility at each error construction site, while reducing the
complexity of the diagnostic creation.

This commit also rewords the diagnostics for clarity and style:

- Diagnostics should not end in periods.
- It's unnecessary to say "ignoring it". Since this is a warning by
  default, it's already clear that the link is ignored.

											
										
										
											2020-07-19 12:03:35 -05:00
+								//~^ ERROR `i`
-												properly calculate spans for intra-doc link resolution errors

											
										
										
											2018-11-14 18:14:31 -06:00
+								pub fn test_ice() {
 								    unimplemented!();
 								}