2020-02-08 23:00:49 -06:00
|
|
|
#![feature(test)] // compiletest_rs requires this attribute
|
2020-10-09 05:45:29 -05:00
|
|
|
#![feature(once_cell)]
|
2017-11-14 07:56:00 -06:00
|
|
|
|
2018-12-29 10:46:25 -06:00
|
|
|
use compiletest_rs as compiletest;
|
2020-02-01 04:04:04 -06:00
|
|
|
use compiletest_rs::common::Mode as TestMode;
|
2015-04-13 12:58:18 -05:00
|
|
|
|
2021-05-06 15:43:19 -05:00
|
|
|
use std::env::{self, remove_var, set_var, var_os};
|
|
|
|
use std::ffi::{OsStr, OsString};
|
2018-05-30 13:29:00 -05:00
|
|
|
use std::fs;
|
2018-06-07 12:16:50 -05:00
|
|
|
use std::io;
|
2018-05-22 03:21:42 -05:00
|
|
|
use std::path::{Path, PathBuf};
|
2015-04-13 12:58:18 -05:00
|
|
|
|
2020-02-01 04:04:04 -06:00
|
|
|
mod cargo;
|
2019-11-07 01:01:25 -06:00
|
|
|
|
2020-12-06 08:01:03 -06:00
|
|
|
// whether to run internal tests or not
|
|
|
|
const RUN_INTERNAL_TESTS: bool = cfg!(feature = "internal-lints");
|
|
|
|
|
2020-02-08 23:00:49 -06:00
|
|
|
fn host_lib() -> PathBuf {
|
2020-07-14 07:59:59 -05:00
|
|
|
option_env!("HOST_LIBS").map_or(cargo::CARGO_TARGET_DIR.join(env!("PROFILE")), PathBuf::from)
|
2017-11-14 07:56:00 -06:00
|
|
|
}
|
|
|
|
|
2020-02-08 23:00:49 -06:00
|
|
|
fn clippy_driver_path() -> PathBuf {
|
2020-07-14 07:59:59 -05:00
|
|
|
option_env!("CLIPPY_DRIVER_PATH").map_or(cargo::TARGET_LIB.join("clippy-driver"), PathBuf::from)
|
2020-02-08 23:00:49 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
// When we'll want to use `extern crate ..` for a dependency that is used
|
|
|
|
// both by the crate and the compiler itself, we can't simply pass -L flags
|
|
|
|
// as we'll get a duplicate matching versions. Instead, disambiguate with
|
|
|
|
// `--extern dep=path`.
|
|
|
|
// See https://github.com/rust-lang/rust-clippy/issues/4015.
|
|
|
|
//
|
|
|
|
// FIXME: We cannot use `cargo build --message-format=json` to resolve to dependency files.
|
|
|
|
// Because it would force-rebuild if the options passed to `build` command is not the same
|
|
|
|
// as what we manually pass to `cargo` invocation
|
|
|
|
fn third_party_crates() -> String {
|
|
|
|
use std::collections::HashMap;
|
2020-05-28 08:45:24 -05:00
|
|
|
static CRATES: &[&str] = &["serde", "serde_derive", "regex", "clippy_lints", "syn", "quote"];
|
2020-02-08 23:00:49 -06:00
|
|
|
let dep_dir = cargo::TARGET_LIB.join("deps");
|
|
|
|
let mut crates: HashMap<&str, PathBuf> = HashMap::with_capacity(CRATES.len());
|
|
|
|
for entry in fs::read_dir(dep_dir).unwrap() {
|
|
|
|
let path = match entry {
|
|
|
|
Ok(entry) => entry.path(),
|
2020-05-28 08:45:24 -05:00
|
|
|
Err(_) => continue,
|
2020-02-08 23:00:49 -06:00
|
|
|
};
|
|
|
|
if let Some(name) = path.file_name().and_then(OsStr::to_str) {
|
|
|
|
for dep in CRATES {
|
2021-01-30 11:06:34 -06:00
|
|
|
if name.starts_with(&format!("lib{}-", dep))
|
|
|
|
&& name.rsplit('.').next().map(|ext| ext.eq_ignore_ascii_case("rlib")) == Some(true)
|
|
|
|
{
|
2020-06-22 12:29:04 -05:00
|
|
|
if let Some(old) = crates.insert(dep, path.clone()) {
|
|
|
|
panic!("Found multiple rlibs for crate `{}`: `{:?}` and `{:?}", dep, old, path);
|
|
|
|
}
|
2020-02-08 23:00:49 -06:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
let v: Vec<_> = crates
|
|
|
|
.into_iter()
|
|
|
|
.map(|(dep, path)| format!("--extern {}={}", dep, path.display()))
|
|
|
|
.collect();
|
|
|
|
v.join(" ")
|
2017-11-14 07:56:00 -06:00
|
|
|
}
|
|
|
|
|
2020-02-01 04:04:04 -06:00
|
|
|
fn default_config() -> compiletest::Config {
|
2017-08-02 11:07:05 -05:00
|
|
|
let mut config = compiletest::Config::default();
|
2015-08-11 13:22:20 -05:00
|
|
|
|
2021-02-25 04:25:22 -06:00
|
|
|
if let Ok(filters) = env::var("TESTNAME") {
|
|
|
|
config.filters = filters.split(',').map(std::string::ToString::to_string).collect();
|
2015-08-11 13:22:20 -05:00
|
|
|
}
|
2015-04-13 12:58:18 -05:00
|
|
|
|
2020-02-08 23:00:49 -06:00
|
|
|
if let Some(path) = option_env!("RUSTC_LIB_PATH") {
|
|
|
|
let path = PathBuf::from(path);
|
2020-02-01 04:04:04 -06:00
|
|
|
config.run_lib_path = path.clone();
|
|
|
|
config.compile_lib_path = path;
|
2017-11-14 07:56:00 -06:00
|
|
|
}
|
2019-04-22 08:04:48 -05:00
|
|
|
|
2018-12-27 09:57:23 -06:00
|
|
|
config.target_rustcflags = Some(format!(
|
2020-10-09 05:45:29 -05:00
|
|
|
"--emit=metadata -L {0} -L {1} -Dwarnings -Zui-testing {2}",
|
2020-02-08 23:00:49 -06:00
|
|
|
host_lib().join("deps").display(),
|
|
|
|
cargo::TARGET_LIB.join("deps").display(),
|
|
|
|
third_party_crates(),
|
2018-12-27 09:57:23 -06:00
|
|
|
));
|
2017-11-14 07:56:00 -06:00
|
|
|
|
2021-04-14 08:20:49 -05:00
|
|
|
config.build_base = host_lib().join("test_build_base");
|
2020-02-08 23:00:49 -06:00
|
|
|
config.rustc_path = clippy_driver_path();
|
2017-11-14 07:56:00 -06:00
|
|
|
config
|
|
|
|
}
|
2015-04-13 12:58:18 -05:00
|
|
|
|
2021-05-06 15:43:19 -05:00
|
|
|
fn run_ui(cfg: &mut compiletest::Config) {
|
2020-02-01 04:04:04 -06:00
|
|
|
cfg.mode = TestMode::Ui;
|
|
|
|
cfg.src_base = Path::new("tests").join("ui");
|
2021-05-06 15:43:19 -05:00
|
|
|
// use tests/clippy.toml
|
|
|
|
let _g = VarGuard::set("CARGO_MANIFEST_DIR", std::fs::canonicalize("tests").unwrap());
|
2021-04-08 10:50:13 -05:00
|
|
|
compiletest::run_tests(cfg);
|
2018-05-30 13:29:00 -05:00
|
|
|
}
|
|
|
|
|
2020-12-06 08:01:03 -06:00
|
|
|
fn run_internal_tests(cfg: &mut compiletest::Config) {
|
|
|
|
// only run internal tests with the internal-tests feature
|
|
|
|
if !RUN_INTERNAL_TESTS {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
cfg.mode = TestMode::Ui;
|
|
|
|
cfg.src_base = Path::new("tests").join("ui-internal");
|
2021-04-08 10:50:13 -05:00
|
|
|
compiletest::run_tests(cfg);
|
2020-12-06 08:01:03 -06:00
|
|
|
}
|
|
|
|
|
2020-05-28 08:45:24 -05:00
|
|
|
fn run_ui_toml(config: &mut compiletest::Config) {
|
|
|
|
fn run_tests(config: &compiletest::Config, mut tests: Vec<tester::TestDescAndFn>) -> Result<bool, io::Error> {
|
|
|
|
let mut result = true;
|
|
|
|
let opts = compiletest::test_opts(config);
|
|
|
|
for dir in fs::read_dir(&config.src_base)? {
|
|
|
|
let dir = dir?;
|
|
|
|
if !dir.file_type()?.is_dir() {
|
2018-05-30 13:29:00 -05:00
|
|
|
continue;
|
|
|
|
}
|
2020-05-28 08:45:24 -05:00
|
|
|
let dir_path = dir.path();
|
2021-05-06 15:43:19 -05:00
|
|
|
let _g = VarGuard::set("CARGO_MANIFEST_DIR", &dir_path);
|
2020-05-28 08:45:24 -05:00
|
|
|
for file in fs::read_dir(&dir_path)? {
|
|
|
|
let file = file?;
|
|
|
|
let file_path = file.path();
|
|
|
|
if file.file_type()?.is_dir() {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if file_path.extension() != Some(OsStr::new("rs")) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
let paths = compiletest::common::TestPaths {
|
|
|
|
file: file_path,
|
|
|
|
base: config.src_base.clone(),
|
|
|
|
relative_dir: dir_path.file_name().unwrap().into(),
|
|
|
|
};
|
2021-04-08 10:50:13 -05:00
|
|
|
let test_name = compiletest::make_test_name(config, &paths);
|
2020-05-28 08:45:24 -05:00
|
|
|
let index = tests
|
|
|
|
.iter()
|
|
|
|
.position(|test| test.desc.name == test_name)
|
|
|
|
.expect("The test should be in there");
|
|
|
|
result &= tester::run_tests_console(&opts, vec![tests.swap_remove(index)])?;
|
2018-05-30 13:29:00 -05:00
|
|
|
}
|
2018-05-30 14:26:09 -05:00
|
|
|
}
|
2020-05-28 08:45:24 -05:00
|
|
|
Ok(result)
|
2018-05-30 14:26:09 -05:00
|
|
|
}
|
|
|
|
|
2020-02-01 04:04:04 -06:00
|
|
|
config.mode = TestMode::Ui;
|
|
|
|
config.src_base = Path::new("tests").join("ui-toml").canonicalize().unwrap();
|
|
|
|
|
2021-04-08 10:50:13 -05:00
|
|
|
let tests = compiletest::make_tests(config);
|
2018-05-30 14:26:09 -05:00
|
|
|
|
2021-04-08 10:50:13 -05:00
|
|
|
let res = run_tests(config, tests);
|
2020-05-28 08:45:24 -05:00
|
|
|
match res {
|
|
|
|
Ok(true) => {},
|
|
|
|
Ok(false) => panic!("Some tests failed"),
|
|
|
|
Err(e) => {
|
|
|
|
panic!("I/O failure during tests: {:?}", e);
|
|
|
|
},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn run_ui_cargo(config: &mut compiletest::Config) {
|
|
|
|
fn run_tests(
|
|
|
|
config: &compiletest::Config,
|
2021-02-25 04:25:22 -06:00
|
|
|
filters: &[String],
|
2020-05-28 08:45:24 -05:00
|
|
|
mut tests: Vec<tester::TestDescAndFn>,
|
|
|
|
) -> Result<bool, io::Error> {
|
|
|
|
let mut result = true;
|
|
|
|
let opts = compiletest::test_opts(config);
|
|
|
|
|
|
|
|
for dir in fs::read_dir(&config.src_base)? {
|
|
|
|
let dir = dir?;
|
|
|
|
if !dir.file_type()?.is_dir() {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Use the filter if provided
|
|
|
|
let dir_path = dir.path();
|
2021-02-25 04:25:22 -06:00
|
|
|
for filter in filters {
|
|
|
|
if !dir_path.ends_with(filter) {
|
|
|
|
continue;
|
|
|
|
}
|
2020-05-28 08:45:24 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
for case in fs::read_dir(&dir_path)? {
|
|
|
|
let case = case?;
|
|
|
|
if !case.file_type()?.is_dir() {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
let src_path = case.path().join("src");
|
|
|
|
|
2020-06-09 09:36:01 -05:00
|
|
|
// When switching between branches, if the previous branch had a test
|
|
|
|
// that the current branch does not have, the directory is not removed
|
|
|
|
// because an ignored Cargo.lock file exists.
|
|
|
|
if !src_path.exists() {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
env::set_current_dir(&src_path)?;
|
2020-05-28 08:45:24 -05:00
|
|
|
for file in fs::read_dir(&src_path)? {
|
|
|
|
let file = file?;
|
|
|
|
if file.file_type()?.is_dir() {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Search for the main file to avoid running a test for each file in the project
|
|
|
|
let file_path = file.path();
|
|
|
|
match file_path.file_name().and_then(OsStr::to_str) {
|
|
|
|
Some("main.rs") => {},
|
|
|
|
_ => continue,
|
|
|
|
}
|
2021-05-06 15:43:19 -05:00
|
|
|
let _g = VarGuard::set("CLIPPY_CONF_DIR", case.path());
|
2020-05-28 08:45:24 -05:00
|
|
|
let paths = compiletest::common::TestPaths {
|
|
|
|
file: file_path,
|
|
|
|
base: config.src_base.clone(),
|
|
|
|
relative_dir: src_path.strip_prefix(&config.src_base).unwrap().into(),
|
|
|
|
};
|
2021-04-08 10:50:13 -05:00
|
|
|
let test_name = compiletest::make_test_name(config, &paths);
|
2020-05-28 08:45:24 -05:00
|
|
|
let index = tests
|
|
|
|
.iter()
|
|
|
|
.position(|test| test.desc.name == test_name)
|
|
|
|
.expect("The test should be in there");
|
|
|
|
result &= tester::run_tests_console(&opts, vec![tests.swap_remove(index)])?;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
Ok(result)
|
|
|
|
}
|
|
|
|
|
2020-08-11 08:43:21 -05:00
|
|
|
if cargo::is_rustc_test_suite() {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-05-28 08:45:24 -05:00
|
|
|
config.mode = TestMode::Ui;
|
|
|
|
config.src_base = Path::new("tests").join("ui-cargo").canonicalize().unwrap();
|
|
|
|
|
2021-04-08 10:50:13 -05:00
|
|
|
let tests = compiletest::make_tests(config);
|
2020-05-28 08:45:24 -05:00
|
|
|
|
|
|
|
let current_dir = env::current_dir().unwrap();
|
2021-04-08 10:50:13 -05:00
|
|
|
let res = run_tests(config, &config.filters, tests);
|
2020-05-28 08:45:24 -05:00
|
|
|
env::set_current_dir(current_dir).unwrap();
|
|
|
|
|
2018-05-30 14:26:09 -05:00
|
|
|
match res {
|
2018-06-07 12:16:50 -05:00
|
|
|
Ok(true) => {},
|
2018-05-30 14:26:09 -05:00
|
|
|
Ok(false) => panic!("Some tests failed"),
|
|
|
|
Err(e) => {
|
2020-05-28 08:45:24 -05:00
|
|
|
panic!("I/O failure during tests: {:?}", e);
|
2018-06-07 12:16:50 -05:00
|
|
|
},
|
2018-05-30 13:29:00 -05:00
|
|
|
}
|
2015-04-13 12:58:18 -05:00
|
|
|
}
|
|
|
|
|
2016-06-05 14:05:28 -05:00
|
|
|
fn prepare_env() {
|
2017-09-01 03:29:49 -05:00
|
|
|
set_var("CLIPPY_DISABLE_DOCS_LINKS", "true");
|
2021-01-15 03:56:44 -06:00
|
|
|
set_var("__CLIPPY_INTERNAL_TESTS", "true");
|
2018-03-13 09:02:40 -05:00
|
|
|
//set_var("RUST_BACKTRACE", "0");
|
2016-06-05 14:05:28 -05:00
|
|
|
}
|
|
|
|
|
2015-04-13 12:58:18 -05:00
|
|
|
#[test]
|
|
|
|
fn compile_test() {
|
2016-06-05 14:05:28 -05:00
|
|
|
prepare_env();
|
2020-02-01 04:04:04 -06:00
|
|
|
let mut config = default_config();
|
2021-05-06 15:43:19 -05:00
|
|
|
run_ui(&mut config);
|
2020-02-01 04:04:04 -06:00
|
|
|
run_ui_toml(&mut config);
|
2020-05-28 08:45:24 -05:00
|
|
|
run_ui_cargo(&mut config);
|
2020-12-06 08:01:03 -06:00
|
|
|
run_internal_tests(&mut config);
|
2015-04-13 12:58:18 -05:00
|
|
|
}
|
2021-05-06 15:43:19 -05:00
|
|
|
|
|
|
|
/// Restores an env var on drop
|
|
|
|
#[must_use]
|
|
|
|
struct VarGuard {
|
|
|
|
key: &'static str,
|
|
|
|
value: Option<OsString>,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl VarGuard {
|
|
|
|
fn set(key: &'static str, val: impl AsRef<OsStr>) -> Self {
|
|
|
|
let value = var_os(key);
|
|
|
|
set_var(key, val);
|
|
|
|
Self { key, value }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Drop for VarGuard {
|
|
|
|
fn drop(&mut self) {
|
|
|
|
match self.value.as_deref() {
|
|
|
|
None => remove_var(self.key),
|
|
|
|
Some(value) => set_var(self.key, value),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|