2019-12-30 07:25:19 -06:00
|
|
|
//! An algorithm to find a path to refer to a certain item.
|
|
|
|
|
2019-12-30 10:31:15 -06:00
|
|
|
use crate::{
|
|
|
|
db::DefDatabase,
|
|
|
|
item_scope::ItemInNs,
|
|
|
|
path::{ModPath, PathKind},
|
2019-12-30 15:51:37 -06:00
|
|
|
visibility::Visibility,
|
|
|
|
CrateId, ModuleDefId, ModuleId,
|
2019-12-30 10:31:15 -06:00
|
|
|
};
|
2019-12-30 14:18:43 -06:00
|
|
|
use hir_expand::name::Name;
|
2019-12-30 07:25:19 -06:00
|
|
|
|
2019-12-30 16:08:40 -06:00
|
|
|
const MAX_PATH_LEN: usize = 15;
|
|
|
|
|
2019-12-30 14:18:43 -06:00
|
|
|
pub fn find_path(db: &impl DefDatabase, item: ItemInNs, from: ModuleId) -> Option<ModPath> {
|
2019-12-30 16:08:40 -06:00
|
|
|
find_path_inner(db, item, from, MAX_PATH_LEN)
|
2019-12-30 16:07:47 -06:00
|
|
|
}
|
|
|
|
|
2019-12-30 16:08:40 -06:00
|
|
|
fn find_path_inner(
|
|
|
|
db: &impl DefDatabase,
|
|
|
|
item: ItemInNs,
|
|
|
|
from: ModuleId,
|
|
|
|
max_len: usize,
|
|
|
|
) -> Option<ModPath> {
|
2019-12-30 16:07:47 -06:00
|
|
|
if max_len == 0 {
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
|
2019-12-30 16:08:40 -06:00
|
|
|
// Base cases:
|
|
|
|
|
2019-12-30 14:18:43 -06:00
|
|
|
// - if the item is already in scope, return the name under which it is
|
2019-12-30 10:31:15 -06:00
|
|
|
let def_map = db.crate_def_map(from.krate);
|
|
|
|
let from_scope: &crate::item_scope::ItemScope = &def_map.modules[from.local_id].scope;
|
|
|
|
if let Some((name, _)) = from_scope.reverse_get(item) {
|
2019-12-30 14:18:43 -06:00
|
|
|
return Some(ModPath::from_simple_segments(PathKind::Plain, vec![name.clone()]));
|
|
|
|
}
|
|
|
|
|
|
|
|
// - if the item is the crate root, return `crate`
|
2019-12-30 15:51:37 -06:00
|
|
|
if item
|
|
|
|
== ItemInNs::Types(ModuleDefId::ModuleId(ModuleId {
|
|
|
|
krate: from.krate,
|
|
|
|
local_id: def_map.root,
|
|
|
|
}))
|
|
|
|
{
|
2019-12-30 14:18:43 -06:00
|
|
|
return Some(ModPath::from_simple_segments(PathKind::Crate, Vec::new()));
|
|
|
|
}
|
|
|
|
|
2019-12-30 15:40:50 -06:00
|
|
|
// - if the item is the parent module, use `super` (this is not used recursively, since `super::super` is ugly)
|
|
|
|
if let Some(parent_id) = def_map.modules[from.local_id].parent {
|
2019-12-30 15:51:37 -06:00
|
|
|
if item
|
|
|
|
== ItemInNs::Types(ModuleDefId::ModuleId(ModuleId {
|
|
|
|
krate: from.krate,
|
|
|
|
local_id: parent_id,
|
|
|
|
}))
|
|
|
|
{
|
2019-12-30 15:40:50 -06:00
|
|
|
return Some(ModPath::from_simple_segments(PathKind::Super(1), Vec::new()));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-12-30 14:18:43 -06:00
|
|
|
// - if the item is the crate root of a dependency crate, return the name from the extern prelude
|
|
|
|
for (name, def_id) in &def_map.extern_prelude {
|
|
|
|
if item == ItemInNs::Types(*def_id) {
|
|
|
|
return Some(ModPath::from_simple_segments(PathKind::Plain, vec![name.clone()]));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// - if the item is in the prelude, return the name from there
|
2019-12-30 14:33:25 -06:00
|
|
|
if let Some(prelude_module) = def_map.prelude {
|
|
|
|
let prelude_def_map = db.crate_def_map(prelude_module.krate);
|
2019-12-30 15:51:37 -06:00
|
|
|
let prelude_scope: &crate::item_scope::ItemScope =
|
|
|
|
&prelude_def_map.modules[prelude_module.local_id].scope;
|
2019-12-30 14:33:25 -06:00
|
|
|
if let Some((name, vis)) = prelude_scope.reverse_get(item) {
|
|
|
|
if vis.is_visible_from(db, from) {
|
|
|
|
return Some(ModPath::from_simple_segments(PathKind::Plain, vec![name.clone()]));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-12-30 14:18:43 -06:00
|
|
|
|
|
|
|
// Recursive case:
|
|
|
|
// - if the item is an enum variant, refer to it via the enum
|
2019-12-30 14:33:25 -06:00
|
|
|
if let Some(ModuleDefId::EnumVariantId(variant)) = item.as_module_def_id() {
|
|
|
|
if let Some(mut path) = find_path(db, ItemInNs::Types(variant.parent.into()), from) {
|
|
|
|
let data = db.enum_data(variant.parent);
|
|
|
|
path.segments.push(data.variants[variant.local_id].name.clone());
|
|
|
|
return Some(path);
|
|
|
|
}
|
|
|
|
// If this doesn't work, it seems we have no way of referring to the
|
|
|
|
// enum; that's very weird, but there might still be a reexport of the
|
|
|
|
// variant somewhere
|
|
|
|
}
|
2019-12-30 14:18:43 -06:00
|
|
|
|
|
|
|
// - otherwise, look for modules containing (reexporting) it and import it from one of those
|
|
|
|
let importable_locations = find_importable_locations(db, item, from);
|
2019-12-30 16:07:47 -06:00
|
|
|
let mut best_path = None;
|
|
|
|
let mut best_path_len = max_len;
|
2019-12-30 14:18:43 -06:00
|
|
|
for (module_id, name) in importable_locations {
|
2019-12-30 16:08:40 -06:00
|
|
|
let mut path = match find_path_inner(
|
|
|
|
db,
|
|
|
|
ItemInNs::Types(ModuleDefId::ModuleId(module_id)),
|
|
|
|
from,
|
|
|
|
best_path_len - 1,
|
|
|
|
) {
|
2019-12-30 14:18:43 -06:00
|
|
|
None => continue,
|
|
|
|
Some(path) => path,
|
|
|
|
};
|
|
|
|
path.segments.push(name);
|
2019-12-30 16:07:47 -06:00
|
|
|
if path_len(&path) < best_path_len {
|
|
|
|
best_path_len = path_len(&path);
|
|
|
|
best_path = Some(path);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
best_path
|
|
|
|
}
|
|
|
|
|
|
|
|
fn path_len(path: &ModPath) -> usize {
|
2019-12-30 16:08:40 -06:00
|
|
|
path.segments.len()
|
|
|
|
+ match path.kind {
|
|
|
|
PathKind::Plain => 0,
|
|
|
|
PathKind::Super(i) => i as usize,
|
|
|
|
PathKind::Crate => 1,
|
|
|
|
PathKind::Abs => 0,
|
|
|
|
PathKind::DollarCrate(_) => 1,
|
|
|
|
}
|
2019-12-30 14:18:43 -06:00
|
|
|
}
|
|
|
|
|
2019-12-30 15:51:37 -06:00
|
|
|
fn find_importable_locations(
|
|
|
|
db: &impl DefDatabase,
|
|
|
|
item: ItemInNs,
|
|
|
|
from: ModuleId,
|
|
|
|
) -> Vec<(ModuleId, Name)> {
|
2019-12-30 14:18:43 -06:00
|
|
|
let crate_graph = db.crate_graph();
|
|
|
|
let mut result = Vec::new();
|
2019-12-30 16:07:47 -06:00
|
|
|
// We only look in the crate from which we are importing, and the direct
|
|
|
|
// dependencies. We cannot refer to names from transitive dependencies
|
|
|
|
// directly (only through reexports in direct dependencies).
|
2019-12-30 15:51:37 -06:00
|
|
|
for krate in Some(from.krate)
|
|
|
|
.into_iter()
|
|
|
|
.chain(crate_graph.dependencies(from.krate).map(|dep| dep.crate_id))
|
|
|
|
{
|
|
|
|
result.extend(
|
|
|
|
db.importable_locations_in_crate(item, krate)
|
|
|
|
.iter()
|
|
|
|
.filter(|(_, _, vis)| vis.is_visible_from(db, from))
|
|
|
|
.map(|(m, n, _)| (*m, n.clone())),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
result
|
|
|
|
}
|
|
|
|
|
2019-12-30 16:07:47 -06:00
|
|
|
/// Collects all locations from which we might import the item in a particular
|
|
|
|
/// crate. These include the original definition of the item, and any
|
|
|
|
/// non-private `use`s.
|
|
|
|
///
|
|
|
|
/// Note that the crate doesn't need to be the one in which the item is defined;
|
|
|
|
/// it might be re-exported in other crates. We cache this as a query since we
|
|
|
|
/// need to walk the whole def map for it.
|
2019-12-30 15:51:37 -06:00
|
|
|
pub(crate) fn importable_locations_in_crate_query(
|
|
|
|
db: &impl DefDatabase,
|
|
|
|
item: ItemInNs,
|
|
|
|
krate: CrateId,
|
|
|
|
) -> std::sync::Arc<[(ModuleId, Name, Visibility)]> {
|
|
|
|
let def_map = db.crate_def_map(krate);
|
|
|
|
let mut result = Vec::new();
|
|
|
|
for (local_id, data) in def_map.modules.iter() {
|
|
|
|
if let Some((name, vis)) = data.scope.reverse_get(item) {
|
|
|
|
let is_private = if let Visibility::Module(private_to) = vis {
|
|
|
|
private_to.local_id == local_id
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
};
|
|
|
|
let is_original_def = if let Some(module_def_id) = item.as_module_def_id() {
|
|
|
|
data.scope.declarations().any(|it| it == module_def_id)
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
};
|
|
|
|
if is_private && !is_original_def {
|
|
|
|
// Ignore private imports. these could be used if we are
|
|
|
|
// in a submodule of this module, but that's usually not
|
|
|
|
// what the user wants; and if this module can import
|
|
|
|
// the item and we're a submodule of it, so can we.
|
|
|
|
// Also this keeps the cached data smaller.
|
|
|
|
continue;
|
2019-12-30 14:18:43 -06:00
|
|
|
}
|
2019-12-30 15:51:37 -06:00
|
|
|
result.push((ModuleId { krate, local_id }, name.clone(), vis));
|
2019-12-30 14:18:43 -06:00
|
|
|
}
|
2019-12-30 10:31:15 -06:00
|
|
|
}
|
2019-12-30 15:51:37 -06:00
|
|
|
result.into()
|
2019-12-30 07:25:19 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use super::*;
|
2019-12-30 10:31:15 -06:00
|
|
|
use crate::test_db::TestDB;
|
2019-12-30 07:25:19 -06:00
|
|
|
use hir_expand::hygiene::Hygiene;
|
2019-12-30 10:31:15 -06:00
|
|
|
use ra_db::fixture::WithFixture;
|
|
|
|
use ra_syntax::ast::AstNode;
|
2019-12-30 07:25:19 -06:00
|
|
|
|
|
|
|
/// `code` needs to contain a cursor marker; checks that `find_path` for the
|
|
|
|
/// item the `path` refers to returns that same path when called from the
|
|
|
|
/// module the cursor is in.
|
|
|
|
fn check_found_path(code: &str, path: &str) {
|
|
|
|
let (db, pos) = TestDB::with_position(code);
|
|
|
|
let module = db.module_for_file(pos.file_id);
|
|
|
|
let parsed_path_file = ra_syntax::SourceFile::parse(&format!("use {};", path));
|
2019-12-30 10:31:15 -06:00
|
|
|
let ast_path = parsed_path_file
|
|
|
|
.syntax_node()
|
|
|
|
.descendants()
|
|
|
|
.find_map(ra_syntax::ast::Path::cast)
|
|
|
|
.unwrap();
|
2019-12-30 07:25:19 -06:00
|
|
|
let mod_path = ModPath::from_src(ast_path, &Hygiene::new_unhygienic()).unwrap();
|
|
|
|
|
|
|
|
let crate_def_map = db.crate_def_map(module.krate);
|
2019-12-30 10:31:15 -06:00
|
|
|
let resolved = crate_def_map
|
|
|
|
.resolve_path(
|
|
|
|
&db,
|
|
|
|
module.local_id,
|
|
|
|
&mod_path,
|
|
|
|
crate::item_scope::BuiltinShadowMode::Module,
|
|
|
|
)
|
|
|
|
.0
|
|
|
|
.take_types()
|
|
|
|
.unwrap();
|
2019-12-30 07:25:19 -06:00
|
|
|
|
2019-12-30 10:31:15 -06:00
|
|
|
let found_path = find_path(&db, ItemInNs::Types(resolved), module);
|
2019-12-30 07:25:19 -06:00
|
|
|
|
2019-12-30 14:18:43 -06:00
|
|
|
assert_eq!(found_path, Some(mod_path));
|
2019-12-30 07:25:19 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn same_module() {
|
|
|
|
let code = r#"
|
2019-12-30 10:31:15 -06:00
|
|
|
//- /main.rs
|
|
|
|
struct S;
|
|
|
|
<|>
|
|
|
|
"#;
|
2019-12-30 07:25:19 -06:00
|
|
|
check_found_path(code, "S");
|
|
|
|
}
|
2019-12-30 10:31:15 -06:00
|
|
|
|
2019-12-30 14:33:25 -06:00
|
|
|
#[test]
|
|
|
|
fn enum_variant() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
enum E { A }
|
|
|
|
<|>
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "E::A");
|
|
|
|
}
|
|
|
|
|
2019-12-30 10:31:15 -06:00
|
|
|
#[test]
|
|
|
|
fn sub_module() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
mod foo {
|
|
|
|
pub struct S;
|
|
|
|
}
|
|
|
|
<|>
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "foo::S");
|
|
|
|
}
|
|
|
|
|
2019-12-30 15:40:50 -06:00
|
|
|
#[test]
|
|
|
|
fn super_module() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
mod foo;
|
|
|
|
//- /foo.rs
|
|
|
|
mod bar;
|
|
|
|
struct S;
|
|
|
|
//- /foo/bar.rs
|
|
|
|
<|>
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "super::S");
|
|
|
|
}
|
|
|
|
|
2019-12-30 14:18:43 -06:00
|
|
|
#[test]
|
|
|
|
fn crate_root() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
mod foo;
|
|
|
|
//- /foo.rs
|
|
|
|
<|>
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "crate");
|
|
|
|
}
|
|
|
|
|
2019-12-30 10:31:15 -06:00
|
|
|
#[test]
|
|
|
|
fn same_crate() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
mod foo;
|
|
|
|
struct S;
|
|
|
|
//- /foo.rs
|
|
|
|
<|>
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "crate::S");
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn different_crate() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs crate:main deps:std
|
|
|
|
<|>
|
|
|
|
//- /std.rs crate:std
|
|
|
|
pub struct S;
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "std::S");
|
|
|
|
}
|
|
|
|
|
2019-12-30 14:18:43 -06:00
|
|
|
#[test]
|
|
|
|
fn different_crate_renamed() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs crate:main deps:std
|
|
|
|
extern crate std as std_renamed;
|
|
|
|
<|>
|
|
|
|
//- /std.rs crate:std
|
|
|
|
pub struct S;
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "std_renamed::S");
|
|
|
|
}
|
|
|
|
|
2019-12-30 10:31:15 -06:00
|
|
|
#[test]
|
|
|
|
fn same_crate_reexport() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
mod bar {
|
|
|
|
mod foo { pub(super) struct S; }
|
|
|
|
pub(crate) use foo::*;
|
|
|
|
}
|
|
|
|
<|>
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "bar::S");
|
|
|
|
}
|
2019-12-30 14:18:43 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn same_crate_reexport_rename() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
mod bar {
|
|
|
|
mod foo { pub(super) struct S; }
|
|
|
|
pub(crate) use foo::S as U;
|
|
|
|
}
|
|
|
|
<|>
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "bar::U");
|
|
|
|
}
|
|
|
|
|
2019-12-30 14:33:25 -06:00
|
|
|
#[test]
|
|
|
|
fn different_crate_reexport() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs crate:main deps:std
|
|
|
|
<|>
|
|
|
|
//- /std.rs crate:std deps:core
|
|
|
|
pub use core::S;
|
|
|
|
//- /core.rs crate:core
|
|
|
|
pub struct S;
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "std::S");
|
|
|
|
}
|
|
|
|
|
2019-12-30 14:18:43 -06:00
|
|
|
#[test]
|
|
|
|
fn prelude() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs crate:main deps:std
|
|
|
|
<|>
|
|
|
|
//- /std.rs crate:std
|
|
|
|
pub mod prelude { pub struct S; }
|
|
|
|
#[prelude_import]
|
|
|
|
pub use prelude::*;
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "S");
|
|
|
|
}
|
2019-12-30 14:33:25 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn enum_variant_from_prelude() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs crate:main deps:std
|
|
|
|
<|>
|
|
|
|
//- /std.rs crate:std
|
|
|
|
pub mod prelude {
|
|
|
|
pub enum Option<T> { Some(T), None }
|
|
|
|
pub use Option::*;
|
|
|
|
}
|
|
|
|
#[prelude_import]
|
|
|
|
pub use prelude::*;
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "None");
|
|
|
|
check_found_path(code, "Some");
|
|
|
|
}
|
2019-12-30 15:22:12 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn shortest_path() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
pub mod foo;
|
|
|
|
pub mod baz;
|
|
|
|
struct S;
|
|
|
|
<|>
|
|
|
|
//- /foo.rs
|
|
|
|
pub mod bar { pub struct S; }
|
|
|
|
//- /baz.rs
|
|
|
|
pub use crate::foo::bar::S;
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "baz::S");
|
|
|
|
}
|
2019-12-30 15:40:50 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn discount_private_imports() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
mod foo;
|
|
|
|
pub mod bar { pub struct S; }
|
|
|
|
use bar::S;
|
|
|
|
//- /foo.rs
|
|
|
|
<|>
|
|
|
|
"#;
|
|
|
|
// crate::S would be shorter, but using private imports seems wrong
|
|
|
|
check_found_path(code, "crate::bar::S");
|
|
|
|
}
|
2019-12-30 16:07:47 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn import_cycle() {
|
|
|
|
let code = r#"
|
|
|
|
//- /main.rs
|
|
|
|
pub mod foo;
|
|
|
|
pub mod bar;
|
|
|
|
pub mod baz;
|
|
|
|
//- /bar.rs
|
|
|
|
<|>
|
|
|
|
//- /foo.rs
|
|
|
|
pub use super::baz;
|
|
|
|
pub struct S;
|
|
|
|
//- /baz.rs
|
|
|
|
pub use super::foo;
|
|
|
|
"#;
|
|
|
|
check_found_path(code, "crate::foo::S");
|
|
|
|
}
|
2019-12-30 07:25:19 -06:00
|
|
|
}
|