2023-04-20 09:37:15 -05:00
|
|
|
//@run-rustfix
|
2019-08-05 15:05:05 -05:00
|
|
|
|
2018-10-28 09:37:39 -05:00
|
|
|
#![warn(clippy::needless_bool)]
|
2019-08-05 15:05:05 -05:00
|
|
|
#![allow(
|
|
|
|
unused,
|
|
|
|
dead_code,
|
|
|
|
clippy::no_effect,
|
|
|
|
clippy::if_same_then_else,
|
2021-10-04 01:33:40 -05:00
|
|
|
clippy::equatable_if_let,
|
2023-06-10 06:43:30 -05:00
|
|
|
clippy::needless_if,
|
2021-06-25 15:34:45 -05:00
|
|
|
clippy::needless_return,
|
2021-07-29 05:10:18 -05:00
|
|
|
clippy::self_named_constructors
|
2019-08-05 15:05:05 -05:00
|
|
|
)]
|
2018-10-11 05:16:22 -05:00
|
|
|
|
2018-10-28 09:37:39 -05:00
|
|
|
use std::cell::Cell;
|
2017-09-18 05:47:33 -05:00
|
|
|
|
2018-10-28 09:37:39 -05:00
|
|
|
macro_rules! bool_comparison_trigger {
|
|
|
|
($($i:ident: $def:expr, $stb:expr );+ $(;)*) => (
|
|
|
|
|
|
|
|
#[derive(Clone)]
|
|
|
|
pub struct Trigger {
|
|
|
|
$($i: (Cell<bool>, bool, bool)),+
|
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
impl Trigger {
|
|
|
|
pub fn trigger(&self, key: &str) -> bool {
|
|
|
|
$(
|
|
|
|
if let stringify!($i) = key {
|
|
|
|
return self.$i.1 && self.$i.2 == $def;
|
|
|
|
}
|
|
|
|
)+
|
|
|
|
false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
)
|
|
|
|
}
|
2017-09-18 05:47:33 -05:00
|
|
|
|
2015-05-01 17:35:49 -05:00
|
|
|
fn main() {
|
2015-08-11 13:22:20 -05:00
|
|
|
let x = true;
|
2016-07-03 18:17:31 -05:00
|
|
|
let y = false;
|
2019-08-05 15:05:05 -05:00
|
|
|
x;
|
|
|
|
!x;
|
|
|
|
!(x && y);
|
2021-12-14 06:27:55 -06:00
|
|
|
let a = 0;
|
|
|
|
let b = 1;
|
|
|
|
|
|
|
|
a != b;
|
|
|
|
a == b;
|
|
|
|
a >= b;
|
|
|
|
a > b;
|
|
|
|
a <= b;
|
|
|
|
a < b;
|
2018-12-09 16:26:16 -06:00
|
|
|
if x {
|
|
|
|
x
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}; // would also be questionable, but we don't catch this yet
|
2016-03-14 10:41:41 -05:00
|
|
|
bool_ret3(x);
|
|
|
|
bool_ret4(x);
|
2019-08-05 15:05:05 -05:00
|
|
|
bool_ret5(x, x);
|
2016-07-03 18:17:31 -05:00
|
|
|
bool_ret6(x, x);
|
2018-10-28 09:37:39 -05:00
|
|
|
needless_bool(x);
|
|
|
|
needless_bool2(x);
|
|
|
|
needless_bool3(x);
|
2021-12-02 15:47:57 -06:00
|
|
|
needless_bool_condition();
|
2023-05-10 14:06:36 -05:00
|
|
|
|
|
|
|
if a == b {
|
|
|
|
true
|
|
|
|
} else {
|
|
|
|
// Do not lint as this comment might be important
|
|
|
|
false
|
|
|
|
};
|
2016-03-14 10:41:41 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn bool_ret3(x: bool) -> bool {
|
2019-08-05 15:05:05 -05:00
|
|
|
return x;
|
2016-07-03 18:17:31 -05:00
|
|
|
}
|
|
|
|
|
2019-08-05 15:05:05 -05:00
|
|
|
fn bool_ret4(x: bool) -> bool {
|
|
|
|
return !x;
|
2016-03-14 10:41:41 -05:00
|
|
|
}
|
|
|
|
|
2019-08-05 15:05:05 -05:00
|
|
|
fn bool_ret5(x: bool, y: bool) -> bool {
|
|
|
|
return x && y;
|
2016-07-03 18:17:31 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn bool_ret6(x: bool, y: bool) -> bool {
|
2019-08-05 15:05:05 -05:00
|
|
|
return !(x && y);
|
2015-05-01 17:35:49 -05:00
|
|
|
}
|
2018-10-28 09:37:39 -05:00
|
|
|
|
|
|
|
fn needless_bool(x: bool) {
|
2019-08-05 15:05:05 -05:00
|
|
|
if x {};
|
2018-10-28 09:37:39 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn needless_bool2(x: bool) {
|
2019-08-05 15:05:05 -05:00
|
|
|
if !x {};
|
2018-10-28 09:37:39 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn needless_bool3(x: bool) {
|
|
|
|
bool_comparison_trigger! {
|
|
|
|
test_one: false, false;
|
|
|
|
test_three: false, false;
|
|
|
|
test_two: true, true;
|
|
|
|
}
|
2018-12-09 16:26:16 -06:00
|
|
|
|
2019-08-05 15:05:05 -05:00
|
|
|
if x {};
|
|
|
|
if !x {};
|
2018-10-28 10:28:17 -05:00
|
|
|
}
|
2019-01-20 09:15:00 -06:00
|
|
|
|
|
|
|
fn needless_bool_in_the_suggestion_wraps_the_predicate_of_if_else_statement_in_brackets() {
|
|
|
|
let b = false;
|
|
|
|
let returns_bool = || false;
|
|
|
|
|
|
|
|
let x = if b {
|
|
|
|
true
|
2019-08-05 15:05:05 -05:00
|
|
|
} else { !returns_bool() };
|
2019-01-20 09:15:00 -06:00
|
|
|
}
|
2021-12-02 15:47:57 -06:00
|
|
|
|
|
|
|
unsafe fn no(v: u8) -> u8 {
|
|
|
|
v
|
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(clippy::unnecessary_operation)]
|
|
|
|
fn needless_bool_condition() -> bool {
|
|
|
|
(unsafe { no(4) } & 1 != 0);
|
|
|
|
let _brackets_unneeded = unsafe { no(4) } & 1 != 0;
|
|
|
|
fn foo() -> bool {
|
|
|
|
// parentheses are needed here
|
|
|
|
(unsafe { no(4) } & 1 != 0)
|
|
|
|
}
|
|
|
|
|
|
|
|
foo()
|
|
|
|
}
|