rust/clippy_lints/src/exit.rs

48 lines
1.8 KiB
Rust
Raw Normal View History

2019-10-21 15:55:01 -05:00
use crate::utils::{is_entrypoint_fn, match_def_path, paths, qpath_res, span_lint};
2019-10-18 14:09:42 -05:00
use if_chain::if_chain;
2020-01-11 05:37:08 -06:00
use rustc::lint::{LateContext, LateLintPass};
2020-01-06 10:39:50 -06:00
use rustc_hir::{Expr, ExprKind, Item, ItemKind, Node};
2020-01-11 05:37:08 -06:00
use rustc_session::{declare_lint_pass, declare_tool_lint};
2019-10-18 14:09:42 -05:00
declare_clippy_lint! {
/// **What it does:** `exit()` terminates the program and doesn't provide a
/// stack trace.
///
/// **Why is this bad?** Ideally a program is terminated by finishing
/// the main function.
///
2019-10-19 07:31:02 -05:00
/// **Known problems:** None.
2019-10-18 14:09:42 -05:00
///
/// **Example:**
/// ```ignore
/// std::process::exit(0)
/// ```
pub EXIT,
restriction,
"`std::process::exit` is called, terminating the program"
}
declare_lint_pass!(Exit => [EXIT]);
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Exit {
2019-12-27 01:12:26 -06:00
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr<'_>) {
2019-10-18 14:09:42 -05:00
if_chain! {
if let ExprKind::Call(ref path_expr, ref _args) = e.kind;
if let ExprKind::Path(ref path) = path_expr.kind;
if let Some(def_id) = qpath_res(cx, path, path_expr.hir_id).opt_def_id();
if match_def_path(cx, def_id, &paths::EXIT);
then {
2019-11-07 21:16:43 -06:00
let parent = cx.tcx.hir().get_parent_item(e.hir_id);
if let Some(Node::Item(Item{kind: ItemKind::Fn(..), ..})) = cx.tcx.hir().find(parent) {
2019-10-24 14:17:21 -05:00
// If the next item up is a function we check if it is an entry point
// and only then emit a linter warning
let def_id = cx.tcx.hir().local_def_id(parent);
if !is_entrypoint_fn(cx, def_id) {
span_lint(cx, EXIT, e.span, "usage of `process::exit`");
2019-10-19 07:31:02 -05:00
}
}
2019-10-18 14:09:42 -05:00
}
}
}
}