2019-09-25 05:28:19 -07:00
|
|
|
// run-rustfix
|
|
|
|
|
2022-06-25 14:16:31 +02:00
|
|
|
#![feature(lint_reasons)]
|
2021-09-18 09:40:16 -05:00
|
|
|
#![feature(let_else)]
|
2021-02-25 23:33:46 +01:00
|
|
|
#![allow(unused)]
|
2021-10-04 10:03:40 +03:30
|
|
|
#![allow(
|
|
|
|
clippy::if_same_then_else,
|
|
|
|
clippy::single_match,
|
|
|
|
clippy::needless_bool,
|
|
|
|
clippy::equatable_if_let
|
|
|
|
)]
|
2018-07-28 17:34:52 +02:00
|
|
|
#![warn(clippy::needless_return)]
|
2015-08-11 18:55:07 +02:00
|
|
|
|
2022-06-18 16:36:47 +00:00
|
|
|
use std::cell::RefCell;
|
|
|
|
|
2019-06-19 14:56:02 +02:00
|
|
|
macro_rules! the_answer {
|
2019-06-20 13:44:00 +02:00
|
|
|
() => {
|
|
|
|
42
|
|
|
|
};
|
2019-06-19 14:56:02 +02:00
|
|
|
}
|
|
|
|
|
2015-08-11 18:55:07 +02:00
|
|
|
fn test_end_of_fn() -> bool {
|
|
|
|
if true {
|
|
|
|
// no error!
|
|
|
|
return true;
|
|
|
|
}
|
2015-12-11 16:28:05 +09:00
|
|
|
return true;
|
2015-08-11 18:55:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
fn test_no_semicolon() -> bool {
|
2018-12-09 23:26:16 +01:00
|
|
|
return true;
|
2015-08-11 18:55:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
fn test_if_block() -> bool {
|
|
|
|
if true {
|
2016-06-07 18:33:11 +02:00
|
|
|
return true;
|
2015-08-11 18:55:07 +02:00
|
|
|
} else {
|
2016-06-07 18:33:11 +02:00
|
|
|
return false;
|
2015-08-11 18:55:07 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_match(x: bool) -> bool {
|
|
|
|
match x {
|
2016-07-14 18:32:09 +02:00
|
|
|
true => return false,
|
2015-08-11 18:55:07 +02:00
|
|
|
false => {
|
2016-06-07 18:33:11 +02:00
|
|
|
return true;
|
2018-12-09 23:26:16 +01:00
|
|
|
},
|
2015-08-11 18:55:07 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_closure() {
|
|
|
|
let _ = || {
|
2016-06-07 18:33:11 +02:00
|
|
|
return true;
|
2015-08-11 18:55:07 +02:00
|
|
|
};
|
2017-01-15 13:16:02 +09:00
|
|
|
let _ = || return true;
|
2015-08-11 18:55:07 +02:00
|
|
|
}
|
|
|
|
|
2019-06-19 14:56:02 +02:00
|
|
|
fn test_macro_call() -> i32 {
|
|
|
|
return the_answer!();
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_void_fun() {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_void_if_fun(b: bool) {
|
|
|
|
if b {
|
|
|
|
return;
|
|
|
|
} else {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-20 13:44:00 +02:00
|
|
|
fn test_void_match(x: u32) {
|
|
|
|
match x {
|
|
|
|
0 => (),
|
|
|
|
_ => return,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-12-28 11:15:53 +00:00
|
|
|
fn test_nested_match(x: u32) {
|
|
|
|
match x {
|
|
|
|
0 => (),
|
|
|
|
1 => {
|
|
|
|
let _ = 42;
|
|
|
|
return;
|
|
|
|
},
|
|
|
|
_ => return,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-06-18 16:36:47 +00:00
|
|
|
fn temporary_outlives_local() -> String {
|
|
|
|
let x = RefCell::<String>::default();
|
|
|
|
return x.borrow().clone();
|
2020-08-28 16:10:16 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
fn borrows_but_not_last(value: bool) -> String {
|
|
|
|
if value {
|
2022-06-18 16:36:47 +00:00
|
|
|
let x = RefCell::<String>::default();
|
|
|
|
let _a = x.borrow().clone();
|
2020-08-28 16:10:16 +02:00
|
|
|
return String::from("test");
|
|
|
|
} else {
|
|
|
|
return String::new();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-01-15 10:41:29 +01:00
|
|
|
macro_rules! needed_return {
|
|
|
|
($e:expr) => {
|
|
|
|
if $e > 3 {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_return_in_macro() {
|
|
|
|
// This will return and the macro below won't be executed. Removing the `return` from the macro
|
|
|
|
// will change semantics.
|
|
|
|
needed_return!(10);
|
|
|
|
needed_return!(0);
|
|
|
|
}
|
|
|
|
|
2021-01-04 21:20:44 +01:00
|
|
|
mod issue6501 {
|
2021-08-17 16:22:48 -04:00
|
|
|
#[allow(clippy::unnecessary_lazy_evaluations)]
|
2021-01-04 21:20:44 +01:00
|
|
|
fn foo(bar: Result<(), ()>) {
|
|
|
|
bar.unwrap_or_else(|_| return)
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_closure() {
|
|
|
|
let _ = || {
|
|
|
|
return;
|
|
|
|
};
|
|
|
|
let _ = || return;
|
|
|
|
}
|
2021-01-18 22:33:25 +01:00
|
|
|
|
|
|
|
struct Foo;
|
|
|
|
#[allow(clippy::unnecessary_lazy_evaluations)]
|
|
|
|
fn bar(res: Result<Foo, u8>) -> Foo {
|
|
|
|
res.unwrap_or_else(|_| return Foo)
|
|
|
|
}
|
2021-01-04 21:20:44 +01:00
|
|
|
}
|
|
|
|
|
2021-04-12 21:37:19 +09:00
|
|
|
async fn async_test_end_of_fn() -> bool {
|
|
|
|
if true {
|
|
|
|
// no error!
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_no_semicolon() -> bool {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_if_block() -> bool {
|
|
|
|
if true {
|
|
|
|
return true;
|
|
|
|
} else {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_match(x: bool) -> bool {
|
|
|
|
match x {
|
|
|
|
true => return false,
|
|
|
|
false => {
|
|
|
|
return true;
|
|
|
|
},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_closure() {
|
|
|
|
let _ = || {
|
|
|
|
return true;
|
|
|
|
};
|
|
|
|
let _ = || return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_macro_call() -> i32 {
|
|
|
|
return the_answer!();
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_void_fun() {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_void_if_fun(b: bool) {
|
|
|
|
if b {
|
|
|
|
return;
|
|
|
|
} else {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_void_match(x: u32) {
|
|
|
|
match x {
|
|
|
|
0 => (),
|
|
|
|
_ => return,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-06-18 16:36:47 +00:00
|
|
|
async fn async_temporary_outlives_local() -> String {
|
|
|
|
let x = RefCell::<String>::default();
|
|
|
|
return x.borrow().clone();
|
2021-04-12 21:37:19 +09:00
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_borrows_but_not_last(value: bool) -> String {
|
|
|
|
if value {
|
2022-06-18 16:36:47 +00:00
|
|
|
let x = RefCell::<String>::default();
|
|
|
|
let _a = x.borrow().clone();
|
2021-04-12 21:37:19 +09:00
|
|
|
return String::from("test");
|
|
|
|
} else {
|
|
|
|
return String::new();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_return_in_macro() {
|
|
|
|
needed_return!(10);
|
|
|
|
needed_return!(0);
|
|
|
|
}
|
|
|
|
|
2021-09-18 09:40:16 -05:00
|
|
|
fn let_else() {
|
|
|
|
let Some(1) = Some(1) else { return };
|
|
|
|
}
|
|
|
|
|
2022-06-02 20:16:46 +08:00
|
|
|
fn needless_return_macro() -> String {
|
|
|
|
let _ = "foo";
|
|
|
|
let _ = "bar";
|
|
|
|
return format!("Hello {}", "world!");
|
|
|
|
}
|
|
|
|
|
2022-06-25 14:16:31 +02:00
|
|
|
fn check_expect() -> bool {
|
|
|
|
if true {
|
|
|
|
// no error!
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
#[expect(clippy::needless_return)]
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2021-04-12 21:58:34 +09:00
|
|
|
fn main() {}
|