2020-01-06 00:36:33 -06:00
|
|
|
error: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
|
2024-02-19 07:53:53 -06:00
|
|
|
--> tests/ui/blocks_in_conditions.rs:30:5
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2020-02-04 09:08:39 -06:00
|
|
|
LL | / if {
|
2023-11-30 01:41:54 -06:00
|
|
|
LL | |
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | let x = 3;
|
|
|
|
LL | | x == 3
|
|
|
|
LL | | } {
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2023-11-30 01:41:54 -06:00
|
|
|
= note: `-D clippy::blocks-in-conditions` implied by `-D warnings`
|
|
|
|
= help: to override `-D warnings` add `#[allow(clippy::blocks_in_conditions)]`
|
2020-02-04 09:08:39 -06:00
|
|
|
help: try
|
|
|
|
|
|
2021-08-11 09:21:33 -05:00
|
|
|
LL ~ let res = {
|
2023-11-30 01:41:54 -06:00
|
|
|
LL +
|
2021-08-11 09:21:33 -05:00
|
|
|
LL + let x = 3;
|
|
|
|
LL + x == 3
|
|
|
|
LL ~ }; if res {
|
2020-02-04 09:08:39 -06:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: omit braces around single expression condition
|
2024-02-19 07:53:53 -06:00
|
|
|
--> tests/ui/blocks_in_conditions.rs:42:8
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2021-03-12 08:30:50 -06:00
|
|
|
LL | if { true } { 6 } else { 10 }
|
2020-02-04 09:08:39 -06:00
|
|
|
| ^^^^^^^^ help: try: `true`
|
2017-02-07 14:05:30 -06:00
|
|
|
|
2017-05-17 07:19:44 -05:00
|
|
|
error: this boolean expression can be simplified
|
2024-02-19 07:53:53 -06:00
|
|
|
--> tests/ui/blocks_in_conditions.rs:48:8
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2021-03-12 08:30:50 -06:00
|
|
|
LL | if true && x == 3 { 6 } else { 10 }
|
2017-07-21 03:40:23 -05:00
|
|
|
| ^^^^^^^^^^^^^^ help: try: `x == 3`
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-08-01 09:30:44 -05:00
|
|
|
= note: `-D clippy::nonminimal-bool` implied by `-D warnings`
|
2023-08-01 07:02:21 -05:00
|
|
|
= help: to override `-D warnings` add `#[allow(clippy::nonminimal_bool)]`
|
2017-05-17 07:19:44 -05:00
|
|
|
|
2023-11-30 01:41:54 -06:00
|
|
|
error: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
|
2024-02-19 07:53:53 -06:00
|
|
|
--> tests/ui/blocks_in_conditions.rs:75:5
|
2023-11-21 19:29:44 -06:00
|
|
|
|
|
|
|
|
LL | / match {
|
2023-11-30 01:41:54 -06:00
|
|
|
LL | |
|
2023-11-21 19:29:44 -06:00
|
|
|
LL | | let opt = Some(2);
|
|
|
|
LL | | opt
|
|
|
|
LL | | } {
|
|
|
|
| |_____^
|
|
|
|
|
|
|
|
|
help: try
|
|
|
|
|
|
|
|
|
LL ~ let res = {
|
2023-11-30 01:41:54 -06:00
|
|
|
LL +
|
2023-11-21 19:29:44 -06:00
|
|
|
LL + let opt = Some(2);
|
|
|
|
LL + opt
|
|
|
|
LL ~ }; match res {
|
|
|
|
|
|
|
|
|
|
2024-02-11 14:16:11 -06:00
|
|
|
error: aborting due to 4 previous errors
|
2018-01-16 10:06:27 -06:00
|
|
|
|