2013-05-22 21:51:21 -05:00
|
|
|
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution and at
|
|
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 02:30:51 -06:00
|
|
|
// If `Mul` used an associated type for its output, this test would
|
|
|
|
// work more smoothly.
|
2015-01-05 00:36:00 -06:00
|
|
|
#![feature(old_orphan_check)]
|
Fix orphan checking (cc #19470). (This is not a complete fix of #19470 because of the backwards compatibility feature gate.)
This is a [breaking-change]. The new rules require that, for an impl of a trait defined
in some other crate, two conditions must hold:
1. Some type must be local.
2. Every type parameter must appear "under" some local type.
Here are some examples that are legal:
```rust
struct MyStruct<T> { ... }
// Here `T` appears "under' `MyStruct`.
impl<T> Clone for MyStruct<T> { }
// Here `T` appears "under' `MyStruct` as well. Note that it also appears
// elsewhere.
impl<T> Iterator<T> for MyStruct<T> { }
```
Here is an illegal example:
```rust
// Here `U` does not appear "under" `MyStruct` or any other local type.
// We call `U` "uncovered".
impl<T,U> Iterator<U> for MyStruct<T> { }
```
There are a couple of ways to rewrite this last example so that it is
legal:
1. In some cases, the uncovered type parameter (here, `U`) should be converted
into an associated type. This is however a non-local change that requires access
to the original trait. Also, associated types are not fully baked.
2. Add `U` as a type parameter of `MyStruct`:
```rust
struct MyStruct<T,U> { ... }
impl<T,U> Iterator<U> for MyStruct<T,U> { }
```
3. Create a newtype wrapper for `U`
```rust
impl<T,U> Iterator<Wrapper<U>> for MyStruct<T,U> { }
```
Because associated types are not fully baked, which in the case of the
`Hash` trait makes adhering to this rule impossible, you can
temporarily disable this rule in your crate by using
`#![feature(old_orphan_check)]`. Note that the `old_orphan_check`
feature will be removed before 1.0 is released.
2014-12-26 02:30:51 -06:00
|
|
|
|
2014-12-22 11:04:23 -06:00
|
|
|
use std::ops::Mul;
|
|
|
|
|
2013-05-22 21:51:21 -05:00
|
|
|
struct Vec2 {
|
2013-09-26 01:26:09 -05:00
|
|
|
x: f64,
|
|
|
|
y: f64
|
2013-05-22 21:51:21 -05:00
|
|
|
}
|
|
|
|
|
librustc: Make `Copy` opt-in.
This change makes the compiler no longer infer whether types (structures
and enumerations) implement the `Copy` trait (and thus are implicitly
copyable). Rather, you must implement `Copy` yourself via `impl Copy for
MyType {}`.
A new warning has been added, `missing_copy_implementations`, to warn
you if a non-generic public type has been added that could have
implemented `Copy` but didn't.
For convenience, you may *temporarily* opt out of this behavior by using
`#![feature(opt_out_copy)]`. Note though that this feature gate will never be
accepted and will be removed by the time that 1.0 is released, so you should
transition your code away from using it.
This breaks code like:
#[deriving(Show)]
struct Point2D {
x: int,
y: int,
}
fn main() {
let mypoint = Point2D {
x: 1,
y: 1,
};
let otherpoint = mypoint;
println!("{}{}", mypoint, otherpoint);
}
Change this code to:
#[deriving(Show)]
struct Point2D {
x: int,
y: int,
}
impl Copy for Point2D {}
fn main() {
let mypoint = Point2D {
x: 1,
y: 1,
};
let otherpoint = mypoint;
println!("{}{}", mypoint, otherpoint);
}
This is the backwards-incompatible part of #13231.
Part of RFC #3.
[breaking-change]
2014-12-05 19:01:33 -06:00
|
|
|
impl Copy for Vec2 {}
|
|
|
|
|
2013-05-22 21:51:21 -05:00
|
|
|
// methods we want to export as methods as well as operators
|
|
|
|
impl Vec2 {
|
|
|
|
#[inline(always)]
|
2013-09-26 01:26:09 -05:00
|
|
|
fn vmul(self, other: f64) -> Vec2 {
|
2013-05-22 21:51:21 -05:00
|
|
|
Vec2 { x: self.x * other, y: self.y * other }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Right-hand-side operator visitor pattern
|
|
|
|
trait RhsOfVec2Mul<Result> { fn mul_vec2_by(&self, lhs: &Vec2) -> Result; }
|
|
|
|
|
|
|
|
// Vec2's implementation of Mul "from the other side" using the above trait
|
2014-12-31 14:45:13 -06:00
|
|
|
impl<Res, Rhs: RhsOfVec2Mul<Res>> Mul<Rhs> for Vec2 {
|
|
|
|
type Output = Res;
|
|
|
|
|
2014-12-01 16:33:22 -06:00
|
|
|
fn mul(self, rhs: Rhs) -> Res { rhs.mul_vec2_by(&self) }
|
2013-05-22 21:51:21 -05:00
|
|
|
}
|
|
|
|
|
2013-09-26 01:26:09 -05:00
|
|
|
// Implementation of 'f64 as right-hand-side of Vec2::Mul'
|
|
|
|
impl RhsOfVec2Mul<Vec2> for f64 {
|
2013-05-22 21:51:21 -05:00
|
|
|
fn mul_vec2_by(&self, lhs: &Vec2) -> Vec2 { lhs.vmul(*self) }
|
|
|
|
}
|
|
|
|
|
|
|
|
// Usage with failing inference
|
|
|
|
pub fn main() {
|
2014-04-21 16:58:52 -05:00
|
|
|
let a = Vec2 { x: 3.0f64, y: 4.0f64 };
|
2013-05-22 21:51:21 -05:00
|
|
|
|
|
|
|
// the following compiles and works properly
|
2014-04-21 16:58:52 -05:00
|
|
|
let v1: Vec2 = a * 3.0f64;
|
2013-09-25 00:16:43 -05:00
|
|
|
println!("{} {}", v1.x, v1.y);
|
2013-05-22 21:51:21 -05:00
|
|
|
|
|
|
|
// the following compiles but v2 will not be Vec2 yet and
|
|
|
|
// using it later will cause an error that the type of v2
|
|
|
|
// must be known
|
2014-04-21 16:58:52 -05:00
|
|
|
let v2 = a * 3.0f64;
|
2013-09-25 00:16:43 -05:00
|
|
|
println!("{} {}", v2.x, v2.y); // error regarding v2's type
|
2013-05-22 21:51:21 -05:00
|
|
|
}
|