2019-06-21 18:30:24 -05:00
|
|
|
warning: denote infinite loops with `loop { ... }`
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:42:5
|
2019-06-21 18:30:24 -05:00
|
|
|
|
|
|
|
|
LL | while true {
|
|
|
|
| ^^^^^^^^^^ help: use `loop`
|
|
|
|
|
|
2019-07-16 15:17:38 -05:00
|
|
|
= note: `#[warn(while_true)]` on by default
|
2019-06-21 18:30:24 -05:00
|
|
|
|
2017-09-30 01:52:51 -05:00
|
|
|
warning: unnecessary parentheses around assigned value
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:45:31
|
2017-09-30 01:52:51 -05:00
|
|
|
|
|
2018-10-16 23:36:02 -05:00
|
|
|
LL | let mut registry_no = (format!("NX-{}", 74205));
|
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
|
2017-09-30 01:52:51 -05:00
|
|
|
|
|
2020-01-22 17:57:38 -06:00
|
|
|
note: the lint level is defined here
|
2018-12-25 09:56:47 -06:00
|
|
|
--> $DIR/suggestions.rs:3:21
|
2017-10-20 16:00:57 -05:00
|
|
|
|
|
2018-02-22 18:42:32 -06:00
|
|
|
LL | #![warn(unused_mut, unused_parens)] // UI tests pass `-A unused`—see Issue #43896
|
2017-10-20 16:00:57 -05:00
|
|
|
| ^^^^^^^^^^^^^
|
2017-09-30 01:52:51 -05:00
|
|
|
|
2017-09-15 14:49:10 -05:00
|
|
|
warning: variable does not need to be mutable
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:45:13
|
2017-09-15 14:49:10 -05:00
|
|
|
|
|
2018-10-16 23:36:02 -05:00
|
|
|
LL | let mut registry_no = (format!("NX-{}", 74205));
|
|
|
|
| ----^^^^^^^^^^^
|
2017-09-15 14:49:10 -05:00
|
|
|
| |
|
|
|
|
| help: remove this `mut`
|
|
|
|
|
|
2020-01-22 17:57:38 -06:00
|
|
|
note: the lint level is defined here
|
2018-12-25 09:56:47 -06:00
|
|
|
--> $DIR/suggestions.rs:3:9
|
2017-09-15 14:49:10 -05:00
|
|
|
|
|
2018-02-22 18:42:32 -06:00
|
|
|
LL | #![warn(unused_mut, unused_parens)] // UI tests pass `-A unused`—see Issue #43896
|
2017-09-15 14:49:10 -05:00
|
|
|
| ^^^^^^^^^^
|
|
|
|
|
2018-01-23 12:54:57 -06:00
|
|
|
warning: variable does not need to be mutable
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:51:13
|
2018-01-23 12:54:57 -06:00
|
|
|
|
|
2018-02-22 18:42:32 -06:00
|
|
|
LL | let mut
|
2018-01-23 12:54:57 -06:00
|
|
|
| _____________^
|
|
|
|
| |_____________|
|
|
|
|
| ||
|
2018-02-22 18:42:32 -06:00
|
|
|
LL | || b = 1;
|
2018-01-23 12:54:57 -06:00
|
|
|
| ||____________-^
|
|
|
|
| |____________|
|
|
|
|
| help: remove this `mut`
|
|
|
|
|
2019-07-18 17:05:23 -05:00
|
|
|
error: const items should never be `#[no_mangle]`
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:5:14
|
2017-10-12 02:42:52 -05:00
|
|
|
|
|
2018-06-28 00:50:24 -05:00
|
|
|
LL | #[no_mangle] const DISCOVERY: usize = 1;
|
2017-10-12 02:42:52 -05:00
|
|
|
| -----^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
| |
|
|
|
|
| help: try a static value: `pub static`
|
|
|
|
|
|
2019-07-16 15:17:38 -05:00
|
|
|
= note: `#[deny(no_mangle_const_items)]` on by default
|
2017-10-12 02:42:52 -05:00
|
|
|
|
2019-02-15 16:26:36 -06:00
|
|
|
warning: functions generic over types or consts must be mangled
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:11:1
|
2017-10-12 02:42:52 -05:00
|
|
|
|
|
2018-06-28 00:50:24 -05:00
|
|
|
LL | #[no_mangle]
|
2017-10-12 02:42:52 -05:00
|
|
|
| ------------ help: remove this attribute
|
2019-03-09 06:03:44 -06:00
|
|
|
LL |
|
2018-02-22 18:42:32 -06:00
|
|
|
LL | pub fn defiant<T>(_t: T) {}
|
2017-10-12 02:42:52 -05:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
2019-07-16 15:17:38 -05:00
|
|
|
= note: `#[warn(no_mangle_generic_items)]` on by default
|
2017-10-12 02:42:52 -05:00
|
|
|
|
2019-03-12 20:55:37 -05:00
|
|
|
warning: the `warp_factor:` in this pattern is redundant
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:57:23
|
2019-03-12 20:55:37 -05:00
|
|
|
|
|
|
|
|
LL | Equinox { warp_factor: warp_factor } => {}
|
2019-12-21 16:59:38 -06:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use shorthand field pattern: `warp_factor`
|
2019-03-12 20:55:37 -05:00
|
|
|
|
|
2019-07-16 15:17:38 -05:00
|
|
|
= note: `#[warn(non_shorthand_field_patterns)]` on by default
|
2019-03-12 20:55:37 -05:00
|
|
|
|
2019-07-18 17:05:23 -05:00
|
|
|
error: const items should never be `#[no_mangle]`
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:21:18
|
2017-10-12 02:42:52 -05:00
|
|
|
|
|
2018-09-21 17:58:11 -05:00
|
|
|
LL | #[no_mangle] pub const DAUNTLESS: bool = true;
|
|
|
|
| ---------^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
| |
|
|
|
|
| help: try a static value: `pub static`
|
2017-10-12 02:42:52 -05:00
|
|
|
|
2019-02-15 16:26:36 -06:00
|
|
|
warning: functions generic over types or consts must be mangled
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:24:18
|
2018-06-28 00:50:24 -05:00
|
|
|
|
|
2018-09-21 17:58:11 -05:00
|
|
|
LL | #[no_mangle] pub fn val_jean<T>() {}
|
|
|
|
| ------------ ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
| |
|
|
|
|
| help: remove this attribute
|
2018-01-15 20:32:18 -06:00
|
|
|
|
2019-07-18 17:05:23 -05:00
|
|
|
error: const items should never be `#[no_mangle]`
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:29:18
|
2018-01-15 20:32:18 -06:00
|
|
|
|
|
2018-09-21 17:58:11 -05:00
|
|
|
LL | #[no_mangle] pub(crate) const VETAR: bool = true;
|
|
|
|
| ----------------^^^^^^^^^^^^^^^^^^^^
|
2018-06-28 00:30:23 -05:00
|
|
|
| |
|
2018-09-21 17:58:11 -05:00
|
|
|
| help: try a static value: `pub static`
|
2018-06-28 00:30:23 -05:00
|
|
|
|
2019-02-15 16:26:36 -06:00
|
|
|
warning: functions generic over types or consts must be mangled
|
2020-02-28 13:58:09 -06:00
|
|
|
--> $DIR/suggestions.rs:32:18
|
2018-06-28 00:30:23 -05:00
|
|
|
|
|
2018-09-21 17:58:11 -05:00
|
|
|
LL | #[no_mangle] pub(crate) fn crossfield<T>() {}
|
|
|
|
| ------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
| |
|
|
|
|
| help: remove this attribute
|
2018-06-28 00:30:23 -05:00
|
|
|
|
2018-09-21 17:58:11 -05:00
|
|
|
error: aborting due to 3 previous errors
|
2017-10-12 02:42:52 -05:00
|
|
|
|