mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14b96659e4
rust/src/test/ui/lint/lint-unexported-no-mangle.stderr

29 lines
1.0 KiB
Plaintext
Raw Normal View History

Fix private_no_mangle_fns message grammar
2018-12-11 23:42:23 -06:00
warning: lint `private_no_mangle_fns` has been removed: `no longer a warning, #[no_mangle] functions always exported`
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
|
rustc: Allow `#[no_mangle]` anywhere in a crate This commit updates the compiler to allow the `#[no_mangle]` (and `#[export_name]` attributes) to be located anywhere within a crate. These attributes are unconditionally processed, causing the compiler to always generate an exported symbol with the appropriate name. After some discussion on #54135 it was found that not a great reason this hasn't been allowed already, and it seems to match the behavior that many expect! Previously the compiler would only export a `#[no_mangle]` symbol if it were *publicly reachable*, meaning that it itself is `pub` and it's otherwise publicly reachable from the root of the crate. This new definition is that `#[no_mangle]` *is always reachable*, no matter where it is in a crate or whether it has `pub` or not. This should make it much easier to declare an exported symbol with a known and unique name, even when it's an internal implementation detail of the crate itself. Note that these symbols will persist beyond LTO as well, always making their way to the linker. Along the way this commit removes the `private_no_mangle_functions` lint (also for statics) as there's no longer any need to lint these situations. Furthermore a good number of tests were updated now that symbol visibility has been changed. Closes #54135
2018-09-21 17:58:11 -05:00
= note: requested on the command line with `-F private_no_mangle_fns`
Fix private_no_mangle_fns message grammar
2018-12-11 23:42:23 -06:00
warning: lint `private_no_mangle_statics` has been removed: `no longer a warning, #[no_mangle] statics always exported`
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
|
rustc: Allow `#[no_mangle]` anywhere in a crate This commit updates the compiler to allow the `#[no_mangle]` (and `#[export_name]` attributes) to be located anywhere within a crate. These attributes are unconditionally processed, causing the compiler to always generate an exported symbol with the appropriate name. After some discussion on #54135 it was found that not a great reason this hasn't been allowed already, and it seems to match the behavior that many expect! Previously the compiler would only export a `#[no_mangle]` symbol if it were *publicly reachable*, meaning that it itself is `pub` and it's otherwise publicly reachable from the root of the crate. This new definition is that `#[no_mangle]` *is always reachable*, no matter where it is in a crate or whether it has `pub` or not. This should make it much easier to declare an exported symbol with a known and unique name, even when it's an internal implementation detail of the crate itself. Note that these symbols will persist beyond LTO as well, always making their way to the linker. Along the way this commit removes the `private_no_mangle_functions` lint (also for statics) as there's no longer any need to lint these situations. Furthermore a good number of tests were updated now that symbol visibility has been changed. Closes #54135
2018-09-21 17:58:11 -05:00
= note: requested on the command line with `-F private_no_mangle_statics`
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
error: const items should never be #[no_mangle]
--> $DIR/lint-unexported-no-mangle.rs:19:1
|
LL | const FOO: u64 = 1; //~ ERROR const items should never be #[no_mangle]
| -----^^^^^^^^^^^^^^
| |
| help: try a static value: `pub static`
|
= note: requested on the command line with `-F no-mangle-const-items`
error: const items should never be #[no_mangle]
--> $DIR/lint-unexported-no-mangle.rs:22:1
|
LL | pub const PUB_FOO: u64 = 1; //~ ERROR const items should never be #[no_mangle]
| ---------^^^^^^^^^^^^^^^^^^
| |
| help: try a static value: `pub static`
rustc: Allow `#[no_mangle]` anywhere in a crate This commit updates the compiler to allow the `#[no_mangle]` (and `#[export_name]` attributes) to be located anywhere within a crate. These attributes are unconditionally processed, causing the compiler to always generate an exported symbol with the appropriate name. After some discussion on #54135 it was found that not a great reason this hasn't been allowed already, and it seems to match the behavior that many expect! Previously the compiler would only export a `#[no_mangle]` symbol if it were *publicly reachable*, meaning that it itself is `pub` and it's otherwise publicly reachable from the root of the crate. This new definition is that `#[no_mangle]` *is always reachable*, no matter where it is in a crate or whether it has `pub` or not. This should make it much easier to declare an exported symbol with a known and unique name, even when it's an internal implementation detail of the crate itself. Note that these symbols will persist beyond LTO as well, always making their way to the linker. Along the way this commit removes the `private_no_mangle_functions` lint (also for statics) as there's no longer any need to lint these situations. Furthermore a good number of tests were updated now that symbol visibility has been changed. Closes #54135
2018-09-21 17:58:11 -05:00
error: aborting due to 2 previous errors
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
Reference in New Issue Copy Permalink