2018-07-05 05:37:50 -05:00
We are currently in the process of discussing Clippy 1.0 via the RFC process in https://github.com/rust-lang/rfcs/pull/2476 . The RFC's goal is to clarify policies around lint categorizations and the policy around which lints should be in the compiler and which lints should be in Clippy. Please leave your thoughts on the RFC PR.
2018-06-20 13:37:22 -05:00
2018-07-05 05:37:50 -05:00
# Clippy
2016-05-06 09:07:47 -05:00
2017-08-06 06:10:21 -05:00
[![Build Status ](https://travis-ci.org/rust-lang-nursery/rust-clippy.svg?branch=master )](https://travis-ci.org/rust-lang-nursery/rust-clippy)
2018-03-29 17:12:19 -05:00
[![Windows Build status ](https://ci.appveyor.com/api/projects/status/id677xpw1dguo7iw?svg=true )](https://ci.appveyor.com/project/rust-lang-libs/rust-clippy)
2018-05-04 07:23:53 -05:00
[![Current Version ](https://meritbadge.herokuapp.com/clippy )](https://crates.io/crates/clippy)
2017-11-22 14:26:11 -06:00
[![License: MPL-2.0 ](https://img.shields.io/crates/l/clippy.svg )](#license)
2014-11-19 01:50:46 -06:00
2017-10-14 14:47:38 -05:00
A collection of lints to catch common mistakes and improve your [Rust ](https://github.com/rust-lang/rust ) code.
2014-11-19 13:19:03 -06:00
2018-09-18 12:28:58 -05:00
[There are 277 lints included in this crate! ](https://rust-lang-nursery.github.io/rust-clippy/master/index.html )
2017-09-01 13:29:36 -05:00
2018-07-05 05:37:50 -05:00
We have a bunch of lint categories to allow you to choose how much Clippy is supposed to ~~annoy~~ help you:
2018-03-29 06:04:52 -05:00
2018-07-28 10:35:24 -05:00
* `clippy::all` (everything that has no false positives)
* `clippy::pedantic` (everything)
* `clippy::nursery` (new lints that aren't quite ready yet)
* `clippy::style` (code that should be written in a more idiomatic way)
* `clippy::complexity` (code that does something simple but in a complex way)
* `clippy::perf` (code that can be written in a faster way)
* `clippy::cargo` (checks against the cargo manifest)
* **`clippy::correctness`** (code that is just outright wrong or very very useless)
2018-03-29 06:04:52 -05:00
2017-09-01 13:29:36 -05:00
More to come, please [file an issue ](https://github.com/rust-lang-nursery/rust-clippy/issues ) if you have ideas!
2016-02-22 08:50:40 -06:00
Table of contents:
2016-03-10 14:42:24 -06:00
2016-05-06 09:07:47 -05:00
* [Usage instructions ](#usage )
* [Configuration ](#configuration )
* [License ](#license )
2016-09-15 10:19:30 -05:00
## Usage
2016-11-18 21:46:12 -06:00
Since this is a tool for helping the developer of a library or application
2018-07-05 05:37:50 -05:00
write better code, it is recommended not to include Clippy as a hard dependency.
2016-11-19 21:16:36 -06:00
Options include using it as an optional dependency, as a cargo subcommand, or
2018-07-16 15:05:02 -05:00
as an included feature during build. These options are detailed below.
2016-11-18 21:46:12 -06:00
2018-07-16 15:05:02 -05:00
### As a cargo subcommand (`cargo clippy`)
2016-09-15 10:19:30 -05:00
2018-07-16 15:05:02 -05:00
One way to use Clippy is by installing Clippy through rustup as a cargo
subcommand.
2018-04-02 04:13:02 -05:00
2018-07-16 15:05:02 -05:00
#### Step 1: Install rustup
2018-04-02 04:13:02 -05:00
2018-07-16 15:05:02 -05:00
You can install [rustup ](http://rustup.rs/ ) on supported platforms. This will help
2018-09-11 13:29:00 -05:00
us install Clippy and its dependencies.
2017-12-27 10:06:40 -06:00
2018-07-16 15:05:02 -05:00
If you already have rustup installed, update to ensure you have the latest
rustup and compiler:
2017-12-27 10:06:40 -06:00
```terminal
2018-07-16 15:05:02 -05:00
rustup update
2017-12-27 10:06:40 -06:00
```
2018-09-11 13:29:00 -05:00
#### Step 2: Install Clippy
2018-01-12 04:33:13 -06:00
2018-09-11 13:29:00 -05:00
Once you have rustup and the latest stable release (at least Rust 1.29) installed, run the following command:
2018-04-02 04:13:02 -05:00
```terminal
2018-09-11 13:29:00 -05:00
rustup component add clippy-preview
2018-04-02 04:13:02 -05:00
```
2018-09-11 13:29:00 -05:00
Now you can run Clippy by invoking `cargo clippy` .
2018-07-16 15:05:02 -05:00
2018-07-05 05:37:50 -05:00
### Running Clippy from the command line without installing it
2016-09-15 10:19:30 -05:00
2018-07-05 05:37:50 -05:00
To have cargo compile your crate with Clippy without Clippy installation
2016-09-15 10:19:30 -05:00
in your code, you can use:
```terminal
2018-02-08 05:37:56 -06:00
cargo run --bin cargo-clippy --manifest-path=path_to_clippys_Cargo.toml
2016-09-15 10:19:30 -05:00
```
2017-08-06 06:10:21 -05:00
*[Note](https://github.com/rust-lang-nursery/rust-clippy/wiki#a-word-of-warning):*
2018-07-05 05:37:50 -05:00
Be sure that Clippy was compiled with the same version of rustc that cargo invokes here!
2016-09-15 10:19:30 -05:00
2018-09-14 01:21:14 -05:00
### Travis CI
You can add Clippy to Travis CI in the same way you use it locally:
```yml
- rust: stable
2018-09-14 04:21:27 -05:00
- rust: beta
2018-09-14 01:21:14 -05:00
before_script:
- rustup component add clippy-preview
script:
- cargo clippy
2018-09-14 04:21:27 -05:00
# if you want the build job to fail when encountering warnings, use
- cargo clippy -- -D warnings
# in order to also check tests and none-default crate features, use
- cargo clippy --all-targets --all-features -- -D warnings
2018-09-14 01:21:14 -05:00
- cargo test
# etc.
```
2016-09-15 10:19:30 -05:00
## Configuration
2018-09-02 04:31:39 -05:00
Some lints can be configured in a TOML file named `clippy.toml` or `.clippy.toml` . It contains a basic `variable = value` mapping eg.
2016-09-15 10:19:30 -05:00
```toml
blacklisted-names = ["toto", "tata", "titi"]
cyclomatic-complexity-threshold = 30
```
2018-01-07 05:50:42 -06:00
See the [list of lints ](https://rust-lang-nursery.github.io/rust-clippy/master/index.html ) for more information about which lints can be configured and the
2016-09-15 10:19:30 -05:00
meaning of the variables.
2018-01-07 05:50:42 -06:00
To deactivate the “for further information visit *lint-link* ” message you can
2017-09-01 03:29:49 -05:00
define the `CLIPPY_DISABLE_DOCS_LINKS` environment variable.
2016-09-15 10:19:30 -05:00
### Allowing/denying lints
2018-09-13 04:27:01 -05:00
You can add options to your code to `allow` /`warn`/`deny` Clippy lints:
2016-09-15 10:19:30 -05:00
2018-07-28 10:35:24 -05:00
* the whole set of `Warn` lints using the `clippy` lint group (`#![deny(clippy::all)]`)
2016-09-15 10:19:30 -05:00
2018-07-28 10:35:24 -05:00
* all lints using both the `clippy` and `clippy::pedantic` lint groups (`#![deny(clippy::all)]`,
`#![deny(clippy::pedantic)]` ). Note that `clippy::pedantic` contains some very aggressive
2016-09-15 10:19:30 -05:00
lints prone to false positives.
2018-07-28 10:35:24 -05:00
* only some lints (`#![deny(clippy::single_match, clippy::box_vec)]`, etc)
2016-09-15 10:19:30 -05:00
* `allow` /`warn`/`deny` can be limited to a single function or module using `#[allow(...)]` , etc
Note: `deny` produces errors instead of warnings.
2018-09-13 04:27:01 -05:00
Note: To use the new `clippy::lint_name` syntax, `#![feature(tool_lints)]` has to be activated
currently. If you want to compile your code with the stable toolchain you can use a `cfg_attr` to
activate the `tool_lints` feature:
```rust
#![cfg_attr(feature = "cargo-clippy", feature(tool_lints))]
#![cfg_attr(feature = "cargo-clippy", allow(clippy::lint_name))]
```
For this to work you have to use Clippy on the nightly toolchain: `cargo +nightly clippy` . If you
want to use Clippy with the stable toolchain, you can stick to the old unscoped method to
enable/disable Clippy lints until `tool_lints` are stable:
```rust
#![cfg_attr(feature = "cargo-clippy", allow(clippy_lint))]
```
2016-05-06 09:07:47 -05:00
## License
Licensed under [MPL ](https://www.mozilla.org/MPL/2.0/ ).
If you're having issues with the license, let me know and I'll try to change it to something more permissive.