mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
11e128025a
rust/tests/ui/lint/lint-invalid-atomic-ordering-fence.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

20 lines
660 B
Plaintext
Raw Normal View History

Add memory fence tests for `invalid_atomic_ordering`
2020-01-09 11:51:13 -06:00
error: memory fences cannot have `Relaxed` ordering
Uplift the `invalid_atomic_ordering` lint from clippy to rustc - Deprecate clippy::invalid_atomic_ordering - Use rustc_diagnostic_item for the orderings in the invalid_atomic_ordering lint - Reduce code duplication - Give up on making enum variants diagnostic items and just look for `Ordering` instead I ran into tons of trouble with this because apparently the change to store HIR attrs in a side table also gave the DefIds of the constructor instead of the variant itself. So I had to change `matches_ordering` to also check the grandparent of the defid as well. - Rename `atomic_ordering_x` symbols to just the name of the variant - Fix typos in checks - there were a few places that said "may not be Release" in the diagnostic but actually checked for SeqCst in the lint. - Make constant items const - Use fewer diagnostic items - Only look at arguments after making sure the method matches This prevents an ICE when there aren't enough arguments. - Ignore trait methods - Only check Ctors instead of going through `qpath_res` The functions take values, so this couldn't ever be anything else. - Add if_chain to allowed dependencies - Fix grammar - Remove unnecessary allow
2020-12-02 17:16:12 -06:00
--> $DIR/lint-invalid-atomic-ordering-fence.rs:17:11
Add memory fence tests for `invalid_atomic_ordering`
2020-01-09 11:51:13 -06:00
|
LL | fence(Ordering::Relaxed);
| ^^^^^^^^^^^^^^^^^
|
= help: consider using ordering modes `Acquire`, `Release`, `AcqRel` or `SeqCst`
bless ui tests
2022-09-18 10:55:36 -05:00
= note: `#[deny(invalid_atomic_ordering)]` on by default
Add memory fence tests for `invalid_atomic_ordering`
2020-01-09 11:51:13 -06:00
error: memory fences cannot have `Relaxed` ordering
Uplift the `invalid_atomic_ordering` lint from clippy to rustc - Deprecate clippy::invalid_atomic_ordering - Use rustc_diagnostic_item for the orderings in the invalid_atomic_ordering lint - Reduce code duplication - Give up on making enum variants diagnostic items and just look for `Ordering` instead I ran into tons of trouble with this because apparently the change to store HIR attrs in a side table also gave the DefIds of the constructor instead of the variant itself. So I had to change `matches_ordering` to also check the grandparent of the defid as well. - Rename `atomic_ordering_x` symbols to just the name of the variant - Fix typos in checks - there were a few places that said "may not be Release" in the diagnostic but actually checked for SeqCst in the lint. - Make constant items const - Use fewer diagnostic items - Only look at arguments after making sure the method matches This prevents an ICE when there aren't enough arguments. - Ignore trait methods - Only check Ctors instead of going through `qpath_res` The functions take values, so this couldn't ever be anything else. - Add if_chain to allowed dependencies - Fix grammar - Remove unnecessary allow
2020-12-02 17:16:12 -06:00
--> $DIR/lint-invalid-atomic-ordering-fence.rs:19:20
Add memory fence tests for `invalid_atomic_ordering`
2020-01-09 11:51:13 -06:00
|
LL | compiler_fence(Ordering::Relaxed);
| ^^^^^^^^^^^^^^^^^
|
= help: consider using ordering modes `Acquire`, `Release`, `AcqRel` or `SeqCst`
error: aborting due to 2 previous errors
Reference in New Issue Copy Permalink