mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
rust/tests/ui/lint/rfc-2457-non-ascii-idents/lint-confusable-idents.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

27 lines
748 B
Plaintext
Raw Normal View History

Reword confusable idents lint Fix #76140.
2023-08-04 16:46:08 +00:00
error: found both `ｓ` and `s` as identifiers, which look alike
Stablize `non_ascii_idents` feature.
2021-04-03 10:35:11 +08:00
--> $DIR/lint-confusable-idents.rs:8:9
Implement `confusable_idents` lint.
2020-04-25 09:38:31 +08:00
|
LL | const ｓ: usize = 42;
Reword confusable idents lint Fix #76140.
2023-08-04 16:46:08 +00:00
| -- other identifier used here
Implement `confusable_idents` lint.
2020-04-25 09:38:31 +08:00
...
LL | let s = "rust";
Reword confusable idents lint Fix #76140.
2023-08-04 16:46:08 +00:00
| ^ this identifier can be confused with `ｓ`
Implement `confusable_idents` lint.
2020-04-25 09:38:31 +08:00
|
note: the lint level is defined here
Stablize `non_ascii_idents` feature.
2021-04-03 10:35:11 +08:00
--> $DIR/lint-confusable-idents.rs:1:9
Implement `confusable_idents` lint.
2020-04-25 09:38:31 +08:00
|
LL | #![deny(confusable_idents)]
| ^^^^^^^^^^^^^^^^^
Reword confusable idents lint Fix #76140.
2023-08-04 16:46:08 +00:00
error: found both `s_s` and `ｓ_ｓ` as identifiers, which look alike
Stablize `non_ascii_idents` feature.
2021-04-03 10:35:11 +08:00
--> $DIR/lint-confusable-idents.rs:9:9
Fix symbol ordering for confusable idents detection. Confusable idents detection uses a type `BTreeMap<Symbol, Span>`. This is highly dubious given that `Symbol` doesn't guarantee a meaningful order. (In practice, it currently gives an order that mostly matches source code order.) As a result, changes in `Symbol` representation make the `lint-confusable-idents.rs` test fail, because this error message: > identifier pair considered confusable between `ｓ` and `s` is changed to this: > identifier pair considered confusable between `s` and `ｓ` and the corresponding span pointers get swapped erroneously, leading to an incorrect "previous identifier" label. This commit sorts the relevant symbols by span before doing the checking, which ensures that the ident that appears first in the code will be mentioned first in the message. The commit also extends the test slightly to be more thorough.
2020-08-05 17:29:13 +10:00
|
LL | const s_s: usize = 42;
Reword confusable idents lint Fix #76140.
2023-08-04 16:46:08 +00:00
| --- other identifier used here
Fix symbol ordering for confusable idents detection. Confusable idents detection uses a type `BTreeMap<Symbol, Span>`. This is highly dubious given that `Symbol` doesn't guarantee a meaningful order. (In practice, it currently gives an order that mostly matches source code order.) As a result, changes in `Symbol` representation make the `lint-confusable-idents.rs` test fail, because this error message: > identifier pair considered confusable between `ｓ` and `s` is changed to this: > identifier pair considered confusable between `s` and `ｓ` and the corresponding span pointers get swapped erroneously, leading to an incorrect "previous identifier" label. This commit sorts the relevant symbols by span before doing the checking, which ensures that the ident that appears first in the code will be mentioned first in the message. The commit also extends the test slightly to be more thorough.
2020-08-05 17:29:13 +10:00
...
LL | let ｓ_ｓ = "rust2";
Reword confusable idents lint Fix #76140.
2023-08-04 16:46:08 +00:00
| ^^^^^ this identifier can be confused with `s_s`
Fix symbol ordering for confusable idents detection. Confusable idents detection uses a type `BTreeMap<Symbol, Span>`. This is highly dubious given that `Symbol` doesn't guarantee a meaningful order. (In practice, it currently gives an order that mostly matches source code order.) As a result, changes in `Symbol` representation make the `lint-confusable-idents.rs` test fail, because this error message: > identifier pair considered confusable between `ｓ` and `s` is changed to this: > identifier pair considered confusable between `s` and `ｓ` and the corresponding span pointers get swapped erroneously, leading to an incorrect "previous identifier" label. This commit sorts the relevant symbols by span before doing the checking, which ensures that the ident that appears first in the code will be mentioned first in the message. The commit also extends the test slightly to be more thorough.
2020-08-05 17:29:13 +10:00
error: aborting due to 2 previous errors
Implement `confusable_idents` lint.
2020-04-25 09:38:31 +08:00
Reference in New Issue Copy Permalink