rust/clippy_lints/src/empty_enum.rs

46 lines
1.4 KiB
Rust
Raw Normal View History

//! lint when there is an enum with no variants
2018-05-30 03:15:50 -05:00
use crate::utils::span_lint_and_then;
2019-12-03 17:16:03 -06:00
use rustc::declare_lint_pass;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
2020-01-06 10:39:50 -06:00
use rustc_hir::*;
2019-12-03 17:16:03 -06:00
use rustc_session::declare_tool_lint;
2018-03-28 08:24:26 -05:00
declare_clippy_lint! {
/// **What it does:** Checks for `enum`s with no variants.
///
/// **Why is this bad?** Enum's with no variants should be replaced with `!`,
/// the uninhabited type,
/// or a wrapper around it.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust
/// enum Test {}
/// ```
pub EMPTY_ENUM,
2018-03-28 08:24:26 -05:00
pedantic,
"enum with no variants"
}
2019-04-08 15:43:55 -05:00
declare_lint_pass!(EmptyEnum => [EMPTY_ENUM]);
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for EmptyEnum {
2019-12-22 08:42:41 -06:00
fn check_item(&mut self, cx: &LateContext<'_, '_>, item: &Item<'_>) {
let did = cx.tcx.hir().local_def_id(item.hir_id);
2019-09-27 10:16:06 -05:00
if let ItemKind::Enum(..) = item.kind {
2017-04-27 07:00:35 -05:00
let ty = cx.tcx.type_of(did);
2018-11-27 14:14:15 -06:00
let adt = ty.ty_adt_def().expect("already checked whether this is an enum");
if adt.variants.is_empty() {
span_lint_and_then(cx, EMPTY_ENUM, item.span, "enum with no variants", |db| {
2018-11-27 14:14:15 -06:00
db.span_help(
item.span,
"consider using the uninhabited type `!` or a wrapper around it",
);
});
}
}
}
}