rust/tests/ui/privacy/private-in-public-non-principal.stderr

warning: private trait `PrivNonPrincipal` in public interface (error E0445)
  --> $DIR/private-in-public-non-principal.rs:7:1
   |
LL | pub fn leak_dyn_nonprincipal() -> Box<dyn PubPrincipal + PrivNonPrincipal> { loop {} }
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
   = note: `#[warn(private_in_public)]` on by default

error: missing documentation for an associated function
  --> $DIR/private-in-public-non-principal.rs:14:9
   |
LL |         pub fn check_doc_lint() {}
   |         ^^^^^^^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> $DIR/private-in-public-non-principal.rs:11:8
   |
LL | #[deny(missing_docs)]
   |        ^^^^^^^^^^^^

error: aborting due to previous error; 1 warning emitted
Address review comments Say "trait" instead of "type" in diagnostics for `dyn Trait` 2018-12-30 18:02:40 -06:00			warning: private trait `PrivNonPrincipal` in public interface (error E0445)
introduce `negative_impls` feature gate and document They used to be covered by `optin_builtin_traits` but negative impls are now applicable to all traits, not just auto traits. This also adds docs in the unstable book for the current state of auto traits. 2020-01-09 04:56:38 -06:00			`--> $DIR/private-in-public-non-principal.rs:7:1`
privacy: Use common `DefId` visiting infra for all privacy visitors 2018-12-16 07:18:45 -06:00			`\|`
Update ui test suite to use dyn 2019-05-28 13:46:13 -05:00			`LL \| pub fn leak_dyn_nonprincipal() -> Box<dyn PubPrincipal + PrivNonPrincipal> { loop {} }`
Use smaller def span for functions Currently, the def span of a funtion encompasses the entire function signature and body. However, this is usually unnecessarily verbose - when we are pointing at an entire function in a diagnostic, we almost always want to point at the signature. The actual contents of the body tends to be irrelevant to the diagnostic we are emitting, and just takes up additional screen space. This commit changes the `def_span` of all function items (freestanding functions, `impl`-block methods, and `trait`-block methods) to be the span of the signature. For example, the function ```rust pub fn foo<T>(val: T) -> T { val } ``` now has a `def_span` corresponding to `pub fn foo<T>(val: T) -> T` (everything before the opening curly brace). Trait methods without a body have a `def_span` which includes the trailing semicolon. For example: ```rust trait Foo { fn bar(); }``` the function definition `Foo::bar` has a `def_span` of `fn bar();` This makes our diagnostic output much shorter, and emphasizes information that is relevant to whatever diagnostic we are reporting. We continue to use the full span (including the body) in a few of places: * MIR building uses the full span when building source scopes. * 'Outlives suggestions' use the full span to sort the diagnostics being emitted. * The `#[rustc_on_unimplemented(enclosing_scope="in this scope")]` attribute points the entire scope body. * The 'unconditional recursion' lint uses the full span to show additional context for the recursive call. All of these cases work only with local items, so we don't need to add anything extra to crate metadata. 2020-08-12 16:02:14 -05:00			`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
privacy: Use common `DefId` visiting infra for all privacy visitors 2018-12-16 07:18:45 -06:00			`\|`
			`= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!`
			`= note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>`
bless ui tests 2022-09-18 10:55:36 -05:00			= note: `#[warn(private_in_public)]` on by default
privacy: Use common `DefId` visiting infra for all privacy visitors 2018-12-16 07:18:45 -06:00
convert a couple more errors 2020-03-21 19:47:23 -05:00			`error: missing documentation for an associated function`
wip pacify the merciless ui tests 2020-03-26 06:41:26 -05:00			`--> $DIR/private-in-public-non-principal.rs:14:9`
privacy: Use common `DefId` visiting infra for all privacy visitors 2018-12-16 07:18:45 -06:00			`\|`
Update tests 2019-03-09 06:03:44 -06:00			`LL \| pub fn check_doc_lint() {}`
privacy: Use common `DefId` visiting infra for all privacy visitors 2018-12-16 07:18:45 -06:00			`\| ^^^^^^^^^^^^^^^^^^^^^^^`
			`\|`
Normalise notes with the/is 2020-01-22 17:57:38 -06:00			`note: the lint level is defined here`
introduce `negative_impls` feature gate and document They used to be covered by `optin_builtin_traits` but negative impls are now applicable to all traits, not just auto traits. This also adds docs in the unstable book for the current state of auto traits. 2020-01-09 04:56:38 -06:00			`--> $DIR/private-in-public-non-principal.rs:11:8`
privacy: Use common `DefId` visiting infra for all privacy visitors 2018-12-16 07:18:45 -06:00			`\|`
			`LL \| #[deny(missing_docs)]`
			`\| ^^^^^^^^^^^^`

rustc: Add a warning count upon completion 2020-03-11 10:30:09 -05:00			`error: aborting due to previous error; 1 warning emitted`
privacy: Use common `DefId` visiting infra for all privacy visitors 2018-12-16 07:18:45 -06:00