rust/tests/ui/privacy/issue-30079.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

32 lines
1.1 KiB
Plaintext
Raw Normal View History

2018-07-15 16:11:54 -05:00
warning: private type `m1::Priv` in public interface (error E0446)
2018-12-25 09:56:47 -06:00
--> $DIR/issue-30079.rs:6:9
2018-07-15 16:11:54 -05:00
|
2019-03-09 06:03:44 -06:00
LL | pub fn f(_: Priv) {}
Use smaller def span for functions Currently, the def span of a funtion encompasses the entire function signature and body. However, this is usually unnecessarily verbose - when we are pointing at an entire function in a diagnostic, we almost always want to point at the signature. The actual contents of the body tends to be irrelevant to the diagnostic we are emitting, and just takes up additional screen space. This commit changes the `def_span` of all function items (freestanding functions, `impl`-block methods, and `trait`-block methods) to be the span of the signature. For example, the function ```rust pub fn foo<T>(val: T) -> T { val } ``` now has a `def_span` corresponding to `pub fn foo<T>(val: T) -> T` (everything before the opening curly brace). Trait methods without a body have a `def_span` which includes the trailing semicolon. For example: ```rust trait Foo { fn bar(); }``` the function definition `Foo::bar` has a `def_span` of `fn bar();` This makes our diagnostic output much shorter, and emphasizes information that is relevant to whatever diagnostic we are reporting. We continue to use the full span (including the body) in a few of places: * MIR building uses the full span when building source scopes. * 'Outlives suggestions' use the full span to sort the diagnostics being emitted. * The `#[rustc_on_unimplemented(enclosing_scope="in this scope")]` attribute points the entire scope body. * The 'unconditional recursion' lint uses the full span to show additional context for the recursive call. All of these cases work only with local items, so we don't need to add anything extra to crate metadata.
2020-08-12 16:02:14 -05:00
| ^^^^^^^^^^^^^^^^^
2018-07-15 16:11:54 -05:00
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #34537 <https://github.com/rust-lang/rust/issues/34537>
2022-09-18 10:55:36 -05:00
= note: `#[warn(private_in_public)]` on by default
2018-07-15 16:11:54 -05:00
error[E0446]: private type `m2::Priv` in public interface
2018-12-25 09:56:47 -06:00
--> $DIR/issue-30079.rs:18:9
2018-07-15 16:11:54 -05:00
|
LL | struct Priv;
2022-02-13 09:27:59 -06:00
| ----------- `m2::Priv` declared as private
2018-07-15 16:11:54 -05:00
LL | impl ::std::ops::Deref for ::SemiPriv {
2019-03-09 06:03:44 -06:00
LL | type Target = Priv;
2022-02-13 09:27:59 -06:00
| ^^^^^^^^^^^ can't leak private type
2018-07-15 16:11:54 -05:00
error[E0446]: private type `m3::Priv` in public interface
2018-12-25 09:56:47 -06:00
--> $DIR/issue-30079.rs:35:9
2018-07-15 16:11:54 -05:00
|
LL | struct Priv;
2022-02-13 09:27:59 -06:00
| ----------- `m3::Priv` declared as private
2018-07-15 16:11:54 -05:00
LL | impl ::SemiPrivTrait for () {
2019-03-09 06:03:44 -06:00
LL | type Assoc = Priv;
2022-02-13 09:27:59 -06:00
| ^^^^^^^^^^ can't leak private type
2018-07-15 16:11:54 -05:00
error: aborting due to 2 previous errors; 1 warning emitted
2018-07-15 16:11:54 -05:00
For more information about this error, try `rustc --explain E0446`.