rust/clippy_lints/src/dbg_macro.rs

76 lines
2.5 KiB
Rust
Raw Normal View History

use clippy_utils::diagnostics::{span_lint_and_help, span_lint_and_sugg};
use clippy_utils::source::snippet_opt;
2020-03-01 12:23:33 +09:00
use rustc_ast::ast;
use rustc_ast::tokenstream::TokenStream;
use rustc_errors::Applicability;
2020-01-12 15:08:41 +09:00
use rustc_lint::{EarlyContext, EarlyLintPass};
2020-01-11 20:37:08 +09:00
use rustc_session::{declare_lint_pass, declare_tool_lint};
use rustc_span::source_map::Span;
2019-01-31 02:39:38 +09:00
declare_clippy_lint! {
/// ### What it does
/// Checks for usage of dbg!() macro.
///
/// ### Why is this bad?
/// `dbg!` macro is intended as a debugging tool. It
/// should not be in version control.
///
/// ### Known problems
/// * The lint level is unaffected by crate attributes. The level can still
/// be set for functions, modules and other items. To change the level for
/// the entire crate, please use command line flags. More information and a
/// configuration example can be found in [clippy#6610].
///
/// [clippy#6610]: https://github.com/rust-lang/rust-clippy/issues/6610#issuecomment-977120558
///
/// ### Example
/// ```rust,ignore
/// // Bad
/// dbg!(true)
///
/// // Good
/// true
/// ```
#[clippy::version = "1.34.0"]
2019-01-31 02:39:38 +09:00
pub DBG_MACRO,
2019-02-01 09:23:40 +09:00
restriction,
2019-01-31 02:39:38 +09:00
"`dbg!` macro is intended as a debugging tool"
}
2019-04-08 13:43:55 -07:00
declare_lint_pass!(DbgMacro => [DBG_MACRO]);
2019-01-31 02:39:38 +09:00
2019-04-08 13:43:55 -07:00
impl EarlyLintPass for DbgMacro {
fn check_mac(&mut self, cx: &EarlyContext<'_>, mac: &ast::MacCall) {
if mac.path == sym!(dbg) {
2019-12-03 17:54:32 +01:00
if let Some(sugg) = tts_span(mac.args.inner_tokens()).and_then(|span| snippet_opt(cx, span)) {
2019-02-03 18:50:00 +09:00
span_lint_and_sugg(
cx,
DBG_MACRO,
2019-12-03 17:54:32 +01:00
mac.span(),
2019-02-03 18:50:00 +09:00
"`dbg!` macro is intended as a debugging tool",
"ensure to avoid having uses of it in version control",
sugg,
Applicability::MaybeIncorrect,
);
} else {
span_lint_and_help(
2019-02-03 18:50:00 +09:00
cx,
DBG_MACRO,
2019-12-03 17:54:32 +01:00
mac.span(),
2019-02-03 18:50:00 +09:00
"`dbg!` macro is intended as a debugging tool",
None,
2019-02-03 18:50:00 +09:00
"ensure to avoid having uses of it in version control",
);
}
2019-01-31 02:39:38 +09:00
}
}
}
// Get span enclosing entire the token stream.
fn tts_span(tts: TokenStream) -> Option<Span> {
let mut cursor = tts.into_trees();
let first = cursor.next()?.span();
2019-09-04 16:19:59 +02:00
let span = cursor.last().map_or(first, |tree| first.to(tree.span()));
Some(span)
}