2021-09-17 01:55:26 -05:00
|
|
|
#![warn(clippy::uninit_vec)]
|
|
|
|
|
|
|
|
use std::mem::MaybeUninit;
|
|
|
|
|
2021-09-20 14:32:53 -05:00
|
|
|
#[derive(Default)]
|
|
|
|
struct MyVec {
|
|
|
|
vec: Vec<u8>,
|
|
|
|
}
|
|
|
|
|
2023-03-18 17:22:04 -05:00
|
|
|
union MyOwnMaybeUninit {
|
|
|
|
value: u8,
|
|
|
|
uninit: (),
|
|
|
|
}
|
|
|
|
|
2021-09-17 01:55:26 -05:00
|
|
|
fn main() {
|
|
|
|
// with_capacity() -> set_len() should be detected
|
|
|
|
let mut vec: Vec<u8> = Vec::with_capacity(1000);
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` immediately after reserving a buffer creates uninitial
|
2021-09-17 01:55:26 -05:00
|
|
|
unsafe {
|
|
|
|
vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
|
|
|
// reserve() -> set_len() should be detected
|
|
|
|
vec.reserve(1000);
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` immediately after reserving a buffer creates uninitial
|
2021-09-17 01:55:26 -05:00
|
|
|
unsafe {
|
|
|
|
vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
2021-10-07 10:18:01 -05:00
|
|
|
// new() -> set_len() should be detected
|
|
|
|
let mut vec: Vec<u8> = Vec::new();
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` on empty `Vec` creates out-of-bound values
|
2021-10-07 10:18:01 -05:00
|
|
|
unsafe {
|
|
|
|
vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
|
|
|
// default() -> set_len() should be detected
|
|
|
|
let mut vec: Vec<u8> = Default::default();
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` on empty `Vec` creates out-of-bound values
|
2021-10-07 10:18:01 -05:00
|
|
|
unsafe {
|
|
|
|
vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
|
|
|
let mut vec: Vec<u8> = Vec::default();
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` on empty `Vec` creates out-of-bound values
|
2021-10-07 10:18:01 -05:00
|
|
|
unsafe {
|
|
|
|
vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
2021-09-17 01:55:26 -05:00
|
|
|
// test when both calls are enclosed in the same unsafe block
|
|
|
|
unsafe {
|
|
|
|
let mut vec: Vec<u8> = Vec::with_capacity(1000);
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` immediately after reserving a buffer creates unini
|
2021-09-17 01:55:26 -05:00
|
|
|
vec.set_len(200);
|
|
|
|
|
|
|
|
vec.reserve(1000);
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` immediately after reserving a buffer creates unini
|
2021-09-17 01:55:26 -05:00
|
|
|
vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
2021-09-20 14:32:53 -05:00
|
|
|
let mut vec: Vec<u8> = Vec::with_capacity(1000);
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` immediately after reserving a buffer creates uninitial
|
2021-09-20 14:32:53 -05:00
|
|
|
unsafe {
|
|
|
|
// test the case where there are other statements in the following unsafe block
|
|
|
|
vec.set_len(200);
|
|
|
|
assert!(vec.len() == 200);
|
|
|
|
}
|
|
|
|
|
|
|
|
// handle vec stored in the field of a struct
|
|
|
|
let mut my_vec = MyVec::default();
|
|
|
|
my_vec.vec.reserve(1000);
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` immediately after reserving a buffer creates uninitial
|
2021-09-20 14:32:53 -05:00
|
|
|
unsafe {
|
|
|
|
my_vec.vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
|
|
|
my_vec.vec = Vec::with_capacity(1000);
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` immediately after reserving a buffer creates uninitial
|
2021-09-20 14:32:53 -05:00
|
|
|
unsafe {
|
|
|
|
my_vec.vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
2021-10-05 10:43:44 -05:00
|
|
|
// Test `#[allow(...)]` attributes on inner unsafe block (shouldn't trigger)
|
|
|
|
let mut vec: Vec<u8> = Vec::with_capacity(1000);
|
|
|
|
#[allow(clippy::uninit_vec)]
|
|
|
|
unsafe {
|
|
|
|
vec.set_len(200);
|
|
|
|
}
|
|
|
|
|
2021-09-17 01:55:26 -05:00
|
|
|
// MaybeUninit-wrapped types should not be detected
|
|
|
|
unsafe {
|
2021-09-17 13:42:32 -05:00
|
|
|
let mut vec: Vec<MaybeUninit<u8>> = Vec::with_capacity(1000);
|
|
|
|
vec.set_len(200);
|
|
|
|
|
|
|
|
let mut vec: Vec<(MaybeUninit<u8>, MaybeUninit<bool>)> = Vec::with_capacity(1000);
|
|
|
|
vec.set_len(200);
|
|
|
|
|
|
|
|
let mut vec: Vec<(MaybeUninit<u8>, [MaybeUninit<bool>; 2])> = Vec::with_capacity(1000);
|
2021-09-17 01:55:26 -05:00
|
|
|
vec.set_len(200);
|
|
|
|
}
|
2021-09-20 14:32:53 -05:00
|
|
|
|
|
|
|
// known false negative
|
|
|
|
let mut vec1: Vec<u8> = Vec::with_capacity(1000);
|
|
|
|
let mut vec2: Vec<u8> = Vec::with_capacity(1000);
|
|
|
|
unsafe {
|
2021-10-05 10:43:44 -05:00
|
|
|
vec1.set_len(200);
|
|
|
|
vec2.set_len(200);
|
2021-09-20 14:32:53 -05:00
|
|
|
}
|
2022-09-22 18:06:13 -05:00
|
|
|
|
|
|
|
// set_len(0) should not be detected
|
|
|
|
let mut vec: Vec<u8> = Vec::with_capacity(1000);
|
|
|
|
unsafe {
|
|
|
|
vec.set_len(0);
|
|
|
|
}
|
2023-03-18 17:22:04 -05:00
|
|
|
|
|
|
|
// ZSTs should not be detected
|
|
|
|
let mut vec: Vec<()> = Vec::with_capacity(1000);
|
|
|
|
unsafe {
|
|
|
|
vec.set_len(10);
|
|
|
|
}
|
|
|
|
|
|
|
|
// unions should not be detected
|
|
|
|
let mut vec: Vec<MyOwnMaybeUninit> = Vec::with_capacity(1000);
|
|
|
|
unsafe {
|
|
|
|
vec.set_len(10);
|
|
|
|
}
|
|
|
|
|
|
|
|
polymorphic::<()>();
|
|
|
|
|
|
|
|
fn polymorphic<T>() {
|
|
|
|
// We are conservative around polymorphic types.
|
|
|
|
let mut vec: Vec<T> = Vec::with_capacity(1000);
|
2023-07-28 14:35:48 -05:00
|
|
|
//~^ ERROR: calling `set_len()` immediately after reserving a buffer creates unini
|
2023-03-18 17:22:04 -05:00
|
|
|
unsafe {
|
|
|
|
vec.set_len(10);
|
|
|
|
}
|
|
|
|
}
|
2023-03-26 09:52:46 -05:00
|
|
|
|
|
|
|
fn poly_maybe_uninit<T>() {
|
|
|
|
// We are conservative around polymorphic types.
|
|
|
|
let mut vec: Vec<MaybeUninit<T>> = Vec::with_capacity(1000);
|
|
|
|
unsafe {
|
|
|
|
vec.set_len(10);
|
|
|
|
}
|
|
|
|
}
|
2021-09-17 01:55:26 -05:00
|
|
|
}
|