2016-03-07 09:31:38 -06:00
|
|
|
#![feature(plugin, inclusive_range_syntax)]
|
2016-01-30 11:03:53 -06:00
|
|
|
#![plugin(clippy)]
|
|
|
|
|
2016-05-13 09:43:47 -05:00
|
|
|
#![allow(dead_code, no_effect, unnecessary_operation)]
|
2016-01-30 13:10:14 -06:00
|
|
|
#![allow(let_and_return)]
|
|
|
|
#![allow(needless_return)]
|
|
|
|
#![allow(unused_variables)]
|
2016-02-09 18:22:53 -06:00
|
|
|
#![allow(cyclomatic_complexity)]
|
2016-02-22 08:42:24 -06:00
|
|
|
#![allow(blacklisted_name)]
|
2016-06-21 16:53:45 -05:00
|
|
|
#![allow(collapsible_if)]
|
2016-07-13 12:02:28 -05:00
|
|
|
#![allow(zero_divided_by_zero, eq_op)]
|
2016-01-30 11:03:53 -06:00
|
|
|
|
2016-02-09 18:22:53 -06:00
|
|
|
fn bar<T>(_: T) {}
|
2016-01-30 11:03:53 -06:00
|
|
|
fn foo() -> bool { unimplemented!() }
|
|
|
|
|
2016-03-07 09:31:38 -06:00
|
|
|
struct Foo {
|
|
|
|
bar: u8,
|
|
|
|
}
|
|
|
|
|
2016-10-08 08:16:00 -05:00
|
|
|
pub enum Abc {
|
|
|
|
A,
|
|
|
|
B,
|
|
|
|
C,
|
|
|
|
}
|
|
|
|
|
2016-02-09 09:45:47 -06:00
|
|
|
#[deny(if_same_then_else)]
|
2016-02-09 18:22:53 -06:00
|
|
|
#[deny(match_same_arms)]
|
2016-02-13 08:36:57 -06:00
|
|
|
fn if_same_then_else() -> Result<&'static str, ()> {
|
2016-02-09 09:45:47 -06:00
|
|
|
if true {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-03-07 09:31:38 -06:00
|
|
|
Foo { bar: 42 };
|
|
|
|
0..10;
|
|
|
|
..;
|
|
|
|
0..;
|
|
|
|
..10;
|
|
|
|
0...10;
|
2016-01-30 12:16:49 -06:00
|
|
|
foo();
|
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else { //~ERROR this `if` has identical blocks
|
2016-03-07 09:31:38 -06:00
|
|
|
Foo { bar: 42 };
|
|
|
|
0..10;
|
|
|
|
..;
|
|
|
|
0..;
|
|
|
|
..10;
|
|
|
|
0...10;
|
2016-01-30 12:16:49 -06:00
|
|
|
foo();
|
|
|
|
}
|
|
|
|
|
2016-03-07 09:31:38 -06:00
|
|
|
if true {
|
|
|
|
Foo { bar: 42 };
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
Foo { bar: 43 };
|
|
|
|
}
|
|
|
|
|
2016-10-01 15:27:10 -05:00
|
|
|
if true {
|
|
|
|
();
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
()
|
|
|
|
}
|
|
|
|
|
2016-03-07 09:31:38 -06:00
|
|
|
if true {
|
|
|
|
0..10;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
0...10;
|
|
|
|
}
|
|
|
|
|
2016-01-30 12:16:49 -06:00
|
|
|
if true {
|
|
|
|
foo();
|
|
|
|
foo();
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
foo();
|
|
|
|
}
|
|
|
|
|
2016-10-01 19:17:04 -05:00
|
|
|
let _ = match 42 {
|
|
|
|
42 => {
|
|
|
|
//~^ NOTE same as this
|
2016-10-08 08:16:00 -05:00
|
|
|
//~| NOTE removing
|
2016-10-01 19:17:04 -05:00
|
|
|
foo();
|
|
|
|
let mut a = 42 + [23].len() as i32;
|
|
|
|
if true {
|
|
|
|
a += 7;
|
|
|
|
}
|
|
|
|
a = -31-a;
|
|
|
|
a
|
|
|
|
}
|
|
|
|
_ => { //~ERROR this `match` has identical arm bodies
|
|
|
|
foo();
|
|
|
|
let mut a = 42 + [23].len() as i32;
|
|
|
|
if true {
|
|
|
|
a += 7;
|
|
|
|
}
|
|
|
|
a = -31-a;
|
|
|
|
a
|
|
|
|
}
|
2016-01-30 12:16:49 -06:00
|
|
|
};
|
|
|
|
|
2016-10-08 08:16:00 -05:00
|
|
|
let _ = match Abc::A {
|
|
|
|
Abc::A => 0,
|
|
|
|
//~^ NOTE same as this
|
|
|
|
//~| NOTE removing
|
|
|
|
Abc::B => 1,
|
|
|
|
_ => 0, //~ERROR this `match` has identical arm bodies
|
|
|
|
};
|
|
|
|
|
2016-01-30 12:16:49 -06:00
|
|
|
if true {
|
|
|
|
foo();
|
|
|
|
}
|
|
|
|
|
2016-02-09 09:45:47 -06:00
|
|
|
let _ = if true {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-01-30 12:16:49 -06:00
|
|
|
42
|
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else { //~ERROR this `if` has identical blocks
|
2016-01-30 12:16:49 -06:00
|
|
|
42
|
|
|
|
};
|
2016-01-30 13:10:14 -06:00
|
|
|
|
2016-10-01 15:27:10 -05:00
|
|
|
if true {
|
|
|
|
//~^NOTE same as this
|
|
|
|
for _ in &[42] {
|
|
|
|
let foo: &Option<_> = &Some::<u8>(42);
|
|
|
|
if true {
|
|
|
|
break;
|
|
|
|
} else {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else { //~ERROR this `if` has identical blocks
|
|
|
|
for _ in &[42] {
|
|
|
|
let foo: &Option<_> = &Some::<u8>(42);
|
|
|
|
if true {
|
|
|
|
break;
|
|
|
|
} else {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-02-09 09:45:47 -06:00
|
|
|
if true {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-01-30 13:10:14 -06:00
|
|
|
let bar = if true {
|
|
|
|
42
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
43
|
|
|
|
};
|
|
|
|
|
|
|
|
while foo() { break; }
|
|
|
|
bar + 1;
|
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else { //~ERROR this `if` has identical blocks
|
2016-01-30 13:10:14 -06:00
|
|
|
let bar = if true {
|
|
|
|
42
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
43
|
|
|
|
};
|
|
|
|
|
|
|
|
while foo() { break; }
|
|
|
|
bar + 1;
|
|
|
|
}
|
|
|
|
|
2016-02-09 09:45:47 -06:00
|
|
|
if true {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-02-09 18:22:53 -06:00
|
|
|
let _ = match 42 {
|
|
|
|
42 => 1,
|
|
|
|
a if a > 0 => 2,
|
|
|
|
10...15 => 3,
|
|
|
|
_ => 4,
|
|
|
|
};
|
2016-01-30 13:10:14 -06:00
|
|
|
}
|
2016-02-09 09:45:47 -06:00
|
|
|
else if false {
|
|
|
|
foo();
|
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else if foo() { //~ERROR this `if` has identical blocks
|
|
|
|
let _ = match 42 {
|
|
|
|
42 => 1,
|
|
|
|
a if a > 0 => 2,
|
|
|
|
10...15 => 3,
|
|
|
|
_ => 4,
|
|
|
|
};
|
2016-01-30 13:10:14 -06:00
|
|
|
}
|
|
|
|
|
2016-02-09 09:45:47 -06:00
|
|
|
if true {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-02-09 09:45:47 -06:00
|
|
|
if let Some(a) = Some(42) {}
|
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else { //~ERROR this `if` has identical blocks
|
2016-02-09 09:45:47 -06:00
|
|
|
if let Some(a) = Some(42) {}
|
|
|
|
}
|
|
|
|
|
2016-05-27 07:24:28 -05:00
|
|
|
if true {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-05-27 07:24:28 -05:00
|
|
|
if let (1, .., 3) = (1, 2, 3) {}
|
|
|
|
}
|
|
|
|
else { //~ERROR this `if` has identical blocks
|
|
|
|
if let (1, .., 3) = (1, 2, 3) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
if true {
|
|
|
|
if let (1, .., 3) = (1, 2, 3) {}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if let (.., 3) = (1, 2, 3) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
if true {
|
|
|
|
if let (1, .., 3) = (1, 2, 3) {}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if let (.., 4) = (1, 2, 3) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
if true {
|
|
|
|
if let (1, .., 3) = (1, 2, 3) {}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if let (.., 1, 3) = (1, 2, 3) {}
|
|
|
|
}
|
|
|
|
|
2016-10-01 15:27:10 -05:00
|
|
|
if true {
|
|
|
|
if let Some(42) = None {}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if let Option::Some(42) = None {}
|
|
|
|
}
|
|
|
|
|
|
|
|
if true {
|
|
|
|
if let Some(42) = None::<u8> {}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
if let Some(42) = None {}
|
|
|
|
}
|
|
|
|
|
2016-02-09 09:45:47 -06:00
|
|
|
if true {
|
2016-01-30 13:10:14 -06:00
|
|
|
if let Some(a) = Some(42) {}
|
|
|
|
}
|
|
|
|
else {
|
2016-02-09 09:45:47 -06:00
|
|
|
if let Some(a) = Some(43) {}
|
2016-01-30 13:10:14 -06:00
|
|
|
}
|
|
|
|
|
2016-02-09 18:22:53 -06:00
|
|
|
let _ = match 42 {
|
|
|
|
42 => foo(),
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
|
|
|
//~|NOTE `42 | 51`
|
2016-02-09 18:22:53 -06:00
|
|
|
51 => foo(), //~ERROR this `match` has identical arm bodies
|
|
|
|
_ => true,
|
|
|
|
};
|
|
|
|
|
2016-03-28 18:39:35 -05:00
|
|
|
let _ = match Some(42) {
|
|
|
|
Some(_) => 24,
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
|
|
|
//~|NOTE `Some(_) | None`
|
2016-05-31 13:14:32 -05:00
|
|
|
None => 24, //~ERROR this `match` has identical arm bodies
|
2016-03-28 18:39:35 -05:00
|
|
|
};
|
|
|
|
|
2016-05-31 14:50:13 -05:00
|
|
|
let _ = match Some(42) {
|
|
|
|
Some(foo) => 24,
|
|
|
|
None => 24,
|
|
|
|
};
|
|
|
|
|
2016-02-09 18:22:53 -06:00
|
|
|
let _ = match Some(42) {
|
|
|
|
Some(42) => 24,
|
|
|
|
Some(a) => 24, // bindings are different
|
|
|
|
None => 0,
|
|
|
|
};
|
|
|
|
|
2016-03-28 18:39:35 -05:00
|
|
|
let _ = match Some(42) {
|
|
|
|
Some(a) if a > 0 => 24,
|
|
|
|
Some(a) => 24, // one arm has a guard
|
|
|
|
None => 0,
|
|
|
|
};
|
|
|
|
|
2016-02-09 18:22:53 -06:00
|
|
|
match (Some(42), Some(42)) {
|
|
|
|
(Some(a), None) => bar(a),
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
|
|
|
//~|NOTE `(Some(a), None) | (None, Some(a))`
|
2016-02-09 18:22:53 -06:00
|
|
|
(None, Some(a)) => bar(a), //~ERROR this `match` has identical arm bodies
|
|
|
|
_ => (),
|
|
|
|
}
|
|
|
|
|
2016-05-27 07:24:28 -05:00
|
|
|
match (Some(42), Some(42)) {
|
|
|
|
(Some(a), ..) => bar(a),
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
|
|
|
//~|NOTE `(Some(a), ..) | (.., Some(a))`
|
2016-05-27 07:24:28 -05:00
|
|
|
(.., Some(a)) => bar(a), //~ERROR this `match` has identical arm bodies
|
|
|
|
_ => (),
|
|
|
|
}
|
|
|
|
|
|
|
|
match (1, 2, 3) {
|
|
|
|
(1, .., 3) => 42,
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
|
|
|
//~|NOTE `(1, .., 3) | (.., 3)`
|
2016-05-27 07:24:28 -05:00
|
|
|
(.., 3) => 42, //~ERROR this `match` has identical arm bodies
|
|
|
|
_ => 0,
|
|
|
|
};
|
|
|
|
|
2016-07-13 02:43:33 -05:00
|
|
|
let _ = if true {
|
|
|
|
//~^NOTE same as this
|
|
|
|
0.0
|
|
|
|
} else { //~ERROR this `if` has identical blocks
|
|
|
|
0.0
|
|
|
|
};
|
|
|
|
|
|
|
|
let _ = if true {
|
|
|
|
//~^NOTE same as this
|
|
|
|
-0.0
|
|
|
|
} else { //~ERROR this `if` has identical blocks
|
|
|
|
-0.0
|
|
|
|
};
|
|
|
|
|
|
|
|
let _ = if true {
|
|
|
|
0.0
|
|
|
|
} else {
|
|
|
|
-0.0
|
|
|
|
};
|
|
|
|
|
2016-07-13 11:35:31 -05:00
|
|
|
// Different NaNs
|
|
|
|
let _ = if true {
|
2016-07-13 12:02:28 -05:00
|
|
|
0.0 / 0.0
|
2016-07-13 11:35:31 -05:00
|
|
|
} else {
|
2016-07-13 12:02:28 -05:00
|
|
|
std::f32::NAN
|
2016-07-13 11:35:31 -05:00
|
|
|
};
|
|
|
|
|
|
|
|
// Same NaNs
|
|
|
|
let _ = if true {
|
|
|
|
//~^NOTE same as this
|
|
|
|
std::f32::NAN
|
|
|
|
} else { //~ERROR this `if` has identical blocks
|
|
|
|
std::f32::NAN
|
|
|
|
};
|
|
|
|
|
2016-07-13 02:43:33 -05:00
|
|
|
let _ = match Some(()) {
|
|
|
|
Some(()) => 0.0,
|
|
|
|
None => -0.0
|
|
|
|
};
|
|
|
|
|
2016-02-09 18:22:53 -06:00
|
|
|
match (Some(42), Some("")) {
|
|
|
|
(Some(a), None) => bar(a),
|
|
|
|
(None, Some(a)) => bar(a), // bindings have different types
|
|
|
|
_ => (),
|
|
|
|
}
|
|
|
|
|
2016-02-13 08:36:57 -06:00
|
|
|
if true {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-02-13 08:36:57 -06:00
|
|
|
try!(Ok("foo"));
|
|
|
|
}
|
|
|
|
else { //~ERROR this `if` has identical blocks
|
|
|
|
try!(Ok("foo"));
|
|
|
|
}
|
|
|
|
|
2016-02-09 09:45:47 -06:00
|
|
|
if true {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-01-30 13:10:14 -06:00
|
|
|
let foo = "";
|
2016-02-13 08:36:57 -06:00
|
|
|
return Ok(&foo[0..]);
|
2016-01-30 13:10:14 -06:00
|
|
|
}
|
2016-02-09 09:45:47 -06:00
|
|
|
else if false {
|
|
|
|
let foo = "bar";
|
2016-02-13 08:36:57 -06:00
|
|
|
return Ok(&foo[0..]);
|
2016-02-09 09:45:47 -06:00
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else { //~ERROR this `if` has identical blocks
|
2016-01-30 13:10:14 -06:00
|
|
|
let foo = "";
|
2016-02-13 08:36:57 -06:00
|
|
|
return Ok(&foo[0..]);
|
2016-01-30 13:10:14 -06:00
|
|
|
}
|
2016-01-30 12:16:49 -06:00
|
|
|
}
|
|
|
|
|
2016-02-09 09:45:47 -06:00
|
|
|
#[deny(ifs_same_cond)]
|
|
|
|
#[allow(if_same_then_else)] // all empty blocks
|
2016-01-30 12:16:49 -06:00
|
|
|
fn ifs_same_cond() {
|
2016-01-30 11:03:53 -06:00
|
|
|
let a = 0;
|
2016-02-09 08:18:27 -06:00
|
|
|
let b = false;
|
|
|
|
|
|
|
|
if b {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-02-09 08:18:27 -06:00
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else if b { //~ERROR this `if` has the same condition as a previous if
|
2016-02-09 08:18:27 -06:00
|
|
|
}
|
2016-01-30 11:03:53 -06:00
|
|
|
|
|
|
|
if a == 1 {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-01-30 11:03:53 -06:00
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else if a == 1 { //~ERROR this `if` has the same condition as a previous if
|
2016-01-30 11:03:53 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
if 2*a == 1 {
|
2016-07-10 07:46:39 -05:00
|
|
|
//~^NOTE same as this
|
2016-01-30 11:03:53 -06:00
|
|
|
}
|
|
|
|
else if 2*a == 2 {
|
|
|
|
}
|
2016-02-09 18:22:53 -06:00
|
|
|
else if 2*a == 1 { //~ERROR this `if` has the same condition as a previous if
|
2016-01-30 11:03:53 -06:00
|
|
|
}
|
|
|
|
else if a == 1 {
|
|
|
|
}
|
|
|
|
|
2016-02-13 08:36:57 -06:00
|
|
|
// See #659
|
|
|
|
if cfg!(feature = "feature1-659") {
|
|
|
|
1
|
|
|
|
} else if cfg!(feature = "feature2-659") {
|
|
|
|
2
|
|
|
|
} else {
|
|
|
|
3
|
|
|
|
};
|
|
|
|
|
2016-01-30 13:10:14 -06:00
|
|
|
let mut v = vec![1];
|
|
|
|
if v.pop() == None { // ok, functions
|
|
|
|
}
|
|
|
|
else if v.pop() == None {
|
|
|
|
}
|
|
|
|
|
|
|
|
if v.len() == 42 { // ok, functions
|
2016-01-30 11:03:53 -06:00
|
|
|
}
|
2016-01-30 13:10:14 -06:00
|
|
|
else if v.len() == 42 {
|
2016-01-30 11:03:53 -06:00
|
|
|
}
|
|
|
|
}
|
2016-01-30 12:16:49 -06:00
|
|
|
|
|
|
|
fn main() {}
|