2014-01-25 01:37:51 -06:00
|
|
|
// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
|
2012-12-03 18:48:01 -06:00
|
|
|
// file at the top-level directory of this distribution and at
|
|
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
//! Lints, aka compiler warnings.
|
|
|
|
//!
|
2013-10-02 13:29:29 -05:00
|
|
|
//! A 'lint' check is a kind of miscellaneous constraint that a user _might_
|
|
|
|
//! want to enforce, but might reasonably want to permit as well, on a
|
|
|
|
//! module-by-module basis. They contrast with static constraints enforced by
|
|
|
|
//! other phases of the compiler, which are generally required to hold in order
|
|
|
|
//! to compile the program at all.
|
|
|
|
//!
|
2014-06-06 17:49:48 -05:00
|
|
|
//! Most lints can be written as `LintPass` instances. These run just before
|
|
|
|
//! translation to LLVM bytecode. The `LintPass`es built into rustc are defined
|
|
|
|
//! within `builtin.rs`, which has further comments on how to add such a lint.
|
2014-06-18 19:26:14 -05:00
|
|
|
//! rustc can also load user-defined lint plugins via the plugin mechanism.
|
2014-06-02 17:27:15 -05:00
|
|
|
//!
|
2014-06-06 17:49:48 -05:00
|
|
|
//! Some of rustc's lints are defined elsewhere in the compiler and work by
|
|
|
|
//! calling `add_lint()` on the overall `Session` object. This works when
|
|
|
|
//! it happens before the main lint pass, which emits the lints stored by
|
|
|
|
//! `add_lint()`. To emit lints after the main lint pass (from trans, for
|
|
|
|
//! example) requires more effort. See `emit_lint` and `GatherNodeLevels`
|
|
|
|
//! in `context.rs`.
|
2013-05-17 17:28:44 -05:00
|
|
|
|
2014-06-04 16:35:58 -05:00
|
|
|
#![macro_escape]
|
2014-02-10 08:36:31 -06:00
|
|
|
|
2014-06-04 16:35:58 -05:00
|
|
|
use std::hash;
|
2014-07-18 08:53:29 -05:00
|
|
|
use std::ascii::AsciiExt;
|
2013-08-31 11:13:04 -05:00
|
|
|
use syntax::codemap::Span;
|
2014-06-06 17:49:48 -05:00
|
|
|
use syntax::visit::FnKind;
|
|
|
|
use syntax::ast;
|
|
|
|
|
2014-06-13 17:03:26 -05:00
|
|
|
pub use lint::context::{Context, LintStore, raw_emit_lint, check_crate, gather_attrs};
|
2012-12-23 16:41:37 -06:00
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Specification of a single lint.
|
|
|
|
pub struct Lint {
|
|
|
|
/// A string identifier for the lint.
|
|
|
|
///
|
2014-06-13 15:04:52 -05:00
|
|
|
/// This identifies the lint in attributes and in command-line arguments.
|
|
|
|
/// In those contexts it is always lowercase, but this field is compared
|
|
|
|
/// in a way which is case-insensitive for ASCII characters. This allows
|
|
|
|
/// `declare_lint!()` invocations to follow the convention of upper-case
|
|
|
|
/// statics without repeating the name.
|
|
|
|
///
|
|
|
|
/// The name is written with underscores, e.g. "unused_imports".
|
|
|
|
/// On the command line, underscores become dashes.
|
2014-06-06 17:49:48 -05:00
|
|
|
pub name: &'static str,
|
|
|
|
|
|
|
|
/// Default level for the lint.
|
|
|
|
pub default_level: Level,
|
|
|
|
|
|
|
|
/// Description of the lint or the issue it detects.
|
|
|
|
///
|
|
|
|
/// e.g. "imports that are never used"
|
|
|
|
pub desc: &'static str,
|
|
|
|
}
|
|
|
|
|
2014-06-13 15:04:52 -05:00
|
|
|
impl Lint {
|
|
|
|
/// Get the lint's name, with ASCII letters converted to lowercase.
|
|
|
|
pub fn name_lower(&self) -> String {
|
|
|
|
self.name.to_ascii_lower()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Build a `Lint` initializer.
|
2014-06-04 16:35:58 -05:00
|
|
|
#[macro_export]
|
|
|
|
macro_rules! lint_initializer (
|
|
|
|
($name:ident, $level:ident, $desc:expr) => (
|
|
|
|
::rustc::lint::Lint {
|
|
|
|
name: stringify!($name),
|
|
|
|
default_level: ::rustc::lint::$level,
|
|
|
|
desc: $desc,
|
|
|
|
}
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Declare a static item of type `&'static Lint`.
|
2014-06-04 16:35:58 -05:00
|
|
|
#[macro_export]
|
|
|
|
macro_rules! declare_lint (
|
|
|
|
// FIXME(#14660): deduplicate
|
|
|
|
(pub $name:ident, $level:ident, $desc:expr) => (
|
|
|
|
pub static $name: &'static ::rustc::lint::Lint
|
|
|
|
= &lint_initializer!($name, $level, $desc);
|
|
|
|
);
|
|
|
|
($name:ident, $level:ident, $desc:expr) => (
|
|
|
|
static $name: &'static ::rustc::lint::Lint
|
|
|
|
= &lint_initializer!($name, $level, $desc);
|
|
|
|
);
|
|
|
|
)
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Declare a static `LintArray` and return it as an expression.
|
2014-06-04 16:35:58 -05:00
|
|
|
#[macro_export]
|
|
|
|
macro_rules! lint_array ( ($( $lint:expr ),*) => (
|
|
|
|
{
|
2014-10-27 17:37:07 -05:00
|
|
|
#[allow(non_upper_case_globals)]
|
2014-10-06 19:30:54 -05:00
|
|
|
static array: LintArray = &[ $( &$lint ),* ];
|
2014-06-04 16:35:58 -05:00
|
|
|
array
|
|
|
|
}
|
|
|
|
))
|
2014-06-01 18:16:00 -05:00
|
|
|
|
2014-10-06 19:30:54 -05:00
|
|
|
pub type LintArray = &'static [&'static &'static Lint];
|
2014-06-04 16:35:58 -05:00
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Trait for types providing lint checks.
|
|
|
|
///
|
|
|
|
/// Each `check` method checks a single syntax node, and should not
|
|
|
|
/// invoke methods recursively (unlike `Visitor`). By default they
|
|
|
|
/// do nothing.
|
2014-06-02 17:27:15 -05:00
|
|
|
//
|
2014-06-04 16:35:58 -05:00
|
|
|
// FIXME: eliminate the duplication with `Visitor`. But this also
|
|
|
|
// contains a few lint-specific methods with no equivalent in `Visitor`.
|
2014-06-10 16:03:19 -05:00
|
|
|
pub trait LintPass {
|
2014-06-04 16:35:58 -05:00
|
|
|
/// Get descriptions of the lints this `LintPass` object can emit.
|
|
|
|
///
|
|
|
|
/// NB: there is no enforcement that the object only emits lints it registered.
|
|
|
|
/// And some `rustc` internal `LintPass`es register lints to be emitted by other
|
|
|
|
/// parts of the compiler. If you want enforced access restrictions for your
|
|
|
|
/// `Lint`, make it a private `static` item in its own module.
|
|
|
|
fn get_lints(&self) -> LintArray;
|
|
|
|
|
2014-06-17 19:06:04 -05:00
|
|
|
fn check_crate(&mut self, _: &Context, _: &ast::Crate) { }
|
2014-06-02 17:27:15 -05:00
|
|
|
fn check_ident(&mut self, _: &Context, _: Span, _: ast::Ident) { }
|
|
|
|
fn check_mod(&mut self, _: &Context, _: &ast::Mod, _: Span, _: ast::NodeId) { }
|
|
|
|
fn check_view_item(&mut self, _: &Context, _: &ast::ViewItem) { }
|
|
|
|
fn check_foreign_item(&mut self, _: &Context, _: &ast::ForeignItem) { }
|
|
|
|
fn check_item(&mut self, _: &Context, _: &ast::Item) { }
|
|
|
|
fn check_local(&mut self, _: &Context, _: &ast::Local) { }
|
|
|
|
fn check_block(&mut self, _: &Context, _: &ast::Block) { }
|
|
|
|
fn check_stmt(&mut self, _: &Context, _: &ast::Stmt) { }
|
|
|
|
fn check_arm(&mut self, _: &Context, _: &ast::Arm) { }
|
|
|
|
fn check_pat(&mut self, _: &Context, _: &ast::Pat) { }
|
|
|
|
fn check_decl(&mut self, _: &Context, _: &ast::Decl) { }
|
|
|
|
fn check_expr(&mut self, _: &Context, _: &ast::Expr) { }
|
|
|
|
fn check_expr_post(&mut self, _: &Context, _: &ast::Expr) { }
|
|
|
|
fn check_ty(&mut self, _: &Context, _: &ast::Ty) { }
|
|
|
|
fn check_generics(&mut self, _: &Context, _: &ast::Generics) { }
|
|
|
|
fn check_fn(&mut self, _: &Context,
|
2014-09-09 17:54:36 -05:00
|
|
|
_: FnKind, _: &ast::FnDecl, _: &ast::Block, _: Span, _: ast::NodeId) { }
|
2014-06-02 17:27:15 -05:00
|
|
|
fn check_ty_method(&mut self, _: &Context, _: &ast::TypeMethod) { }
|
2014-08-04 15:56:56 -05:00
|
|
|
fn check_trait_method(&mut self, _: &Context, _: &ast::TraitItem) { }
|
2014-06-02 17:27:15 -05:00
|
|
|
fn check_struct_def(&mut self, _: &Context,
|
|
|
|
_: &ast::StructDef, _: ast::Ident, _: &ast::Generics, _: ast::NodeId) { }
|
|
|
|
fn check_struct_def_post(&mut self, _: &Context,
|
|
|
|
_: &ast::StructDef, _: ast::Ident, _: &ast::Generics, _: ast::NodeId) { }
|
|
|
|
fn check_struct_field(&mut self, _: &Context, _: &ast::StructField) { }
|
|
|
|
fn check_variant(&mut self, _: &Context, _: &ast::Variant, _: &ast::Generics) { }
|
2014-11-15 19:57:54 -06:00
|
|
|
fn check_variant_post(&mut self, _: &Context, _: &ast::Variant, _: &ast::Generics) { }
|
2014-06-02 17:27:15 -05:00
|
|
|
fn check_opt_lifetime_ref(&mut self, _: &Context, _: Span, _: &Option<ast::Lifetime>) { }
|
|
|
|
fn check_lifetime_ref(&mut self, _: &Context, _: &ast::Lifetime) { }
|
2014-08-05 21:59:24 -05:00
|
|
|
fn check_lifetime_decl(&mut self, _: &Context, _: &ast::LifetimeDef) { }
|
2014-06-02 17:27:15 -05:00
|
|
|
fn check_explicit_self(&mut self, _: &Context, _: &ast::ExplicitSelf) { }
|
|
|
|
fn check_mac(&mut self, _: &Context, _: &ast::Mac) { }
|
|
|
|
fn check_path(&mut self, _: &Context, _: &ast::Path, _: ast::NodeId) { }
|
|
|
|
fn check_attribute(&mut self, _: &Context, _: &ast::Attribute) { }
|
|
|
|
|
|
|
|
/// Called when entering a syntax node that can have lint attributes such
|
|
|
|
/// as `#[allow(...)]`. Called with *all* the attributes of that node.
|
|
|
|
fn enter_lint_attrs(&mut self, _: &Context, _: &[ast::Attribute]) { }
|
|
|
|
|
|
|
|
/// Counterpart to `enter_lint_attrs`.
|
|
|
|
fn exit_lint_attrs(&mut self, _: &Context, _: &[ast::Attribute]) { }
|
|
|
|
}
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// A lint pass boxed up as a trait object.
|
|
|
|
pub type LintPassObject = Box<LintPass + 'static>;
|
2014-06-02 17:27:15 -05:00
|
|
|
|
2014-06-04 16:35:58 -05:00
|
|
|
/// Identifies a lint known to the compiler.
|
|
|
|
#[deriving(Clone)]
|
|
|
|
pub struct LintId {
|
|
|
|
// Identity is based on pointer equality of this field.
|
|
|
|
lint: &'static Lint,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl PartialEq for LintId {
|
|
|
|
fn eq(&self, other: &LintId) -> bool {
|
2014-06-25 14:47:34 -05:00
|
|
|
(self.lint as *const Lint) == (other.lint as *const Lint)
|
2014-06-04 16:35:58 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Eq for LintId { }
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
impl<S: hash::Writer> hash::Hash<S> for LintId {
|
2014-06-04 16:35:58 -05:00
|
|
|
fn hash(&self, state: &mut S) {
|
2014-06-25 14:47:34 -05:00
|
|
|
let ptr = self.lint as *const Lint;
|
2014-06-04 16:35:58 -05:00
|
|
|
ptr.hash(state);
|
|
|
|
}
|
2012-01-19 02:50:51 -06:00
|
|
|
}
|
|
|
|
|
2014-06-04 16:35:58 -05:00
|
|
|
impl LintId {
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Get the `LintId` for a `Lint`.
|
2014-06-04 16:35:58 -05:00
|
|
|
pub fn of(lint: &'static Lint) -> LintId {
|
|
|
|
LintId {
|
|
|
|
lint: lint,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Get the name of the lint.
|
2014-06-13 15:04:52 -05:00
|
|
|
pub fn as_str(&self) -> String {
|
|
|
|
self.lint.name_lower()
|
Nomenclature fixes in the lint checker. Fewer double-negatives.
New style is allow(foo), warn(foo), deny(foo) and forbid(foo),
mirrored by -A foo, -W foo, -D foo and -F foo on command line.
These replace -W no-foo, -W foo, -W err-foo, respectively.
Forbid is new, and means "deny, and you can't override it".
2012-07-26 19:08:21 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Setting for how to handle a lint.
|
2014-05-31 12:43:52 -05:00
|
|
|
#[deriving(Clone, PartialEq, PartialOrd, Eq, Ord)]
|
2014-05-21 06:50:37 -05:00
|
|
|
pub enum Level {
|
|
|
|
Allow, Warn, Deny, Forbid
|
2012-01-21 11:20:22 -06:00
|
|
|
}
|
|
|
|
|
2014-06-04 16:35:58 -05:00
|
|
|
impl Level {
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Convert a level to a lower-case string.
|
2014-06-04 16:35:58 -05:00
|
|
|
pub fn as_str(self) -> &'static str {
|
|
|
|
match self {
|
|
|
|
Allow => "allow",
|
|
|
|
Warn => "warn",
|
|
|
|
Deny => "deny",
|
|
|
|
Forbid => "forbid",
|
|
|
|
}
|
|
|
|
}
|
2013-07-16 23:12:16 -05:00
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Convert a lower-case string to a level.
|
2014-06-04 16:35:58 -05:00
|
|
|
pub fn from_str(x: &str) -> Option<Level> {
|
|
|
|
match x {
|
|
|
|
"allow" => Some(Allow),
|
|
|
|
"warn" => Some(Warn),
|
|
|
|
"deny" => Some(Deny),
|
|
|
|
"forbid" => Some(Forbid),
|
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2013-04-30 00:15:17 -05:00
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// How a lint level was set.
|
|
|
|
#[deriving(Clone, PartialEq, Eq)]
|
2014-05-19 16:57:24 -05:00
|
|
|
pub enum LintSource {
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Lint is at the default level as declared
|
|
|
|
/// in rustc or a plugin.
|
2013-05-09 12:22:26 -05:00
|
|
|
Default,
|
2012-06-04 18:07:54 -05:00
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Lint level was set by an attribute.
|
|
|
|
Node(Span),
|
2013-05-28 15:44:53 -05:00
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
/// Lint level was set by a command-line flag.
|
|
|
|
CommandLine,
|
2013-05-24 03:27:31 -05:00
|
|
|
}
|
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
pub type LevelSource = (Level, LintSource);
|
2013-04-30 00:15:17 -05:00
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
pub mod builtin;
|
2013-05-07 01:07:00 -05:00
|
|
|
|
2014-06-06 17:49:48 -05:00
|
|
|
mod context;
|